[Rev 01] RFR: 6724: Agent argument as a path to a probe definition XML should be optional
Kangcheng Xu
kxu at openjdk.java.net
Wed Mar 11 15:16:27 UTC 2020
On Tue, 10 Mar 2020 09:37:42 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update documentation
>
> agent/src/main/java/org/openjdk/jmc/agent/Agent.java line 134:
>
>> 133: } catch (XMLStreamException e) {
>> 134: // noop
>> 135: }
>
> Nit: perhaps document with something like // noop since null causes defaults to be used - the stream will not be used
Thank you. Fixed in b7e05c347f9f634f6d52e9639c619d66c74e9576
> agent/src/main/java/org/openjdk/jmc/agent/Agent.java line 105:
>
>> 104: TransformRegistry registry =
>> 105: configuration != null ? DefaultTransformRegistry.from(configuration) : DefaultTransformRegistry.empty();
>> 106: instrumentation.addTransformer(new Transformer(registry), true);
>
> Nit: should document that null as argument for the configuration stream means using the empty configuration.
Thank you. Fixed in b7e05c347f9f634f6d52e9639c619d66c74e9576
-------------
PR: https://git.openjdk.java.net/jmc/pull/63
More information about the jmc-dev
mailing list