[Rev 04] RFR: 6691: The root of the flame graph could be improved

[Marcus Hirt]

On Tue, 17 Mar 2020 16:02:53 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> https://bugs.openjdk.java.net/browse/JMC-6691
>
> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6691: tooltips improvements minor

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceTreeUtils.java
line 109:

> 108: 	public static TraceNode createRootWithDescription(IItemCollection items, int branchCount) {
> 109:
> 110: 		StringBuilder titleSb = new StringBuilder();

Nit: you don't start with new line in other methods.

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceTreeUtils.java
line 203:

> 202: 		StringBuilder titleSb, StringBuilder descSb, Map<String, Integer> orderedItemCountByType) {
> 203:
> 204: 		int i = 0;

Ok. Maybe you do. ;)

-------------

PR: https://git.openjdk.java.net/jmc/pull/67