RFR: 6725: Formalize agent probe definition XML schema and enforce validations

Kangcheng Xu kxu at openjdk.java.net
Tue Mar 31 14:36:38 UTC 2020


On Thu, 26 Mar 2020 21:19:26 GMT, Kangcheng Xu <kxu at openjdk.org> wrote:

>> This PR back to WIP. After rebasing to resolve conflicts with #63 and #68, the following test fails. I'm looking into
>> this problem right now.
>> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.107 s <<< FAILURE! - in
>> org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms [ERROR]
>> testRetrieveCurrentTransforms(org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms)  Time elapsed: 0.076 s  <<<
>> ERROR! java.lang.reflect.UndeclaredThrowableException
>>         at
>>         org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms.doRetrieveCurrentTransforms(TestRetrieveCurrentTransforms.java:74)
>>         at
>>         org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms.testRetrieveCurrentTransforms(TestRetrieveCurrentTransforms.java:62)
>> Caused by: javax.management.InstanceNotFoundException: org.openjdk.jmc.jfr.agent:type=AgentController
>>         at
>>         org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms.doRetrieveCurrentTransforms(TestRetrieveCurrentTransforms.java:74)
>>         at
>>         org.openjdk.jmc.agent.test.TestRetrieveCurrentTransforms.testRetrieveCurrentTransforms(TestRetrieveCurrentTransforms.java:62)
>> 
>> [INFO]
>> [INFO] Results:
>> [INFO]
>> [ERROR] Errors:
>> [ERROR]   TestRetrieveCurrentTransforms.testRetrieveCurrentTransforms:62->doRetrieveCurrentTransforms:74 »
>> UndeclaredThrowable [INFO]
>> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
>
>> This PR back to WIP. After rebasing to resolve conflicts with #63 and #68, the following test fails.
> 
> Fixed in fc110df. PR is ready for review again.

Ping @aptmac and @neugens. Could you kindly review this PR if that's possible? Thanks!

-------------

PR: https://git.openjdk.java.net/jmc/pull/66


More information about the jmc-dev mailing list