RFR: 6531: Make the flame chart view render labels on windows

[Thomas May]

On Mon, 24 Feb 2020 20:36:01 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> I think I'm ok with this being a stop-gap measure. It does make third party-dependencies a bit funny - and there is a
>> bit of trust involved in getting the javascript from a private fork of a project, and even a private push of the
>> resulting build to a CDN. As soon as the Eclipse changes are in, in any form and shape, we should switch.
>
>> As soon as the Eclipse changes are in, in any form and shape, we should switch.
> 
> Agreed, it would be very limiting to continue on this way.
> 
> This PR required some rebasing after the latest flamegraph commits to include colour highlighting. I had to include an
> additional commit here that allows for the colouring to work with IE, because some syntax and functions are too
> advanced for ES2015.  About the `flameviewColoring.js`, I made the changes in the file to make it compatible with IE,
> but would it be worthwhile to go the route of making a `flameviewColoring-ie.js` so that if/when Chromium functionality
> is introduced instead of refactoring the colouring script we could just drop the `-ie` version? Let me know your
> thoughts on this one.  Here's an example screenshot of it working in Windows with text highlighting:
> ![windows-highlighting](https://user-images.githubusercontent.com/10425301/75188682-92177b00-571a-11ea-9a3f-e8bd7b91d3b9.png)

Dumb question, but would a shorter path be to run babel against d3 (Or have that as part of the build?)

That would eliminate the need to maintain your own version and make updating a lot easier.

-------------

PR: https://git.openjdk.java.net/jmc/pull/41