RFR: 6945: Create build script for Windows [v4]
Guru Hb
ghb at openjdk.java.net
Mon Nov 2 16:35:54 UTC 2020
On Sun, 1 Nov 2020 07:41:06 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:
>> Build script for windows mimics behavior of the *nix one
>>
>> Special handling for Jetty server with killing it at the end of the action
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
>
> add *.log in gitignore
Looks good to me, Verified on windows 10.
This is good to start using simplified batch file to use JMC.
We can have a follow on bug fix for improvement , If there is an existing jetty , this happens
1. more often in the jenkins where the build get's hung and main process will be terminated but jetty process will be still running
2. Some times we keep this jetty running to make sure dependency are reachable to eclipse. During this time the jetty process launched from batch file will fail (as we can see from log file).
-------------
Marked as reviewed by ghb (Reviewer).
PR: https://git.openjdk.java.net/jmc/pull/147
More information about the jmc-dev
mailing list