RFR: 4984: Label missing for Focus Selection combobox [v2]

Marcus Hirt hirt at openjdk.java.net
Tue Nov 10 16:00:58 UTC 2020


On Wed, 4 Nov 2020 16:52:06 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> Added a new label for Selection combo box. This was an issue pointed out by vpat.
>> 
>> Please review the change.
>
> Suchita Chaturvedi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Rebasing branch with master
>  - 4984: Label missing for Focus Selection combobox

application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties line 274:

> 272: FlavorSelector_BUTTON_TIMERANGE_SET_TOOLTIP=Zoom to time range on relevant places on the page
> 273: FlavorSelector_LABEL_ASPECT=Aspect:
> 274: FlavorSelector_LABEL_SELECTION=Selection:

Selection is a bit of an overloaded term. Perhaps Focus would be better (it also takes less screen estate)? Check with a few more people to see which makes the more sense. 

The action is "Set as As Focused Selection".

-------------

PR: https://git.openjdk.java.net/jmc/pull/155


More information about the jmc-dev mailing list