RFR: 4984: Label missing for Focus Selection combobox [v3]

Guru Hb ghb at openjdk.java.net
Fri Nov 13 15:37:58 UTC 2020


On Thu, 12 Nov 2020 22:38:08 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> Added a new label for Selection combo box. This was an issue pointed out by vpat.
>> 
>> Please review the change.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Changed label to focus and rebased branch with master

Changes requested by ghb (Reviewer).

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java line 767:

> 765: 					.displayUsing(IDisplayable.AUTO);
> 766: 			StringBuilder sb = new StringBuilder("<form>"); //$NON-NLS-1$
> 767: 			sb.append("<li style='image' value='" + COUNT_IMG_KEY + "'><span nowrap='true'>"); //$NON-NLS-1$ //$NON-NLS-2$

Unrelated changes

-------------

PR: https://git.openjdk.java.net/jmc/pull/155


More information about the jmc-dev mailing list