RFR: 6787: Simplified stack trace tree model [v2]
Alex Ciminian
github.com+348973+cimi at openjdk.java.net
Thu Nov 19 16:12:25 UTC 2020
On Thu, 19 Nov 2020 14:19:55 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> Alex Ciminian has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - 6787: s/JSON/Json/ in all new files
>> - 6787: more fixing of copyright notices
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/FlameGraphJSONMarshaller.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2020, Datadog, Inc. All rights reserved.
>
> Per OCA, Oracle copyrights will need to be in all files, and first. See other files.
I have no idea how/why any of this works
> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/tree/AggregatableFrame.java line 1:
>
>> 1: /*
>
> This one is from my graph work. I think it is fine to commit it separately here though. I can take a separate pass in my general cleanup and make it a shared class.
Yes, I also copied `Node` from there and changed it slightly. It would be nice to consolidate once both implementations are in.
-------------
PR: https://git.openjdk.java.net/jmc/pull/159
More information about the jmc-dev
mailing list