RFR: 6507: Use GraphViz to render stack traces [v3]

[Miroslav Wengner]

On Tue, 17 Nov 2020 18:02:12 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Still need some pruning options to not be insanely slow when having plenty of nodes, but this is a start.
>
> Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 31 commits:
> 
>  - Merge branch 'master' into graphview
>  - Making spotbugs happier
>  - Formatting
>  - Cleanup
>  - Merge pull request #1 from cimi/graphview
>    
>    6507: inline graphviz wasm as base64 in js
>  - 6507: inline graphviz wasm as base64 in js
>    
>    This is required to avoid fetching it as an external resource at runtime.
>  - Moving this out for now - to be completed at another time
>  - Removing another one
>  - Removing unused class
>  - Allow more zoom
>  - ... and 21 more: https://git.openjdk.java.net/jmc/compare/c3f49204...469f8d93

I've add some comments

application/org.openjdk.jmc.flightrecorder.graphview/.classpath line 4:

> 2: <classpath>
> 3: 	<classpathentry kind="src" path="src/main/java"/>
> 4: 	<classpathentry kind="src" path="src/test/java"/>

I'd add there classpathentry kind="src" path="src/main/resources"

application/org.openjdk.jmc.flightrecorder.graphview/META-INF/MANIFEST.MF line 3:

> 1: Manifest-Version: 1.0
> 2: Bundle-ManifestVersion: 2
> 3: Bundle-Name: Flamegraph

I'd change it to Bundle-Name:GraphView
I'd add: Bundle-Localization: plugin

application/org.openjdk.jmc.flightrecorder.graphview/src/main/java/org/openjdk/jmc/flightrecorder/graphview/views/GraphView.java line 227:

> 225: 			@Override
> 226: 			public void completed(ProgressEvent event) {
> 227: 				browser.removeProgressListener(this);

this doesn't necessary mean that the ProgressAdapter will be removed, especially during the fast scrolling the adapter won't be completed. It may cause the issues in the displayed context (wrong context stays visible). I'd recommend to do  it exactly as in FlameGraphView

-------------

PR: https://git.openjdk.java.net/jmc/pull/162