RFR: 6507: Use GraphViz to render stack traces [v4]
Marcus Hirt
hirt at openjdk.java.net
Wed Nov 25 11:36:55 UTC 2020
On Mon, 23 Nov 2020 13:42:25 GMT, Guru Hb <ghb at openjdk.org> wrote:
>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixing review issues
>
> application/org.openjdk.jmc.flightrecorder.graphview/pom.xml line 68:
>
>> 66: </goals>
>> 67: <configuration>
>> 68: <url>https://d3js.org/d3.v5.min.js</url>
>
> Unless there is incompatibility with latest version, Please update the external js and wasm libraries to
> 1. https://unpkg.com/d3-graphviz@3.0.5/build/d3-graphviz.js --> https://unpkg.com/d3-graphviz@3.1.0/build/d3-graphviz.js
> 2. https://d3js.org/d3.v5.min.js --> https://d3js.org/d3.v6.min.js
> 3. https://unpkg.com/@hpcc-js/wasm@0.3.11/dist/index.js --> https://unpkg.com/@hpcc-js/wasm@0.3.14/dist/index.js
> 4. https://unpkg.com/d3-graphviz@3.0.5/build/d3-graphviz.js --> https://unpkg.com/d3-graphviz@3.1.0/build/d3-graphviz.js
> 5. https://unpkg.com/@hpcc-js/wasm@0.3.11/dist/graphvizlib.wasm --> https://unpkg.com/@hpcc-js/wasm@0.3.14/dist/graphvizlib.wasm
Wasm is already at 3.14 and Graphviz is at 3.1.0. Upgrading to d3.v6 seems to make the zooming not work. I'll go with this for now.
-------------
PR: https://git.openjdk.java.net/jmc/pull/162
More information about the jmc-dev
mailing list