Integrated: 6690: Find a home for the Flame View in the JMC perspective

Wed Nov 25 15:06:56 UTC 2020

On Tue, 24 Nov 2020 17:56:30 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Adding another plug-in to the default perspective can cause the JVM browser to be loaded _after_ the Flight Recorder UI, making views end up in the wrong place. To avoid this, I added a dependency on the JVM Browser bundle. This is sad, since it was previously easy to, for example, build a JFR-only-file viewer, without even including the JVM browser, JMX Console etc, by simply editing the features. A better long term solution would probably be to include the flame graph in the JFR UI bundle. I suggest using the dependency approach for 8.0.0, since I don't know anyone shipping a partial release of the JMC app, for now.

This pull request has now been integrated.

Changeset: 73fce3fd
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/73fce3fd
Stats:     15 lines in 2 files changed: 9 ins; 0 del; 6 mod

6690: Find a home for the Flame View in the JMC perspective

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.java.net/jmc/pull/167