RFR: 6996: Properly support converters

[Marcus Hirt]

On Thu, 26 Nov 2020 20:39:18 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> Including simple test to verify that the resulting instrumented methods are ok.
>
> agent/src/main/java/org/openjdk/jmc/agent/converters/FileConverter.java line 51:
> 
>> 49: 			return file.getCanonicalPath();
>> 50: 		} catch (Throwable e) {
>> 51: 			Agent.getLogger().warning("Agent failed to convert file to String: " + e.getMessage());
> 
> Should propagate the original exception instead of just its message?

I thought it might be annoying, since you know where you've declared them. But perhaps I should - there might be multiple locations. Another variant would be to silently ignore and just return the path, but perhaps you do want to know.

-------------

PR: https://git.openjdk.java.net/jmc/pull/168