RFR: 6996: Properly support converters [v2]

Marcus Hirt hirt at openjdk.java.net
Fri Nov 27 09:34:21 UTC 2020


On Fri, 27 Nov 2020 09:30:51 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Including simple test to verify that the resulting instrumented methods are ok.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixes missing license headers, transients and exception

agent/.settings/org.eclipse.jdt.core.prefs line 4:

> 2: org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
> 3: org.eclipse.jdt.core.compiler.codegen.methodParameters=do not generate
> 4: org.eclipse.jdt.core.compiler.codegen.targetPlatform=11

Note that this will be changed back by @Josh-Matsuoka once the JDK 8 fixes are in. :)

agent/src/main/java/org/openjdk/jmc/agent/Agent.java line 60:

> 58: 	 * This should be generated as part of the build later.
> 59: 	 */
> 60: 	public final static String VERSION = "0.1.0"; //$NON-NLS-1$

Perhaps we want to bump this to 0.9 or something, signifying that we're getting close to production ready?

-------------

PR: https://git.openjdk.java.net/jmc/pull/168


More information about the jmc-dev mailing list