RFR: 6996: Properly support converters [v6]

Marcus Hirt hirt at openjdk.java.net
Fri Nov 27 17:45:00 UTC 2020


On Fri, 27 Nov 2020 17:09:20 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing JMX serialization
>
> core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/baseline/JfrRuleBaseline.xml line 1:
> 
>> 1: <?xml version="1.0" encoding="UTF-8" standalone="no"?>
> 
> Should be excluded still, I think?

It should at least be added in a separate issue. ;)

> agent/src/main/java/org/openjdk/jmc/agent/util/TypeUtils.java line 224:
> 
>> 222: 		/*
>> 223: 		 * if (convertable.getConverterClassName() != null) { return false; }
>> 224: 		 */
> 
> A left-over?

Yep. Thanks!

-------------

PR: https://git.openjdk.java.net/jmc/pull/168


More information about the jmc-dev mailing list