From thomas.stuefe at gmail.com  Thu Oct  1 07:02:16 2020
From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=)
Date: Thu, 1 Oct 2020 09:02:16 +0200
Subject: Event Browser column sort order
Message-ID: <CAA-vtUwC_C_a1OieRGEsoXwBAhssnTyhRsbgG5HxfmYy_cJ5gA@mail.gmail.com>

Hi all,

I find the column sort order in the Event Browser not really helpful. It
seems to be alphabetically sorted (see e.g. MetaspaceSummary).

It would be better if the order the events are specified at in
share/jfr/metadata/metadata.xml would be used. E.g. for GC related events
I'd always expect gcid and "When" in the first two columns.

If that is too complicated, how about sorting by name instead of label? Or
introducing an "order" field and sorting by that?

Thanks, Thomas

From github.com+4610701+jpbempel at openjdk.java.net  Thu Oct  1 16:11:13 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Thu, 1 Oct 2020 16:11:13 GMT
Subject: RFR: 6766: Add heap usage before and after GC to the Garbage
 Collections table [v2]
In-Reply-To: <FmGNJ1AJayDV_PlfvZQ6z6ReoHNWx4QeaDOpHJJa0cg=.8e7ea41d-d0ab-4aaf-9334-88c183c25512@github.com>
References: <FmGNJ1AJayDV_PlfvZQ6z6ReoHNWx4QeaDOpHJJa0cg=.8e7ea41d-d0ab-4aaf-9334-88c183c25512@github.com>
Message-ID: <8WS80GFNTiug8IT9cRziJhj7F1b0FgWUs9M0lXni7o4=.cec37681-fb0b-43fc-90e8-93152491c6d4@github.com>

> Columns are hidden for now
> 
> Here some screenshots of the changes:
> 
> ![JMC_UsedHeapBeforeAfterGC](https://user-images.githubusercontent.com/4610701/94465934-f030a300-01c0-11eb-8492-2b921f695833.png)
> 
> 
> 
> ![JMC_UsedHeapBeforeAfterGCColumns](https://user-images.githubusercontent.com/4610701/94465962-fc1c6500-01c0-11eb-8dc9-5b3346668381.png)

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  fix constant names with underscore

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/112/files
  - new: https://git.openjdk.java.net/jmc/pull/112/files/962b2453..d03089d6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=112&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=112&range=00-01

  Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/112.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/112/head:pull/112

PR: https://git.openjdk.java.net/jmc/pull/112

From hirt at openjdk.java.net  Thu Oct  1 17:27:07 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 1 Oct 2020 17:27:07 GMT
Subject: Integrated: 6909: Upgrade to Eclipse 2020-09
In-Reply-To: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
Message-ID: <t2oE1Zjwi-j3lVOFsDUBaZ-CvmmzdDRb46FsREiHu4U=.b72c17e3-5b5a-4556-b6da-9d51790a6536@github.com>

On Mon, 21 Sep 2020 10:38:50 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
> be the default.

This pull request has now been integrated.

Changeset: a63a7067
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/a63a7067
Stats:     1270 lines in 35 files changed: 418 ins; 199 del; 653 mod

6909: Upgrade to Eclipse 2020-09

Reviewed-by: neugens, ghb, aptmac

-------------

PR: https://git.openjdk.java.net/jmc/pull/111

From hirt at openjdk.java.net  Thu Oct  1 17:27:07 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 1 Oct 2020 17:27:07 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v13]
In-Reply-To: <iLKO7-FFSOfUW28qfw6FdWryecP0d9JNUagrnABVI8k=.898638ae-bcad-4f78-9d12-7e0610b21d97@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
 <PkKBW8gz1-iGYZXEwSs8GgJbCeznZjSzYA5s_q8E6vM=.10722998-e116-466f-8fc7-1c17e89c413c@github.com>
 <iLKO7-FFSOfUW28qfw6FdWryecP0d9JNUagrnABVI8k=.898638ae-bcad-4f78-9d12-7e0610b21d97@github.com>
Message-ID: <KAOG7wf7bUO5UYa7ReVj3B9Mls5zYk4tW1NyrogUSlg=.cabb5dc4-4509-42b1-a734-ce1f81211f0f@github.com>

On Wed, 30 Sep 2020 11:39:24 GMT, Guru Hb <ghb at openjdk.org> wrote:

>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Formatting
>
> Looks good to me, Verified unittest on windows and linux.

Bombs away! Let me know if you run into trouble.

-------------

PR: https://git.openjdk.java.net/jmc/pull/111

From hirt at openjdk.java.net  Thu Oct  1 17:28:05 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 1 Oct 2020 17:28:05 GMT
Subject: RFR: 6766: Add heap usage before and after GC to the Garbage
 Collections table [v2]
In-Reply-To: <8WS80GFNTiug8IT9cRziJhj7F1b0FgWUs9M0lXni7o4=.cec37681-fb0b-43fc-90e8-93152491c6d4@github.com>
References: <FmGNJ1AJayDV_PlfvZQ6z6ReoHNWx4QeaDOpHJJa0cg=.8e7ea41d-d0ab-4aaf-9334-88c183c25512@github.com>
 <8WS80GFNTiug8IT9cRziJhj7F1b0FgWUs9M0lXni7o4=.cec37681-fb0b-43fc-90e8-93152491c6d4@github.com>
Message-ID: <l_s3yown6T_j99XCcP_DQk_uP21UcQHt-FZSoDMS_Cw=.d91afd45-ab90-4b4b-b111-3355f8596c3d@github.com>

On Thu, 1 Oct 2020 16:11:13 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> Columns are hidden for now
>> 
>> Here some screenshots of the changes:
>> 
>> ![JMC_UsedHeapBeforeAfterGC](https://user-images.githubusercontent.com/4610701/94465934-f030a300-01c0-11eb-8492-2b921f695833.png)
>> 
>> 
>> 
>> ![JMC_UsedHeapBeforeAfterGCColumns](https://user-images.githubusercontent.com/4610701/94465962-fc1c6500-01c0-11eb-8dc9-5b3346668381.png)
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix constant names with underscore

Marked as reviewed by hirt (Lead).

Changes requested by hirt (Lead).

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/GarbageCollectionsPage.java
line 322:

> 320: 						o -> ((GC) o).getRefCount(t)).style(SWT.RIGHT).build());
> 321: 			}
> 322: 			columns.add(new ColumnBuilder(Messages.GarbageCollectionsPage_USED_HEAP_BEFOREGC, "usedHeapBegoreGC",
> //$NON-NLS-1$

Forgot to update these.

-------------

PR: https://git.openjdk.java.net/jmc/pull/112

From github.com+4610701+jpbempel at openjdk.java.net  Thu Oct  1 19:30:12 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Thu, 1 Oct 2020 19:30:12 GMT
Subject: RFR: 6766: Add heap usage before and after GC to the Garbage
 Collections table [v3]
In-Reply-To: <FmGNJ1AJayDV_PlfvZQ6z6ReoHNWx4QeaDOpHJJa0cg=.8e7ea41d-d0ab-4aaf-9334-88c183c25512@github.com>
References: <FmGNJ1AJayDV_PlfvZQ6z6ReoHNWx4QeaDOpHJJa0cg=.8e7ea41d-d0ab-4aaf-9334-88c183c25512@github.com>
Message-ID: <sou48Fa0wAEhDkMJ2SamZV9XVyeGcRNDvhU5tsRnH7g=.28742c82-5999-40eb-92ef-c79d0581e78d@github.com>

> Columns are hidden for now
> 
> Here some screenshots of the changes:
> 
> ![JMC_UsedHeapBeforeAfterGC](https://user-images.githubusercontent.com/4610701/94465934-f030a300-01c0-11eb-8492-2b921f695833.png)
> 
> 
> 
> ![JMC_UsedHeapBeforeAfterGCColumns](https://user-images.githubusercontent.com/4610701/94465962-fc1c6500-01c0-11eb-8dc9-5b3346668381.png)

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  fix constant name for columns

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/112/files
  - new: https://git.openjdk.java.net/jmc/pull/112/files/d03089d6..6c82cdbc

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=112&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=112&range=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/112.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/112/head:pull/112

PR: https://git.openjdk.java.net/jmc/pull/112

From github.com+4610701+jpbempel at openjdk.java.net  Fri Oct  2 06:38:07 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Fri, 2 Oct 2020 06:38:07 GMT
Subject: RFR: 6905: Add rule for heap dumps
Message-ID: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>

Rule based on ne JDK15 jdk.HeapDump event.
If at least on heap dump is performed, rule indicates it as information, score 50.
For test added a new JFR file containing an example where 2 dumps were performed

-------------

Commit messages:
 - Add rule for heap dumps

Changes: https://git.openjdk.java.net/jmc/pull/113/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=113&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6905
  Stats: 571 lines in 8 files changed: 571 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/113.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/113/head:pull/113

PR: https://git.openjdk.java.net/jmc/pull/113

From hirt at openjdk.java.net  Fri Oct  2 06:38:07 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 2 Oct 2020 06:38:07 GMT
Subject: RFR: 6905: Add rule for heap dumps
In-Reply-To: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
References: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
Message-ID: <shHnSfrvpi6Hi_lA-TYFhIOa5zbDtjW841y7oLTXBHY=.beaff79f-5a31-4d2a-9054-cd344a2b3b10@github.com>

On Thu, 1 Oct 2020 21:08:42 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> Rule based on ne JDK15 jdk.HeapDump event.
> If at least on heap dump is performed, rule indicates it as information, score 50.
> For test added a new JFR file containing an example where 2 dumps were performed

Hi @jpbempel - run mvn spotless:apply, and the remaining problem should go away. :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/113

From github.com+4610701+jpbempel at openjdk.java.net  Fri Oct  2 06:48:11 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Fri, 2 Oct 2020 06:48:11 GMT
Subject: RFR: 6905: Add rule for heap dumps [v2]
In-Reply-To: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
References: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
Message-ID: <XHLqJE3Sf49cdZ-shcOnDFiFteQlb12l-iLnh2TXXeQ=.3536b3c7-e060-4169-8d38-7ac9b3d16d66@github.com>

> Rule based on ne JDK15 jdk.HeapDump event.
> If at least on heap dump is performed, rule indicates it as information, score 50.
> For test added a new JFR file containing an example where 2 dumps were performed

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  fix formatting

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/113/files
  - new: https://git.openjdk.java.net/jmc/pull/113/files/c712184f..3a0eb713

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=113&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=113&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/113.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/113/head:pull/113

PR: https://git.openjdk.java.net/jmc/pull/113

From github.com+4610701+jpbempel at openjdk.java.net  Fri Oct  2 06:48:12 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Fri, 2 Oct 2020 06:48:12 GMT
Subject: RFR: 6905: Add rule for heap dumps
In-Reply-To: <shHnSfrvpi6Hi_lA-TYFhIOa5zbDtjW841y7oLTXBHY=.beaff79f-5a31-4d2a-9054-cd344a2b3b10@github.com>
References: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
 <shHnSfrvpi6Hi_lA-TYFhIOa5zbDtjW841y7oLTXBHY=.beaff79f-5a31-4d2a-9054-cd344a2b3b10@github.com>
Message-ID: <jnidF0moUD87Rl8atQBjbyjc_LR8A3cj5-miBqOakOE=.09f6ec3a-fe77-4ee5-8ce6-8ed1bdab9fdb@github.com>

On Thu, 1 Oct 2020 21:37:39 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Rule based on ne JDK15 jdk.HeapDump event.
>> If at least on heap dump is performed, rule indicates it as information, score 50.
>> For test added a new JFR file containing an example where 2 dumps were performed
>
> Hi @jpbempel - run mvn spotless:apply, and the remaining problem should go away. :)

hi @thegreystone , in fact running `spotless:apply` did not fix anything.
strangely enough, it passes on windows. and I committed from Window BTW.

-------------

PR: https://git.openjdk.java.net/jmc/pull/113

From github.com+4610701+jpbempel at openjdk.java.net  Fri Oct  2 08:49:35 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Fri, 2 Oct 2020 08:49:35 GMT
Subject: RFR: 6905: Add rule for heap dumps
In-Reply-To: <jnidF0moUD87Rl8atQBjbyjc_LR8A3cj5-miBqOakOE=.09f6ec3a-fe77-4ee5-8ce6-8ed1bdab9fdb@github.com>
References: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
 <shHnSfrvpi6Hi_lA-TYFhIOa5zbDtjW841y7oLTXBHY=.beaff79f-5a31-4d2a-9054-cd344a2b3b10@github.com>
 <jnidF0moUD87Rl8atQBjbyjc_LR8A3cj5-miBqOakOE=.09f6ec3a-fe77-4ee5-8ce6-8ed1bdab9fdb@github.com>
Message-ID: <RZVzJiVAj7L69kt9Ky59iBJVw5dJBgAZbTaE1ohX-4A=.4c082f92-fa2c-4607-8cc8-1e1fd6cb42fc@github.com>

On Fri, 2 Oct 2020 06:45:28 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> Hi @jpbempel - run mvn spotless:apply, and the remaining problem should go away. :)
>
> hi @thegreystone , in fact running `spotless:apply` did not fix anything.
> strangely enough, it passes on windows. And I committed from Windows BTW.

with WSL 2, I was able to reproduce the formatting errors, but no on native windows.
I think there is an issue with spotless on windows

-------------

PR: https://git.openjdk.java.net/jmc/pull/113

From github.com+4610701+jpbempel at openjdk.java.net  Fri Oct  2 15:36:51 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Fri, 2 Oct 2020 15:36:51 GMT
Subject: RFR: 6905: Add rule for heap dumps [v3]
In-Reply-To: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
References: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
Message-ID: <QZAKRd-37VancdrtuEFHTIDCWDfBVahRhgZLk-ux4qA=.a0f56d53-4c12-45a6-8ca3-3a91fc2509e9@github.com>

> Rule based on ne JDK15 jdk.HeapDump event.
> If at least on heap dump is performed, rule indicates it as information, score 50.
> For test added a new JFR file containing an example where 2 dumps were performed

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  fix formatting

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/113/files
  - new: https://git.openjdk.java.net/jmc/pull/113/files/3a0eb713..821404c0

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=113&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=113&range=01-02

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/113.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/113/head:pull/113

PR: https://git.openjdk.java.net/jmc/pull/113

From github.com+4610701+jpbempel at openjdk.java.net  Fri Oct  2 15:36:53 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Fri, 2 Oct 2020 15:36:53 GMT
Subject: RFR: 6905: Add rule for heap dumps
In-Reply-To: <RZVzJiVAj7L69kt9Ky59iBJVw5dJBgAZbTaE1ohX-4A=.4c082f92-fa2c-4607-8cc8-1e1fd6cb42fc@github.com>
References: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
 <shHnSfrvpi6Hi_lA-TYFhIOa5zbDtjW841y7oLTXBHY=.beaff79f-5a31-4d2a-9054-cd344a2b3b10@github.com>
 <jnidF0moUD87Rl8atQBjbyjc_LR8A3cj5-miBqOakOE=.09f6ec3a-fe77-4ee5-8ce6-8ed1bdab9fdb@github.com>
 <RZVzJiVAj7L69kt9Ky59iBJVw5dJBgAZbTaE1ohX-4A=.4c082f92-fa2c-4607-8cc8-1e1fd6cb42fc@github.com>
Message-ID: <MfZTvhzHXubvK5m_l0IBGhoE7nwFpvzqPpB1vPxjgPc=.8dc8a726-9dad-4492-9651-44e56debfdcf@github.com>

On Fri, 2 Oct 2020 08:46:46 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> hi @thegreystone , in fact running `spotless:apply` did not fix anything.
>> strangely enough, it passes on windows. And I committed from Windows BTW.
>
> with WSL 2, I was able to reproduce the formatting errors, but no on native windows.
> I think there is an issue with spotless on windows

ok find the issue related to windows script: checkformatting.bat
it basically stopped after the `mvn p2:site` command and not run the spotless check
I can fix that if you want in a separate PR but I think need an issue in JIRA

-------------

PR: https://git.openjdk.java.net/jmc/pull/113

From hirt at openjdk.java.net  Fri Oct  2 15:43:36 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 2 Oct 2020 15:43:36 GMT
Subject: RFR: 6905: Add rule for heap dumps
In-Reply-To: <MfZTvhzHXubvK5m_l0IBGhoE7nwFpvzqPpB1vPxjgPc=.8dc8a726-9dad-4492-9651-44e56debfdcf@github.com>
References: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
 <shHnSfrvpi6Hi_lA-TYFhIOa5zbDtjW841y7oLTXBHY=.beaff79f-5a31-4d2a-9054-cd344a2b3b10@github.com>
 <jnidF0moUD87Rl8atQBjbyjc_LR8A3cj5-miBqOakOE=.09f6ec3a-fe77-4ee5-8ce6-8ed1bdab9fdb@github.com>
 <RZVzJiVAj7L69kt9Ky59iBJVw5dJBgAZbTaE1ohX-4A=.4c082f92-fa2c-4607-8cc8-1e1fd6cb42fc@github.com>
 <MfZTvhzHXubvK5m_l0IBGhoE7nwFpvzqPpB1vPxjgPc=.8dc8a726-9dad-4492-9651-44e56debfdcf@github.com>
Message-ID: <rgLiNfONmdC-1S9gTtJvL1ulbsiQZGJlIwPV1wx8Y0M=.2de14344-1b53-4639-8af3-6dfe377f6e61@github.com>

On Fri, 2 Oct 2020 15:32:16 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> with WSL 2, I was able to reproduce the formatting errors, but no on native windows.
>> I think there is an issue with spotless on windows
>
> ok find the issue related to windows script: checkformatting.bat
> it basically stopped after the `mvn p2:site` command and not run the spotless check
> I can fix that if you want in a separate PR but I think need an issue in JIRA

I created https://bugs.openjdk.java.net/browse/JMC-6914.

-------------

PR: https://git.openjdk.java.net/jmc/pull/113

From hirt at openjdk.java.net  Fri Oct  2 15:44:39 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 2 Oct 2020 15:44:39 GMT
Subject: RFR: 6766: Add heap usage before and after GC to the Garbage
 Collections table [v3]
In-Reply-To: <sou48Fa0wAEhDkMJ2SamZV9XVyeGcRNDvhU5tsRnH7g=.28742c82-5999-40eb-92ef-c79d0581e78d@github.com>
References: <FmGNJ1AJayDV_PlfvZQ6z6ReoHNWx4QeaDOpHJJa0cg=.8e7ea41d-d0ab-4aaf-9334-88c183c25512@github.com>
 <sou48Fa0wAEhDkMJ2SamZV9XVyeGcRNDvhU5tsRnH7g=.28742c82-5999-40eb-92ef-c79d0581e78d@github.com>
Message-ID: <wlH9oX25wD8AhLQLDWCY9dMskoqqD9PmNmC_1Ze0bsA=.fb53d2ab-1250-43e3-a07e-0d7570a1a3fb@github.com>

On Thu, 1 Oct 2020 19:30:12 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> Columns are hidden for now
>> 
>> Here some screenshots of the changes:
>> 
>> ![JMC_UsedHeapBeforeAfterGC](https://user-images.githubusercontent.com/4610701/94465934-f030a300-01c0-11eb-8492-2b921f695833.png)
>> 
>> 
>> 
>> ![JMC_UsedHeapBeforeAfterGCColumns](https://user-images.githubusercontent.com/4610701/94465962-fc1c6500-01c0-11eb-8dc9-5b3346668381.png)
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix constant name for columns

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/112

From github.com+4610701+jpbempel at openjdk.java.net  Fri Oct  2 16:40:39 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Fri, 2 Oct 2020 16:40:39 GMT
Subject: Integrated: 6766: Add heap usage before and after GC to the Garbage
 Collections table
In-Reply-To: <FmGNJ1AJayDV_PlfvZQ6z6ReoHNWx4QeaDOpHJJa0cg=.8e7ea41d-d0ab-4aaf-9334-88c183c25512@github.com>
References: <FmGNJ1AJayDV_PlfvZQ6z6ReoHNWx4QeaDOpHJJa0cg=.8e7ea41d-d0ab-4aaf-9334-88c183c25512@github.com>
Message-ID: <CCC6XWRRA5BFHfPfdCBRtcxxfXmXqKoAi-k2qlnbJew=.3e4bce9a-18c5-4d45-8b9a-61c64f307d25@github.com>

On Mon, 28 Sep 2020 17:30:35 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> Columns are hidden for now
> 
> Here some screenshots of the changes:
> 
> ![JMC_UsedHeapBeforeAfterGC](https://user-images.githubusercontent.com/4610701/94465934-f030a300-01c0-11eb-8492-2b921f695833.png)
> 
> 
> 
> ![JMC_UsedHeapBeforeAfterGCColumns](https://user-images.githubusercontent.com/4610701/94465962-fc1c6500-01c0-11eb-8dc9-5b3346668381.png)

This pull request has now been integrated.

Changeset: 97f4d9ff
Author:    Jean-Philippe Bempel <jean-philippe at bempel.fr>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/97f4d9ff
Stats:     16 lines in 3 files changed: 14 ins; 0 del; 2 mod

6766: Add heap usage before and after GC to the Garbage Collections table

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/112

From github.com+4610701+jpbempel at openjdk.java.net  Fri Oct  2 17:26:43 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Fri, 2 Oct 2020 17:26:43 GMT
Subject: RFR: 6914: Fix windows check formatting script
Message-ID: <Wjz9mVVKBMM-edD_fT8GVIzL7VOLfm4ZmZu67kBI0sE=.db3e1340-d36d-4ac6-b3ab-253d2cf4b4bd@github.com>

because mvn is itself a script we need to call with call command
to get control back to the main script

-------------

Commit messages:
 - Fix windows check formatting script

Changes: https://git.openjdk.java.net/jmc/pull/114/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=114&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6914
  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/114.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/114/head:pull/114

PR: https://git.openjdk.java.net/jmc/pull/114

From hirt at openjdk.java.net  Fri Oct  2 17:49:34 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 2 Oct 2020 17:49:34 GMT
Subject: RFR: 6914: Fix windows check formatting script
In-Reply-To: <Wjz9mVVKBMM-edD_fT8GVIzL7VOLfm4ZmZu67kBI0sE=.db3e1340-d36d-4ac6-b3ab-253d2cf4b4bd@github.com>
References: <Wjz9mVVKBMM-edD_fT8GVIzL7VOLfm4ZmZu67kBI0sE=.db3e1340-d36d-4ac6-b3ab-253d2cf4b4bd@github.com>
Message-ID: <4tPlQwAiOilt7E5JwVC1hlr7CHqrqjNasS8uG2LMChE=.ecaf8cc9-70fc-4a56-9f67-0944c5fdd73b@github.com>

On Fri, 2 Oct 2020 17:23:45 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> because mvn is itself a script we need to call with call command
> to get control back to the main script

Updated the bug with some additional thoughts:
https://bugs.openjdk.java.net/browse/JMC-6914

-------------

PR: https://git.openjdk.java.net/jmc/pull/114

From hirt at openjdk.java.net  Fri Oct  2 20:43:39 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 2 Oct 2020 20:43:39 GMT
Subject: RFR: 6905: Add rule for heap dumps [v3]
In-Reply-To: <QZAKRd-37VancdrtuEFHTIDCWDfBVahRhgZLk-ux4qA=.a0f56d53-4c12-45a6-8ca3-3a91fc2509e9@github.com>
References: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
 <QZAKRd-37VancdrtuEFHTIDCWDfBVahRhgZLk-ux4qA=.a0f56d53-4c12-45a6-8ca3-3a91fc2509e9@github.com>
Message-ID: <Yl9EYHEi4ySPPf8qe4NSD_vkbtTLBSKLNIxcZ3UajaY=.d76f8f02-f75a-46d1-9738-adff830d0535@github.com>

On Fri, 2 Oct 2020 15:36:51 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> Rule based on ne JDK15 jdk.HeapDump event.
>> If at least on heap dump is performed, rule indicates it as information, score 50.
>> For test added a new JFR file containing an example where 2 dumps were performed
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix formatting

Changes requested by hirt (Lead).

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/HeapDumpRule.java
line 1:

> 1: package org.openjdk.jmc.flightrecorder.rules.jdk.memory;

Must have copyright notice - look for one with Datadog in it to copy. Should have Oracle first, Datadog next, 2020.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/HeapDumpRule.java
line 1:

> 1: package org.openjdk.jmc.flightrecorder.rules.jdk.memory;

Needs copyright notice. Copy one which includes Datadog, ensure year is set to 2020. (The Datadog part is not added
retroactively to files initiated by Oracle, but for entirely new files, like this one, we should add it.)

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties
line 322:

> 320: HeapContentRuleFactory_TEXT_OK=No problems were found with the heap content.
> 321: HeapInspectionGcRuleFactory_RULE_NAME=GCs Caused by Heap Inspection
> 322: HeapDumpRule_RULE_NAME=Heap Dump

Update copyright year. Should be "2018, 2020, ".

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/Messages.java
line 299:

> 297: 	public static final String HeapContentRuleFactory_TEXT_OK = "HeapContentRuleFactory_TEXT_OK"; //$NON-NLS-1$
> 298: 	public static final String HeapContentRule_AGGR_CLASS_SCORE = "HeapContentRule_AGGR_CLASS_SCORE"; //$NON-NLS-1$
> 299: 	public static final String HeapDumpRule_RULE_NAME = "HeapDumpRule_RULE_NAME"; //$NON-NLS-1$

Update copyright year. Should be "2018, 2020, ".

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/META-INF/services/org.openjdk.jmc.flightrecorder.rules.IRule
line 80:

> 78: org.openjdk.jmc.flightrecorder.rules.jdk.memory.GcPauseRatioRule
> 79: org.openjdk.jmc.flightrecorder.rules.jdk.memory.HeapContentRule
> 80: org.openjdk.jmc.flightrecorder.rules.jdk.memory.HeapDumpRule

Update copyright year. Should be "2018, 2020, ".

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkTypeIDs.java line 201:

> 199:
> 200: 	public static final String NATIVE_LIBRARY = PREFIX + "NativeLibrary";
> 201:

Copyright year in this file should be updated to "2018, 2020".

-------------

PR: https://git.openjdk.java.net/jmc/pull/113

From hirt at openjdk.java.net  Fri Oct  2 21:55:40 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 2 Oct 2020 21:55:40 GMT
Subject: RFR: 6915: JMC dev launchers do not include JOverflow
Message-ID: <640UB7Z_4yPezKr4-Vu4aE-X1gz_7hxQlMeX8ksWzoc=.e434c5ee-8027-40eb-8240-9c33d6d9037a@github.com>

Also cleaned up formatting and added proper license headers.

-------------

Commit messages:
 - Added ending line breaks where missing for consistency
 - 6915: JMC dev launchers do not include JOverflow

Changes: https://git.openjdk.java.net/jmc/pull/115/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=115&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6915
  Stats: 740 lines in 9 files changed: 176 ins; 0 del; 564 mod
  Patch: https://git.openjdk.java.net/jmc/pull/115.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/115/head:pull/115

PR: https://git.openjdk.java.net/jmc/pull/115

From hirt at openjdk.java.net  Fri Oct  2 22:03:39 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 2 Oct 2020 22:03:39 GMT
Subject: RFR: 6916: JOverflow treemap listener depending on internal SWT class
Message-ID: <1BvV5hl5AmO9OTwbj-lXjCuGix84ePJt7ckRd1Ua2DQ=.dc633c57-481d-419a-b6bb-35864b939d92@github.com>

Also removing unused constant.

-------------

Commit messages:
 - 6916: JOverflow treemap listener depending on internal SWT class

Changes: https://git.openjdk.java.net/jmc/pull/116/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=116&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6916
  Stats: 8 lines in 2 files changed: 2 ins; 4 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/116.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/116/head:pull/116

PR: https://git.openjdk.java.net/jmc/pull/116

From hirt at openjdk.java.net  Fri Oct  2 22:18:40 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 2 Oct 2020 22:18:40 GMT
Subject: RFR: 6917: Clean warnings in the agent project
Message-ID: <bjOkkdmkV3esy3kkfWfvvMWqtL3Vf0ZD_Jcr5KJc9KI=.6482a2eb-937c-4321-a886-8d792fa31ce1@github.com>

Also project compiler setting mismatch.

-------------

Commit messages:
 - 6917: Clean warnings in the agent project

Changes: https://git.openjdk.java.net/jmc/pull/117/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=117&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6917
  Stats: 21 lines in 5 files changed: 9 ins; 6 del; 6 mod
  Patch: https://git.openjdk.java.net/jmc/pull/117.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/117/head:pull/117

PR: https://git.openjdk.java.net/jmc/pull/117

From hirt at openjdk.java.net  Fri Oct  2 22:32:39 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 2 Oct 2020 22:32:39 GMT
Subject: RFR: 6837: More formal tone in the agent settings
Message-ID: <nAe8qxOo3rExrJcC0uPODi_d4ZWHO4VsQu7jVjzQx6w=.77d35440-1da3-43cc-8a28-fa0dd55763f8@github.com>

Wasn't as bad as I remembered it.

-------------

Commit messages:
 - 6837: More formal tone in the agent settings

Changes: https://git.openjdk.java.net/jmc/pull/118/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=118&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6837
  Stats: 14 lines in 2 files changed: 2 ins; 0 del; 12 mod
  Patch: https://git.openjdk.java.net/jmc/pull/118.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/118/head:pull/118

PR: https://git.openjdk.java.net/jmc/pull/118

From github.com+4610701+jpbempel at openjdk.java.net  Sat Oct  3 08:19:43 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sat, 3 Oct 2020 08:19:43 GMT
Subject: RFR: 6914: Fix windows check formatting script [v2]
In-Reply-To: <Wjz9mVVKBMM-edD_fT8GVIzL7VOLfm4ZmZu67kBI0sE=.db3e1340-d36d-4ac6-b3ab-253d2cf4b4bd@github.com>
References: <Wjz9mVVKBMM-edD_fT8GVIzL7VOLfm4ZmZu67kBI0sE=.db3e1340-d36d-4ac6-b3ab-253d2cf4b4bd@github.com>
Message-ID: <3SFf-s5IZqkU0FM5DzS9IUb_uT_-sZrySdH3YAktVGs=.9e0c36f0-c97b-471a-8aec-c2b0ba4ea9df@github.com>

> because mvn is itself a script we need to call with call command
> to get control back to the main script

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  fail fast on calls

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/114/files
  - new: https://git.openjdk.java.net/jmc/pull/114/files/2407fd76..f52e9342

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=114&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=114&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/114.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/114/head:pull/114

PR: https://git.openjdk.java.net/jmc/pull/114

From github.com+4610701+jpbempel at openjdk.java.net  Sat Oct  3 08:19:43 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sat, 3 Oct 2020 08:19:43 GMT
Subject: RFR: 6914: Fix windows check formatting script
In-Reply-To: <4tPlQwAiOilt7E5JwVC1hlr7CHqrqjNasS8uG2LMChE=.ecaf8cc9-70fc-4a56-9f67-0944c5fdd73b@github.com>
References: <Wjz9mVVKBMM-edD_fT8GVIzL7VOLfm4ZmZu67kBI0sE=.db3e1340-d36d-4ac6-b3ab-253d2cf4b4bd@github.com>
 <4tPlQwAiOilt7E5JwVC1hlr7CHqrqjNasS8uG2LMChE=.ecaf8cc9-70fc-4a56-9f67-0944c5fdd73b@github.com>
Message-ID: <aJ2rzCipjOc8VyatGct_K5CPehCXyWOOTxTVeqkYPEE=.13b3f73e-273f-4090-9d67-ffddcaa0df57@github.com>

On Fri, 2 Oct 2020 17:47:12 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> because mvn is itself a script we need to call with call command
>> to get control back to the main script
>
> Updated the bug with some additional thoughts:
> https://bugs.openjdk.java.net/browse/JMC-6914

Added the exit on failed calls

-------------

PR: https://git.openjdk.java.net/jmc/pull/114

From github.com+4610701+jpbempel at openjdk.java.net  Sat Oct  3 11:56:45 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sat, 3 Oct 2020 11:56:45 GMT
Subject: RFR: 6905: Add rule for heap dumps [v4]
In-Reply-To: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
References: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
Message-ID: <iNAXph-XH21TjvcHVwpGExMOcWeiP0fxvRSCZOfRPOU=.1a297463-f5f5-45c4-b605-8ff0cacc2692@github.com>

> Rule based on ne JDK15 jdk.HeapDump event.
> If at least on heap dump is performed, rule indicates it as information, score 50.
> For test added a new JFR file containing an example where 2 dumps were performed

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  Amend copyright years

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/113/files
  - new: https://git.openjdk.java.net/jmc/pull/113/files/821404c0..fda6458a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=113&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=113&range=02-03

  Stats: 36 lines in 5 files changed: 32 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/113.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/113/head:pull/113

PR: https://git.openjdk.java.net/jmc/pull/113

From hirt at openjdk.java.net  Sat Oct  3 12:03:36 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 3 Oct 2020 12:03:36 GMT
Subject: RFR: 6905: Add rule for heap dumps [v4]
In-Reply-To: <iNAXph-XH21TjvcHVwpGExMOcWeiP0fxvRSCZOfRPOU=.1a297463-f5f5-45c4-b605-8ff0cacc2692@github.com>
References: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
 <iNAXph-XH21TjvcHVwpGExMOcWeiP0fxvRSCZOfRPOU=.1a297463-f5f5-45c4-b605-8ff0cacc2692@github.com>
Message-ID: <6_oOcols1MbKJn4Lr8_WuXaqhPi96_y8-drn9W-UWWA=.a154a8e7-77c3-45fa-a115-4e71091b5d89@github.com>

On Sat, 3 Oct 2020 11:56:45 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> Rule based on ne JDK15 jdk.HeapDump event.
>> If at least on heap dump is performed, rule indicates it as information, score 50.
>> For test added a new JFR file containing an example where 2 dumps were performed
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Amend copyright years

Changes requested by hirt (Lead).

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/HeapDumpRule.java
line 2:

> 1: /*
> 2:  * Copyright (c) 2020, Datadog, Inc. All rights reserved.

Needs the Oracle copyright above the Datadog one.

-------------

PR: https://git.openjdk.java.net/jmc/pull/113

From github.com+4610701+jpbempel at openjdk.java.net  Sat Oct  3 13:49:44 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sat, 3 Oct 2020 13:49:44 GMT
Subject: RFR: 6905: Add rule for heap dumps [v5]
In-Reply-To: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
References: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
Message-ID: <1S2IS7pDA_dUY64yKHwU1-7ixSOHgtOPKSwPzhRI25o=.9935141a-3193-4ed7-b9b3-543a1cae25db@github.com>

> Rule based on ne JDK15 jdk.HeapDump event.
> If at least on heap dump is performed, rule indicates it as information, score 50.
> For test added a new JFR file containing an example where 2 dumps were performed

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  Fix license

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/113/files
  - new: https://git.openjdk.java.net/jmc/pull/113/files/fda6458a..2ea2b3e0

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=113&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=113&range=03-04

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/113.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/113/head:pull/113

PR: https://git.openjdk.java.net/jmc/pull/113

From hirt at openjdk.java.net  Sat Oct  3 20:24:37 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 3 Oct 2020 20:24:37 GMT
Subject: RFR: 6905: Add rule for heap dumps [v5]
In-Reply-To: <1S2IS7pDA_dUY64yKHwU1-7ixSOHgtOPKSwPzhRI25o=.9935141a-3193-4ed7-b9b3-543a1cae25db@github.com>
References: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
 <1S2IS7pDA_dUY64yKHwU1-7ixSOHgtOPKSwPzhRI25o=.9935141a-3193-4ed7-b9b3-543a1cae25db@github.com>
Message-ID: <UW8QR-9EwsxNxYumF1A4xXQebGR6mVJ4sPspmLvgEB8=.70af732b-41ca-45de-bb89-fddae77d23d0@github.com>

On Sat, 3 Oct 2020 13:49:44 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> Rule based on ne JDK15 jdk.HeapDump event.
>> If at least on heap dump is performed, rule indicates it as information, score 50.
>> For test added a new JFR file containing an example where 2 dumps were performed
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix license

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/113

From github.com+4610701+jpbempel at openjdk.java.net  Sun Oct  4 08:20:35 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sun, 4 Oct 2020 08:20:35 GMT
Subject: Integrated: 6905: Add rule for heap dumps
In-Reply-To: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
References: <iJPgKvZKNqBmBX8htT8c6tZe--CBmw0CiGdwJeMGmhs=.cb40c6dd-1ee0-45ab-98e4-c83aa4a68465@github.com>
Message-ID: <PsHaGCgQA4jqlsM2w_4PFlnK4ERUKXkghvMPOHOxdts=.f4809e67-bac0-4621-b9b8-fd21131a2277@github.com>

On Thu, 1 Oct 2020 21:08:42 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> Rule based on ne JDK15 jdk.HeapDump event.
> If at least on heap dump is performed, rule indicates it as information, score 50.
> For test added a new JFR file containing an example where 2 dumps were performed

This pull request has now been integrated.

Changeset: 62ed0e87
Author:    Jean-Philippe Bempel <jean-philippe at bempel.fr>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/62ed0e87
Stats:     609 lines in 8 files changed: 605 ins; 0 del; 4 mod

6905: Add rule for heap dumps

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/113

From duke at openjdk.java.net  Sun Oct  4 16:52:51 2020
From: duke at openjdk.java.net (duke)
Date: Sun, 4 Oct 2020 16:52:51 GMT
Subject: git: openjdk/jmc-graphics: 6633: Adding jcheck configuration file
Message-ID: <1645f684-7196-41b5-8976-8c1722c7d0bc@openjdk.java.net>

Changeset: fb2de197
Author:    Marcus Hirt <marcus at hirt.se>
Date:      2019-11-15 14:59:29 +0000
URL:       https://git.openjdk.java.net/jmc-graphics/commit/fb2de197

6633: Adding jcheck configuration file

+ .jcheck/conf


From hirt at openjdk.java.net  Sun Oct  4 19:15:40 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 4 Oct 2020 19:15:40 GMT
Subject: RFR: 6899: Upgrade core to 8
Message-ID: <nBjx96UCZDslQA2O1Zt-Y2m8dJ51IH_sfUkWkZxcIeY=.2f824707-946b-48fb-8648-2ca6cadc33a5@github.com>

For some reason the Eclipse compiler fails some type inferences when switching to JDK 8, so had to add some
(unnecessary) casts. (Also set JDK 11 as required for running the application builds.)

-------------

Commit messages:
 - 6899: Upgrade core to 8

Changes: https://git.openjdk.java.net/jmc/pull/120/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=120&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6899
  Stats: 155 lines in 43 files changed: 26 ins; 4 del; 125 mod
  Patch: https://git.openjdk.java.net/jmc/pull/120.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/120/head:pull/120

PR: https://git.openjdk.java.net/jmc/pull/120

From hirt at openjdk.java.net  Sun Oct  4 19:23:36 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 4 Oct 2020 19:23:36 GMT
Subject: RFR: 6914: Fix windows check formatting script [v2]
In-Reply-To: <3SFf-s5IZqkU0FM5DzS9IUb_uT_-sZrySdH3YAktVGs=.9e0c36f0-c97b-471a-8aec-c2b0ba4ea9df@github.com>
References: <Wjz9mVVKBMM-edD_fT8GVIzL7VOLfm4ZmZu67kBI0sE=.db3e1340-d36d-4ac6-b3ab-253d2cf4b4bd@github.com>
 <3SFf-s5IZqkU0FM5DzS9IUb_uT_-sZrySdH3YAktVGs=.9e0c36f0-c97b-471a-8aec-c2b0ba4ea9df@github.com>
Message-ID: <pu7XJYeeuuZAabc-M0EOrKlaTtNxs1dI__SYfSzIvvk=.1be37e18-a714-4acb-9e0a-e3b126c8fe95@github.com>

On Sat, 3 Oct 2020 08:19:43 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> because mvn is itself a script we need to call with call command
>> to get control back to the main script
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fail fast on calls

Would you perhaps want different fail codes for different fails?

-------------

Marked as reviewed by hirt (Lead).

PR: https://git.openjdk.java.net/jmc/pull/114

From hirt at openjdk.java.net  Sun Oct  4 19:25:45 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 4 Oct 2020 19:25:45 GMT
Subject: RFR: 6899: Upgrade core to 8 [v2]
In-Reply-To: <nBjx96UCZDslQA2O1Zt-Y2m8dJ51IH_sfUkWkZxcIeY=.2f824707-946b-48fb-8648-2ca6cadc33a5@github.com>
References: <nBjx96UCZDslQA2O1Zt-Y2m8dJ51IH_sfUkWkZxcIeY=.2f824707-946b-48fb-8648-2ca6cadc33a5@github.com>
Message-ID: <POKfzPEZ9UklkWPRe0gpp-L9tI6l5dzPs3Y_9UI-soY=.6bf63ac7-f335-448c-a8e1-f6bb1f81ebd6@github.com>

> For some reason the Eclipse compiler fails some type inferences when switching to JDK 8, so had to add some
> (unnecessary) casts. (Also set JDK 11 as required for running the application builds.)

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Formatting

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/120/files
  - new: https://git.openjdk.java.net/jmc/pull/120/files/96e10707..bcc22b6a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=120&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=120&range=00-01

  Stats: 23 lines in 2 files changed: 0 ins; 0 del; 23 mod
  Patch: https://git.openjdk.java.net/jmc/pull/120.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/120/head:pull/120

PR: https://git.openjdk.java.net/jmc/pull/120

From github.com+4610701+jpbempel at openjdk.java.net  Sun Oct  4 20:18:39 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sun, 4 Oct 2020 20:18:39 GMT
Subject: RFR: 6908: Rule for warning about the starting of processes
Message-ID: <pc2pjzWnFJymc17SF8uZn4F0BLd6CABi23NvByGQLWI=.d035b243-ad60-47b8-9d48-f5c62dc27c39@github.com>

When a new process was started from the current JVM, we inform with a 50 score
that 1 or more processes was started
based on new JDK15 ProcessStart event

-------------

Commit messages:
 - Rule for warning about the starting of processes

Changes: https://git.openjdk.java.net/jmc/pull/121/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=121&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6908
  Stats: 199 lines in 6 files changed: 199 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/121.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/121/head:pull/121

PR: https://git.openjdk.java.net/jmc/pull/121

From github.com+4610701+jpbempel at openjdk.java.net  Sun Oct  4 20:21:45 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sun, 4 Oct 2020 20:21:45 GMT
Subject: RFR: 6914: Fix windows check formatting script [v3]
In-Reply-To: <Wjz9mVVKBMM-edD_fT8GVIzL7VOLfm4ZmZu67kBI0sE=.db3e1340-d36d-4ac6-b3ab-253d2cf4b4bd@github.com>
References: <Wjz9mVVKBMM-edD_fT8GVIzL7VOLfm4ZmZu67kBI0sE=.db3e1340-d36d-4ac6-b3ab-253d2cf4b4bd@github.com>
Message-ID: <GyBFLSbwRN9HWVMDI-mR3Be9ume4H1KUJzLDcaHdZog=.a857b552-7809-49c4-9347-ddcab52f3b06@github.com>

> because mvn is itself a script we need to call with call command
> to get control back to the main script

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  Add different exit code for each call

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/114/files
  - new: https://git.openjdk.java.net/jmc/pull/114/files/f52e9342..15c317ae

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=114&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=114&range=01-02

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/114.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/114/head:pull/114

PR: https://git.openjdk.java.net/jmc/pull/114

From github.com+4610701+jpbempel at openjdk.java.net  Sun Oct  4 20:21:46 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sun, 4 Oct 2020 20:21:46 GMT
Subject: RFR: 6914: Fix windows check formatting script [v2]
In-Reply-To: <pu7XJYeeuuZAabc-M0EOrKlaTtNxs1dI__SYfSzIvvk=.1be37e18-a714-4acb-9e0a-e3b126c8fe95@github.com>
References: <Wjz9mVVKBMM-edD_fT8GVIzL7VOLfm4ZmZu67kBI0sE=.db3e1340-d36d-4ac6-b3ab-253d2cf4b4bd@github.com>
 <3SFf-s5IZqkU0FM5DzS9IUb_uT_-sZrySdH3YAktVGs=.9e0c36f0-c97b-471a-8aec-c2b0ba4ea9df@github.com>
 <pu7XJYeeuuZAabc-M0EOrKlaTtNxs1dI__SYfSzIvvk=.1be37e18-a714-4acb-9e0a-e3b126c8fe95@github.com>
Message-ID: <MxtZ2Rwtvak0WegyWDsF70Hv1t-7KxBXCfPfVPo93qU=.fc931748-fdb9-49e0-9051-647b8cf746b8@github.com>

On Sun, 4 Oct 2020 19:20:38 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fail fast on calls
>
> Would you perhaps want different fail codes for different fails?

Fine by me :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/114

From hirt at openjdk.java.net  Sun Oct  4 20:54:36 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 4 Oct 2020 20:54:36 GMT
Subject: RFR: 6908: Rule for warning about the starting of processes
In-Reply-To: <pc2pjzWnFJymc17SF8uZn4F0BLd6CABi23NvByGQLWI=.d035b243-ad60-47b8-9d48-f5c62dc27c39@github.com>
References: <pc2pjzWnFJymc17SF8uZn4F0BLd6CABi23NvByGQLWI=.d035b243-ad60-47b8-9d48-f5c62dc27c39@github.com>
Message-ID: <usNfFWzot5heR6BkGK5KavNZTgHRuZpvTNjzqZB7PnU=.cd5a470a-4057-452a-b595-0f4b05158c54@github.com>

On Sun, 4 Oct 2020 20:14:21 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> When a new process was started from the current JVM, we inform with a 50 score
> that 1 or more processes was started
> based on new JDK15 ProcessStart event

Formatting. ;)

-------------

PR: https://git.openjdk.java.net/jmc/pull/121

From github.com+4610701+jpbempel at openjdk.java.net  Mon Oct  5 07:17:44 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Mon, 5 Oct 2020 07:17:44 GMT
Subject: RFR: 6908: Rule for warning about the starting of processes [v2]
In-Reply-To: <pc2pjzWnFJymc17SF8uZn4F0BLd6CABi23NvByGQLWI=.d035b243-ad60-47b8-9d48-f5c62dc27c39@github.com>
References: <pc2pjzWnFJymc17SF8uZn4F0BLd6CABi23NvByGQLWI=.d035b243-ad60-47b8-9d48-f5c62dc27c39@github.com>
Message-ID: <09w7BfoJ9WkOJrHEn2E3s5DEZQxFbw2jAaXdd9F0yIM=.4fd359f9-e041-4808-8f1e-ef0b792e630c@github.com>

> When a new process was started from the current JVM, we inform with a 50 score
> that 1 or more processes was started
> based on new JDK15 ProcessStart event

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  fix formatting

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/121/files
  - new: https://git.openjdk.java.net/jmc/pull/121/files/3de783e6..284874e0

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=121&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=121&range=00-01

  Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/121.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/121/head:pull/121

PR: https://git.openjdk.java.net/jmc/pull/121

From aptmac at openjdk.java.net  Mon Oct  5 15:49:38 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 5 Oct 2020 15:49:38 GMT
Subject: RFR: 6916: JOverflow treemap listener depending on internal SWT
 class
In-Reply-To: <1BvV5hl5AmO9OTwbj-lXjCuGix84ePJt7ckRd1Ua2DQ=.dc633c57-481d-419a-b6bb-35864b939d92@github.com>
References: <1BvV5hl5AmO9OTwbj-lXjCuGix84ePJt7ckRd1Ua2DQ=.dc633c57-481d-419a-b6bb-35864b939d92@github.com>
Message-ID: <EaSesUMCvpEw9gkyh0u-ImUeSPRCjhPEJn8OYwP1F2k=.7108f3ed-c622-41ba-b184-1b06c5124f43@github.com>

On Fri, 2 Oct 2020 21:59:22 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also removing unused constant.

Marked as reviewed by aptmac (Committer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/116

From aptmac at openjdk.java.net  Mon Oct  5 16:27:37 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 5 Oct 2020 16:27:37 GMT
Subject: RFR: 6915: JMC dev launchers do not include JOverflow
In-Reply-To: <640UB7Z_4yPezKr4-Vu4aE-X1gz_7hxQlMeX8ksWzoc=.e434c5ee-8027-40eb-8240-9c33d6d9037a@github.com>
References: <640UB7Z_4yPezKr4-Vu4aE-X1gz_7hxQlMeX8ksWzoc=.e434c5ee-8027-40eb-8240-9c33d6d9037a@github.com>
Message-ID: <oD9eV6ZcRVttGCv22IbakxoGZiKCzTAnfQHWI4RCu3c=.7725881e-9d80-4016-babe-1df3ccc5461f@github.com>

On Fri, 2 Oct 2020 21:49:58 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also cleaned up formatting and added proper license headers.

Marked as reviewed by aptmac (Committer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/115

From hirt at openjdk.java.net  Mon Oct  5 17:52:38 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 5 Oct 2020 17:52:38 GMT
Subject: RFR: 6908: Rule for warning about the starting of processes [v2]
In-Reply-To: <09w7BfoJ9WkOJrHEn2E3s5DEZQxFbw2jAaXdd9F0yIM=.4fd359f9-e041-4808-8f1e-ef0b792e630c@github.com>
References: <pc2pjzWnFJymc17SF8uZn4F0BLd6CABi23NvByGQLWI=.d035b243-ad60-47b8-9d48-f5c62dc27c39@github.com>
 <09w7BfoJ9WkOJrHEn2E3s5DEZQxFbw2jAaXdd9F0yIM=.4fd359f9-e041-4808-8f1e-ef0b792e630c@github.com>
Message-ID: <tfzngfYjtxLo8-vujC_UEImgxzaygwR8NHmQaAF2n-c=.cc856ab0-42e1-4634-998f-7c8393bfa762@github.com>

On Mon, 5 Oct 2020 07:17:44 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> When a new process was started from the current JVM, we inform with a 50 score
>> that 1 or more processes was started
>> based on new JDK15 ProcessStart event
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix formatting

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/121

From ghb at openjdk.java.net  Mon Oct  5 21:05:40 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Mon, 5 Oct 2020 21:05:40 GMT
Subject: RFR: 6899: Upgrade core to 8 [v2]
In-Reply-To: <POKfzPEZ9UklkWPRe0gpp-L9tI6l5dzPs3Y_9UI-soY=.6bf63ac7-f335-448c-a8e1-f6bb1f81ebd6@github.com>
References: <nBjx96UCZDslQA2O1Zt-Y2m8dJ51IH_sfUkWkZxcIeY=.2f824707-946b-48fb-8648-2ca6cadc33a5@github.com>
 <POKfzPEZ9UklkWPRe0gpp-L9tI6l5dzPs3Y_9UI-soY=.6bf63ac7-f335-448c-a8e1-f6bb1f81ebd6@github.com>
Message-ID: <0rNZ9ZJrGRom_gaVhK0jXs2P9DF3LZDsjpT2ed4dXg4=.6900d9b6-f0da-4bca-9195-cfe80e3f663b@github.com>

On Sun, 4 Oct 2020 19:25:45 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> For some reason the Eclipse compiler fails some type inferences when switching to JDK 8, so had to add some
>> (unnecessary) casts. (Also set JDK 11 as required for running the application builds.)
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Formatting

Verified on Mac OS X and Linux.
Please update copyright year for JfrLoaderToolkit.java , Rest of the changed looks good to me.

-------------

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/120

From github.com+4610701+jpbempel at openjdk.java.net  Tue Oct  6 02:48:38 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Tue, 6 Oct 2020 02:48:38 GMT
Subject: Integrated: 6908: Rule for warning about the starting of processes
In-Reply-To: <pc2pjzWnFJymc17SF8uZn4F0BLd6CABi23NvByGQLWI=.d035b243-ad60-47b8-9d48-f5c62dc27c39@github.com>
References: <pc2pjzWnFJymc17SF8uZn4F0BLd6CABi23NvByGQLWI=.d035b243-ad60-47b8-9d48-f5c62dc27c39@github.com>
Message-ID: <7j4Xm_OonWEsarn9YkKwvi9ISegISk-tDtz1vzk65e4=.5bd2b040-40fa-4f13-a2a1-210355a5067f@github.com>

On Sun, 4 Oct 2020 20:14:21 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> When a new process was started from the current JVM, we inform with a 50 score
> that 1 or more processes was started
> based on new JDK15 ProcessStart event

This pull request has now been integrated.

Changeset: 581a13f4
Author:    Jean-Philippe Bempel <jean-philippe at bempel.fr>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/581a13f4
Stats:     200 lines in 6 files changed: 200 ins; 0 del; 0 mod

6908: Rule for warning about the starting of processes

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/121

From ghb at openjdk.java.net  Tue Oct  6 05:21:38 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Tue, 6 Oct 2020 05:21:38 GMT
Subject: RFR: 6837: More formal tone in the agent settings
In-Reply-To: <nAe8qxOo3rExrJcC0uPODi_d4ZWHO4VsQu7jVjzQx6w=.77d35440-1da3-43cc-8a28-fa0dd55763f8@github.com>
References: <nAe8qxOo3rExrJcC0uPODi_d4ZWHO4VsQu7jVjzQx6w=.77d35440-1da3-43cc-8a28-fa0dd55763f8@github.com>
Message-ID: <4PnWYQ4erAH3cEtn6WszKe76ZcnJEAmbyScETrZvcdg=.364bf6b8-45ac-4a25-a4bd-50ed545c3ca4@github.com>

On Fri, 2 Oct 2020 22:28:39 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Wasn't as bad as I remembered it.

Marked as reviewed by ghb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/118

From ghb at openjdk.java.net  Tue Oct  6 05:22:37 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Tue, 6 Oct 2020 05:22:37 GMT
Subject: RFR: 6917: Clean warnings in the agent project
In-Reply-To: <bjOkkdmkV3esy3kkfWfvvMWqtL3Vf0ZD_Jcr5KJc9KI=.6482a2eb-937c-4321-a886-8d792fa31ce1@github.com>
References: <bjOkkdmkV3esy3kkfWfvvMWqtL3Vf0ZD_Jcr5KJc9KI=.6482a2eb-937c-4321-a886-8d792fa31ce1@github.com>
Message-ID: <zbcu7KfOdRAOajL5Ghsp_tw7ucMxDuX_SZCJMT4SkU8=.f36ff8f4-1873-42cd-85cd-658de6700cd2@github.com>

On Fri, 2 Oct 2020 22:15:02 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also project compiler setting mismatch.

Marked as reviewed by ghb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/117

From ghb at openjdk.java.net  Tue Oct  6 05:23:41 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Tue, 6 Oct 2020 05:23:41 GMT
Subject: RFR: 6916: JOverflow treemap listener depending on internal SWT
 class
In-Reply-To: <1BvV5hl5AmO9OTwbj-lXjCuGix84ePJt7ckRd1Ua2DQ=.dc633c57-481d-419a-b6bb-35864b939d92@github.com>
References: <1BvV5hl5AmO9OTwbj-lXjCuGix84ePJt7ckRd1Ua2DQ=.dc633c57-481d-419a-b6bb-35864b939d92@github.com>
Message-ID: <3YGGs9mbzhSQXIjog2UUo8elE-Aw2KTVAyyOu86QdXo=.6ef0f558-a2a7-4954-8351-ae4d9585d8fe@github.com>

On Fri, 2 Oct 2020 21:59:22 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also removing unused constant.

Marked as reviewed by ghb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/116

From ghb at openjdk.java.net  Tue Oct  6 05:25:38 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Tue, 6 Oct 2020 05:25:38 GMT
Subject: RFR: 6915: JMC dev launchers do not include JOverflow
In-Reply-To: <640UB7Z_4yPezKr4-Vu4aE-X1gz_7hxQlMeX8ksWzoc=.e434c5ee-8027-40eb-8240-9c33d6d9037a@github.com>
References: <640UB7Z_4yPezKr4-Vu4aE-X1gz_7hxQlMeX8ksWzoc=.e434c5ee-8027-40eb-8240-9c33d6d9037a@github.com>
Message-ID: <cSv-odfSvig5RSJTjZrcA2FT-uAYTQdDO17-CKDDCB8=.36547031-c949-4773-9e32-79c7b38d7344@github.com>

On Fri, 2 Oct 2020 21:49:58 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also cleaned up formatting and added proper license headers.

Marked as reviewed by ghb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/115

From ghb at openjdk.java.net  Tue Oct  6 05:26:38 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Tue, 6 Oct 2020 05:26:38 GMT
Subject: RFR: 6914: Fix windows check formatting script [v3]
In-Reply-To: <GyBFLSbwRN9HWVMDI-mR3Be9ume4H1KUJzLDcaHdZog=.a857b552-7809-49c4-9347-ddcab52f3b06@github.com>
References: <Wjz9mVVKBMM-edD_fT8GVIzL7VOLfm4ZmZu67kBI0sE=.db3e1340-d36d-4ac6-b3ab-253d2cf4b4bd@github.com>
 <GyBFLSbwRN9HWVMDI-mR3Be9ume4H1KUJzLDcaHdZog=.a857b552-7809-49c4-9347-ddcab52f3b06@github.com>
Message-ID: <Drrw5JmgbfXx8OdnGCpL-vvRbn6o6zas5qm-c1SIfSg=.75d817d1-735d-4c37-997d-d78efd75c9bc@github.com>

On Sun, 4 Oct 2020 20:21:45 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> because mvn is itself a script we need to call with call command
>> to get control back to the main script
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add different exit code for each call

Marked as reviewed by ghb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/114

From hirt at openjdk.java.net  Tue Oct  6 09:00:49 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 6 Oct 2020 09:00:49 GMT
Subject: RFR: 6899: Upgrade core to 8 [v3]
In-Reply-To: <nBjx96UCZDslQA2O1Zt-Y2m8dJ51IH_sfUkWkZxcIeY=.2f824707-946b-48fb-8648-2ca6cadc33a5@github.com>
References: <nBjx96UCZDslQA2O1Zt-Y2m8dJ51IH_sfUkWkZxcIeY=.2f824707-946b-48fb-8648-2ca6cadc33a5@github.com>
Message-ID: <v4p2hKMHMjSLSfuC65xUpUsjRWL3pQPcA1l_raPJ7HA=.da4192a3-cd8a-47e7-b7b5-e4068015d25a@github.com>

> For some reason the Eclipse compiler fails some type inferences when switching to JDK 8, so had to add some
> (unnecessary) casts. (Also set JDK 11 as required for running the application builds.)

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Fixing copyright year

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/120/files
  - new: https://git.openjdk.java.net/jmc/pull/120/files/bcc22b6a..04466fb7

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=120&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=120&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/120.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/120/head:pull/120

PR: https://git.openjdk.java.net/jmc/pull/120

From github.com+4610701+jpbempel at openjdk.java.net  Tue Oct  6 09:04:39 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Tue, 6 Oct 2020 09:04:39 GMT
Subject: Integrated: 6914: Fix windows check formatting script
In-Reply-To: <Wjz9mVVKBMM-edD_fT8GVIzL7VOLfm4ZmZu67kBI0sE=.db3e1340-d36d-4ac6-b3ab-253d2cf4b4bd@github.com>
References: <Wjz9mVVKBMM-edD_fT8GVIzL7VOLfm4ZmZu67kBI0sE=.db3e1340-d36d-4ac6-b3ab-253d2cf4b4bd@github.com>
Message-ID: <xph4TJOBCSz0t9gqplB7tvlYov48JqCOt3z16_InaGU=.cbb1bc36-c3c8-4a0f-bca6-4b1b44443da6@github.com>

On Fri, 2 Oct 2020 17:23:45 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> because mvn is itself a script we need to call with call command
> to get control back to the main script

This pull request has now been integrated.

Changeset: 1250b527
Author:    Jean-Philippe Bempel <jean-philippe at bempel.fr>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/1250b527
Stats:     4 lines in 1 file changed: 0 ins; 0 del; 4 mod

6914: Fix windows check formatting script

Reviewed-by: hirt, ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/114

From neugens at redhat.com  Tue Oct  6 09:20:03 2020
From: neugens at redhat.com (Mario Torre)
Date: Tue, 6 Oct 2020 11:20:03 +0200
Subject: RFR: 6899: Upgrade core to 8 [v3]
In-Reply-To: <v4p2hKMHMjSLSfuC65xUpUsjRWL3pQPcA1l_raPJ7HA=.da4192a3-cd8a-47e7-b7b5-e4068015d25a@github.com>
References: <nBjx96UCZDslQA2O1Zt-Y2m8dJ51IH_sfUkWkZxcIeY=.2f824707-946b-48fb-8648-2ca6cadc33a5@github.com>
 <v4p2hKMHMjSLSfuC65xUpUsjRWL3pQPcA1l_raPJ7HA=.da4192a3-cd8a-47e7-b7b5-e4068015d25a@github.com>
Message-ID: <CAJwKKmZGfj=XVnGw9tBOHtVkB8O=tL9Az2+LMXDJ4weA79O3YQ@mail.gmail.com>

Hi Marcus,

I'm a bit concerned by this bit:


  <requireJavaVersion>
- <version>[1.8.0-40,)</version>
- <message>Building JMC requires Java 8 version JDK 1.8.0_40 or later</message>
+ <version>[11,)</version>
+ <message>Building JMC requires Java 11 or later</message>
  </requireJavaVersion>

This means that we now require a JDK 11 to be installed in the systems
that do build JMC now, I believe so far we were able to build with 8
only if I'm not wrong?

Cheers,
Mario

On Tue, Oct 6, 2020 at 11:01 AM Marcus Hirt <hirt at openjdk.java.net> wrote:
>
> > For some reason the Eclipse compiler fails some type inferences when switching to JDK 8, so had to add some
> > (unnecessary) casts. (Also set JDK 11 as required for running the application builds.)
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>
>   Fixing copyright year
>
> -------------
>
> Changes:
>   - all: https://git.openjdk.java.net/jmc/pull/120/files
>   - new: https://git.openjdk.java.net/jmc/pull/120/files/bcc22b6a..04466fb7
>
> Webrevs:
>  - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=120&range=02
>  - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=120&range=01-02
>
>   Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
>   Patch: https://git.openjdk.java.net/jmc/pull/120.diff
>   Fetch: git fetch https://git.openjdk.java.net/jmc pull/120/head:pull/120
>
> PR: https://git.openjdk.java.net/jmc/pull/120
>


-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898


From ghb at openjdk.java.net  Tue Oct  6 09:48:39 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Tue, 6 Oct 2020 09:48:39 GMT
Subject: RFR: 6899: Upgrade core to 8 [v3]
In-Reply-To: <v4p2hKMHMjSLSfuC65xUpUsjRWL3pQPcA1l_raPJ7HA=.da4192a3-cd8a-47e7-b7b5-e4068015d25a@github.com>
References: <nBjx96UCZDslQA2O1Zt-Y2m8dJ51IH_sfUkWkZxcIeY=.2f824707-946b-48fb-8648-2ca6cadc33a5@github.com>
 <v4p2hKMHMjSLSfuC65xUpUsjRWL3pQPcA1l_raPJ7HA=.da4192a3-cd8a-47e7-b7b5-e4068015d25a@github.com>
Message-ID: <k0OadY0XO94bb7vuBHmXZLmQ_Ha4T_c7A8JIgwIy7fw=.ebd66cdb-b7b1-4ca8-bd6e-c3e05e0946b7@github.com>

On Tue, 6 Oct 2020 09:00:49 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> For some reason the Eclipse compiler fails some type inferences when switching to JDK 8, so had to add some
>> (unnecessary) casts. (Also set JDK 11 as required for running the application builds.)
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing copyright year

Marked as reviewed by ghb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/120

From hirt at openjdk.java.net  Tue Oct  6 09:48:40 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 6 Oct 2020 09:48:40 GMT
Subject: RFR: 6899: Upgrade core to 8 [v3]
In-Reply-To: <k0OadY0XO94bb7vuBHmXZLmQ_Ha4T_c7A8JIgwIy7fw=.ebd66cdb-b7b1-4ca8-bd6e-c3e05e0946b7@github.com>
References: <nBjx96UCZDslQA2O1Zt-Y2m8dJ51IH_sfUkWkZxcIeY=.2f824707-946b-48fb-8648-2ca6cadc33a5@github.com>
 <v4p2hKMHMjSLSfuC65xUpUsjRWL3pQPcA1l_raPJ7HA=.da4192a3-cd8a-47e7-b7b5-e4068015d25a@github.com>
 <k0OadY0XO94bb7vuBHmXZLmQ_Ha4T_c7A8JIgwIy7fw=.ebd66cdb-b7b1-4ca8-bd6e-c3e05e0946b7@github.com>
Message-ID: <0ZsagSMHPrsfHtz53ZdL3a7oHPymuRzIeJhtAj4W_A0=.f231ea23-0860-400d-886e-ad7b663489e6@github.com>

On Tue, 6 Oct 2020 09:42:34 GMT, Guru Hb <ghb at openjdk.org> wrote:

>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing copyright year
>
> Marked as reviewed by ghb (Reviewer).

Yes, that part doesn't matter much though, as this change was effectively introduced with the upgrade to Tycho 2.0 (and
the 2020-09 platform), which requires JDK 11 for building. You can still build against older platforms.

-------------

PR: https://git.openjdk.java.net/jmc/pull/120

From hirt at openjdk.java.net  Tue Oct  6 09:48:41 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 6 Oct 2020 09:48:41 GMT
Subject: Integrated: 6899: Upgrade core to 8
In-Reply-To: <nBjx96UCZDslQA2O1Zt-Y2m8dJ51IH_sfUkWkZxcIeY=.2f824707-946b-48fb-8648-2ca6cadc33a5@github.com>
References: <nBjx96UCZDslQA2O1Zt-Y2m8dJ51IH_sfUkWkZxcIeY=.2f824707-946b-48fb-8648-2ca6cadc33a5@github.com>
Message-ID: <CKxEkTgCiOEloMOTrOwB5fmhFWaQkJtUWwPMcHlcnsY=.a16cb3da-c71d-40a2-9214-e75ddcbd6cac@github.com>

On Sun, 4 Oct 2020 19:11:30 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> For some reason the Eclipse compiler fails some type inferences when switching to JDK 8, so had to add some
> (unnecessary) casts. (Also set JDK 11 as required for running the application builds.)

This pull request has now been integrated.

Changeset: d308b076
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/d308b076
Stats:     138 lines in 43 files changed: 26 ins; 4 del; 108 mod

6899: Upgrade core to 8

Reviewed-by: ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/120

From hirt at openjdk.java.net  Tue Oct  6 10:59:40 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 6 Oct 2020 10:59:40 GMT
Subject: Integrated: 6837: More formal tone in the agent settings
In-Reply-To: <nAe8qxOo3rExrJcC0uPODi_d4ZWHO4VsQu7jVjzQx6w=.77d35440-1da3-43cc-8a28-fa0dd55763f8@github.com>
References: <nAe8qxOo3rExrJcC0uPODi_d4ZWHO4VsQu7jVjzQx6w=.77d35440-1da3-43cc-8a28-fa0dd55763f8@github.com>
Message-ID: <dXhYrCDo6CADokpLfFC2eZLEKGNUTAhMTKk3y9kA6wc=.315a0985-a26f-4cae-9df9-0e2ae9a8f0bc@github.com>

On Fri, 2 Oct 2020 22:28:39 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Wasn't as bad as I remembered it.

This pull request has now been integrated.

Changeset: e74a5ff3
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/e74a5ff3
Stats:     14 lines in 2 files changed: 2 ins; 0 del; 12 mod

6837: More formal tone in the agent settings

Reviewed-by: ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/118

From hirt at openjdk.java.net  Tue Oct  6 11:01:43 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 6 Oct 2020 11:01:43 GMT
Subject: Integrated: 6915: JMC dev launchers do not include JOverflow
In-Reply-To: <640UB7Z_4yPezKr4-Vu4aE-X1gz_7hxQlMeX8ksWzoc=.e434c5ee-8027-40eb-8240-9c33d6d9037a@github.com>
References: <640UB7Z_4yPezKr4-Vu4aE-X1gz_7hxQlMeX8ksWzoc=.e434c5ee-8027-40eb-8240-9c33d6d9037a@github.com>
Message-ID: <e8g_Z87T0VfFo8H2NIIxtGdG441se13O9tA21xsylpU=.63ba041e-5b57-41fa-8771-562d5d70a219@github.com>

On Fri, 2 Oct 2020 21:49:58 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also cleaned up formatting and added proper license headers.

This pull request has now been integrated.

Changeset: c7f10501
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/c7f10501
Stats:     740 lines in 9 files changed: 176 ins; 0 del; 564 mod

6915: JMC dev launchers do not include JOverflow

Reviewed-by: aptmac, ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/115

From hirt at openjdk.java.net  Tue Oct  6 11:03:40 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 6 Oct 2020 11:03:40 GMT
Subject: Integrated: 6916: JOverflow treemap listener depending on internal
 SWT class
In-Reply-To: <1BvV5hl5AmO9OTwbj-lXjCuGix84ePJt7ckRd1Ua2DQ=.dc633c57-481d-419a-b6bb-35864b939d92@github.com>
References: <1BvV5hl5AmO9OTwbj-lXjCuGix84ePJt7ckRd1Ua2DQ=.dc633c57-481d-419a-b6bb-35864b939d92@github.com>
Message-ID: <s2kS4KjVwIhGWBIvwf9AwcUBp7z4eppNaKxklzuXM1E=.186970e1-ba32-432b-aabc-61a66aa69dd6@github.com>

On Fri, 2 Oct 2020 21:59:22 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also removing unused constant.

This pull request has now been integrated.

Changeset: 63f3b354
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/63f3b354
Stats:     8 lines in 2 files changed: 2 ins; 4 del; 2 mod

6916: JOverflow treemap listener depending on internal SWT class

Reviewed-by: aptmac, ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/116

From hirt at openjdk.java.net  Tue Oct  6 11:04:38 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 6 Oct 2020 11:04:38 GMT
Subject: Integrated: 6917: Clean warnings in the agent project
In-Reply-To: <bjOkkdmkV3esy3kkfWfvvMWqtL3Vf0ZD_Jcr5KJc9KI=.6482a2eb-937c-4321-a886-8d792fa31ce1@github.com>
References: <bjOkkdmkV3esy3kkfWfvvMWqtL3Vf0ZD_Jcr5KJc9KI=.6482a2eb-937c-4321-a886-8d792fa31ce1@github.com>
Message-ID: <plOl6_zdT2P79ayc8vGCjyq0q8dy_52ABJygFP6wzsg=.99f32055-e800-49c4-9415-37fb59c87840@github.com>

On Fri, 2 Oct 2020 22:15:02 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also project compiler setting mismatch.

This pull request has now been integrated.

Changeset: c3b53e6d
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/c3b53e6d
Stats:     21 lines in 5 files changed: 9 ins; 6 del; 6 mod

6917: Clean warnings in the agent project

Reviewed-by: ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/117

From marcus.hirt at datadoghq.com  Tue Oct  6 12:41:43 2020
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Tue, 6 Oct 2020 14:41:43 +0200
Subject: Migrating jmc7 to GitHub.
Message-ID: <CAOpWGx3sG7FR8HN2+bbH6MXG68WZFLzZQiy1+uqDXebiS46PRQ@mail.gmail.com>

Hi all,

Since there were no objections, we'll go ahead with moving the jmc7
repository to GitHub.

Kind regards,
Marcus

From marcus.hirt at datadoghq.com  Tue Oct  6 12:48:11 2020
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Tue, 6 Oct 2020 14:48:11 +0200
Subject: GitHub release model.
Message-ID: <CAOpWGx0Kuh0vU=OHxxDGxpfX8QrANbxugLq7T6mhvctdyuaNGw@mail.gmail.com>

Hi all,

It's time we start considering how we want to manage the source across
releases. One model that looks attractive is what is done in the JavaFX
project. We'll branch for major releases and tag commits in those branches
for our actual releases.

If this is not enough, and we ever feel the need to work on several minor
releases in parallel for a specific major release, we could create branches
as needed from the major release branches.

We could name the branches jmc7, jmc8 etc. And yep, we could fold in the
jmc7 repo being ported to GitHub into a jmc7 branch in the jmc repo and
retire the jmc7 repo.

What do you think?

Kind regards,
Marcus

From neugens at redhat.com  Tue Oct  6 12:54:00 2020
From: neugens at redhat.com (Mario Torre)
Date: Tue, 6 Oct 2020 14:54:00 +0200
Subject: GitHub release model.
In-Reply-To: <CAOpWGx0Kuh0vU=OHxxDGxpfX8QrANbxugLq7T6mhvctdyuaNGw@mail.gmail.com>
References: <CAOpWGx0Kuh0vU=OHxxDGxpfX8QrANbxugLq7T6mhvctdyuaNGw@mail.gmail.com>
Message-ID: <CAJwKKmZCP8wWjnQjwSU2TAn4mSw9nxVe4T84EcVu=Hm4-HvWNg@mail.gmail.com>

What's the model used by OpenJDK?

I think it makes sense to use the same so we have a consistent process.

Personally, I do prefer multiple separate explicit repositories, but
that's just me. There's not much difference between having in tree
branches and explicit forks really anyway. I agree on the tagging in
either case.

Cheers,
Mario

On Tue, Oct 6, 2020 at 2:49 PM Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
>
> Hi all,
>
> It's time we start considering how we want to manage the source across
> releases. One model that looks attractive is what is done in the JavaFX
> project. We'll branch for major releases and tag commits in those branches
> for our actual releases.
>
> If this is not enough, and we ever feel the need to work on several minor
> releases in parallel for a specific major release, we could create branches
> as needed from the major release branches.
>
> We could name the branches jmc7, jmc8 etc. And yep, we could fold in the
> jmc7 repo being ported to GitHub into a jmc7 branch in the jmc repo and
> retire the jmc7 repo.
>
> What do you think?
>
> Kind regards,
> Marcus
>


-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898


From marcus.hirt at datadoghq.com  Tue Oct  6 13:22:41 2020
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Tue, 6 Oct 2020 15:22:41 +0200
Subject: GitHub release model.
In-Reply-To: <CAJwKKmZCP8wWjnQjwSU2TAn4mSw9nxVe4T84EcVu=Hm4-HvWNg@mail.gmail.com>
References: <CAOpWGx0Kuh0vU=OHxxDGxpfX8QrANbxugLq7T6mhvctdyuaNGw@mail.gmail.com>
 <CAJwKKmZCP8wWjnQjwSU2TAn4mSw9nxVe4T84EcVu=Hm4-HvWNg@mail.gmail.com>
Message-ID: <CAOpWGx3C07bcdeR9yrtTQGFkbginbrf7G28b72Uj1BpSFN4Ctg@mail.gmail.com>

Hi Mario,

OpenJDK is creating a new repo for each release. That's a bit clunky, and a
decision that seems to be mostly based on "not changing too much at the
same time". With branches we can create new ones on our own. With new repos
we can't.

Kind regards,
Marcus

On Tue, Oct 6, 2020 at 2:54 PM Mario Torre <neugens at redhat.com> wrote:

> What's the model used by OpenJDK?
>
> I think it makes sense to use the same so we have a consistent process.
>
> Personally, I do prefer multiple separate explicit repositories, but
> that's just me. There's not much difference between having in tree
> branches and explicit forks really anyway. I agree on the tagging in
> either case.
>
> Cheers,
> Mario
>
> On Tue, Oct 6, 2020 at 2:49 PM Marcus Hirt <marcus.hirt at datadoghq.com>
> wrote:
> >
> > Hi all,
> >
> > It's time we start considering how we want to manage the source across
> > releases. One model that looks attractive is what is done in the JavaFX
> > project. We'll branch for major releases and tag commits in those
> branches
> > for our actual releases.
> >
> > If this is not enough, and we ever feel the need to work on several minor
> > releases in parallel for a specific major release, we could create
> branches
> > as needed from the major release branches.
> >
> > We could name the branches jmc7, jmc8 etc. And yep, we could fold in the
> > jmc7 repo being ported to GitHub into a jmc7 branch in the jmc repo and
> > retire the jmc7 repo.
> >
> > What do you think?
> >
> > Kind regards,
> > Marcus
> >
>
>
> --
> Mario Torre
> Associate Manager, Software Engineering
> Red Hat GmbH <https://www.redhat.com>
> 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
>
>

From guru.hb at oracle.com  Tue Oct  6 14:12:06 2020
From: guru.hb at oracle.com (Guru)
Date: Tue, 6 Oct 2020 19:42:06 +0530
Subject: GitHub release model.
In-Reply-To: <CAOpWGx3C07bcdeR9yrtTQGFkbginbrf7G28b72Uj1BpSFN4Ctg@mail.gmail.com>
References: <CAOpWGx0Kuh0vU=OHxxDGxpfX8QrANbxugLq7T6mhvctdyuaNGw@mail.gmail.com>
 <CAJwKKmZCP8wWjnQjwSU2TAn4mSw9nxVe4T84EcVu=Hm4-HvWNg@mail.gmail.com>
 <CAOpWGx3C07bcdeR9yrtTQGFkbginbrf7G28b72Uj1BpSFN4Ctg@mail.gmail.com>
Message-ID: <6DDD5F0C-23F8-47A3-9A44-53766678BE7E@oracle.com>

Hi Marcus and Mario,

"OpenJDK creating a new repo for each release? : This is due to the LTS and Non-LTS model, where LTS Model will have https://github.com/openjdk/jdk11u <https://github.com/openjdk/jdk11u> and Non LTS model : https://github.com/openjdk/jdk13u <https://github.com/openjdk/jdk13u> , https://github.com/openjdk/jdk15u <https://github.com/openjdk/jdk15u> and https://github.com/openjdk/jdk14u <https://github.com/openjdk/jdk14u> , etc. 

Where as for JMC we could have Single Repository "https://github.com/openjdk/jmc <https://github.com/openjdk/jmc>? with 
a. Main release ? Separate branch as and when we release (i.e JMC8, JMC9, ?) 
b. Minor release ? Tags (i.e JMC-8.0.0, JMC-8.0.1,...)

This will make easier to manage compared to multiple repo and This is the model which is used in https://github.com/openjdk/jfx <https://github.com/openjdk/jfx> (OpenJFX).  

Thanks,
Guru

> On 06-Oct-2020, at 6:52 PM, Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
> 
> Hi Mario,
> 
> OpenJDK is creating a new repo for each release. That's a bit clunky, and a
> decision that seems to be mostly based on "not changing too much at the
> same time". With branches we can create new ones on our own. With new repos
> we can't.
> 
> Kind regards,
> Marcus
> 
> On Tue, Oct 6, 2020 at 2:54 PM Mario Torre <neugens at redhat.com> wrote:
> 
>> What's the model used by OpenJDK?
>> 
>> I think it makes sense to use the same so we have a consistent process.
>> 
>> Personally, I do prefer multiple separate explicit repositories, but
>> that's just me. There's not much difference between having in tree
>> branches and explicit forks really anyway. I agree on the tagging in
>> either case.
>> 
>> Cheers,
>> Mario
>> 
>> On Tue, Oct 6, 2020 at 2:49 PM Marcus Hirt <marcus.hirt at datadoghq.com>
>> wrote:
>>> 
>>> Hi all,
>>> 
>>> It's time we start considering how we want to manage the source across
>>> releases. One model that looks attractive is what is done in the JavaFX
>>> project. We'll branch for major releases and tag commits in those
>> branches
>>> for our actual releases.
>>> 
>>> If this is not enough, and we ever feel the need to work on several minor
>>> releases in parallel for a specific major release, we could create
>> branches
>>> as needed from the major release branches.
>>> 
>>> We could name the branches jmc7, jmc8 etc. And yep, we could fold in the
>>> jmc7 repo being ported to GitHub into a jmc7 branch in the jmc repo and
>>> retire the jmc7 repo.
>>> 
>>> What do you think?
>>> 
>>> Kind regards,
>>> Marcus
>>> 
>> 
>> 
>> --
>> Mario Torre
>> Associate Manager, Software Engineering
>> Red Hat GmbH <https://www.redhat.com>
>> 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
>> 
>> 


From marcus.hirt at datadoghq.com  Tue Oct  6 17:36:15 2020
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Tue, 6 Oct 2020 19:36:15 +0200
Subject: GitHub release model.
In-Reply-To: <6DDD5F0C-23F8-47A3-9A44-53766678BE7E@oracle.com>
References: <CAOpWGx0Kuh0vU=OHxxDGxpfX8QrANbxugLq7T6mhvctdyuaNGw@mail.gmail.com>
 <CAJwKKmZCP8wWjnQjwSU2TAn4mSw9nxVe4T84EcVu=Hm4-HvWNg@mail.gmail.com>
 <CAOpWGx3C07bcdeR9yrtTQGFkbginbrf7G28b72Uj1BpSFN4Ctg@mail.gmail.com>
 <6DDD5F0C-23F8-47A3-9A44-53766678BE7E@oracle.com>
Message-ID: <CAOpWGx3JSL1h21=j2RoGDRjKyHf1ZWWCcxDAU=OWqwdFH6rr5g@mail.gmail.com>

Yep. Personally I'd prefer a single repo and branches too. Anyone else
wanna weigh in? Are we missing anything?

Kind regards,
Marcus

On Tue, Oct 6, 2020 at 4:14 PM Guru <guru.hb at oracle.com> wrote:

> Hi Marcus and Mario,
>
> "OpenJDK creating a new repo for each release? : This is due to the LTS
> and Non-LTS model, where LTS Model will have
> https://github.com/openjdk/jdk11u and Non LTS model :
> https://github.com/openjdk/jdk13u , https://github.com/openjdk/jdk15u and
> https://github.com/openjdk/jdk14u , etc.
>
> Where as for JMC we could have Single Repository "
> https://github.com/openjdk/jmc? with
> a. Main release ? Separate branch as and when we release (i.e JMC8, JMC9,
> ?)
> b. Minor release ? Tags (i.e JMC-8.0.0, JMC-8.0.1,...)
>
> This will make easier to manage compared to multiple repo and This is the
> model which is used in https://github.com/openjdk/jfx (OpenJFX).
>
> Thanks,
> Guru
>
> On 06-Oct-2020, at 6:52 PM, Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
>
> Hi Mario,
>
> OpenJDK is creating a new repo for each release. That's a bit clunky, and a
> decision that seems to be mostly based on "not changing too much at the
> same time". With branches we can create new ones on our own. With new repos
> we can't.
>
> Kind regards,
> Marcus
>
> On Tue, Oct 6, 2020 at 2:54 PM Mario Torre <neugens at redhat.com> wrote:
>
> What's the model used by OpenJDK?
>
> I think it makes sense to use the same so we have a consistent process.
>
> Personally, I do prefer multiple separate explicit repositories, but
> that's just me. There's not much difference between having in tree
> branches and explicit forks really anyway. I agree on the tagging in
> either case.
>
> Cheers,
> Mario
>
> On Tue, Oct 6, 2020 at 2:49 PM Marcus Hirt <marcus.hirt at datadoghq.com>
> wrote:
>
>
> Hi all,
>
> It's time we start considering how we want to manage the source across
> releases. One model that looks attractive is what is done in the JavaFX
> project. We'll branch for major releases and tag commits in those
>
> branches
>
> for our actual releases.
>
> If this is not enough, and we ever feel the need to work on several minor
> releases in parallel for a specific major release, we could create
>
> branches
>
> as needed from the major release branches.
>
> We could name the branches jmc7, jmc8 etc. And yep, we could fold in the
> jmc7 repo being ported to GitHub into a jmc7 branch in the jmc repo and
> retire the jmc7 repo.
>
> What do you think?
>
> Kind regards,
> Marcus
>
>
>
> --
> Mario Torre
> Associate Manager, Software Engineering
> Red Hat GmbH <https://www.redhat.com>
> 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
>
>
>
>

From github.com+28612+gunnarmorling at openjdk.java.net  Wed Oct  7 11:17:11 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Wed, 7 Oct 2020 11:17:11 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
Message-ID: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>

6910: Missing manifest prevents agent jar from running

-------------

Commit messages:
 - 6910: Adding MANIFEST.MF to agent JAR

Changes: https://git.openjdk.java.net/jmc/pull/122/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=122&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6910
  Stats: 24 lines in 1 file changed: 12 ins; 12 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/122.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/122/head:pull/122

PR: https://git.openjdk.java.net/jmc/pull/122

From aptmac at openjdk.java.net  Wed Oct  7 11:17:11 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Wed, 7 Oct 2020 11:17:11 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
Message-ID: <Q5V4DZpQDgCYd1qTThv8yxvY_DieamahNNHQaFmScCM=.6f985014-cf5f-41c4-8ff8-fd681956d5ab@github.com>

On Mon, 5 Oct 2020 14:12:46 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> 6910: Missing manifest prevents agent jar from running

Marked as reviewed by aptmac (Committer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From github.com+28612+gunnarmorling at openjdk.java.net  Wed Oct  7 11:17:12 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Wed, 7 Oct 2020 11:17:12 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
Message-ID: <LkZTC0ysFprmU8Sp6sJTcd_LxqG120owa115q5FHOUY=.784ccaf8-e6a6-44f6-824e-bbe14c97e7eb@github.com>

On Mon, 5 Oct 2020 14:12:46 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> 6910: Missing manifest prevents agent jar from running

My employer, Red Hat, has signed the OCA.

// CC @thegreystone, @neugens, @aptmac.

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From github.com+28612+gunnarmorling at openjdk.java.net  Wed Oct  7 11:17:12 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Wed, 7 Oct 2020 11:17:12 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <LkZTC0ysFprmU8Sp6sJTcd_LxqG120owa115q5FHOUY=.784ccaf8-e6a6-44f6-824e-bbe14c97e7eb@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
 <LkZTC0ysFprmU8Sp6sJTcd_LxqG120owa115q5FHOUY=.784ccaf8-e6a6-44f6-824e-bbe14c97e7eb@github.com>
Message-ID: <JJjAE-8cwlk5y-c0wywtSM-8TDW1y2MyURmtWSq2Pg0=.da65adc7-a611-423f-bde5-14b046a7a9f4@github.com>

On Mon, 5 Oct 2020 14:14:11 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> 6910: Missing manifest prevents agent jar from running
>
> My employer, Red Hat, has signed the OCA.
> 
> // CC @thegreystone, @neugens, @aptmac.

Build failures are connectity issues with Maven Central.

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From hirt at openjdk.java.net  Wed Oct  7 11:17:12 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 7 Oct 2020 11:17:12 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <Q5V4DZpQDgCYd1qTThv8yxvY_DieamahNNHQaFmScCM=.6f985014-cf5f-41c4-8ff8-fd681956d5ab@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
 <Q5V4DZpQDgCYd1qTThv8yxvY_DieamahNNHQaFmScCM=.6f985014-cf5f-41c4-8ff8-fd681956d5ab@github.com>
Message-ID: <to1nUkyLRSGnAAe7Ft7RA0KAIDUMUwG_Tj6N2mTkocM=.f11b0abc-9ffd-4e83-948f-14df37ef8e15@github.com>

On Mon, 5 Oct 2020 16:24:15 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> 6910: Missing manifest prevents agent jar from running
>
> Marked as reviewed by aptmac (Committer).

Hi Gunnar! Thanks for setting covered! Please allow for a few days for verification.

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From github.com+28612+gunnarmorling at openjdk.java.net  Wed Oct  7 11:17:12 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Wed, 7 Oct 2020 11:17:12 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <to1nUkyLRSGnAAe7Ft7RA0KAIDUMUwG_Tj6N2mTkocM=.f11b0abc-9ffd-4e83-948f-14df37ef8e15@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
 <Q5V4DZpQDgCYd1qTThv8yxvY_DieamahNNHQaFmScCM=.6f985014-cf5f-41c4-8ff8-fd681956d5ab@github.com>
 <to1nUkyLRSGnAAe7Ft7RA0KAIDUMUwG_Tj6N2mTkocM=.f11b0abc-9ffd-4e83-948f-14df37ef8e15@github.com>
Message-ID: <pQjTLXJpt1fcX3aywoLVAjPK6TQ5vGGR0o0HLJQYEjk=.deff5ed7-782c-4e06-9213-ccb8daa83529@github.com>

On Mon, 5 Oct 2020 17:22:04 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Please allow for a few days for verification.

Sure; is this a once-off effort, or do you need to repeat this every time I send a PR? In other words, would it help if
I signed a personal OCA?

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From jkang at openjdk.java.net  Wed Oct  7 11:17:12 2020
From: jkang at openjdk.java.net (Jie Kang)
Date: Wed, 7 Oct 2020 11:17:12 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <pQjTLXJpt1fcX3aywoLVAjPK6TQ5vGGR0o0HLJQYEjk=.deff5ed7-782c-4e06-9213-ccb8daa83529@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
 <Q5V4DZpQDgCYd1qTThv8yxvY_DieamahNNHQaFmScCM=.6f985014-cf5f-41c4-8ff8-fd681956d5ab@github.com>
 <to1nUkyLRSGnAAe7Ft7RA0KAIDUMUwG_Tj6N2mTkocM=.f11b0abc-9ffd-4e83-948f-14df37ef8e15@github.com>
 <pQjTLXJpt1fcX3aywoLVAjPK6TQ5vGGR0o0HLJQYEjk=.deff5ed7-782c-4e06-9213-ccb8daa83529@github.com>
Message-ID: <6NYeRGIx9nkbr7Xa4FvTYABEVlqSnuHwbcS8dR3aMTk=.b5aa6e02-9911-4d2f-81b2-7cfa34c58aa6@github.com>

On Mon, 5 Oct 2020 19:38:47 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> > Please allow for a few days for verification.
> 
> Sure; is this a once-off effort, or do you need to repeat this every time I send a PR? In other words, would it help if
> I signed a personal OCA?

OCA verification is one time so you won't need to repeat it every single PR.

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From marcus.hirt at datadoghq.com  Wed Oct  7 11:45:17 2020
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Wed, 7 Oct 2020 13:45:17 +0200
Subject: Migrating jmc7 to GitHub.
In-Reply-To: <CAOpWGx3sG7FR8HN2+bbH6MXG68WZFLzZQiy1+uqDXebiS46PRQ@mail.gmail.com>
References: <CAOpWGx3sG7FR8HN2+bbH6MXG68WZFLzZQiy1+uqDXebiS46PRQ@mail.gmail.com>
Message-ID: <CAOpWGx2NkerMAfJfuAT677h7XAVPHZwuABYU_95dWnm=qXqb6Q@mail.gmail.com>

Hi all,

We'll do this in two steps. First step is moving jmc7 over to
Git/GitHub/Skara. This will happen on Friday, the 9th of October.

Kind regards,
Marcus

On Tue, Oct 6, 2020 at 2:41 PM Marcus Hirt <marcus.hirt at datadoghq.com>
wrote:

> Hi all,
>
> Since there were no objections, we'll go ahead with moving the jmc7
> repository to GitHub.
>
> Kind regards,
> Marcus
>

From hirt at openjdk.java.net  Wed Oct  7 17:34:06 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 7 Oct 2020 17:34:06 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <6NYeRGIx9nkbr7Xa4FvTYABEVlqSnuHwbcS8dR3aMTk=.b5aa6e02-9911-4d2f-81b2-7cfa34c58aa6@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
 <Q5V4DZpQDgCYd1qTThv8yxvY_DieamahNNHQaFmScCM=.6f985014-cf5f-41c4-8ff8-fd681956d5ab@github.com>
 <to1nUkyLRSGnAAe7Ft7RA0KAIDUMUwG_Tj6N2mTkocM=.f11b0abc-9ffd-4e83-948f-14df37ef8e15@github.com>
 <pQjTLXJpt1fcX3aywoLVAjPK6TQ5vGGR0o0HLJQYEjk=.deff5ed7-782c-4e06-9213-ccb8daa83529@github.com>
 <6NYeRGIx9nkbr7Xa4FvTYABEVlqSnuHwbcS8dR3aMTk=.b5aa6e02-9911-4d2f-81b2-7cfa34c58aa6@github.com>
Message-ID: <XH92wHI4NJQj0tdOevWNNMRMkWuZelQVSTM-LKXdaVQ=.71e47741-ca1a-4f0d-a077-edc19923b381@github.com>

On Tue, 6 Oct 2020 14:56:52 GMT, Jie Kang <jkang at openjdk.org> wrote:

>>> Please allow for a few days for verification.
>> 
>> Sure; is this a once-off effort, or do you need to repeat this every time I send a PR? In other words, would it help if
>> I signed a personal OCA?
>
>> > Please allow for a few days for verification.
>> 
>> Sure; is this a once-off effort, or do you need to repeat this every time I send a PR? In other words, would it help if
>> I signed a personal OCA?
> 
> OCA verification is one time so you won't need to repeat it every single PR.

Rerunning the tests. We see all these maven timeouts for some reason. We should look into this.

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From github.com+28612+gunnarmorling at openjdk.java.net  Wed Oct  7 18:38:07 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Wed, 7 Oct 2020 18:38:07 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <XH92wHI4NJQj0tdOevWNNMRMkWuZelQVSTM-LKXdaVQ=.71e47741-ca1a-4f0d-a077-edc19923b381@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
 <Q5V4DZpQDgCYd1qTThv8yxvY_DieamahNNHQaFmScCM=.6f985014-cf5f-41c4-8ff8-fd681956d5ab@github.com>
 <to1nUkyLRSGnAAe7Ft7RA0KAIDUMUwG_Tj6N2mTkocM=.f11b0abc-9ffd-4e83-948f-14df37ef8e15@github.com>
 <pQjTLXJpt1fcX3aywoLVAjPK6TQ5vGGR0o0HLJQYEjk=.deff5ed7-782c-4e06-9213-ccb8daa83529@github.com>
 <6NYeRGIx9nkbr7Xa4FvTYABEVlqSnuHwbcS8dR3aMTk=.b5aa6e02-9911-4d2f-81b2-7cfa34c58aa6@github.com>
 <XH92wHI4NJQj0tdOevWNNMRMkWuZelQVSTM-LKXdaVQ=.71e47741-ca1a-4f0d-a077-edc19923b381@github.com>
Message-ID: <o_ZCsIdbXQgG1anU3uc1BoKYDIA8FTzVH8--u8G-aNI=.9433f786-1ea1-4ff4-8563-512c863182e4@github.com>

On Wed, 7 Oct 2020 17:31:21 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>>> > Please allow for a few days for verification.
>>> 
>>> Sure; is this a once-off effort, or do you need to repeat this every time I send a PR? In other words, would it help if
>>> I signed a personal OCA?
>> 
>> OCA verification is one time so you won't need to repeat it every single PR.
>
> Rerunning the tests. We see all these maven timeouts for some reason. We should look into this.

Not exactly sure about the timeout issue, but perhaps it's a good idea to keep the local Maven repo between runs?

This will reduce likelyhood for this issue to occur as not everything is downloaded from scratch all the time and by
that also increased build speed quite a bit. We e.g. do this
[here](https://github.com/moditect/layrry/blob/master/.github/workflows/maven.yml#L39-L44) for Layrry; I could push a
commit for this to this PR if you want?

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From github.com+4610701+jpbempel at openjdk.java.net  Wed Oct  7 19:14:10 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Wed, 7 Oct 2020 19:14:10 GMT
Subject: RFR: 6173: jmc -open requires full path
Message-ID: <ohahuqEBf3XJ9agsEfa2hjo2cbyyAiLSgaml0OXYM4c=.8a76d65b-f7d2-458d-bea4-ee9ec8b22053@github.com>

Handle special Mac case where user.dir is set by mac eclipse launcher
to the directory where is jmc binary.
Hopfully, PWD env var is kept where the program was launched so we can use it
to prepend to the providing filename.

-------------

Commit messages:
 - 6173: jmc -open requires full path

Changes: https://git.openjdk.java.net/jmc/pull/123/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=123&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6173
  Stats: 16 lines in 1 file changed: 14 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/123.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/123/head:pull/123

PR: https://git.openjdk.java.net/jmc/pull/123

From hirt at openjdk.java.net  Thu Oct  8 06:53:08 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 8 Oct 2020 06:53:08 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <Jq_Mq_SqN4lVa9TaAo1tYixcLnpl-K0iUr0H2YVbO-w=.056ff6e7-e5f4-4a14-9d41-b1cced6fc9af@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
 <Q5V4DZpQDgCYd1qTThv8yxvY_DieamahNNHQaFmScCM=.6f985014-cf5f-41c4-8ff8-fd681956d5ab@github.com>
 <to1nUkyLRSGnAAe7Ft7RA0KAIDUMUwG_Tj6N2mTkocM=.f11b0abc-9ffd-4e83-948f-14df37ef8e15@github.com>
 <pQjTLXJpt1fcX3aywoLVAjPK6TQ5vGGR0o0HLJQYEjk=.deff5ed7-782c-4e06-9213-ccb8daa83529@github.com>
 <6NYeRGIx9nkbr7Xa4FvTYABEVlqSnuHwbcS8dR3aMTk=.b5aa6e02-9911-4d2f-81b2-7cfa34c58aa6@github.com>
 <XH92wHI4NJQj0tdOevWNNMRMkWuZelQVSTM-LKXdaVQ=.71e47741-ca1a-4f0d-a077-edc19923b381@github.com>
 <o_ZCsIdbXQgG1anU3uc1BoKYDIA8FTzVH8--u8G-aNI=.9433f786-1ea1-4ff4-8563-512c863182e4@github.com>
 <Jq_Mq_SqN4lVa9TaAo1tYixcLnpl-K0iUr0H2YVbO-w=.056ff6e7-e5f4-4a14-9d41-b1cced6fc9af@github.com>
Message-ID: <j3oBIkzw_TfWi21qGTx37rRhjWK8ApMoKLfrruUnMZA=.ff6cbacb-f97b-4935-88e6-d7039ca71a0d@github.com>

On Wed, 7 Oct 2020 21:13:54 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Not exactly sure about the timeout issue, but perhaps it's a good idea to keep the local Maven repo between runs?
>> 
>> This will reduce likelyhood for this issue to occur as not everything is downloaded from scratch all the time and by
>> that also increased build speed quite a bit. We e.g. do this
>> [here](https://github.com/moditect/layrry/blob/master/.github/workflows/maven.yml#L39-L44) for Layrry; I could push a
>> commit for this to this PR if you want?
>
> That is a good idea - but let's do it as a separate commit. I'll open up a new ticket for it.

Opened https://bugs.openjdk.java.net/browse/JMC-6925.

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From hirt at openjdk.java.net  Thu Oct  8 06:53:03 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 8 Oct 2020 06:53:03 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <o_ZCsIdbXQgG1anU3uc1BoKYDIA8FTzVH8--u8G-aNI=.9433f786-1ea1-4ff4-8563-512c863182e4@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
 <Q5V4DZpQDgCYd1qTThv8yxvY_DieamahNNHQaFmScCM=.6f985014-cf5f-41c4-8ff8-fd681956d5ab@github.com>
 <to1nUkyLRSGnAAe7Ft7RA0KAIDUMUwG_Tj6N2mTkocM=.f11b0abc-9ffd-4e83-948f-14df37ef8e15@github.com>
 <pQjTLXJpt1fcX3aywoLVAjPK6TQ5vGGR0o0HLJQYEjk=.deff5ed7-782c-4e06-9213-ccb8daa83529@github.com>
 <6NYeRGIx9nkbr7Xa4FvTYABEVlqSnuHwbcS8dR3aMTk=.b5aa6e02-9911-4d2f-81b2-7cfa34c58aa6@github.com>
 <XH92wHI4NJQj0tdOevWNNMRMkWuZelQVSTM-LKXdaVQ=.71e47741-ca1a-4f0d-a077-edc19923b381@github.com>
 <o_ZCsIdbXQgG1anU3uc1BoKYDIA8FTzVH8--u8G-aNI=.9433f786-1ea1-4ff4-8563-512c863182e4@github.com>
Message-ID: <Jq_Mq_SqN4lVa9TaAo1tYixcLnpl-K0iUr0H2YVbO-w=.056ff6e7-e5f4-4a14-9d41-b1cced6fc9af@github.com>

On Wed, 7 Oct 2020 18:35:23 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> Rerunning the tests. We see all these maven timeouts for some reason. We should look into this.
>
> Not exactly sure about the timeout issue, but perhaps it's a good idea to keep the local Maven repo between runs?
> 
> This will reduce likelyhood for this issue to occur as not everything is downloaded from scratch all the time and by
> that also increased build speed quite a bit. We e.g. do this
> [here](https://github.com/moditect/layrry/blob/master/.github/workflows/maven.yml#L39-L44) for Layrry; I could push a
> commit for this to this PR if you want?

That is a good idea - but let's do it as a separate commit. I'll open up a new ticket for it.

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From github.com+28612+gunnarmorling at openjdk.java.net  Thu Oct  8 06:53:12 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Thu, 8 Oct 2020 06:53:12 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <j3oBIkzw_TfWi21qGTx37rRhjWK8ApMoKLfrruUnMZA=.ff6cbacb-f97b-4935-88e6-d7039ca71a0d@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
 <Q5V4DZpQDgCYd1qTThv8yxvY_DieamahNNHQaFmScCM=.6f985014-cf5f-41c4-8ff8-fd681956d5ab@github.com>
 <to1nUkyLRSGnAAe7Ft7RA0KAIDUMUwG_Tj6N2mTkocM=.f11b0abc-9ffd-4e83-948f-14df37ef8e15@github.com>
 <pQjTLXJpt1fcX3aywoLVAjPK6TQ5vGGR0o0HLJQYEjk=.deff5ed7-782c-4e06-9213-ccb8daa83529@github.com>
 <6NYeRGIx9nkbr7Xa4FvTYABEVlqSnuHwbcS8dR3aMTk=.b5aa6e02-9911-4d2f-81b2-7cfa34c58aa6@github.com>
 <XH92wHI4NJQj0tdOevWNNMRMkWuZelQVSTM-LKXdaVQ=.71e47741-ca1a-4f0d-a077-edc19923b381@github.com>
 <o_ZCsIdbXQgG1anU3uc1BoKYDIA8FTzVH8--u8G-aNI=.9433f786-1ea1-4ff4-8563-512c863182e4@github.com>
 <Jq_Mq_SqN4lVa9TaAo1tYixcLnpl-K0iUr0H2YVbO-w=.056ff6e7-e5f4-4a14-9d41-b1cced6fc9af@github.com>
 <j3oBIkzw_TfWi21qGTx37rRhjWK8ApMoKLfrruUnMZA=.ff6cbacb-f97b-4935-88e6-d7039ca71a0d@github.com>
Message-ID: <ZOEGWWXb5NNzApA5m1Nl3G1x1AnJNPMNfCTBVW2kn3k=.38c15bcf-1bf1-4e04-b470-bab5fdbccdbb@github.com>

On Wed, 7 Oct 2020 21:20:49 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> That is a good idea - but let's do it as a separate commit. I'll open up a new ticket for it.
>
> Opened https://bugs.openjdk.java.net/browse/JMC-6925.

Ok, sweet. Will send another PR for that shortly.

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From github.com+28612+gunnarmorling at openjdk.java.net  Thu Oct  8 06:53:18 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Thu, 8 Oct 2020 06:53:18 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <ZOEGWWXb5NNzApA5m1Nl3G1x1AnJNPMNfCTBVW2kn3k=.38c15bcf-1bf1-4e04-b470-bab5fdbccdbb@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
 <Q5V4DZpQDgCYd1qTThv8yxvY_DieamahNNHQaFmScCM=.6f985014-cf5f-41c4-8ff8-fd681956d5ab@github.com>
 <to1nUkyLRSGnAAe7Ft7RA0KAIDUMUwG_Tj6N2mTkocM=.f11b0abc-9ffd-4e83-948f-14df37ef8e15@github.com>
 <pQjTLXJpt1fcX3aywoLVAjPK6TQ5vGGR0o0HLJQYEjk=.deff5ed7-782c-4e06-9213-ccb8daa83529@github.com>
 <6NYeRGIx9nkbr7Xa4FvTYABEVlqSnuHwbcS8dR3aMTk=.b5aa6e02-9911-4d2f-81b2-7cfa34c58aa6@github.com>
 <XH92wHI4NJQj0tdOevWNNMRMkWuZelQVSTM-LKXdaVQ=.71e47741-ca1a-4f0d-a077-edc19923b381@github.com>
 <o_ZCsIdbXQgG1anU3uc1BoKYDIA8FTzVH8--u8G-aNI=.9433f786-1ea1-4ff4-8563-512c863182e4@github.com>
 <Jq_Mq_SqN4lVa9TaAo1tYixcLnpl-K0iUr0H2YVbO-w=.056ff6e7-e5f4-4a14-9d41-b1cced6fc9af@github.com>
 <j3oBIkzw_TfWi21qGTx37rRhjWK8ApMoKLfrruUnMZA=.ff6cbacb-f97b-4935-88e6-d7039ca71a0d@github.com>
 <ZOEGWWXb5NNzApA5m1Nl3G1x1AnJNPMNfCTBVW2kn3k=.38c15bcf-1bf1-4e04-b470-bab5fdbccdbb@github.com>
Message-ID: <pBoKSbwIMkb8RtGQJMU828irIC8UqKXRln6zThcQ9Vw=.c93bfe04-c8fd-41bd-8224-16a6818df3f0@github.com>

On Thu, 8 Oct 2020 05:42:04 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> Opened https://bugs.openjdk.java.net/browse/JMC-6925.
>
> Ok, sweet. Will send another PR for that shortly.

Btw. how does issue handling work in general, can I also open one myself? I noticed a few glitches where inconsistent
configuration could be handled more gracefully in the agent (e.g. defining a return value for a void method will cause
an exception due to an illegally named field for the value in the generated event type, whereas this should only
trigger a warning IMO).

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From hirt at openjdk.java.net  Thu Oct  8 07:21:41 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 8 Oct 2020 07:21:41 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <pBoKSbwIMkb8RtGQJMU828irIC8UqKXRln6zThcQ9Vw=.c93bfe04-c8fd-41bd-8224-16a6818df3f0@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
 <Q5V4DZpQDgCYd1qTThv8yxvY_DieamahNNHQaFmScCM=.6f985014-cf5f-41c4-8ff8-fd681956d5ab@github.com>
 <to1nUkyLRSGnAAe7Ft7RA0KAIDUMUwG_Tj6N2mTkocM=.f11b0abc-9ffd-4e83-948f-14df37ef8e15@github.com>
 <pQjTLXJpt1fcX3aywoLVAjPK6TQ5vGGR0o0HLJQYEjk=.deff5ed7-782c-4e06-9213-ccb8daa83529@github.com>
 <6NYeRGIx9nkbr7Xa4FvTYABEVlqSnuHwbcS8dR3aMTk=.b5aa6e02-9911-4d2f-81b2-7cfa34c58aa6@github.com>
 <XH92wHI4NJQj0tdOevWNNMRMkWuZelQVSTM-LKXdaVQ=.71e47741-ca1a-4f0d-a077-edc19923b381@github.com>
 <o_ZCsIdbXQgG1anU3uc1BoKYDIA8FTzVH8--u8G-aNI=.9433f786-1ea1-4ff4-8563-512c863182e4@github.com>
 <Jq_Mq_SqN4lVa9TaAo1tYixcLnpl-K0iUr0H2YVbO-w=.056ff6e7-e5f4-4a14-9d41-b1cced6fc9af@github.com>
 <j3oBIkzw_TfWi21qGTx37rRhjWK8ApMoKLfrruUnMZA=.ff6cbacb-f97b-4935-88e6-d7039ca71a0d@github.com>
 <ZOEGWWXb5NNzApA5m1Nl3G1x1AnJNPMNfCTBVW2kn3k=.38c15bcf-1bf1-4e04-b470-bab5fdbccdbb@github.com>
 <pBoKSbwIMkb8RtGQJMU828irIC8UqKXRln6
 zThcQ9Vw=.c93bfe04-c8fd-41bd-8224-16a6818df3f0@github.com>
Message-ID: <rwKTrgKONMaqs4616ZFurTRXKIqPYmEaTa8QS0CLKAQ=.5aef20f7-cd06-4373-bfb8-db50c2339c1f@github.com>

On Thu, 8 Oct 2020 05:44:15 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> Ok, sweet. Will send another PR for that shortly.
>
> Btw. how does issue handling work in general, can I also open one myself? I noticed a few glitches where inconsistent
> configuration could be handled more gracefully in the agent (e.g. defining a return value for a void method will cause
> an exception due to an illegally named field for the value in the generated event type, whereas this should only
> trigger a warning IMO).

I think there might already be some issues open for these agent related blemishes, but if not, I?d be happy to open an
issue for you. JBS access is only granted to OpenJDK Authors. If you think you?ll become a Committer to JMC, I?d be
happy to help you become a JMC author.

See: https://openjdk.java.net/projects/.

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From github.com+28612+gunnarmorling at openjdk.java.net  Thu Oct  8 08:28:40 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Thu, 8 Oct 2020 08:28:40 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <rwKTrgKONMaqs4616ZFurTRXKIqPYmEaTa8QS0CLKAQ=.5aef20f7-cd06-4373-bfb8-db50c2339c1f@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
 <Q5V4DZpQDgCYd1qTThv8yxvY_DieamahNNHQaFmScCM=.6f985014-cf5f-41c4-8ff8-fd681956d5ab@github.com>
 <to1nUkyLRSGnAAe7Ft7RA0KAIDUMUwG_Tj6N2mTkocM=.f11b0abc-9ffd-4e83-948f-14df37ef8e15@github.com>
 <pQjTLXJpt1fcX3aywoLVAjPK6TQ5vGGR0o0HLJQYEjk=.deff5ed7-782c-4e06-9213-ccb8daa83529@github.com>
 <6NYeRGIx9nkbr7Xa4FvTYABEVlqSnuHwbcS8dR3aMTk=.b5aa6e02-9911-4d2f-81b2-7cfa34c58aa6@github.com>
 <XH92wHI4NJQj0tdOevWNNMRMkWuZelQVSTM-LKXdaVQ=.71e47741-ca1a-4f0d-a077-edc19923b381@github.com>
 <o_ZCsIdbXQgG1anU3uc1BoKYDIA8FTzVH8--u8G-aNI=.9433f786-1ea1-4ff4-8563-512c863182e4@github.com>
 <Jq_Mq_SqN4lVa9TaAo1tYixcLnpl-K0iUr0H2YVbO-w=.056ff6e7-e5f4-4a14-9d41-b1cced6fc9af@github.com>
 <j3oBIkzw_TfWi21qGTx37rRhjWK8ApMoKLfrruUnMZA=.ff6cbacb-f97b-4935-88e6-d7039ca71a0d@github.com>
 <ZOEGWWXb5NNzApA5m1Nl3G1x1AnJNPMNfCTBVW2kn3k=.38c15bcf-1bf1-4e04-b470-bab5fdbccdbb@github.com>
 <pBoKSbwIMkb8RtGQJMU828irIC8UqKXRln6
 zThcQ9Vw=.c93bfe04-c8fd-41bd-8224-16a6818df3f0@github.com>
 <rwKTrgKONMaqs4616ZFurTRXKIqPYmEaTa8QS0CLKAQ=.5aef20f7-cd06-4373-bfb8-db50c2339c1f@github.com>
Message-ID: <iwyb992yuN8WHb4ROO21k1aDJXqevJ8gPGtde95K1ck=.86e158b6-9826-4320-9b11-e6d5d01fcab5@github.com>

On Thu, 8 Oct 2020 07:18:39 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> I think there might already be some issues open for these agent related blemishes, but if not, I?d be happy to open an
> issue for you.

Ok, just let me know. I'll prepare a PR once I got the time and can adjust the commit message as needed.

> If you think you?ll become a Committer to JMC, I?d be happy to help you become a JMC author.

That sounds great! So I am definitely interested, let me just see how much time I'll be able to attribute. I don't want
to glok up systems and infrastructure unnecessarily. There's a few things I'd like to improve related to the agent.
Perhaps let me send a few PRs and then we can see whether I deserve the honour of committership :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From ghb at openjdk.java.net  Thu Oct  8 11:00:41 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Thu, 8 Oct 2020 11:00:41 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
Message-ID: <qsAzw1ukxfhCuka2D6OEwJDEUVcgGMmXCbum8bWom5k=.9cde7ea0-9673-4e90-9c22-726e7d396c6a@github.com>

On Mon, 5 Oct 2020 14:12:46 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> 6910: Missing manifest prevents agent jar from running

Changes look good to me.
Verified on Linux build, Generates MANIFEST.MF file with below content :

`
Manifest-Version: 1.0
Created-By: Apache Maven 3.6.3
Built-By: null
Build-Jdk: 11.0.9
Agent-Class: org.openjdk.jmc.agent.Agent
Automatic-Module-Name: org.openjdk.jmc.agent
Bundle-RequiredExecutionEnvironment: JavaSE-1.8
Can-Retransform-Classes: true
Premain-Class: org.openjdk.jmc.agent.Agent

`

-------------

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/122

From hirt at openjdk.java.net  Thu Oct  8 12:49:39 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 8 Oct 2020 12:49:39 GMT
Subject: RFR: 6173: jmc -open requires full path
In-Reply-To: <ohahuqEBf3XJ9agsEfa2hjo2cbyyAiLSgaml0OXYM4c=.8a76d65b-f7d2-458d-bea4-ee9ec8b22053@github.com>
References: <ohahuqEBf3XJ9agsEfa2hjo2cbyyAiLSgaml0OXYM4c=.8a76d65b-f7d2-458d-bea4-ee9ec8b22053@github.com>
Message-ID: <qg5vT7hFWxWdHhttsKERX8vOBs7qkja_-5TT7NrApBY=.d09cea36-1899-4468-af7a-408cbd7b8b9a@github.com>

On Wed, 7 Oct 2020 19:09:52 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> Handle special Mac case where user.dir is set by mac eclipse launcher
> to the directory where is jmc binary.
> Hopfully, PWD env var is kept where the program was launched so we can use it
> to prepend to the providing filename.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/123

From github.com+4610701+jpbempel at openjdk.java.net  Thu Oct  8 14:54:42 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Thu, 8 Oct 2020 14:54:42 GMT
Subject: Integrated: 6173: jmc -open requires full path
In-Reply-To: <ohahuqEBf3XJ9agsEfa2hjo2cbyyAiLSgaml0OXYM4c=.8a76d65b-f7d2-458d-bea4-ee9ec8b22053@github.com>
References: <ohahuqEBf3XJ9agsEfa2hjo2cbyyAiLSgaml0OXYM4c=.8a76d65b-f7d2-458d-bea4-ee9ec8b22053@github.com>
Message-ID: <svINeyZ7b19EjizQLuUcQ3crrj8kEEZlFAGFaMnJ1N0=.dc5622c0-c521-4961-962d-d8c7bff16f97@github.com>

On Wed, 7 Oct 2020 19:09:52 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> Handle special Mac case where user.dir is set by mac eclipse launcher
> to the directory where is jmc binary.
> Hopfully, PWD env var is kept where the program was launched so we can use it
> to prepend to the providing filename.

This pull request has now been integrated.

Changeset: 28f533aa
Author:    Jean-Philippe Bempel <jean-philippe at bempel.fr>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/28f533aa
Stats:     16 lines in 1 file changed: 14 ins; 1 del; 1 mod

6173: jmc -open requires full path

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/123

From hirt at openjdk.java.net  Thu Oct  8 14:55:41 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 8 Oct 2020 14:55:41 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <qsAzw1ukxfhCuka2D6OEwJDEUVcgGMmXCbum8bWom5k=.9cde7ea0-9673-4e90-9c22-726e7d396c6a@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
 <qsAzw1ukxfhCuka2D6OEwJDEUVcgGMmXCbum8bWom5k=.9cde7ea0-9673-4e90-9c22-726e7d396c6a@github.com>
Message-ID: <xmwj0ycwQtVliQ-vw6pR9StTCxTO1xem2JEOzpbHzR8=.14afa1f8-db9e-4f12-b7dc-db80c50f5e63@github.com>

On Thu, 8 Oct 2020 10:58:30 GMT, Guru Hb <ghb at openjdk.org> wrote:

>> 6910: Missing manifest prevents agent jar from running
>
> Changes look good to me.
> Verified on Linux build, Generates MANIFEST.MF file with below content :
> 
> `
> Manifest-Version: 1.0
> Created-By: Apache Maven 3.6.3
> Built-By: null
> Build-Jdk: 11.0.9
> Agent-Class: org.openjdk.jmc.agent.Agent
> Automatic-Module-Name: org.openjdk.jmc.agent
> Bundle-RequiredExecutionEnvironment: JavaSE-1.8
> Can-Retransform-Classes: true
> Premain-Class: org.openjdk.jmc.agent.Agent
> 
> `

Hi @gunnarmorling! You're good to go! Simply write /integrate in a new message to integrate your changes.

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From github.com+28612+gunnarmorling at openjdk.java.net  Thu Oct  8 15:38:20 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Thu, 8 Oct 2020 15:38:20 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <xmwj0ycwQtVliQ-vw6pR9StTCxTO1xem2JEOzpbHzR8=.14afa1f8-db9e-4f12-b7dc-db80c50f5e63@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
 <qsAzw1ukxfhCuka2D6OEwJDEUVcgGMmXCbum8bWom5k=.9cde7ea0-9673-4e90-9c22-726e7d396c6a@github.com>
 <xmwj0ycwQtVliQ-vw6pR9StTCxTO1xem2JEOzpbHzR8=.14afa1f8-db9e-4f12-b7dc-db80c50f5e63@github.com>
Message-ID: <NnXR8jpNJDYkLx78lZARJFUFBQ03mD45_4PUKiMMbIw=.fd94d271-e02e-47c7-8a67-0aa22a699b52@github.com>

On Thu, 8 Oct 2020 14:53:14 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Changes look good to me.
>> Verified on Linux build, Generates MANIFEST.MF file with below content :
>> 
>> `
>> Manifest-Version: 1.0
>> Created-By: Apache Maven 3.6.3
>> Built-By: null
>> Build-Jdk: 11.0.9
>> Agent-Class: org.openjdk.jmc.agent.Agent
>> Automatic-Module-Name: org.openjdk.jmc.agent
>> Bundle-RequiredExecutionEnvironment: JavaSE-1.8
>> Can-Retransform-Classes: true
>> Premain-Class: org.openjdk.jmc.agent.Agent
>> 
>> `
>
> Hi @gunnarmorling! You're good to go! Simply write /integrate in a new message to integrate your changes.

Oook, let's give this a try then :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From hirt at openjdk.java.net  Thu Oct  8 15:55:18 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 8 Oct 2020 15:55:18 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <NnXR8jpNJDYkLx78lZARJFUFBQ03mD45_4PUKiMMbIw=.fd94d271-e02e-47c7-8a67-0aa22a699b52@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
 <qsAzw1ukxfhCuka2D6OEwJDEUVcgGMmXCbum8bWom5k=.9cde7ea0-9673-4e90-9c22-726e7d396c6a@github.com>
 <xmwj0ycwQtVliQ-vw6pR9StTCxTO1xem2JEOzpbHzR8=.14afa1f8-db9e-4f12-b7dc-db80c50f5e63@github.com>
 <NnXR8jpNJDYkLx78lZARJFUFBQ03mD45_4PUKiMMbIw=.fd94d271-e02e-47c7-8a67-0aa22a699b52@github.com>
Message-ID: <oYve4dAsypkY-lTPtiYl27wYRwU5x2wLQ0nLyOSGIBE=.c5ee2f35-c3e4-4bbf-b598-486df99f4090@github.com>

On Thu, 8 Oct 2020 15:35:16 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> Hi @gunnarmorling! You're good to go! Simply write /integrate in a new message to integrate your changes.
>
> Oook, let's give this a try then :)

Thanks @gunnarmorling, and congratulations on your first commit! :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From github.com+28612+gunnarmorling at openjdk.java.net  Thu Oct  8 15:55:21 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Thu, 8 Oct 2020 15:55:21 GMT
Subject: Integrated: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
Message-ID: <cQwB6mKXD68SKKZVXBGSAEjEGoEpS2GmT8u7Mk21pg0=.785348a2-f667-40ff-868b-972554ef8764@github.com>

On Mon, 5 Oct 2020 14:12:46 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> 6910: Missing manifest prevents agent jar from running

This pull request has now been integrated.

Changeset: ade72241
Author:    Gunnar Morling <gunnar.morling at googlemail.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/ade72241
Stats:     24 lines in 1 file changed: 12 ins; 12 del; 0 mod

6910: Missing manifest prevents agent jar from running

Reviewed-by: aptmac, ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From github.com+28612+gunnarmorling at openjdk.java.net  Thu Oct  8 16:03:20 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Thu, 8 Oct 2020 16:03:20 GMT
Subject: RFR: 6910: Missing manifest prevents agent jar from running
In-Reply-To: <oYve4dAsypkY-lTPtiYl27wYRwU5x2wLQ0nLyOSGIBE=.c5ee2f35-c3e4-4bbf-b598-486df99f4090@github.com>
References: <7gkRxZooGyoeFBuXPblp2WuoEIRmeBLHH9BJwloypyk=.40e87c92-9227-408c-9732-d5cd9a6c12a8@github.com>
 <qsAzw1ukxfhCuka2D6OEwJDEUVcgGMmXCbum8bWom5k=.9cde7ea0-9673-4e90-9c22-726e7d396c6a@github.com>
 <xmwj0ycwQtVliQ-vw6pR9StTCxTO1xem2JEOzpbHzR8=.14afa1f8-db9e-4f12-b7dc-db80c50f5e63@github.com>
 <NnXR8jpNJDYkLx78lZARJFUFBQ03mD45_4PUKiMMbIw=.fd94d271-e02e-47c7-8a67-0aa22a699b52@github.com>
 <oYve4dAsypkY-lTPtiYl27wYRwU5x2wLQ0nLyOSGIBE=.c5ee2f35-c3e4-4bbf-b598-486df99f4090@github.com>
Message-ID: <EbADReddBEIjdANk9aDStHcb3q1clHV6cvUe-IWv7-k=.d4d4ba47-f02f-41b8-bcac-084d30a90094@github.com>

On Thu, 8 Oct 2020 15:53:03 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Oook, let's give this a try then :)
>
> Thanks @gunnarmorling, and congratulations on your first commit! :)

Woohoo, exciiiting :) Thanks for the quick turnaround with everything, glad to have this one in!

-------------

PR: https://git.openjdk.java.net/jmc/pull/122

From github.com+28612+gunnarmorling at openjdk.java.net  Thu Oct  8 20:48:26 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Thu, 8 Oct 2020 20:48:26 GMT
Subject: RFR: 1234: Caching Maven repo
Message-ID: <evOGEAxxrAWbtcIDZVjFOE8nleLSaAJEl3F8b6coTN0=.f40c8ae5-ba19-4f87-b4f9-c44a356cc918@github.com>

So this adds the caching of Maven dependencies we discussed in the other PR. While testing this in my fork, it reduced
the build time from ~30 min to ~23 min. I'll reword the commit message if there's agreement on this and a Jira issue
exists. Thanks!

-------------

Commit messages:
 - 1234: Caching Maven repo

Changes: https://git.openjdk.java.net/jmc/pull/124/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=124&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-1234
  Stats: 18 lines in 1 file changed: 18 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/124.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/124/head:pull/124

PR: https://git.openjdk.java.net/jmc/pull/124

From github.com+28612+gunnarmorling at openjdk.java.net  Thu Oct  8 21:54:27 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Thu, 8 Oct 2020 21:54:27 GMT
Subject: RFR: 1234: Caching Maven repo [v2]
In-Reply-To: <evOGEAxxrAWbtcIDZVjFOE8nleLSaAJEl3F8b6coTN0=.f40c8ae5-ba19-4f87-b4f9-c44a356cc918@github.com>
References: <evOGEAxxrAWbtcIDZVjFOE8nleLSaAJEl3F8b6coTN0=.f40c8ae5-ba19-4f87-b4f9-c44a356cc918@github.com>
Message-ID: <V8NrXfMsn3a1pHcn-Nr0mG2tss7MiVuwSNLL6tzLrfQ=.c49f4900-f993-45c3-b696-a7d6af0a90bd@github.com>

> So this adds the caching of Maven dependencies we discussed in the other PR. While testing this in my fork, it reduced
> the build time from ~30 min to ~23 min. I'll reword the commit message if there's agreement on this and a Jira issue
> exists. Thanks!

Gunnar Morling has refreshed the contents of this pull request, and previous commits have been removed. The incremental
views will show differences compared to the previous content of the PR. The pull request contains one new commit since
the last revision:

  1234: Caching Maven repo

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/124/files
  - new: https://git.openjdk.java.net/jmc/pull/124/files/049a63bf..b17143b1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=124&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=124&range=00-01

  Stats: 18 lines in 1 file changed: 3 ins; 0 del; 15 mod
  Patch: https://git.openjdk.java.net/jmc/pull/124.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/124/head:pull/124

PR: https://git.openjdk.java.net/jmc/pull/124

From github.com+28612+gunnarmorling at openjdk.java.net  Fri Oct  9 05:42:15 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Fri, 9 Oct 2020 05:42:15 GMT
Subject: RFR: 1234: Caching Maven repo
In-Reply-To: <evOGEAxxrAWbtcIDZVjFOE8nleLSaAJEl3F8b6coTN0=.f40c8ae5-ba19-4f87-b4f9-c44a356cc918@github.com>
References: <evOGEAxxrAWbtcIDZVjFOE8nleLSaAJEl3F8b6coTN0=.f40c8ae5-ba19-4f87-b4f9-c44a356cc918@github.com>
Message-ID: <ORmbAlL_xMeOMiAqPBhfJecTneiMDsX03sS5HlShFGo=.738ccf93-8dc1-4ac7-b4db-bf8438072de1@github.com>

On Thu, 8 Oct 2020 20:45:00 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> So this adds the caching of Maven dependencies we discussed in the other PR. While testing this in my fork, it reduced
> the build time from ~30 min to ~23 min. I'll reword the commit message if there's agreement on this and a Jira issue
> exists. Thanks!

Note I haven't really groked the build yet, I suppose there are specific steps in place for downloading the Eclipse
target platform and such. Not sure whether all that is done via Maven's resolver and thus will benefit from this
caching?

Btw. I noticed quite a few downloads via http (instead of https) in what I suppose is the target platform provisioning;
would be great if we could ban any non-https sources.

-------------

PR: https://git.openjdk.java.net/jmc/pull/124

From hirt at openjdk.java.net  Fri Oct  9 09:04:15 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 9 Oct 2020 09:04:15 GMT
Subject: RFR: 6925: Cache the local maven repo between runs
In-Reply-To: <ORmbAlL_xMeOMiAqPBhfJecTneiMDsX03sS5HlShFGo=.738ccf93-8dc1-4ac7-b4db-bf8438072de1@github.com>
References: <evOGEAxxrAWbtcIDZVjFOE8nleLSaAJEl3F8b6coTN0=.f40c8ae5-ba19-4f87-b4f9-c44a356cc918@github.com>
 <ORmbAlL_xMeOMiAqPBhfJecTneiMDsX03sS5HlShFGo=.738ccf93-8dc1-4ac7-b4db-bf8438072de1@github.com>
Message-ID: <K0QbukEyozrDbOi9Z67tOZ5Hv6ax5_brTXqdny5VW2M=.0800e0d6-c589-4f3d-8f6a-08eaaa8e885b@github.com>

On Fri, 9 Oct 2020 05:40:03 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> So this adds the caching of Maven dependencies we discussed in the other PR. While testing this in my fork, it reduced
>> the build time from ~30 min to ~23 min. I'll reword the commit message if there's agreement on this and a Jira issue
>> exists. Thanks!
>
> Note I haven't really groked the build yet, I suppose there are specific steps in place for downloading the Eclipse
> target platform and such. Not sure whether all that is done via Maven's resolver and thus will benefit from this
> caching?  Btw. I noticed quite a few downloads via http (instead of https) in what I suppose is the target platform
> provisioning; would be great if we could ban any non-https sources.

Hi Gunnar! The issue is JMC-6925.

-------------

PR: https://git.openjdk.java.net/jmc/pull/124

From hirt at openjdk.java.net  Fri Oct  9 09:08:17 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 9 Oct 2020 09:08:17 GMT
Subject: RFR: 6925: Cache the local maven repo between runs [v2]
In-Reply-To: <V8NrXfMsn3a1pHcn-Nr0mG2tss7MiVuwSNLL6tzLrfQ=.c49f4900-f993-45c3-b696-a7d6af0a90bd@github.com>
References: <evOGEAxxrAWbtcIDZVjFOE8nleLSaAJEl3F8b6coTN0=.f40c8ae5-ba19-4f87-b4f9-c44a356cc918@github.com>
 <V8NrXfMsn3a1pHcn-Nr0mG2tss7MiVuwSNLL6tzLrfQ=.c49f4900-f993-45c3-b696-a7d6af0a90bd@github.com>
Message-ID: <TR6N7DDi_6nWDkxzEEzbXpriBc8-MKQ_BExk-fFl24g=.82c43ade-663f-4d90-84c6-6874560ba2c1@github.com>

On Thu, 8 Oct 2020 21:54:27 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> So this adds the caching of Maven dependencies we discussed in the other PR. While testing this in my fork, it reduced
>> the build time from ~30 min to ~23 min. I'll reword the commit message if there's agreement on this and a Jira issue
>> exists. Thanks!
>
> Gunnar Morling has refreshed the contents of this pull request, and previous commits have been removed. The incremental
> views will show differences compared to the previous content of the PR.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/124

From marcus.hirt at datadoghq.com  Fri Oct  9 12:51:35 2020
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Fri, 9 Oct 2020 14:51:35 +0200
Subject: The jmc7 repo is now at GitHub.
Message-ID: <CAOpWGx31rWFMXg2q+WREm_TcTLUKMYigRfh62-eOLzHq0oQzQQ@mail.gmail.com>

Hi all,

The jmc7 repo is now available here https://github.com/openjdk/jmc7.

Many thanks to Erik Helin for doing this!

Next step is deciding whether or not to fold it into the jmc repo. So far
most people seem in favour of one repo with release branches. Please let me
know what you think!

Kind regards,
Marcus

From github.com+28612+gunnarmorling at openjdk.java.net  Fri Oct  9 16:35:16 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Fri, 9 Oct 2020 16:35:16 GMT
Subject: RFR: 6925: Cache the local maven repo between runs [v3]
In-Reply-To: <evOGEAxxrAWbtcIDZVjFOE8nleLSaAJEl3F8b6coTN0=.f40c8ae5-ba19-4f87-b4f9-c44a356cc918@github.com>
References: <evOGEAxxrAWbtcIDZVjFOE8nleLSaAJEl3F8b6coTN0=.f40c8ae5-ba19-4f87-b4f9-c44a356cc918@github.com>
Message-ID: <8wp5njv-BDeXZcGzd94PVwi1mNTvIzva_FfH7MT6ZHc=.01f224e4-c0bd-41ff-bb1e-8f5e95bea96e@github.com>

> So this adds the caching of Maven dependencies we discussed in the other PR. While testing this in my fork, it reduced
> the build time from ~30 min to ~23 min. I'll reword the commit message if there's agreement on this and a Jira issue
> exists. Thanks!

Gunnar Morling has refreshed the contents of this pull request, and previous commits have been removed. The incremental
views will show differences compared to the previous content of the PR. The pull request contains one new commit since
the last revision:

  6925: Caching Maven repo

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/124/files
  - new: https://git.openjdk.java.net/jmc/pull/124/files/b17143b1..fd2b718f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=124&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=124&range=01-02

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/124.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/124/head:pull/124

PR: https://git.openjdk.java.net/jmc/pull/124

From github.com+28612+gunnarmorling at openjdk.java.net  Fri Oct  9 16:35:17 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Fri, 9 Oct 2020 16:35:17 GMT
Subject: RFR: 6925: Cache the local maven repo between runs [v2]
In-Reply-To: <TR6N7DDi_6nWDkxzEEzbXpriBc8-MKQ_BExk-fFl24g=.82c43ade-663f-4d90-84c6-6874560ba2c1@github.com>
References: <evOGEAxxrAWbtcIDZVjFOE8nleLSaAJEl3F8b6coTN0=.f40c8ae5-ba19-4f87-b4f9-c44a356cc918@github.com>
 <V8NrXfMsn3a1pHcn-Nr0mG2tss7MiVuwSNLL6tzLrfQ=.c49f4900-f993-45c3-b696-a7d6af0a90bd@github.com>
 <TR6N7DDi_6nWDkxzEEzbXpriBc8-MKQ_BExk-fFl24g=.82c43ade-663f-4d90-84c6-6874560ba2c1@github.com>
Message-ID: <_Urz-uziVqm-lurqn_WGFQoo7vc7Pw7QHUYo5oSjOds=.0cbdc112-1238-4103-82e8-d1280e807205@github.com>

On Fri, 9 Oct 2020 09:05:57 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Gunnar Morling has refreshed the contents of this pull request, and previous commits have been removed. The incremental
>> views will show differences compared to the previous content of the PR.
>
> Marked as reviewed by hirt (Lead).

Changed the commit message to include the issue key and force-pushed.

-------------

PR: https://git.openjdk.java.net/jmc/pull/124

From github.com+28612+gunnarmorling at openjdk.java.net  Fri Oct  9 16:35:17 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Fri, 9 Oct 2020 16:35:17 GMT
Subject: RFR: 6925: Cache the local maven repo between runs [v2]
In-Reply-To: <_Urz-uziVqm-lurqn_WGFQoo7vc7Pw7QHUYo5oSjOds=.0cbdc112-1238-4103-82e8-d1280e807205@github.com>
References: <evOGEAxxrAWbtcIDZVjFOE8nleLSaAJEl3F8b6coTN0=.f40c8ae5-ba19-4f87-b4f9-c44a356cc918@github.com>
 <V8NrXfMsn3a1pHcn-Nr0mG2tss7MiVuwSNLL6tzLrfQ=.c49f4900-f993-45c3-b696-a7d6af0a90bd@github.com>
 <TR6N7DDi_6nWDkxzEEzbXpriBc8-MKQ_BExk-fFl24g=.82c43ade-663f-4d90-84c6-6874560ba2c1@github.com>
 <_Urz-uziVqm-lurqn_WGFQoo7vc7Pw7QHUYo5oSjOds=.0cbdc112-1238-4103-82e8-d1280e807205@github.com>
Message-ID: <_v2RSX6cFqOLb0q4_VG9JbWtexLR8dH8Kx6LAWsDvLg=.31b2db37-960e-4437-b8f5-d538b2f77cbe@github.com>

On Fri, 9 Oct 2020 16:29:46 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> Marked as reviewed by hirt (Lead).
>
> Changed the commit message to include the issue key and force-pushed.

Ah, seems I might not even have had to do this as the commit message will be adjusted automatically?

-------------

PR: https://git.openjdk.java.net/jmc/pull/124

From hirt at openjdk.java.net  Fri Oct  9 16:54:11 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 9 Oct 2020 16:54:11 GMT
Subject: RFR: 6925: Cache the local maven repo between runs [v2]
In-Reply-To: <_v2RSX6cFqOLb0q4_VG9JbWtexLR8dH8Kx6LAWsDvLg=.31b2db37-960e-4437-b8f5-d538b2f77cbe@github.com>
References: <evOGEAxxrAWbtcIDZVjFOE8nleLSaAJEl3F8b6coTN0=.f40c8ae5-ba19-4f87-b4f9-c44a356cc918@github.com>
 <V8NrXfMsn3a1pHcn-Nr0mG2tss7MiVuwSNLL6tzLrfQ=.c49f4900-f993-45c3-b696-a7d6af0a90bd@github.com>
 <TR6N7DDi_6nWDkxzEEzbXpriBc8-MKQ_BExk-fFl24g=.82c43ade-663f-4d90-84c6-6874560ba2c1@github.com>
 <_Urz-uziVqm-lurqn_WGFQoo7vc7Pw7QHUYo5oSjOds=.0cbdc112-1238-4103-82e8-d1280e807205@github.com>
 <_v2RSX6cFqOLb0q4_VG9JbWtexLR8dH8Kx6LAWsDvLg=.31b2db37-960e-4437-b8f5-d538b2f77cbe@github.com>
Message-ID: <hp0xdzIg9pA86EWKDkCyL4T6dBdlG2VciM6yLndzZRs=.50d426ab-d112-4298-b6b1-d11aafab4e58@github.com>

On Fri, 9 Oct 2020 16:31:20 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> Ah, seems I might not even have had to do this as the commit message will be adjusted automatically?

It will be squashed and appropriately named. You do need to set the PR name appropriately though. Skara is pretty nice.
:)

-------------

PR: https://git.openjdk.java.net/jmc/pull/124

From github.com+28612+gunnarmorling at openjdk.java.net  Fri Oct  9 16:59:07 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Fri, 9 Oct 2020 16:59:07 GMT
Subject: Integrated: 6925: Cache the local maven repo between runs
In-Reply-To: <evOGEAxxrAWbtcIDZVjFOE8nleLSaAJEl3F8b6coTN0=.f40c8ae5-ba19-4f87-b4f9-c44a356cc918@github.com>
References: <evOGEAxxrAWbtcIDZVjFOE8nleLSaAJEl3F8b6coTN0=.f40c8ae5-ba19-4f87-b4f9-c44a356cc918@github.com>
Message-ID: <MEJe9ltZJYkO7ybT1BDHiNS81gQkCksMP0NIof17oCc=.b7e2bca7-56f5-428f-978c-1a179742deb4@github.com>

On Thu, 8 Oct 2020 20:45:00 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> So this adds the caching of Maven dependencies we discussed in the other PR. While testing this in my fork, it reduced
> the build time from ~30 min to ~23 min. I'll reword the commit message if there's agreement on this and a Jira issue
> exists. Thanks!

This pull request has now been integrated.

Changeset: 47db669d
Author:    Gunnar Morling <gunnar.morling at googlemail.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/47db669d
Stats:     21 lines in 1 file changed: 21 ins; 0 del; 0 mod

6925: Cache the local maven repo between runs

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/124

From github.com+6304496+dreis2211 at openjdk.java.net  Fri Oct  9 17:40:10 2020
From: github.com+6304496+dreis2211 at openjdk.java.net (Christoph Dreis)
Date: Fri, 9 Oct 2020 17:40:10 GMT
Subject: RFR: 6929: Remove obsolete .hgignore file
Message-ID: <4fog4wi3-FGaSFh9mZ6IMXESfyPVWixFCCJ3KdzaciY=.b2e21841-5f40-4ef3-b081-06b1b0d10603@github.com>

Hi,

this PR removes the `.hgignore` file that seems obsolete after the move to Git(Hub).

Since this is my first PR to the project, I hope this is loosely following other JDK projects.

This would need a ticket in the bug tracker and I hope you can create this for me. I've signed the OCA for the OpenJDK
already, but let me know if I need to confirm something again.

In case you think this is worthwhile, I would appreciate it if this is sponsored.

Cheers,
Christoph

-------------

Commit messages:
 - Remove obsolete .hgignore

Changes: https://git.openjdk.java.net/jmc/pull/125/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=125&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6929
  Stats: 31 lines in 1 file changed: 0 ins; 31 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/125.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/125/head:pull/125

PR: https://git.openjdk.java.net/jmc/pull/125

From hirt at openjdk.java.net  Fri Oct  9 17:40:10 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 9 Oct 2020 17:40:10 GMT
Subject: RFR: 6929: Remove obsolete .hgignore file
In-Reply-To: <4fog4wi3-FGaSFh9mZ6IMXESfyPVWixFCCJ3KdzaciY=.b2e21841-5f40-4ef3-b081-06b1b0d10603@github.com>
References: <4fog4wi3-FGaSFh9mZ6IMXESfyPVWixFCCJ3KdzaciY=.b2e21841-5f40-4ef3-b081-06b1b0d10603@github.com>
Message-ID: <PhjiHOiIV1zIgth6tfOi1zfOy20xUf1hy81s2FQRe58=.906ee8f1-bf8e-4393-a2a2-a672bf02b5cb@github.com>

On Fri, 9 Oct 2020 17:23:22 GMT, Christoph Dreis <github.com+6304496+dreis2211 at openjdk.org> wrote:

> Hi,
> 
> this PR removes the `.hgignore` file that seems obsolete after the move to Git(Hub).
> 
> Since this is my first PR to the project, I hope this is loosely following other JDK projects.
> 
> This would need a ticket in the bug tracker and I hope you can create this for me. I've signed the OCA for the OpenJDK
> already, but let me know if I need to confirm something again.
> In case you think this is worthwhile, I would appreciate it if this is sponsored.
> 
> Cheers,
> Christoph

Hi Christoph! You're recognized by the bot, so all should be well. Welcome to the JMC project!

-------------

PR: https://git.openjdk.java.net/jmc/pull/125

From hirt at openjdk.java.net  Fri Oct  9 19:53:06 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 9 Oct 2020 19:53:06 GMT
Subject: RFR: 6929: Remove obsolete .hgignore file
In-Reply-To: <4fog4wi3-FGaSFh9mZ6IMXESfyPVWixFCCJ3KdzaciY=.b2e21841-5f40-4ef3-b081-06b1b0d10603@github.com>
References: <4fog4wi3-FGaSFh9mZ6IMXESfyPVWixFCCJ3KdzaciY=.b2e21841-5f40-4ef3-b081-06b1b0d10603@github.com>
Message-ID: <G7k1Blor5_rkPqYhAtjDsacgqncLsW2ixm0EwV1DZnI=.87d47aee-cfb9-4510-b52c-c07bfb54d77a@github.com>

On Fri, 9 Oct 2020 17:23:22 GMT, Christoph Dreis <github.com+6304496+dreis2211 at openjdk.org> wrote:

> Hi,
> 
> this PR removes the `.hgignore` file that seems obsolete after the move to Git(Hub).
> 
> Since this is my first PR to the project, I hope this is loosely following other JDK projects.
> 
> This would need a ticket in the bug tracker and I hope you can create this for me. I've signed the OCA for the OpenJDK
> already, but let me know if I need to confirm something again.
> In case you think this is worthwhile, I would appreciate it if this is sponsored.
> 
> Cheers,
> Christoph

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/125

From hirt at openjdk.java.net  Fri Oct  9 20:14:10 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 9 Oct 2020 20:14:10 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v20]
In-Reply-To: <Xmof_RKkV8zx6k0SNx707jOO1Z8GFQD1d6FtbcFBBso=.78a2f05f-8518-49d9-ada1-53eedddd85d3@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
 <Xmof_RKkV8zx6k0SNx707jOO1Z8GFQD1d6FtbcFBBso=.78a2f05f-8518-49d9-ada1-53eedddd85d3@github.com>
Message-ID: <FC5kMQHxz8_gfKjpcsewgf_0fdg6MRJfNnlMVlUPVJQ=.58af68f5-75c8-4cfb-b3ab-8ec354e78111@github.com>

On Tue, 22 Sep 2020 21:01:24 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> stable flameview generation
>
> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6542: more cleanup

Changes requested by hirt (Lead).

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceNode.java
line 102:

> 100: 			return false;
> 101: 		if (packageName == null) {
> 102: 			if (other.packageName != null)

This file should be reverted. All ?if? scopes should have brackets.

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
line 378:

> 376:
> 377: 			TraceNode root = TraceTreeUtils.createRootWithDescription(items, rootFork.getBranchCount());
> 378: 			if (Thread.currentThread().isAlive()) {

I don?t get these thread changes. The current thread is executing your code, and is therefore always alive. Also, if
you want to make these calculations abortable, I?d much prefer an API for it. Maybe an Abortable interface, or perhaps
even better, providing some sort of a progress interface where progress could be reported to and checked against
whether it should abort every now and then. We can discuss which alternative makes most sense.

-------------

PR: https://git.openjdk.java.net/jmc/pull/78

From hirt at openjdk.java.net  Fri Oct  9 20:16:08 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 9 Oct 2020 20:16:08 GMT
Subject: RFR: 6929: Remove obsolete .hgignore file
In-Reply-To: <G7k1Blor5_rkPqYhAtjDsacgqncLsW2ixm0EwV1DZnI=.87d47aee-cfb9-4510-b52c-c07bfb54d77a@github.com>
References: <4fog4wi3-FGaSFh9mZ6IMXESfyPVWixFCCJ3KdzaciY=.b2e21841-5f40-4ef3-b081-06b1b0d10603@github.com>
 <G7k1Blor5_rkPqYhAtjDsacgqncLsW2ixm0EwV1DZnI=.87d47aee-cfb9-4510-b52c-c07bfb54d77a@github.com>
Message-ID: <5sMdiDaEX3b4viv50YyAk_962t63sY3CxaiCyev91p8=.6e753edf-ec4d-4035-92de-1a425e4585da@github.com>

On Fri, 9 Oct 2020 19:50:47 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Hi,
>> 
>> this PR removes the `.hgignore` file that seems obsolete after the move to Git(Hub).
>> 
>> Since this is my first PR to the project, I hope this is loosely following other JDK projects.
>> 
>> This would need a ticket in the bug tracker and I hope you can create this for me. I've signed the OCA for the OpenJDK
>> already, but let me know if I need to confirm something again.
>> In case you think this is worthwhile, I would appreciate it if this is sponsored.
>> 
>> Cheers,
>> Christoph
>
> Marked as reviewed by hirt (Lead).

Thanks! :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/125

From github.com+6304496+dreis2211 at openjdk.java.net  Fri Oct  9 20:16:09 2020
From: github.com+6304496+dreis2211 at openjdk.java.net (Christoph Dreis)
Date: Fri, 9 Oct 2020 20:16:09 GMT
Subject: Integrated: 6929: Remove obsolete .hgignore file
In-Reply-To: <4fog4wi3-FGaSFh9mZ6IMXESfyPVWixFCCJ3KdzaciY=.b2e21841-5f40-4ef3-b081-06b1b0d10603@github.com>
References: <4fog4wi3-FGaSFh9mZ6IMXESfyPVWixFCCJ3KdzaciY=.b2e21841-5f40-4ef3-b081-06b1b0d10603@github.com>
Message-ID: <DHmhTraI3yRt5cc8lQqPkhPUkjbADlolLQpgKdYIwN8=.379c39b7-1bbc-4b1e-8c74-9254d78d3eb5@github.com>

On Fri, 9 Oct 2020 17:23:22 GMT, Christoph Dreis <github.com+6304496+dreis2211 at openjdk.org> wrote:

> Hi,
> 
> this PR removes the `.hgignore` file that seems obsolete after the move to Git(Hub).
> 
> Since this is my first PR to the project, I hope this is loosely following other JDK projects.
> 
> This would need a ticket in the bug tracker and I hope you can create this for me. I've signed the OCA for the OpenJDK
> already, but let me know if I need to confirm something again.
> In case you think this is worthwhile, I would appreciate it if this is sponsored.
> 
> Cheers,
> Christoph

This pull request has now been integrated.

Changeset: 5280df60
Author:    Christoph Dreis <christoph.dreis at freenet.de>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/5280df60
Stats:     31 lines in 1 file changed: 0 ins; 31 del; 0 mod

6929: Remove obsolete .hgignore file

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/125

From schaturvedi at openjdk.java.net  Fri Oct  9 22:49:07 2020
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Fri, 9 Oct 2020 22:49:07 GMT
Subject: RFR: 6364: Improvements to the Thread Graph
In-Reply-To: <PrIx9JRSzJv5-338n2kxEG2thm9pLRRUeeCuuYCz208=.122c1e7d-8f9c-40e3-b0f3-0354cd49bd79@github.com>
References: <3b_EN291IWMTMl6vId_3HM3r9b2p0Bjxd9QYH5qgDO8=.50cc047a-4486-469a-a341-5908f78bb6df@github.com>
 <9z2_Fmh0wzUWsp9Tu1bEudv8_BvAjeAC6RVPPe76FRQ=.1d13e3bc-3d48-4a9b-831f-40b784d57106@github.com>
 <RzkGUXMijABPraKoBm2yRnh7490ldPx8R1pVnLkZuQo=.49c6a560-d0bc-4870-8fc8-6b16c31a4edf@github.com>
 <VtxWPdJ5lCNJANcyQQKDpUAc6oMz6sIIl4AdCngGzNY=.3e9e164a-aeca-4a31-9c0d-90b32e505e1f@github.com>
 <WlsAE5WBZzvaJ7y6s_9776LfwPZxInEyw-9tHkR8BYQ=.cac2ca35-320a-4955-b4ad-9f03cf91e67d@github.com>
 <W46pwscvWVhGWOQ7fZuohiPU3PDSr_fTBcjsYEHZX9U=.3ded4679-f3c5-4fa0-8d3f-febe4b5ff1ae@github.com>
 <PkxbYIW2PTQI6EKSG2QBPXGZsLN_4YAmK8tBzom9Zcc=.6ac6a27f-cb8f-4d40-b910-8f209468280b@github.com>
 <1rFwH_fS08Lr6VT09rAPl5aOjeoDyyfAK1l1DaktMB8=.e94b0d05-4244-46b2-848e-c83f7aa3917a@github.com>
 <m106gabj2MTdvJuIG-7VzB4GU0GwsWw8FvwMStXJvzM=.60dbba90-bc44-4759-9e45-4cc07727fb54@github.com>
 <uGE8OtyeKVfipTGVyNCcHDrlfaxDEBGqhCdPhqjlv8o=.43a35c17-ad84-4831-87ad-740cfbdd7ed1@github.com>
 <jO40oBcEPc8zoPazOkBHqUm813eWjRpi5RJ
 qYv_QCeU=.976e6cb5-a240-4e7d-b2e7-307a66903740@github.com>
 <s8PRQ3LPX5LFCZGk47tfu4T8JfguQGuKNOu6ysh3eo8=.5062e28b-b947-45b7-aaff-4e52f01c3a92@github.com>
 <te05v9SDdp77tUGnpxxtE4WvBeHTsoyZK1xxITVaAXE=.094e17e2-1599-4d6f-89c8-1311786ab932@github.com>
 <gAZnxXu30whSmrmWEqfVRZczClOSfJ3pRT0IImh3gak=.38917981-4205-4c56-9726-608dbb19e1f5@github.com>
 <PrIx9JRSzJv5-338n2kxEG2thm9pLRRUeeCuuYCz208=.122c1e7d-8f9c-40e3-b0f3-0354cd49bd79@github.com>
Message-ID: <2FK-KbfPMUpY4YxmOCnYmU4eSeGNY2WrCAwEtlO07KI=.a471914d-4f34-40ad-b639-8c6a20226245@github.com>

On Wed, 30 Sep 2020 17:40:19 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> "Edit Thread Lanes" at top right corner and "Thread State Selection" button, both are opening the same pop up.
>> 
>> Just a suggestion, Should we keep one and skip the other?
>
> @guruhb - do you and/or Suchita want to review this PR?

I have tried to use the new improved version of threads page. But for many JFRs I am getting "Too much content" issue
and the page is not loading properly.

-------------

PR: https://git.openjdk.java.net/jmc/pull/27

From hirt at openjdk.java.net  Sat Oct 10 13:11:12 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 10 Oct 2020 13:11:12 GMT
Subject: RFR: 6900: Switch from IPredicate to Predicate
Message-ID: <yWrPW8GTPCJoKqamkY7NIMIyOFAYeHKybIDyc3w218A=.bd626f15-f8da-46d3-84c0-5221f9596248@github.com>

Also small updates to the spotbugs exclude file. I'll open a separate issue for going through the spotbugs results and
fixing some problems separately.

-------------

Commit messages:
 - Formatting
 - Updating copyright years
 - 6900: Switch from IPredicate to Predicate

Changes: https://git.openjdk.java.net/jmc/pull/126/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=126&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6900
  Stats: 339 lines in 25 files changed: 29 ins; 80 del; 230 mod
  Patch: https://git.openjdk.java.net/jmc/pull/126.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/126/head:pull/126

PR: https://git.openjdk.java.net/jmc/pull/126

From github.com+924885+jpstotz at openjdk.java.net  Sat Oct 10 16:09:15 2020
From: github.com+924885+jpstotz at openjdk.java.net (Jan S.)
Date: Sat, 10 Oct 2020 16:09:15 GMT
Subject: RFR: 6913: Add daemon thread information to the console threads
 view [v2]
In-Reply-To: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
References: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
Message-ID: <EUy9xe1cQcUE5N8uowwo4KB94oWSLsdeLJfh7H57XFM=.d6806c73-f65c-4102-9c74-681b4d9c6845@github.com>

> I had an Java application which did not exit because of a non-daemon thread still running. Therefore I added a column
> to the treads view that displays if a thread is a daemon thread or not.
> oca: has been signed on 2019-01-17 (got positive response from Dalibor Topic on 2019-01-23).

Jan S. has updated the pull request incrementally with one additional commit since the last revision:

  show error message for Java 8 VMs and older that do not provide isDaemon() in java.lang.management.ThreadInfo

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/110/files
  - new: https://git.openjdk.java.net/jmc/pull/110/files/a726248d..c864b4be

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=110&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=110&range=00-01

  Stats: 11 lines in 3 files changed: 10 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/110.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/110/head:pull/110

PR: https://git.openjdk.java.net/jmc/pull/110

From github.com+924885+jpstotz at openjdk.java.net  Sat Oct 10 16:21:08 2020
From: github.com+924885+jpstotz at openjdk.java.net (Jan S.)
Date: Sat, 10 Oct 2020 16:21:08 GMT
Subject: RFR: 6913: Add daemon thread information to the console threads
 view
In-Reply-To: <ac5V29xE9j7rjNh4jYIBOLagiIh8Z3J_OpTUms81Lbw=.009172e8-4149-4407-b1a4-f194c69c9466@github.com>
References: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
 <NsHuTOvfH63q1O1AdYKmcYXeQw_R8tGScIHGque-r44=.0944bcd3-cc8d-48ff-83e0-9ee75e3d934e@github.com>
 <Ud2TC1JU4GMe7g3PdioqKO5BLCoBOq_YL-Vr6xFrXKg=.111d7cb3-ac83-467c-abd4-23d087d6386b@github.com>
 <OLlVTAq4VJdEegCFMs1GZRkklE1Y5PfEfgjmimfEyBk=.db2a17d9-9ca7-49da-8ea2-0ab72336ca76@github.com>
 <kTGd9ZQCb39I5QRV4pw6AkTbZyWikSrDlHNeywOzXHI=.f7311509-c89f-4bda-bcff-136030f9c786@github.com>
 <ac5V29xE9j7rjNh4jYIBOLagiIh8Z3J_OpTUms81Lbw=.009172e8-4149-4407-b1a4-f194c69c9466@github.com>
Message-ID: <ev_xbTFNHY-UKDE77-8nyWQFxsHJNttx8EJyTjU-M9U=.7311f210-c3c0-4ce0-8a71-ea0234bf5352@github.com>

On Tue, 29 Sep 2020 21:04:38 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> @aptmac I just noticed that you were not talking about the JVM running JMC but about the JVM JMC is connected to. That
>> makes a version check a bit more complicated, at least I don't see a way to do so with my limited knowledge on JMC.
>> My current approach uses a Getter in `org.openjdk.jmc.console.ui.tabs.threads.ThreadInfoCompositeSupport` that catches
>> potential `InvalidKeyException` that occur when enabling the Daemon column on a Java 8 VM.  In such a case a defined
>> error string like "Data not available" is returned and shown for each thread as value in the Daemon column.
>> Do you think this is a suitable approach?
>
>> My current approach uses a Getter in `org.openjdk.jmc.console.ui.tabs.threads.ThreadInfoCompositeSupport` that catches
>> potential `InvalidKeyException` that occur when enabling the Daemon column on a Java 8 VM. In such a case a defined
>> error string like "Data not available" is returned and shown for each thread as value in the Daemon column.
>> Do you think this is a suitable approach?
> 
> Yes, catching the exception in the `Getter.getMember()` could work. Alternatively, it might be cleaner to implement
> this like `IS_DEADLOCKED` or `GET_ALLOCATED_BYTES`, which also perform a check to see if the feature is enabled or not.

@aptmac Sorry for the delay, it took me some time to understand how the information extraction from other JVMs in
Missioncontrol works.

In the end I rejected some approaches I first had in mind and ended up with an simple approach that checks if the
daemon data has been extracted from the target JVM and if not returns the "data not available" message instead of the
actual daemon data.

Hopefully my current approach is what you had in mind when speaking about a clean solution. The two other approaches
you mentioned like `IS_DEADLOCKED` or `GET_ALLOCATED_BYTES` were not that helpful as they get the data from
`ThreadMXBean` not `ThreadInfo` and thus require a different way to handle it.

-------------

PR: https://git.openjdk.java.net/jmc/pull/110

From ghb at openjdk.java.net  Sun Oct 11 06:32:06 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Sun, 11 Oct 2020 06:32:06 GMT
Subject: RFR: 6900: Switch from IPredicate to Predicate
In-Reply-To: <yWrPW8GTPCJoKqamkY7NIMIyOFAYeHKybIDyc3w218A=.bd626f15-f8da-46d3-84c0-5221f9596248@github.com>
References: <yWrPW8GTPCJoKqamkY7NIMIyOFAYeHKybIDyc3w218A=.bd626f15-f8da-46d3-84c0-5221f9596248@github.com>
Message-ID: <lZHiknim0R-5SUvHnCADiRZEzsruKY72dlzPzhTh0VE=.634955d0-5860-48a5-8864-3e0dedab96f0@github.com>

On Sat, 10 Oct 2020 13:07:25 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also small updates to the spotbugs exclude file. I'll open a separate issue for going through the spotbugs results and
> fixing some problems separately.

Changed looks good to me, verified on Linux .
Update copyright year on core/org.openjdk.jmc.flightrecorder/build.properties .

-------------

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/126

From hirt at openjdk.java.net  Sun Oct 11 09:17:40 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 11 Oct 2020 09:17:40 GMT
Subject: git: openjdk/jmc: 6900: Switch from IPredicate to Predicate
Message-ID: <bc32211c-1a42-4f8c-8eae-c29c24fd1adb@openjdk.org>

Changeset: 7de07b4c
Author:    Marcus Hirt <hirt at openjdk.org>
Date:      2020-10-11 09:17:18 +0000
URL:       https://git.openjdk.java.net/jmc/commit/7de07b4c

6900: Switch from IPredicate to Predicate

Reviewed-by: ghb

! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/ItemIterableToolkit.java
! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/StreamModel.java
! application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/LaneEditor.java
! application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/subscription/internal/AbstractAttributeSubscription.java
! configuration/spotbugs/spotbugs-exclude.xml
! core/org.openjdk.jmc.common/.settings/org.eclipse.jdt.core.prefs
- core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IPredicate.java
! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/collection/IteratorToolkit.java
! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/Aggregators.java
! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/GroupingAggregator.java
! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/IItemFilter.java
! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/IItemIterable.java
! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/ItemFilters.java
! core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/PredicateToolkit.java
! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/FewSampledThreadsRule.java
! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/AutoBoxingRule.java
! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/HeapDumpRule.java
! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/util/SingleEntryItemCollection.java
! core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/tree/TimeRangeFilter.java
! core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/tree/TimeRangeThreadFilter.java
! core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/util/RulesToolkit.java
! core/org.openjdk.jmc.flightrecorder/build.properties
! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/EventCollection.java
! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkFilters.java
! core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/mock/item/MockItemIterable.java


From hirt at openjdk.java.net  Sun Oct 11 09:21:06 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 11 Oct 2020 09:21:06 GMT
Subject: Integrated: 6900: Switch from IPredicate to Predicate
In-Reply-To: <yWrPW8GTPCJoKqamkY7NIMIyOFAYeHKybIDyc3w218A=.bd626f15-f8da-46d3-84c0-5221f9596248@github.com>
References: <yWrPW8GTPCJoKqamkY7NIMIyOFAYeHKybIDyc3w218A=.bd626f15-f8da-46d3-84c0-5221f9596248@github.com>
Message-ID: <QeVhdZ0FOUo-vNv-lO0W2_39AE7iGJ1BuM0RkjpGnLU=.f22fcb4a-72fa-4987-87cb-8cc71da5e810@github.com>

On Sat, 10 Oct 2020 13:07:25 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also small updates to the spotbugs exclude file. I'll open a separate issue for going through the spotbugs results and
> fixing some problems separately.

This pull request has now been integrated.

Changeset: 7de07b4c
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/7de07b4c
Stats:     339 lines in 25 files changed: 29 ins; 80 del; 230 mod

6900: Switch from IPredicate to Predicate

Reviewed-by: ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/126

From mwengner at openjdk.java.net  Mon Oct 12 14:27:24 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 12 Oct 2020 14:27:24 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v21]
In-Reply-To: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
Message-ID: <NTiSEjnpCvPbH8PYeJ-F-ooxwKIZLUA1Vb9qt6J7p9E=.7ca228dc-2cca-490e-97ed-212f6710c8f3@github.com>

> stable flameview generation

Miroslav Wengner has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
excludes the unrelated changes brought in by the merge/rebase. The pull request contains 35 additional commits since
the last revision:

 - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6542_Improve_calls_to_render_in_the_flame_view
 - 6542: revert TraceNode - add missing bracket
 - 6542: more cleanup
 - 6542: clean up
 - 6542: cleanup unsused abstractions
 - 6542: correction, to speed up
 - 6542: checkstyle
 - 6542: code clean up
 - 6542: small correction
 - 6542: cleanup improvements
 - ... and 25 more: https://git.openjdk.java.net/jmc/compare/f30b6601...70ba9b4b

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/78/files
  - new: https://git.openjdk.java.net/jmc/pull/78/files/0a72a815..70ba9b4b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=20
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=19-20

  Stats: 3683 lines in 133 files changed: 1746 ins; 336 del; 1601 mod
  Patch: https://git.openjdk.java.net/jmc/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78

PR: https://git.openjdk.java.net/jmc/pull/78

From hirt at openjdk.java.net  Mon Oct 12 15:44:16 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 12 Oct 2020 15:44:16 GMT
Subject: RFR: 6695: Build agent as part of checkin tests
Message-ID: <c7M5oGxqsCSqOIn7GLFpdcAMj6yrNlM5Sp7e6FAgnnE=.6dce7c5b-b4bf-4a40-b971-15a07cdc5902@github.com>

Also adding formatting checks. Seems the integrations tests are failing on Windows, so only running unit tests for now
on Windows. Will open a new issues on that.

-------------

Commit messages:
 - Only unit tests on Windows for now
 - Windows fix
 - Fixing formatting scripts
 - Adding running tests
 - 6695: Build agent as part of checkin tests - first step, formatting

Changes: https://git.openjdk.java.net/jmc/pull/127/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=127&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6695
  Stats: 428 lines in 39 files changed: 102 ins; 83 del; 243 mod
  Patch: https://git.openjdk.java.net/jmc/pull/127.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/127/head:pull/127

PR: https://git.openjdk.java.net/jmc/pull/127

From marcus.hirt at datadoghq.com  Mon Oct 12 17:10:33 2020
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Mon, 12 Oct 2020 19:10:33 +0200
Subject: RFR: 6364: Improvements to the Thread Graph
In-Reply-To: <2FK-KbfPMUpY4YxmOCnYmU4eSeGNY2WrCAwEtlO07KI=.a471914d-4f34-40ad-b639-8c6a20226245@github.com>
References: <3b_EN291IWMTMl6vId_3HM3r9b2p0Bjxd9QYH5qgDO8=.50cc047a-4486-469a-a341-5908f78bb6df@github.com>
 <9z2_Fmh0wzUWsp9Tu1bEudv8_BvAjeAC6RVPPe76FRQ=.1d13e3bc-3d48-4a9b-831f-40b784d57106@github.com>
 <RzkGUXMijABPraKoBm2yRnh7490ldPx8R1pVnLkZuQo=.49c6a560-d0bc-4870-8fc8-6b16c31a4edf@github.com>
 <VtxWPdJ5lCNJANcyQQKDpUAc6oMz6sIIl4AdCngGzNY=.3e9e164a-aeca-4a31-9c0d-90b32e505e1f@github.com>
 <WlsAE5WBZzvaJ7y6s_9776LfwPZxInEyw-9tHkR8BYQ=.cac2ca35-320a-4955-b4ad-9f03cf91e67d@github.com>
 <W46pwscvWVhGWOQ7fZuohiPU3PDSr_fTBcjsYEHZX9U=.3ded4679-f3c5-4fa0-8d3f-febe4b5ff1ae@github.com>
 <PkxbYIW2PTQI6EKSG2QBPXGZsLN_4YAmK8tBzom9Zcc=.6ac6a27f-cb8f-4d40-b910-8f209468280b@github.com>
 <1rFwH_fS08Lr6VT09rAPl5aOjeoDyyfAK1l1DaktMB8=.e94b0d05-4244-46b2-848e-c83f7aa3917a@github.com>
 <m106gabj2MTdvJuIG-7VzB4GU0GwsWw8FvwMStXJvzM=.60dbba90-bc44-4759-9e45-4cc07727fb54@github.com>
 <uGE8OtyeKVfipTGVyNCcHDrlfaxDEBGqhCdPhqjlv8o=.43a35c17-ad84-4831-87ad-740cfbdd7ed1@github.com>
 <s8PRQ3LPX5LFCZGk47tfu4T8JfguQGuKNOu6ysh3eo8=.5062e28b-b947-45b7-aaff-4e52f01c3a92@github.com>
 <te05v9SDdp77tUGnpxxtE4WvBeHTsoyZK1xxITVaAXE=.094e17e2-1599-4d6f-89c8-1311786ab932@github.com>
 <gAZnxXu30whSmrmWEqfVRZczClOSfJ3pRT0IImh3gak=.38917981-4205-4c56-9726-608dbb19e1f5@github.com>
 <PrIx9JRSzJv5-338n2kxEG2thm9pLRRUeeCuuYCz208=.122c1e7d-8f9c-40e3-b0f3-0354cd49bd79@github.com>
 <2FK-KbfPMUpY4YxmOCnYmU4eSeGNY2WrCAwEtlO07KI=.a471914d-4f34-40ad-b639-8c6a20226245@github.com>
Message-ID: <CAOpWGx3nVNTzwkAVwOA+DPTsxFP2T0g=OdMUEBsDgb-UM6x1-g@mail.gmail.com>

I think that's fine - just choose fewer threads, or a smaller time period.
We might want to consider increasing the limit a little bit too - computers
are more powerful these days. We just want to avoid having the UI to get
sluggish because the user decided to view millions of events at the same
time.

On Sat, Oct 10, 2020 at 12:51 AM Suchita Chaturvedi <
schaturvedi at openjdk.java.net> wrote:

> On Wed, 30 Sep 2020 17:40:19 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>
> >> "Edit Thread Lanes" at top right corner and "Thread State Selection"
> button, both are opening the same pop up.
> >>
> >> Just a suggestion, Should we keep one and skip the other?
> >
> > @guruhb - do you and/or Suchita want to review this PR?
>
> I have tried to use the new improved version of threads page. But for many
> JFRs I am getting "Too much content" issue
> and the page is not loading properly.
>
> -------------
>
> PR: https://git.openjdk.java.net/jmc/pull/27
>

From mwengner at openjdk.java.net  Mon Oct 12 21:05:23 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 12 Oct 2020 21:05:23 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v22]
In-Reply-To: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
Message-ID: <p2TfqNJAey_CZipudjdpdSNjPmDckf1eoEs9at8E4YQ=.abdbbd50-0231-4849-8485-0ea566e79b72@github.com>

> stable flameview generation

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6542: removed active thread check, update

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/78/files
  - new: https://git.openjdk.java.net/jmc/pull/78/files/70ba9b4b..11e29db3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=21
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=20-21

  Stats: 41 lines in 2 files changed: 9 ins; 13 del; 19 mod
  Patch: https://git.openjdk.java.net/jmc/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78

PR: https://git.openjdk.java.net/jmc/pull/78

From mwengner at openjdk.java.net  Mon Oct 12 21:05:24 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 12 Oct 2020 21:05:24 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v20]
In-Reply-To: <FC5kMQHxz8_gfKjpcsewgf_0fdg6MRJfNnlMVlUPVJQ=.58af68f5-75c8-4cfb-b3ab-8ec354e78111@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
 <Xmof_RKkV8zx6k0SNx707jOO1Z8GFQD1d6FtbcFBBso=.78a2f05f-8518-49d9-ada1-53eedddd85d3@github.com>
 <FC5kMQHxz8_gfKjpcsewgf_0fdg6MRJfNnlMVlUPVJQ=.58af68f5-75c8-4cfb-b3ab-8ec354e78111@github.com>
Message-ID: <Bp533F3Tur9UdC5ZUjVfOBNrHzcdnmzeKK1K9-0p2_8=.74266e9a-e7ca-4558-8b1a-a9b9667b8b00@github.com>

On Sun, 4 Oct 2020 19:34:49 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6542: more cleanup
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceNode.java
> line 102:
>> 100: 			return false;
>> 101: 		if (packageName == null) {
>> 102: 			if (other.packageName != null)
> 
> This file should be reverted. All ?if? scopes should have brackets.

I've corrected

-------------

PR: https://git.openjdk.java.net/jmc/pull/78

From mwengner at openjdk.java.net  Mon Oct 12 21:11:07 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 12 Oct 2020 21:11:07 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v20]
In-Reply-To: <FC5kMQHxz8_gfKjpcsewgf_0fdg6MRJfNnlMVlUPVJQ=.58af68f5-75c8-4cfb-b3ab-8ec354e78111@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
 <Xmof_RKkV8zx6k0SNx707jOO1Z8GFQD1d6FtbcFBBso=.78a2f05f-8518-49d9-ada1-53eedddd85d3@github.com>
 <FC5kMQHxz8_gfKjpcsewgf_0fdg6MRJfNnlMVlUPVJQ=.58af68f5-75c8-4cfb-b3ab-8ec354e78111@github.com>
Message-ID: <QdoS_UL7bDPgo9RbHzVyeRMsDJ0Hc6hOspzd4xArQmc=.cb75f459-ac75-48d9-9c66-bebae43f7a21@github.com>

On Fri, 9 Oct 2020 20:10:30 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6542: more cleanup
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
> line 378:
>> 376:
>> 377: 			TraceNode root = TraceTreeUtils.createRootWithDescription(items, rootFork.getBranchCount());
>> 378: 			if (Thread.currentThread().isAlive()) {
> 
> I don?t get these thread changes. The current thread is executing your code, and is therefore always alive. Also, if
> you want to make these calculations abortable, I?d much prefer an API for it. Maybe an Abortable interface, or perhaps
> even better, providing some sort of a progress interface where progress could be reported to and checked against
> whether it should abort every now and then. We can discuss which alternative makes most sense.

I've reconsidered my thoughts. I wanted to cancel the Task calculations inside the executor thread before it get's
jointed with the main. I've added the Scheduler executor and a bit delay its start, in case of fast scrolling, it's
more transparent. I've also cleared the code.

-------------

PR: https://git.openjdk.java.net/jmc/pull/78

From mwengner at openjdk.java.net  Mon Oct 12 21:32:20 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 12 Oct 2020 21:32:20 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v23]
In-Reply-To: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
Message-ID: <D5wqroLhom_-c_Xduwjs9oMHiqZZFr5DanUQUIADRv4=.074cf99e-07c1-45a6-8e98-685d22e260ce@github.com>

> stable flameview generation

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6542: check future cancelation

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/78/files
  - new: https://git.openjdk.java.net/jmc/pull/78/files/11e29db3..0a976b5b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=22
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=21-22

  Stats: 13 lines in 1 file changed: 8 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jmc/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78

PR: https://git.openjdk.java.net/jmc/pull/78

From hirt at openjdk.java.net  Mon Oct 12 21:47:16 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 12 Oct 2020 21:47:16 GMT
Subject: RFR: 6846: Parser needs to skip events with no metadata
Message-ID: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>

Also fixing some javadoc errors.

-------------

Commit messages:
 - Better test naming
 - Correcting copyright
 - 6846: Parser needs to skip events with no metadata

Changes: https://git.openjdk.java.net/jmc/pull/128/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=128&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6846
  Stats: 79 lines in 5 files changed: 70 ins; 1 del; 8 mod
  Patch: https://git.openjdk.java.net/jmc/pull/128.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/128/head:pull/128

PR: https://git.openjdk.java.net/jmc/pull/128

From hirt at openjdk.java.net  Mon Oct 12 21:50:20 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 12 Oct 2020 21:50:20 GMT
Subject: RFR: 6846: Parser needs to skip events with no metadata [v2]
In-Reply-To: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>
References: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>
Message-ID: <l2P7ED_LgqYZNp-H8jYUcEPpz2WXypNQVFcHPXeXw0w=.d439483a-36b0-4de5-b477-c82f04d8c40f@github.com>

> Also fixing some javadoc errors.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Formatting

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/128/files
  - new: https://git.openjdk.java.net/jmc/pull/128/files/51ad3e72..f7f25666

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=128&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=128&range=00-01

  Stats: 5 lines in 2 files changed: 0 ins; 1 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/128.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/128/head:pull/128

PR: https://git.openjdk.java.net/jmc/pull/128

From egahlin at openjdk.java.net  Tue Oct 13 03:16:09 2020
From: egahlin at openjdk.java.net (Erik Gahlin)
Date: Tue, 13 Oct 2020 03:16:09 GMT
Subject: RFR: 6846: Parser needs to skip events with no metadata [v2]
In-Reply-To: <l2P7ED_LgqYZNp-H8jYUcEPpz2WXypNQVFcHPXeXw0w=.d439483a-36b0-4de5-b477-c82f04d8c40f@github.com>
References: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>
 <l2P7ED_LgqYZNp-H8jYUcEPpz2WXypNQVFcHPXeXw0w=.d439483a-36b0-4de5-b477-c82f04d8c40f@github.com>
Message-ID: <DvezscpVBOSopSaq9EPXrPxnl7DrwxFW1L7ct-gy9xo=.dc13d551-f069-4a27-9da8-7fc0ad4fd0d0@github.com>

On Mon, 12 Oct 2020 21:50:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Also fixing some javadoc errors.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Formatting

Changes requested by egahlin (Reviewer).

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/TypeManager.java
line 480:

> 478: 	private static void skipEvent(int size, IDataInput input) throws IOException {
> 479: 		// We've read the size of the event (int) and the type (long) so far
> 480: 		for (int i = 0; i < size - DataInputToolkit.INTEGER_SIZE - DataInputToolkit.LONG_SIZE; i++) {

The size and event type ID field is likely compressed, so using a fixed constant size will not work.  I think you need
to find the offset of the first byte in the size field and then add the size to find next event.

-------------

PR: https://git.openjdk.java.net/jmc/pull/128

From github.com+803621+bric3 at openjdk.java.net  Tue Oct 13 07:29:14 2020
From: github.com+803621+bric3 at openjdk.java.net (Brice Dutheil)
Date: Tue, 13 Oct 2020 07:29:14 GMT
Subject: RFR: 6364: Improvements to the Thread Graph
In-Reply-To: <PrIx9JRSzJv5-338n2kxEG2thm9pLRRUeeCuuYCz208=.122c1e7d-8f9c-40e3-b0f3-0354cd49bd79@github.com>
References: <3b_EN291IWMTMl6vId_3HM3r9b2p0Bjxd9QYH5qgDO8=.50cc047a-4486-469a-a341-5908f78bb6df@github.com>
 <9z2_Fmh0wzUWsp9Tu1bEudv8_BvAjeAC6RVPPe76FRQ=.1d13e3bc-3d48-4a9b-831f-40b784d57106@github.com>
 <RzkGUXMijABPraKoBm2yRnh7490ldPx8R1pVnLkZuQo=.49c6a560-d0bc-4870-8fc8-6b16c31a4edf@github.com>
 <VtxWPdJ5lCNJANcyQQKDpUAc6oMz6sIIl4AdCngGzNY=.3e9e164a-aeca-4a31-9c0d-90b32e505e1f@github.com>
 <WlsAE5WBZzvaJ7y6s_9776LfwPZxInEyw-9tHkR8BYQ=.cac2ca35-320a-4955-b4ad-9f03cf91e67d@github.com>
 <W46pwscvWVhGWOQ7fZuohiPU3PDSr_fTBcjsYEHZX9U=.3ded4679-f3c5-4fa0-8d3f-febe4b5ff1ae@github.com>
 <PkxbYIW2PTQI6EKSG2QBPXGZsLN_4YAmK8tBzom9Zcc=.6ac6a27f-cb8f-4d40-b910-8f209468280b@github.com>
 <1rFwH_fS08Lr6VT09rAPl5aOjeoDyyfAK1l1DaktMB8=.e94b0d05-4244-46b2-848e-c83f7aa3917a@github.com>
 <m106gabj2MTdvJuIG-7VzB4GU0GwsWw8FvwMStXJvzM=.60dbba90-bc44-4759-9e45-4cc07727fb54@github.com>
 <uGE8OtyeKVfipTGVyNCcHDrlfaxDEBGqhCdPhqjlv8o=.43a35c17-ad84-4831-87ad-740cfbdd7ed1@github.com>
 <jO40oBcEPc8zoPazOkBHqUm813eWjRpi5RJ
 qYv_QCeU=.976e6cb5-a240-4e7d-b2e7-307a66903740@github.com>
 <s8PRQ3LPX5LFCZGk47tfu4T8JfguQGuKNOu6ysh3eo8=.5062e28b-b947-45b7-aaff-4e52f01c3a92@github.com>
 <te05v9SDdp77tUGnpxxtE4WvBeHTsoyZK1xxITVaAXE=.094e17e2-1599-4d6f-89c8-1311786ab932@github.com>
 <gAZnxXu30whSmrmWEqfVRZczClOSfJ3pRT0IImh3gak=.38917981-4205-4c56-9726-608dbb19e1f5@github.com>
 <PrIx9JRSzJv5-338n2kxEG2thm9pLRRUeeCuuYCz208=.122c1e7d-8f9c-40e3-b0f3-0354cd49bd79@github.com>
Message-ID: <sfEu0KcenRLpGVNpFJ4XEJWKAFBNfcE1-7UXqeWZiRQ=.5799e5b5-6563-456d-a1c3-fb22c2dd3ac5@github.com>

On Wed, 30 Sep 2020 17:40:19 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> "Edit Thread Lanes" at top right corner and "Thread State Selection" button, both are opening the same pop up.
>> 
>> Just a suggestion, Should we keep one and skip the other?
>
> @guruhb - do you and/or Suchita want to review this PR?

@thegreystone @aptmac Maybe make this threshold configrable. Unfortunately this view is very useful, even if the
profile has many threads.

-------------

PR: https://git.openjdk.java.net/jmc/pull/27

From hirt at openjdk.java.net  Tue Oct 13 09:34:14 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 13 Oct 2020 09:34:14 GMT
Subject: RFR: 6846: Parser needs to skip events with no metadata [v2]
In-Reply-To: <DvezscpVBOSopSaq9EPXrPxnl7DrwxFW1L7ct-gy9xo=.dc13d551-f069-4a27-9da8-7fc0ad4fd0d0@github.com>
References: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>
 <l2P7ED_LgqYZNp-H8jYUcEPpz2WXypNQVFcHPXeXw0w=.d439483a-36b0-4de5-b477-c82f04d8c40f@github.com>
 <DvezscpVBOSopSaq9EPXrPxnl7DrwxFW1L7ct-gy9xo=.dc13d551-f069-4a27-9da8-7fc0ad4fd0d0@github.com>
Message-ID: <Pn-tP_qT6vY5o_tm-YCPpxYPcrIN0UCUFlOV2LQUVQ8=.a281178d-5751-4f38-a863-8087aac70b80@github.com>

On Tue, 13 Oct 2020 03:09:56 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Formatting
>
> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/TypeManager.java
> line 480:
>> 478: 	private static void skipEvent(int size, IDataInput input) throws IOException {
>> 479: 		// We've read the size of the event (int) and the type (long) so far
>> 480: 		for (int i = 0; i < size - DataInputToolkit.INTEGER_SIZE - DataInputToolkit.LONG_SIZE; i++) {
> 
> The size and event type ID field is likely compressed, so using a fixed constant size will not work.  I think you need
> to find the offset of the first byte in the size field and then add the size to find next event.

Ugh. You're right. And what's even more fun, I don't need to do anything at all. The event read loop is already
handling it by seeking to the absolute position for the next event. Jumping to the next event is a noop - nothing needs
be done.

-------------

PR: https://git.openjdk.java.net/jmc/pull/128

From hirt at openjdk.java.net  Tue Oct 13 09:38:07 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 13 Oct 2020 09:38:07 GMT
Subject: RFR: 6846: Parser needs to skip events with no metadata [v2]
In-Reply-To: <Pn-tP_qT6vY5o_tm-YCPpxYPcrIN0UCUFlOV2LQUVQ8=.a281178d-5751-4f38-a863-8087aac70b80@github.com>
References: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>
 <l2P7ED_LgqYZNp-H8jYUcEPpz2WXypNQVFcHPXeXw0w=.d439483a-36b0-4de5-b477-c82f04d8c40f@github.com>
 <DvezscpVBOSopSaq9EPXrPxnl7DrwxFW1L7ct-gy9xo=.dc13d551-f069-4a27-9da8-7fc0ad4fd0d0@github.com>
 <Pn-tP_qT6vY5o_tm-YCPpxYPcrIN0UCUFlOV2LQUVQ8=.a281178d-5751-4f38-a863-8087aac70b80@github.com>
Message-ID: <d12bNt1cBSDznV00dvy6OzaObXrgbXoadiADIDsLRtg=.bf6b7116-7caa-4dea-8a61-fe4dfef0456b@github.com>

On Tue, 13 Oct 2020 09:31:16 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/TypeManager.java
>> line 480:
>>> 478: 	private static void skipEvent(int size, IDataInput input) throws IOException {
>>> 479: 		// We've read the size of the event (int) and the type (long) so far
>>> 480: 		for (int i = 0; i < size - DataInputToolkit.INTEGER_SIZE - DataInputToolkit.LONG_SIZE; i++) {
>> 
>> The size and event type ID field is likely compressed, so using a fixed constant size will not work.  I think you need
>> to find the offset of the first byte in the size field and then add the size to find next event.
>
> Ugh. You're right. And what's even more fun, I don't need to do anything at all. The event read loop is already
> handling it by seeking to the absolute position for the next event. Jumping to the next event is a noop - nothing needs
> be done.

Any chance you have a recording with a few events that has metadata, followed by an event with no metadata, then again
followed by a few events with metadata available? :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/128

From hirt at openjdk.java.net  Tue Oct 13 09:51:20 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 13 Oct 2020 09:51:20 GMT
Subject: RFR: 6846: Parser needs to skip events with no metadata [v3]
In-Reply-To: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>
References: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>
Message-ID: <GqsqT38-Hw2ShJmhMnY7dNYP49l8eqBRqSuBBnWsDWY=.8ee116e9-7464-41fc-8f2d-491741936fa7@github.com>

> Also fixing some javadoc errors.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Fix

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/128/files
  - new: https://git.openjdk.java.net/jmc/pull/128/files/f7f25666..b5467758

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=128&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=128&range=01-02

  Stats: 11 lines in 1 file changed: 1 ins; 10 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/128.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/128/head:pull/128

PR: https://git.openjdk.java.net/jmc/pull/128

From egahlin at openjdk.java.net  Tue Oct 13 10:05:07 2020
From: egahlin at openjdk.java.net (Erik Gahlin)
Date: Tue, 13 Oct 2020 10:05:07 GMT
Subject: RFR: 6846: Parser needs to skip events with no metadata [v2]
In-Reply-To: <d12bNt1cBSDznV00dvy6OzaObXrgbXoadiADIDsLRtg=.bf6b7116-7caa-4dea-8a61-fe4dfef0456b@github.com>
References: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>
 <l2P7ED_LgqYZNp-H8jYUcEPpz2WXypNQVFcHPXeXw0w=.d439483a-36b0-4de5-b477-c82f04d8c40f@github.com>
 <DvezscpVBOSopSaq9EPXrPxnl7DrwxFW1L7ct-gy9xo=.dc13d551-f069-4a27-9da8-7fc0ad4fd0d0@github.com>
 <Pn-tP_qT6vY5o_tm-YCPpxYPcrIN0UCUFlOV2LQUVQ8=.a281178d-5751-4f38-a863-8087aac70b80@github.com>
 <d12bNt1cBSDznV00dvy6OzaObXrgbXoadiADIDsLRtg=.bf6b7116-7caa-4dea-8a61-fe4dfef0456b@github.com>
Message-ID: <DomspgEBIWi3MRrJXfvwxg36kwIehpqlihM1TPeceM0=.91d8284b-4fb2-4483-a99c-9dd22d36730f@github.com>

On Tue, 13 Oct 2020 09:35:11 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Ugh. You're right. And what's even more fun, I don't need to do anything at all. The event read loop is already
>> handling it by seeking to the absolute position for the next event. Jumping to the next event is a noop - nothing needs
>> be done.
>
> Any chance you have a recording with a few events that has metadata, followed by an event with no metadata, then again
> followed by a few events with metadata available? :)

No, it should not happen.

-------------

PR: https://git.openjdk.java.net/jmc/pull/128

From hirt at openjdk.java.net  Tue Oct 13 10:25:06 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 13 Oct 2020 10:25:06 GMT
Subject: RFR: 6846: Parser needs to skip events with no metadata [v2]
In-Reply-To: <DomspgEBIWi3MRrJXfvwxg36kwIehpqlihM1TPeceM0=.91d8284b-4fb2-4483-a99c-9dd22d36730f@github.com>
References: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>
 <l2P7ED_LgqYZNp-H8jYUcEPpz2WXypNQVFcHPXeXw0w=.d439483a-36b0-4de5-b477-c82f04d8c40f@github.com>
 <DvezscpVBOSopSaq9EPXrPxnl7DrwxFW1L7ct-gy9xo=.dc13d551-f069-4a27-9da8-7fc0ad4fd0d0@github.com>
 <Pn-tP_qT6vY5o_tm-YCPpxYPcrIN0UCUFlOV2LQUVQ8=.a281178d-5751-4f38-a863-8087aac70b80@github.com>
 <d12bNt1cBSDznV00dvy6OzaObXrgbXoadiADIDsLRtg=.bf6b7116-7caa-4dea-8a61-fe4dfef0456b@github.com>
 <DomspgEBIWi3MRrJXfvwxg36kwIehpqlihM1TPeceM0=.91d8284b-4fb2-4483-a99c-9dd22d36730f@github.com>
Message-ID: <2YqO1ZMTzfgHQjrEAH8o9YRitvdVghzGTdlVJD3JWS0=.c2b45461-de7c-485d-a081-f5aa0e6061b3@github.com>

On Tue, 13 Oct 2020 10:02:26 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Any chance you have a recording with a few events that has metadata, followed by an event with no metadata, then again
>> followed by a few events with metadata available? :)
>
> No, it should not happen.

Ok, then we should be all good.

-------------

PR: https://git.openjdk.java.net/jmc/pull/128

From hirt at openjdk.java.net  Tue Oct 13 10:28:12 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 13 Oct 2020 10:28:12 GMT
Subject: RFR: 6846: Parser needs to skip events with no metadata [v2]
In-Reply-To: <DvezscpVBOSopSaq9EPXrPxnl7DrwxFW1L7ct-gy9xo=.dc13d551-f069-4a27-9da8-7fc0ad4fd0d0@github.com>
References: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>
 <l2P7ED_LgqYZNp-H8jYUcEPpz2WXypNQVFcHPXeXw0w=.d439483a-36b0-4de5-b477-c82f04d8c40f@github.com>
 <DvezscpVBOSopSaq9EPXrPxnl7DrwxFW1L7ct-gy9xo=.dc13d551-f069-4a27-9da8-7fc0ad4fd0d0@github.com>
Message-ID: <CS3otHo_kiB_DEbue7Te0caL9xthCTF2Bbg0WAX57KY=.233d661c-eaa9-4b7a-930e-ff2eadb55fb0@github.com>

On Tue, 13 Oct 2020 03:13:02 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Formatting
>
> Changes requested by egahlin (Reviewer).

Strictly speaking, I could skip sending in the event size now. Then again, I'll need that for next iteration, so I'll
leave it in.

-------------

PR: https://git.openjdk.java.net/jmc/pull/128

From egahlin at openjdk.java.net  Tue Oct 13 11:08:10 2020
From: egahlin at openjdk.java.net (Erik Gahlin)
Date: Tue, 13 Oct 2020 11:08:10 GMT
Subject: RFR: 6846: Parser needs to skip events with no metadata [v3]
In-Reply-To: <GqsqT38-Hw2ShJmhMnY7dNYP49l8eqBRqSuBBnWsDWY=.8ee116e9-7464-41fc-8f2d-491741936fa7@github.com>
References: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>
 <GqsqT38-Hw2ShJmhMnY7dNYP49l8eqBRqSuBBnWsDWY=.8ee116e9-7464-41fc-8f2d-491741936fa7@github.com>
Message-ID: <Pb6km0CJK_Zh2rVCMFAQjwpQRk7d7Ktai8PYAHuGmFU=.d7a3daa9-b608-4fee-970f-f8c55aef8ee5@github.com>

On Tue, 13 Oct 2020 09:51:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Also fixing some javadoc errors.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix

!

-------------

PR: https://git.openjdk.java.net/jmc/pull/128

From hirt at openjdk.java.net  Tue Oct 13 20:32:24 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 13 Oct 2020 20:32:24 GMT
Subject: RFR: 6846: Parser needs to skip events with no metadata [v4]
In-Reply-To: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>
References: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>
Message-ID: <D2srXm-A1dvP7GBpsKdsWL0Pop5E_W_o3b-OvwC8ZKM=.0eb8ab4e-ad10-4c09-a4b1-cb12f6942f2d@github.com>

> Also fixing some javadoc errors.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Will re-add these later then

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/128/files
  - new: https://git.openjdk.java.net/jmc/pull/128/files/b5467758..a854c069

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=128&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=128&range=02-03

  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/128.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/128/head:pull/128

PR: https://git.openjdk.java.net/jmc/pull/128

From egahlin at openjdk.java.net  Wed Oct 14 00:33:06 2020
From: egahlin at openjdk.java.net (Erik Gahlin)
Date: Wed, 14 Oct 2020 00:33:06 GMT
Subject: RFR: 6846: Parser needs to skip events with no metadata [v4]
In-Reply-To: <D2srXm-A1dvP7GBpsKdsWL0Pop5E_W_o3b-OvwC8ZKM=.0eb8ab4e-ad10-4c09-a4b1-cb12f6942f2d@github.com>
References: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>
 <D2srXm-A1dvP7GBpsKdsWL0Pop5E_W_o3b-OvwC8ZKM=.0eb8ab4e-ad10-4c09-a4b1-cb12f6942f2d@github.com>
Message-ID: <6rcu2dBMf53gmI_Fa03Wt5Z6PrsUSAaVziZwjmAPlYA=.b86ab272-a712-4dbc-8d63-b882ed2ac4cf@github.com>

On Tue, 13 Oct 2020 20:32:24 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Also fixing some javadoc errors.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Will re-add these later then

.

-------------

PR: https://git.openjdk.java.net/jmc/pull/128

From egahlin at openjdk.java.net  Wed Oct 14 12:05:11 2020
From: egahlin at openjdk.java.net (Erik Gahlin)
Date: Wed, 14 Oct 2020 12:05:11 GMT
Subject: RFR: 6846: Parser needs to skip events with no metadata [v4]
In-Reply-To: <D2srXm-A1dvP7GBpsKdsWL0Pop5E_W_o3b-OvwC8ZKM=.0eb8ab4e-ad10-4c09-a4b1-cb12f6942f2d@github.com>
References: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>
 <D2srXm-A1dvP7GBpsKdsWL0Pop5E_W_o3b-OvwC8ZKM=.0eb8ab4e-ad10-4c09-a4b1-cb12f6942f2d@github.com>
Message-ID: <YxLYmhLtyhHr3z7zMok-RoPPeJP9la9vgkOjszc0PNE=.cd74a0b8-fc6d-4105-a49f-3efa2b8860d6@github.com>

On Tue, 13 Oct 2020 20:32:24 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Also fixing some javadoc errors.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Will re-add these later then

Marked as reviewed by egahlin (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/128

From hirt at openjdk.java.net  Wed Oct 14 12:09:16 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 14 Oct 2020 12:09:16 GMT
Subject: Integrated: 6846: Parser needs to skip events with no metadata
In-Reply-To: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>
References: <S3xlsuYIzZK7aPNTOC9yYACx1B2e4mUqRJykRqrNQ5Y=.1a7dc3ba-6613-458f-9877-b50f570bc664@github.com>
Message-ID: <8mAGPhs2K_Dmk3NT6FKqIe5TBso3qzPdO9nbi9jy5NA=.2101e912-23b2-4314-8ead-9aed5d173792@github.com>

On Mon, 12 Oct 2020 21:41:55 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also fixing some javadoc errors.

This pull request has now been integrated.

Changeset: fea3cc60
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/fea3cc60
Stats:     68 lines in 4 files changed: 60 ins; 1 del; 7 mod

6846: Parser needs to skip events with no metadata

Reviewed-by: egahlin

-------------

PR: https://git.openjdk.java.net/jmc/pull/128

From marcus.hirt at datadoghq.com  Wed Oct 14 13:17:09 2020
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Wed, 14 Oct 2020 15:17:09 +0200
Subject: Getting the jmc7 repo into the jmc repo as a branch.
Message-ID: <CAOpWGx1E0Y+Fin9TDFtaYseMJHr2k8vUahKBk5Ln=de4P1Q2iQ@mail.gmail.com>

Hi all,

Seems most people would rather have major release versions as branches than
separate repos. Now, what should the branches be called? Just the major
version number? Or jmc followed by the major version number? Something
entirely different?

Kind regards,
Marcus

From guru.hb at oracle.com  Wed Oct 14 13:48:38 2020
From: guru.hb at oracle.com (Guru)
Date: Wed, 14 Oct 2020 19:18:38 +0530
Subject: Getting the jmc7 repo into the jmc repo as a branch.
In-Reply-To: <CAOpWGx1E0Y+Fin9TDFtaYseMJHr2k8vUahKBk5Ln=de4P1Q2iQ@mail.gmail.com>
References: <CAOpWGx1E0Y+Fin9TDFtaYseMJHr2k8vUahKBk5Ln=de4P1Q2iQ@mail.gmail.com>
Message-ID: <5C4416A5-83E9-4253-BA59-93EB837D542A@oracle.com>

Option 1 : Not to pollute the branch name : 
jmc8 (Branch for Major versions + tags for minor) 
   jmc-8.0.0
   jmc-8.y.z
  ...
   jmc-8.z.z
jmc9 (Branch)

Option 2 : Only Branch name, no tags
jmc-8.0.0
jmc-8.0.1
?
jmc-8.x.y

Will wait for other?s opinion. 

Thanks,
Guru
> On 14-Oct-2020, at 6:47 PM, Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
> 
> Hi all,
> 
> Seems most people would rather have major release versions as branches than
> separate repos. Now, what should the branches be called? Just the major
> version number? Or jmc followed by the major version number? Something
> entirely different?
> 
> Kind regards,
> Marcus


From marcus.hirt at datadoghq.com  Wed Oct 14 14:28:52 2020
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Wed, 14 Oct 2020 16:28:52 +0200
Subject: Getting the jmc7 repo into the jmc repo as a branch.
In-Reply-To: <5C4416A5-83E9-4253-BA59-93EB837D542A@oracle.com>
References: <CAOpWGx1E0Y+Fin9TDFtaYseMJHr2k8vUahKBk5Ln=de4P1Q2iQ@mail.gmail.com>
 <5C4416A5-83E9-4253-BA59-93EB837D542A@oracle.com>
Message-ID: <CAOpWGx3xdX_aVZug+fPwZaryM6Yr8jtTqAjWnpEdbVc6kAVNrQ@mail.gmail.com>

Personally I'd go with branching for major development branches and tagging
for releases. The name for the branch could be either just version, so e.g.
"7" or "8", or jmc plus version, so e.g. "jmc7" or "jmc8". I'm perfectly
fine with either, and have no strong feeling either way.

Please let me know what you think.

Kind regards,
Marcus

On Wed, Oct 14, 2020 at 3:50 PM Guru <guru.hb at oracle.com> wrote:

> Option 1 : Not to pollute the branch name :
> jmc8 (Branch for Major versions + tags for minor)
>    jmc-8.0.0
>    jmc-8.y.z
>   ...
>    jmc-8.z.z
> jmc9 (Branch)
>
> Option 2 : Only Branch name, no tags
> jmc-8.0.0
> jmc-8.0.1
> ?
> jmc-8.x.y
>
> Will wait for other?s opinion.
>
> Thanks,
> Guru
> > On 14-Oct-2020, at 6:47 PM, Marcus Hirt <marcus.hirt at datadoghq.com>
> wrote:
> >
> > Hi all,
> >
> > Seems most people would rather have major release versions as branches
> than
> > separate repos. Now, what should the branches be called? Just the major
> > version number? Or jmc followed by the major version number? Something
> > entirely different?
> >
> > Kind regards,
> > Marcus
>
>

From hdafgard at openjdk.java.net  Wed Oct 14 22:39:07 2020
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Wed, 14 Oct 2020 22:39:07 GMT
Subject: RFR: 6695: Build agent as part of checkin tests
In-Reply-To: <c7M5oGxqsCSqOIn7GLFpdcAMj6yrNlM5Sp7e6FAgnnE=.6dce7c5b-b4bf-4a40-b971-15a07cdc5902@github.com>
References: <c7M5oGxqsCSqOIn7GLFpdcAMj6yrNlM5Sp7e6FAgnnE=.6dce7c5b-b4bf-4a40-b971-15a07cdc5902@github.com>
Message-ID: <3uo5HANyPbbLYsgMWYT7J9tRbzOOeeAtdLiYp7VKW-k=.7d098d66-2b9c-48f9-bc87-bb0fc9ce7e5f@github.com>

On Mon, 12 Oct 2020 15:40:25 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also adding formatting checks. Seems the integrations tests are failing on Windows, so only running unit tests for now
> on Windows. Will open a new issues on that.

Marked as reviewed by hdafgard (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/127

From reinhapa at openjdk.java.net  Thu Oct 15 07:09:10 2020
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Thu, 15 Oct 2020 07:09:10 GMT
Subject: RFR: 6940: build.sh test arguments wrong
Message-ID: <eihzIAFjo4MAsEY-vwKiLp2LSWIg-hi9woBWfk6Nbh4=.2361ed71-c3a2-49d3-9875-f4cdf5ed434d@github.com>

Align the help with the actual accepted arguments

-------------

Commit messages:
 - 6940: Updated help to align with the actual accepted test arguments

Changes: https://git.openjdk.java.net/jmc/pull/129/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=129&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6940
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/129.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/129/head:pull/129

PR: https://git.openjdk.java.net/jmc/pull/129

From hirt at openjdk.java.net  Thu Oct 15 08:31:09 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 15 Oct 2020 08:31:09 GMT
Subject: RFR: 6940: build.sh test arguments wrong
In-Reply-To: <eihzIAFjo4MAsEY-vwKiLp2LSWIg-hi9woBWfk6Nbh4=.2361ed71-c3a2-49d3-9875-f4cdf5ed434d@github.com>
References: <eihzIAFjo4MAsEY-vwKiLp2LSWIg-hi9woBWfk6Nbh4=.2361ed71-c3a2-49d3-9875-f4cdf5ed434d@github.com>
Message-ID: <hfexUsOzpvjtBPsgMefkEiQFSSO7lba35x1NHgoOM8s=.00196565-2624-4b3b-b61b-4bc7b3dbcf32@github.com>

On Thu, 15 Oct 2020 06:58:36 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

> Align the help with the actual accepted arguments

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/129

From hirt at openjdk.java.net  Thu Oct 15 08:32:12 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 15 Oct 2020 08:32:12 GMT
Subject: Integrated: 6695: Build agent as part of checkin tests
In-Reply-To: <c7M5oGxqsCSqOIn7GLFpdcAMj6yrNlM5Sp7e6FAgnnE=.6dce7c5b-b4bf-4a40-b971-15a07cdc5902@github.com>
References: <c7M5oGxqsCSqOIn7GLFpdcAMj6yrNlM5Sp7e6FAgnnE=.6dce7c5b-b4bf-4a40-b971-15a07cdc5902@github.com>
Message-ID: <vto10Rkn01B6eVN4wy9TsC7uF-mhB_b4i4V4h8gH5CM=.c0fd2378-4384-49e7-8811-3f02d09c3700@github.com>

On Mon, 12 Oct 2020 15:40:25 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Also adding formatting checks. Seems the integrations tests are failing on Windows, so only running unit tests for now
> on Windows. Will open a new issues on that.

This pull request has now been integrated.

Changeset: f778c8b1
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/f778c8b1
Stats:     428 lines in 39 files changed: 102 ins; 83 del; 243 mod

6695: Build agent as part of checkin tests

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.java.net/jmc/pull/127

From reinhapa at openjdk.java.net  Thu Oct 15 10:22:08 2020
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Thu, 15 Oct 2020 10:22:08 GMT
Subject: Integrated: 6940: build.sh test arguments wrong
In-Reply-To: <eihzIAFjo4MAsEY-vwKiLp2LSWIg-hi9woBWfk6Nbh4=.2361ed71-c3a2-49d3-9875-f4cdf5ed434d@github.com>
References: <eihzIAFjo4MAsEY-vwKiLp2LSWIg-hi9woBWfk6Nbh4=.2361ed71-c3a2-49d3-9875-f4cdf5ed434d@github.com>
Message-ID: <UJ1CWqSedCyHxlzDVE9fAagkOjsf-AMsgVpsEGs3BX0=.4bb28578-2d8e-497b-a00f-8b9d20d48371@github.com>

On Thu, 15 Oct 2020 06:58:36 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

> Align the help with the actual accepted arguments

This pull request has now been integrated.

Changeset: 1988ad11
Author:    Patrick Reinhart <reinhapa at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/1988ad11
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

6940: build.sh test arguments wrong

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/129

From marcus.hirt at datadoghq.com  Thu Oct 15 10:31:44 2020
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Thu, 15 Oct 2020 12:31:44 +0200
Subject: Getting the jmc7 repo into the jmc repo as a branch.
In-Reply-To: <CAOpWGx3xdX_aVZug+fPwZaryM6Yr8jtTqAjWnpEdbVc6kAVNrQ@mail.gmail.com>
References: <CAOpWGx1E0Y+Fin9TDFtaYseMJHr2k8vUahKBk5Ln=de4P1Q2iQ@mail.gmail.com>
 <5C4416A5-83E9-4253-BA59-93EB837D542A@oracle.com>
 <CAOpWGx3xdX_aVZug+fPwZaryM6Yr8jtTqAjWnpEdbVc6kAVNrQ@mail.gmail.com>
Message-ID: <CAOpWGx2XgCMRbcLdpcu47a_f6BLyimHOZfE1x064qAxGmxoWXA@mail.gmail.com>

I did a quick poll in the JMC slack - everyone there wanted "jmc<version>",
e.g. "jmc7", to be the branch naming convention. If you disagree, please
let me know or go to the slack and vote on the poll!

Kind regards,
Marcus

On Wed, Oct 14, 2020 at 4:28 PM Marcus Hirt <marcus.hirt at datadoghq.com>
wrote:

> Personally I'd go with branching for major development branches and
> tagging for releases. The name for the branch could be either just version,
> so e.g. "7" or "8", or jmc plus version, so e.g. "jmc7" or "jmc8". I'm
> perfectly fine with either, and have no strong feeling either way.
>
> Please let me know what you think.
>
> Kind regards,
> Marcus
>
> On Wed, Oct 14, 2020 at 3:50 PM Guru <guru.hb at oracle.com> wrote:
>
>> Option 1 : Not to pollute the branch name :
>> jmc8 (Branch for Major versions + tags for minor)
>>    jmc-8.0.0
>>    jmc-8.y.z
>>   ...
>>    jmc-8.z.z
>> jmc9 (Branch)
>>
>> Option 2 : Only Branch name, no tags
>> jmc-8.0.0
>> jmc-8.0.1
>> ?
>> jmc-8.x.y
>>
>> Will wait for other?s opinion.
>>
>> Thanks,
>> Guru
>> > On 14-Oct-2020, at 6:47 PM, Marcus Hirt <marcus.hirt at datadoghq.com>
>> wrote:
>> >
>> > Hi all,
>> >
>> > Seems most people would rather have major release versions as branches
>> than
>> > separate repos. Now, what should the branches be called? Just the major
>> > version number? Or jmc followed by the major version number? Something
>> > entirely different?
>> >
>> > Kind regards,
>> > Marcus
>>
>>

From reinhapa at openjdk.java.net  Thu Oct 15 19:48:10 2020
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Thu, 15 Oct 2020 19:48:10 GMT
Subject: RFR: 6941: build.sh does not terminate jetty after executing
 '--packageJmc'
Message-ID: <BsZxURyhkFayoL42SRIdRTy6XcwiBxJmF5oF4jB3s44=.9503e42d-6dd3-4b05-9ba6-0ca2ee37b259@github.com>

stopping jetty instance using kill command working on Mac & Linux

-------------

Commit messages:
 - 6941: stopping jetty instance using kill command working on Mac & Linux

Changes: https://git.openjdk.java.net/jmc/pull/130/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=130&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6941
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/130.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/130/head:pull/130

PR: https://git.openjdk.java.net/jmc/pull/130

From github.com+1913914+petrbouda at openjdk.java.net  Fri Oct 16 11:27:06 2020
From: github.com+1913914+petrbouda at openjdk.java.net (Petr Bouda)
Date: Fri, 16 Oct 2020 11:27:06 GMT
Subject: RFR: 6941: build.sh does not terminate jetty after executing
 '--packageJmc'
In-Reply-To: <BsZxURyhkFayoL42SRIdRTy6XcwiBxJmF5oF4jB3s44=.9503e42d-6dd3-4b05-9ba6-0ca2ee37b259@github.com>
References: <BsZxURyhkFayoL42SRIdRTy6XcwiBxJmF5oF4jB3s44=.9503e42d-6dd3-4b05-9ba6-0ca2ee37b259@github.com>
Message-ID: <xrCgulwifgdiHUSHM9PaEXveP35OLnxFjODxdpTBwts=.df0f424a-d6e7-4ad0-bbcc-9eda86f95e17@github.com>

On Thu, 15 Oct 2020 19:42:53 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

> stopping jetty instance using kill command working on Mac & Linux

I checked the pull-request with Linux Mint

jmc git:(pull-request) ? ./build.sh --packageJmc[20/10/16| 1:10PM]
13:10:15 building p2:site - logging output to /home/pbouda/experiments/jmc/target/build_20201016131013.1.p2_site.log
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass
(file:/home/pbouda/.m2/repository/org/codehaus/groovy/groovy-all/2.4.8/groovy-all-2.4.8.jar) to method
java.lang.Object.finalize() WARNING: Please consider reporting this to the maintainers of
org.codehaus.groovy.reflection.CachedClass WARNING: Use --illegal-access=warn to enable warnings of further illegal
reflective access operations WARNING: All illegal access operations will be denied in a future release 13:10:24 run
jetty - logging output to /home/pbouda/experiments/jmc/target/build_20201016131013.2.jetty.log 13:10:24 waiting for
jetty server to start 13:10:25 waiting for jetty server to start
13:10:26 waiting for jetty server to start
13:10:27 jetty server up and running on pid 999930
13:10:27 installing core artifacts - logging output to
/home/pbouda/experiments/jmc/target/build_20201016131013.3.install.log 13:11:48 packaging jmc - logging output to
/home/pbouda/experiments/jmc/target/build_20201016131013.4.package.log You can now run jmc by calling "build.sh --run"
or "/home/pbouda/experiments/jmc/target/products/org.openjdk.jmc/linux/gtk/x86_64/JDK\ Mission\ Control/jmc" 13:18:44
terminating jetty server

?  jmc git:(pull-request) ? build.sh --run                                                            [20/10/16| 1:18PM]
OpenJDK 64-Bit Server VM warning: Option FlightRecorder was deprecated in version 13.0 and will likely be removed in a
future release. Started recording 1.

Use jcmd 1004545 JFR.dump name=JMC_Default filename=FILEPATH to copy recording data to file.

-------------

PR: https://git.openjdk.java.net/jmc/pull/130

From reinhapa at openjdk.java.net  Fri Oct 16 12:26:05 2020
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Fri, 16 Oct 2020 12:26:05 GMT
Subject: RFR: 6941: build.sh does not terminate jetty after executing
 '--packageJmc'
In-Reply-To: <xrCgulwifgdiHUSHM9PaEXveP35OLnxFjODxdpTBwts=.df0f424a-d6e7-4ad0-bbcc-9eda86f95e17@github.com>
References: <BsZxURyhkFayoL42SRIdRTy6XcwiBxJmF5oF4jB3s44=.9503e42d-6dd3-4b05-9ba6-0ca2ee37b259@github.com>
 <xrCgulwifgdiHUSHM9PaEXveP35OLnxFjODxdpTBwts=.df0f424a-d6e7-4ad0-bbcc-9eda86f95e17@github.com>
Message-ID: <2DuJee1g-FFPyjLQ6x9-srFrTljtUUU3eip6OFYzjAg=.6bd5da48-141b-4d22-a3e0-c311d69e8071@github.com>

On Fri, 16 Oct 2020 11:21:23 GMT, Petr Bouda <github.com+1913914+petrbouda at openjdk.org> wrote:

>> stopping jetty instance using kill command working on Mac & Linux
>
> I checked the pull-request with Linux Mint
> 
> jmc git:(pull-request) ? ./build.sh --packageJmc[20/10/16| 1:10PM]
> 13:10:15 building p2:site - logging output to /home/pbouda/experiments/jmc/target/build_20201016131013.1.p2_site.log
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass
> (file:/home/pbouda/.m2/repository/org/codehaus/groovy/groovy-all/2.4.8/groovy-all-2.4.8.jar) to method
> java.lang.Object.finalize() WARNING: Please consider reporting this to the maintainers of
> org.codehaus.groovy.reflection.CachedClass WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations WARNING: All illegal access operations will be denied in a future release 13:10:24 run
> jetty - logging output to /home/pbouda/experiments/jmc/target/build_20201016131013.2.jetty.log 13:10:24 waiting for
> jetty server to start 13:10:25 waiting for jetty server to start
> 13:10:26 waiting for jetty server to start
> 13:10:27 jetty server up and running on pid 999930
> 13:10:27 installing core artifacts - logging output to
> /home/pbouda/experiments/jmc/target/build_20201016131013.3.install.log 13:11:48 packaging jmc - logging output to
> /home/pbouda/experiments/jmc/target/build_20201016131013.4.package.log You can now run jmc by calling "build.sh --run"
> or "/home/pbouda/experiments/jmc/target/products/org.openjdk.jmc/linux/gtk/x86_64/JDK\ Mission\ Control/jmc" 13:18:44
> terminating jetty server
> ?  jmc git:(pull-request) ? build.sh --run                                                            [20/10/16| 1:18PM]
> OpenJDK 64-Bit Server VM warning: Option FlightRecorder was deprecated in version 13.0 and will likely be removed in a
> future release. Started recording 1.
> 
> Use jcmd 1004545 JFR.dump name=JMC_Default filename=FILEPATH to copy recording data to file.

@petrbouda was the successful for you? I personally tested it successfully on Fedora Linux & Mac OS so far...

-------------

PR: https://git.openjdk.java.net/jmc/pull/130

From github.com+1913914+petrbouda at openjdk.java.net  Fri Oct 16 12:32:10 2020
From: github.com+1913914+petrbouda at openjdk.java.net (Petr Bouda)
Date: Fri, 16 Oct 2020 12:32:10 GMT
Subject: RFR: 6941: build.sh does not terminate jetty after executing
 '--packageJmc'
In-Reply-To: <2DuJee1g-FFPyjLQ6x9-srFrTljtUUU3eip6OFYzjAg=.6bd5da48-141b-4d22-a3e0-c311d69e8071@github.com>
References: <BsZxURyhkFayoL42SRIdRTy6XcwiBxJmF5oF4jB3s44=.9503e42d-6dd3-4b05-9ba6-0ca2ee37b259@github.com>
 <xrCgulwifgdiHUSHM9PaEXveP35OLnxFjODxdpTBwts=.df0f424a-d6e7-4ad0-bbcc-9eda86f95e17@github.com>
 <2DuJee1g-FFPyjLQ6x9-srFrTljtUUU3eip6OFYzjAg=.6bd5da48-141b-4d22-a3e0-c311d69e8071@github.com>
Message-ID: <9gdBZaOnWRIqJrXkU_-4jviUVtAV3qiTZqLk_HfGKps=.642b3287-2b14-48bf-8451-15c37ff60b0e@github.com>

On Fri, 16 Oct 2020 12:23:11 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

>> I checked the pull-request with Linux Mint
>> 
>> jmc git:(pull-request) ? ./build.sh --packageJmc[20/10/16| 1:10PM]
>> 13:10:15 building p2:site - logging output to /home/pbouda/experiments/jmc/target/build_20201016131013.1.p2_site.log
>> WARNING: An illegal reflective access operation has occurred
>> WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass
>> (file:/home/pbouda/.m2/repository/org/codehaus/groovy/groovy-all/2.4.8/groovy-all-2.4.8.jar) to method
>> java.lang.Object.finalize() WARNING: Please consider reporting this to the maintainers of
>> org.codehaus.groovy.reflection.CachedClass WARNING: Use --illegal-access=warn to enable warnings of further illegal
>> reflective access operations WARNING: All illegal access operations will be denied in a future release 13:10:24 run
>> jetty - logging output to /home/pbouda/experiments/jmc/target/build_20201016131013.2.jetty.log 13:10:24 waiting for
>> jetty server to start 13:10:25 waiting for jetty server to start
>> 13:10:26 waiting for jetty server to start
>> 13:10:27 jetty server up and running on pid 999930
>> 13:10:27 installing core artifacts - logging output to
>> /home/pbouda/experiments/jmc/target/build_20201016131013.3.install.log 13:11:48 packaging jmc - logging output to
>> /home/pbouda/experiments/jmc/target/build_20201016131013.4.package.log You can now run jmc by calling "build.sh --run"
>> or "/home/pbouda/experiments/jmc/target/products/org.openjdk.jmc/linux/gtk/x86_64/JDK\ Mission\ Control/jmc" 13:18:44
>> terminating jetty server
>> ?  jmc git:(pull-request) ? build.sh --run                                                            [20/10/16| 1:18PM]
>> OpenJDK 64-Bit Server VM warning: Option FlightRecorder was deprecated in version 13.0 and will likely be removed in a
>> future release. Started recording 1.
>> 
>> Use jcmd 1004545 JFR.dump name=JMC_Default filename=FILEPATH to copy recording data to file.
>
> @petrbouda was the successful for you? I personally tested it successfully on Fedora Linux & Mac OS so far...

@reinhapa Yeap, it looks good. I tested it on Linux Mint (Ubuntu), built the artifact, and started it up using
`build.sh --run`

-------------

PR: https://git.openjdk.java.net/jmc/pull/130

From hirt at openjdk.java.net  Fri Oct 16 13:28:08 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 16 Oct 2020 13:28:08 GMT
Subject: RFR: 6941: build.sh does not terminate jetty after executing
 '--packageJmc'
In-Reply-To: <BsZxURyhkFayoL42SRIdRTy6XcwiBxJmF5oF4jB3s44=.9503e42d-6dd3-4b05-9ba6-0ca2ee37b259@github.com>
References: <BsZxURyhkFayoL42SRIdRTy6XcwiBxJmF5oF4jB3s44=.9503e42d-6dd3-4b05-9ba6-0ca2ee37b259@github.com>
Message-ID: <vsXd4DT5n9TySUfMEHkcn9EFxVuX6QSF4j8yu3XnuIc=.a08cb03c-9adc-438b-b16d-bf91df0e29d3@github.com>

On Thu, 15 Oct 2020 19:42:53 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

> stopping jetty instance using kill command working on Mac & Linux

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/130

From reinhapa at openjdk.java.net  Fri Oct 16 13:50:08 2020
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Fri, 16 Oct 2020 13:50:08 GMT
Subject: Integrated: 6941: build.sh does not terminate jetty after executing
 '--packageJmc'
In-Reply-To: <BsZxURyhkFayoL42SRIdRTy6XcwiBxJmF5oF4jB3s44=.9503e42d-6dd3-4b05-9ba6-0ca2ee37b259@github.com>
References: <BsZxURyhkFayoL42SRIdRTy6XcwiBxJmF5oF4jB3s44=.9503e42d-6dd3-4b05-9ba6-0ca2ee37b259@github.com>
Message-ID: <Mk7FtXlimu0ssSoJihvikNv9SKV3C2wK9gzATAQZ44Q=.e2bd2deb-e912-49d5-b2da-15c9c9afd453@github.com>

On Thu, 15 Oct 2020 19:42:53 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

> stopping jetty instance using kill command working on Mac & Linux

This pull request has now been integrated.

Changeset: 8129eddd
Author:    Patrick Reinhart <reinhapa at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/8129eddd
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

6941: build.sh does not terminate jetty after executing '--packageJmc'

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/130

From mwengner at openjdk.java.net  Sun Oct 18 19:42:10 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Sun, 18 Oct 2020 19:42:10 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v20]
In-Reply-To: <FC5kMQHxz8_gfKjpcsewgf_0fdg6MRJfNnlMVlUPVJQ=.58af68f5-75c8-4cfb-b3ab-8ec354e78111@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
 <Xmof_RKkV8zx6k0SNx707jOO1Z8GFQD1d6FtbcFBBso=.78a2f05f-8518-49d9-ada1-53eedddd85d3@github.com>
 <FC5kMQHxz8_gfKjpcsewgf_0fdg6MRJfNnlMVlUPVJQ=.58af68f5-75c8-4cfb-b3ab-8ec354e78111@github.com>
Message-ID: <0OBWmbETJT_DdfCXFgn_rGajj0JCiZx_pBcrLbsknQ4=.35d2941d-6925-4290-a6a0-8c38268ee91b@github.com>

On Fri, 9 Oct 2020 20:11:01 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6542: more cleanup
>
> Changes requested by hirt (Lead).

found the issue. better to open a new branch

-------------

PR: https://git.openjdk.java.net/jmc/pull/78

From mwengner at openjdk.java.net  Sun Oct 18 19:42:11 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Sun, 18 Oct 2020 19:42:11 GMT
Subject: Withdrawn: 6542: Improve calls to render in the flame view
In-Reply-To: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
Message-ID: <UKm1AJss07270f7js3auQWZdKBPh2TK-m9vaWkgvD30=.887478ce-6750-4f50-84f3-8e88cc590a88@github.com>

On Tue, 2 Jun 2020 15:25:53 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

> stable flameview generation

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jmc/pull/78

From mwengner at openjdk.java.net  Sun Oct 18 21:00:11 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Sun, 18 Oct 2020 21:00:11 GMT
Subject: RFR: 6542: Improve calls to render in the flame view
Message-ID: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>

the Flameview shift fix during a fast scrolling over the selections: https://bugs.openjdk.java.net/browse/JMC-6542

-------------

Commit messages:
 - 6542: comments model calculation cancelation
 - 6542: cleanup
 - 6542: correction flameview display,  model calculation separation

Changes: https://git.openjdk.java.net/jmc/pull/133/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=133&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6542
  Stats: 92 lines in 1 file changed: 45 ins; 25 del; 22 mod
  Patch: https://git.openjdk.java.net/jmc/pull/133.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/133/head:pull/133

PR: https://git.openjdk.java.net/jmc/pull/133

From mwengner at openjdk.java.net  Sun Oct 18 21:00:11 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Sun, 18 Oct 2020 21:00:11 GMT
Subject: RFR: 6542: Improve calls to render in the flame view
In-Reply-To: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
References: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
Message-ID: <qlgfkrVxcZ5_CGAZbM-em-0TKVdRDJ4l7tMnNT2kl2w=.d2107a0f-f1f9-4a16-95cd-07ad48728563@github.com>

On Sun, 18 Oct 2020 20:43:56 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

> the Flameview shift fix during a fast scrolling over the selections: https://bugs.openjdk.java.net/browse/JMC-6542

fix for : https://bugs.openjdk.java.net/browse/JMC-6542

-------------

PR: https://git.openjdk.java.net/jmc/pull/133

From hirt at openjdk.java.net  Mon Oct 19 09:15:08 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 19 Oct 2020 09:15:08 GMT
Subject: RFR: 6542: Improve calls to render in the flame view
In-Reply-To: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
References: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
Message-ID: <UXF1McmV_4UiCreBG0kQS5enI9lxysF_gxHwG5wIpew=.ab00b5b3-37fe-433f-9c2d-264e844e0758@github.com>

On Sun, 18 Oct 2020 20:43:56 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

> the Flameview shift fix during a fast scrolling over the selections: https://bugs.openjdk.java.net/browse/JMC-6542

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
line 350:

> 348: 	}
> 349:
> 350: 	private void rebuildModel(IItemCollection items) {

Maybe rename to submitRebuildTask or something?

-------------

PR: https://git.openjdk.java.net/jmc/pull/133

From hirt at openjdk.java.net  Mon Oct 19 09:22:09 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 19 Oct 2020 09:22:09 GMT
Subject: RFR: 6542: Improve calls to render in the flame view
In-Reply-To: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
References: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
Message-ID: <Cw7cuPVJh_Tr7Vq_r2xF_lzyLh2CztZQTjcT5A3-rlc=.602eabe3-073a-4568-8ad1-201f32c00f37@github.com>

On Sun, 18 Oct 2020 20:43:56 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

> the Flameview shift fix during a fast scrolling over the selections: https://bugs.openjdk.java.net/browse/JMC-6542

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
line 385:

> 383:
> 384: 			this.modelState = ModelState.READY;
> 385: 			DisplayToolkit.inDisplayThread().execute(() -> this.setModel(items, jsonModelBuilder.toString()));

Want to get the string first, outside of the lambda?

-------------

PR: https://git.openjdk.java.net/jmc/pull/133

From mwengner at openjdk.java.net  Mon Oct 19 09:32:23 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 19 Oct 2020 09:32:23 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v2]
In-Reply-To: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
References: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
Message-ID: <EfygFqZZ4FGQeW-Z6AtHEpyYlRwj-RoY_id6GdJ60Xs=.ac2214e4-7897-47fa-9fa6-90f7b3e9f88b@github.com>

> the Flameview shift fix during a fast scrolling over the selections: https://bugs.openjdk.java.net/browse/JMC-6542

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6542: minor changes

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/133/files
  - new: https://git.openjdk.java.net/jmc/pull/133/files/e1321588..ad0ff6fd

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=133&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=133&range=00-01

  Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod
  Patch: https://git.openjdk.java.net/jmc/pull/133.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/133/head:pull/133

PR: https://git.openjdk.java.net/jmc/pull/133

From mwengner at openjdk.java.net  Mon Oct 19 09:32:25 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 19 Oct 2020 09:32:25 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v2]
In-Reply-To: <Cw7cuPVJh_Tr7Vq_r2xF_lzyLh2CztZQTjcT5A3-rlc=.602eabe3-073a-4568-8ad1-201f32c00f37@github.com>
References: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
 <Cw7cuPVJh_Tr7Vq_r2xF_lzyLh2CztZQTjcT5A3-rlc=.602eabe3-073a-4568-8ad1-201f32c00f37@github.com>
Message-ID: <XczHywHIe-NkVkgbI44tQrw58qbXekIxS-rg4GOrG90=.28a394af-2bc5-4467-8d11-8a38e32949a1@github.com>

On Mon, 19 Oct 2020 09:19:16 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6542: minor changes
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
> line 385:
>> 383:
>> 384: 			this.modelState = ModelState.READY;
>> 385: 			DisplayToolkit.inDisplayThread().execute(() -> this.setModel(items, jsonModelBuilder.toString()));
> 
> Want to get the string first, outside of the lambda?

done!

> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
> line 350:
>> 348: 	}
>> 349:
>> 350: 	private void rebuildModel(IItemCollection items) {
> 
> Maybe rename to submitRebuildTask or something?

triggerRebuildTask ?

-------------

PR: https://git.openjdk.java.net/jmc/pull/133

From github.com+13562919+felipe-alves-moraes at openjdk.java.net  Mon Oct 19 16:40:15 2020
From: github.com+13562919+felipe-alves-moraes at openjdk.java.net (Felipe Moraes)
Date: Mon, 19 Oct 2020 16:40:15 GMT
Subject: RFR: 6942: The README is showing the wrong syntax for the build script
Message-ID: <QaD-_Dc9NNrRtM4ls2DCuy_Yy0688zqeA6Pv58Vj3kQ=.3ddd0030-07a4-47b2-9a38-680247765d8b@github.com>

6942: The README is showing the wrong syntax for the build script

-------------

Commit messages:
 - Fix readme instructions

Changes: https://git.openjdk.java.net/jmc/pull/132/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=132&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6942
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/132.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/132/head:pull/132

PR: https://git.openjdk.java.net/jmc/pull/132

From hirt at openjdk.java.net  Mon Oct 19 16:56:08 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 19 Oct 2020 16:56:08 GMT
Subject: RFR: 6942: The README is showing the wrong syntax for the build
 script
In-Reply-To: <QaD-_Dc9NNrRtM4ls2DCuy_Yy0688zqeA6Pv58Vj3kQ=.3ddd0030-07a4-47b2-9a38-680247765d8b@github.com>
References: <QaD-_Dc9NNrRtM4ls2DCuy_Yy0688zqeA6Pv58Vj3kQ=.3ddd0030-07a4-47b2-9a38-680247765d8b@github.com>
Message-ID: <iQO2dDXEcueyacYmD0bpd3aAKXi7XGgIxsx6gYT5K3s=.94f925c3-4c4a-41d3-9d71-85c1a95e0c34@github.com>

On Sat, 17 Oct 2020 14:06:40 GMT, Felipe Moraes <github.com+13562919+felipe-alves-moraes at openjdk.org> wrote:

> 6942: The README is showing the wrong syntax for the build script

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/132

From github.com+13562919+felipe-alves-moraes at openjdk.java.net  Mon Oct 19 17:42:21 2020
From: github.com+13562919+felipe-alves-moraes at openjdk.java.net (Felipe Moraes)
Date: Mon, 19 Oct 2020 17:42:21 GMT
Subject: Integrated: 6942: The README is showing the wrong syntax for the
 build script
In-Reply-To: <QaD-_Dc9NNrRtM4ls2DCuy_Yy0688zqeA6Pv58Vj3kQ=.3ddd0030-07a4-47b2-9a38-680247765d8b@github.com>
References: <QaD-_Dc9NNrRtM4ls2DCuy_Yy0688zqeA6Pv58Vj3kQ=.3ddd0030-07a4-47b2-9a38-680247765d8b@github.com>
Message-ID: <mqTyXOXNFlRyBX3o2574qWdyzanp6ZTZrzr6i8YhIPs=.d45336c0-473e-4a60-93af-550970cb2dfd@github.com>

On Sat, 17 Oct 2020 14:06:40 GMT, Felipe Moraes <github.com+13562919+felipe-alves-moraes at openjdk.org> wrote:

> 6942: The README is showing the wrong syntax for the build script

This pull request has now been integrated.

Changeset: ea1b02c3
Author:    fmoraes <felipealvesdemoraes at gmail.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/ea1b02c3
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

6942: The README is showing the wrong syntax for the build script

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/132

From aptmac at openjdk.java.net  Mon Oct 19 18:05:12 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 19 Oct 2020 18:05:12 GMT
Subject: RFR: 6913: Add daemon thread information to the console threads
 view [v2]
In-Reply-To: <EUy9xe1cQcUE5N8uowwo4KB94oWSLsdeLJfh7H57XFM=.d6806c73-f65c-4102-9c74-681b4d9c6845@github.com>
References: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
 <EUy9xe1cQcUE5N8uowwo4KB94oWSLsdeLJfh7H57XFM=.d6806c73-f65c-4102-9c74-681b4d9c6845@github.com>
Message-ID: <r_YZVCRiz33MpowsOgStGs0BJeWF-OajdiFX9apMIBQ=.7e5f0206-1b5d-4667-add7-5b472c395592@github.com>

On Sat, 10 Oct 2020 16:09:15 GMT, Jan S. <github.com+924885+jpstotz at openjdk.org> wrote:

>> I had an Java application which did not exit because of a non-daemon thread still running. Therefore I added a column
>> to the treads view that displays if a thread is a daemon thread or not.
>> oca: has been signed on 2019-01-17 (got positive response from Dalibor Topic on 2019-01-23).
>
> Jan S. has updated the pull request incrementally with one additional commit since the last revision:
> 
>   show error message for Java 8 VMs and older that do not provide isDaemon() in java.lang.management.ThreadInfo

@jpstotz Thank you for the revision, this is what I had in mind. I think the code looks good, and I verified that the
correct messages are showing on a jdk8 jvm vs. a jdk11 jvm.

One minor nit is that the message texts don't usually end in a period, so other than that needing being changed this
looks okay to me.

application/org.openjdk.jmc.console.ui/src/main/resources/org/openjdk/jmc/console/ui/messages/internal/messages.properties
line 178:

> 176: IS_DAEMON_NAME_TEXT=Daemon
> 177: IS_DAEMON_ERROR_VALUE=Data not available
> 178: IS_DAEMON_DESCRIPTION_TEXT=True if the thread is a daemon thread.

Minor nit, but I don't think there should be a period to end the statement

-------------

PR: https://git.openjdk.java.net/jmc/pull/110

From github.com+924885+jpstotz at openjdk.java.net  Mon Oct 19 18:12:20 2020
From: github.com+924885+jpstotz at openjdk.java.net (Jan S.)
Date: Mon, 19 Oct 2020 18:12:20 GMT
Subject: RFR: 6913: Add daemon thread information to the console threads
 view [v3]
In-Reply-To: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
References: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
Message-ID: <ei1SKv0P9WNgHWhcGnxZ4rQ1wR9BOkrAJTpFdIULIlw=.69826cf1-cb65-444f-bfc8-8d909f13d22d@github.com>

> I had an Java application which did not exit because of a non-daemon thread still running. Therefore I added a column
> to the treads view that displays if a thread is a daemon thread or not.
> oca: has been signed on 2019-01-17 (got positive response from Dalibor Topic on 2019-01-23).

Jan S. has updated the pull request incrementally with one additional commit since the last revision:

  message text corrected as requested

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/110/files
  - new: https://git.openjdk.java.net/jmc/pull/110/files/c864b4be..cf4a0fc5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=110&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=110&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/110.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/110/head:pull/110

PR: https://git.openjdk.java.net/jmc/pull/110

From aptmac at openjdk.java.net  Mon Oct 19 18:12:21 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 19 Oct 2020 18:12:21 GMT
Subject: RFR: 6913: Add daemon thread information to the console threads
 view [v3]
In-Reply-To: <ei1SKv0P9WNgHWhcGnxZ4rQ1wR9BOkrAJTpFdIULIlw=.69826cf1-cb65-444f-bfc8-8d909f13d22d@github.com>
References: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
 <ei1SKv0P9WNgHWhcGnxZ4rQ1wR9BOkrAJTpFdIULIlw=.69826cf1-cb65-444f-bfc8-8d909f13d22d@github.com>
Message-ID: <tNliPQ0HmeFBGJOKHFv8eDCO6w0uZv2KbYXTP46ygAo=.d3513d4a-f458-4ba9-8e25-9b3e92863c62@github.com>

On Mon, 19 Oct 2020 18:09:24 GMT, Jan S. <github.com+924885+jpstotz at openjdk.org> wrote:

>> I had an Java application which did not exit because of a non-daemon thread still running. Therefore I added a column
>> to the treads view that displays if a thread is a daemon thread or not.
>> oca: has been signed on 2019-01-17 (got positive response from Dalibor Topic on 2019-01-23).
>
> Jan S. has updated the pull request incrementally with one additional commit since the last revision:
> 
>   message text corrected as requested

Thanks, the changes look okay to me.

The PR will require at least one more review before it's formally approved and ready to integrate.

-------------

Marked as reviewed by aptmac (Committer).

PR: https://git.openjdk.java.net/jmc/pull/110

From github.com+924885+jpstotz at openjdk.java.net  Mon Oct 19 18:12:22 2020
From: github.com+924885+jpstotz at openjdk.java.net (Jan S.)
Date: Mon, 19 Oct 2020 18:12:22 GMT
Subject: RFR: 6913: Add daemon thread information to the console threads
 view [v2]
In-Reply-To: <r_YZVCRiz33MpowsOgStGs0BJeWF-OajdiFX9apMIBQ=.7e5f0206-1b5d-4667-add7-5b472c395592@github.com>
References: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
 <EUy9xe1cQcUE5N8uowwo4KB94oWSLsdeLJfh7H57XFM=.d6806c73-f65c-4102-9c74-681b4d9c6845@github.com>
 <r_YZVCRiz33MpowsOgStGs0BJeWF-OajdiFX9apMIBQ=.7e5f0206-1b5d-4667-add7-5b472c395592@github.com>
Message-ID: <EVrnDDgCxCYGR_efHyuryrWqkK7xiLvpNLwgF9kvKAo=.4e724f2d-c8e6-4c79-a94d-c2fb43f722d7@github.com>

On Mon, 19 Oct 2020 18:02:12 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Jan S. has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   show error message for Java 8 VMs and older that do not provide isDaemon() in java.lang.management.ThreadInfo
>
> @jpstotz Thank you for the revision, this is what I had in mind. I think the code looks good, and I verified that the
> correct messages are showing on a jdk8 jvm vs. a jdk11 jvm.
> One minor nit is that the message texts don't usually end in a period, so other than that needing being changed this
> looks okay to me.

@aptmac I fixed the message text as you suggested.

-------------

PR: https://git.openjdk.java.net/jmc/pull/110

From aptmac at openjdk.java.net  Mon Oct 19 19:03:12 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 19 Oct 2020 19:03:12 GMT
Subject: RFR: 6913: Add daemon thread information to the console threads
 view [v3]
In-Reply-To: <ei1SKv0P9WNgHWhcGnxZ4rQ1wR9BOkrAJTpFdIULIlw=.69826cf1-cb65-444f-bfc8-8d909f13d22d@github.com>
References: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
 <ei1SKv0P9WNgHWhcGnxZ4rQ1wR9BOkrAJTpFdIULIlw=.69826cf1-cb65-444f-bfc8-8d909f13d22d@github.com>
Message-ID: <HyaztUA9aT3TJwis9IjqLr8xat1KHhTWdr4PPa9RzME=.c974496f-2829-46ec-b4c4-8537bc0ad50e@github.com>

On Mon, 19 Oct 2020 18:12:20 GMT, Jan S. <github.com+924885+jpstotz at openjdk.org> wrote:

>> I had an Java application which did not exit because of a non-daemon thread still running. Therefore I added a column
>> to the treads view that displays if a thread is a daemon thread or not.
>> oca: has been signed on 2019-01-17 (got positive response from Dalibor Topic on 2019-01-23).
>
> Jan S. has updated the pull request incrementally with one additional commit since the last revision:
> 
>   message text corrected as requested

Marked as reviewed by aptmac (Committer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/110

From hirt at openjdk.java.net  Mon Oct 19 19:03:13 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 19 Oct 2020 19:03:13 GMT
Subject: RFR: 6913: Add daemon thread information to the console threads
 view [v3]
In-Reply-To: <tNliPQ0HmeFBGJOKHFv8eDCO6w0uZv2KbYXTP46ygAo=.d3513d4a-f458-4ba9-8e25-9b3e92863c62@github.com>
References: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
 <ei1SKv0P9WNgHWhcGnxZ4rQ1wR9BOkrAJTpFdIULIlw=.69826cf1-cb65-444f-bfc8-8d909f13d22d@github.com>
 <tNliPQ0HmeFBGJOKHFv8eDCO6w0uZv2KbYXTP46ygAo=.d3513d4a-f458-4ba9-8e25-9b3e92863c62@github.com>
Message-ID: <ph6s0GWBMG3fnpjZOrkhfYfccrIAUqR2rF_q6MJ5aZI=.affaa42b-cecb-445e-acc0-050a739da69f@github.com>

On Mon, 19 Oct 2020 18:09:24 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Jan S. has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   message text corrected as requested
>
> Thanks, the changes look okay to me.
> 
> The PR will require at least one more review before it's formally approved and ready to integrate.

Gnah - butterfingers. @aptmac, please set it as reviewed on your part.

-------------

PR: https://git.openjdk.java.net/jmc/pull/110

From schaturvedi at openjdk.java.net  Mon Oct 19 20:20:16 2020
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Mon, 19 Oct 2020 20:20:16 GMT
Subject: RFR: 6911: Third Party Upgrade to HdrHistogram 2.1.12
Message-ID: <otO8nTIinvc71vWiTAhXFBT9oovfgFDWFWwnXeLvIuU=.c782c9d5-49b0-4dc2-a512-711cd92c62fa@github.com>

As part of this enhancement, the third party HdrHistogram is upgraded from 2.1.11 to 2.1.12 (latest).

Please review the change.

-------------

Commit messages:
 - 6911: Third Party Upgrade to HdrHistogram 2.1.12

Changes: https://git.openjdk.java.net/jmc/pull/134/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=134&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6911
  Stats: 5 lines in 5 files changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jmc/pull/134.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/134/head:pull/134

PR: https://git.openjdk.java.net/jmc/pull/134

From mwengner at openjdk.java.net  Mon Oct 19 20:24:21 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 19 Oct 2020 20:24:21 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v3]
In-Reply-To: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
References: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
Message-ID: <DjgAdOfKAkW6luC2hPltikg7pak7vsVEeGpMpd-elEg=.10fd9204-3422-4c66-92e7-d8f394f5067b@github.com>

> the Flameview shift fix during a fast scrolling over the selections: https://bugs.openjdk.java.net/browse/JMC-6542

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6542: correction to aboring callable

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/133/files
  - new: https://git.openjdk.java.net/jmc/pull/133/files/ad0ff6fd..92f0f1d4

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=133&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=133&range=01-02

  Stats: 40 lines in 1 file changed: 12 ins; 6 del; 22 mod
  Patch: https://git.openjdk.java.net/jmc/pull/133.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/133/head:pull/133

PR: https://git.openjdk.java.net/jmc/pull/133

From aptmac at openjdk.java.net  Mon Oct 19 21:15:19 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 19 Oct 2020 21:15:19 GMT
Subject: RFR: 6364: Improvements to the Thread Graph [v5]
In-Reply-To: <3b_EN291IWMTMl6vId_3HM3r9b2p0Bjxd9QYH5qgDO8=.50cc047a-4486-469a-a341-5908f78bb6df@github.com>
References: <3b_EN291IWMTMl6vId_3HM3r9b2p0Bjxd9QYH5qgDO8=.50cc047a-4486-469a-a341-5908f78bb6df@github.com>
Message-ID: <_QTxCrm30KMOH44baW13yNvSDfBCDVXJvR8xkuaGCS0=.78b1765b-11cb-4045-acbd-e187c719a542@github.com>

> This patch addresses JMC-6364 [[0]](https://bugs.openjdk.java.net/browse/JMC-6364), the epic for tracking Improvements
> to the JFR Thread Graph. This RFR is also a follow-up to an RFC
> [[1]](http://mail.openjdk.java.net/pipermail/jmc-dev/2019-October/001454.html) that was posted to the jmc-dev list and
> incorporates the feedback that was brought up during discussion.  The new design and features was imagined in
> collaboration with our UX team, and the implementation has been a joint effort between myself and Jessye (@jessyec-s) -
> we had been originally collaborating on a fork of the old (unofficial) JMC GitHub repo. I've folded all the commits
> down into one because the older commits were merged using PRs with a similar format (e.g., `jmc/pull/23`) to this repo,
> so to avoid accidental noise (sorry about that) on other PRs I've just folded them away. If anyone is interested in the
> individual commits that got to this point, I've kept them around in the old repo
> [[2]](https://github.com/aptmac/jmc-old/commits/jfr-threads-page).  This PR aims to improve the usability and
> functionality of the JFR Threads Page by extending and enhancing existing classes. In an attempt to not clutter this PR
> with lots of images and explanatory text, I've created a gist
> [[3]](https://gist.github.com/aptmac/61808c89bfcf1888080884fc8a61bd36) that provides information and images/gifs of the
> new components and intended functionality.  Gist: https://gist.github.com/aptmac/61808c89bfcf1888080884fc8a61bd36
> Summary of changes:
> - Introduction of canvases to display the thread names (left) and timeline (bottom)
> - Scrolled composites to house the text and chart canvases, for vertical scrolling of the chart area
> - Timeline canvas (bottom) is draggable for panning the chart
> - Current threads table has been re-located to a popup table
> - New filter bar (top) which alters the chart view based on time ranges and desired visible activity lanes
> - New display bar (right) which houses the zoom mechanics
> - New zoom pan component for easily navigating the chart
> - Introduction of a colour palette to increase contrast between neighbouring activity lanes
> - Controls to change the height of the thread lanes
> - updated and new uitests
> 
> Before:
> ![before](https://i.imgur.com/TNfGrtJ.png)
> 
> After:
> ![after](https://user-images.githubusercontent.com/10425301/71993902-dfd93200-3205-11ea-8249-cc50409a7a9f.png)
> 
> Let me know if you have any questions about the design & functionality.
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-6364
> [1] http://mail.openjdk.java.net/pipermail/jmc-dev/2019-October/001454.html
> [2] https://github.com/aptmac/jmc-old/commits/jfr-threads-page
> [3] https://gist.github.com/aptmac/61808c89bfcf1888080884fc8a61bd36

Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now
contains 26 commits:

 - fix threads topic for legacy page
 - run mvn:spotless for uitests
 - chore: cleanup string usage and image for overview mode button
 - chore: update layouts in ThreadsPageUILayout and minor cleanup
 - chore(windows): fix a couple of bugs that were inhibiting proper display on Windows
 - chore: update the license headers to 2020 + include third party licenses for FontAwesome and PatternFly
 - feat: improve re-sizing and resetting of lane heights
 - fix: run spotless and fix spotbugs errors
 - test: include tests for the chart and table hiding actions
 - feat: replace popup table with foldable sashform
   
   While an interesting feature, trying to persist settings and selections from the FilterEditor and table within the
   former popup table was not a realistic feat. After demoing the threads page work at the latest bi-weekly JMC hangout
   meeting, it was noted that it'd be nice to be able to easily interact with the table and update selections and filters.
   Based on this information, this commit replaces the popup table with a foldable sashform using controls proposed in
   JMC-6386. This allows the user to quickly hide and unhide both the table or chart based on their workflow.
 - ... and 16 more: https://git.openjdk.java.net/jmc/compare/ea1b02c3...ae16dcb5

-------------

Changes: https://git.openjdk.java.net/jmc/pull/27/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=27&range=04
  Stats: 4794 lines in 50 files changed: 4433 ins; 49 del; 312 mod
  Patch: https://git.openjdk.java.net/jmc/pull/27.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/27/head:pull/27

PR: https://git.openjdk.java.net/jmc/pull/27

From aptmac at openjdk.java.net  Mon Oct 19 21:15:19 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 19 Oct 2020 21:15:19 GMT
Subject: RFR: 6364: Improvements to the Thread Graph
In-Reply-To: <gAZnxXu30whSmrmWEqfVRZczClOSfJ3pRT0IImh3gak=.38917981-4205-4c56-9726-608dbb19e1f5@github.com>
References: <3b_EN291IWMTMl6vId_3HM3r9b2p0Bjxd9QYH5qgDO8=.50cc047a-4486-469a-a341-5908f78bb6df@github.com>
 <9z2_Fmh0wzUWsp9Tu1bEudv8_BvAjeAC6RVPPe76FRQ=.1d13e3bc-3d48-4a9b-831f-40b784d57106@github.com>
 <RzkGUXMijABPraKoBm2yRnh7490ldPx8R1pVnLkZuQo=.49c6a560-d0bc-4870-8fc8-6b16c31a4edf@github.com>
 <VtxWPdJ5lCNJANcyQQKDpUAc6oMz6sIIl4AdCngGzNY=.3e9e164a-aeca-4a31-9c0d-90b32e505e1f@github.com>
 <WlsAE5WBZzvaJ7y6s_9776LfwPZxInEyw-9tHkR8BYQ=.cac2ca35-320a-4955-b4ad-9f03cf91e67d@github.com>
 <W46pwscvWVhGWOQ7fZuohiPU3PDSr_fTBcjsYEHZX9U=.3ded4679-f3c5-4fa0-8d3f-febe4b5ff1ae@github.com>
 <PkxbYIW2PTQI6EKSG2QBPXGZsLN_4YAmK8tBzom9Zcc=.6ac6a27f-cb8f-4d40-b910-8f209468280b@github.com>
 <1rFwH_fS08Lr6VT09rAPl5aOjeoDyyfAK1l1DaktMB8=.e94b0d05-4244-46b2-848e-c83f7aa3917a@github.com>
 <m106gabj2MTdvJuIG-7VzB4GU0GwsWw8FvwMStXJvzM=.60dbba90-bc44-4759-9e45-4cc07727fb54@github.com>
 <uGE8OtyeKVfipTGVyNCcHDrlfaxDEBGqhCdPhqjlv8o=.43a35c17-ad84-4831-87ad-740cfbdd7ed1@github.com>
 <jO40oBcEPc8zoPazOkBHqUm813eWjRpi5RJ
 qYv_QCeU=.976e6cb5-a240-4e7d-b2e7-307a66903740@github.com>
 <s8PRQ3LPX5LFCZGk47tfu4T8JfguQGuKNOu6ysh3eo8=.5062e28b-b947-45b7-aaff-4e52f01c3a92@github.com>
 <te05v9SDdp77tUGnpxxtE4WvBeHTsoyZK1xxITVaAXE=.094e17e2-1599-4d6f-89c8-1311786ab932@github.com>
 <gAZnxXu30whSmrmWEqfVRZczClOSfJ3pRT0IImh3gak=.38917981-4205-4c56-9726-608dbb19e1f5@github.com>
Message-ID: <_FfNWY5vo9gw6mRD7-ps_SZNxCfGqdM0D0uy3BCbqVk=.b7cc3f0c-ddc6-410a-af9c-e430a95c9ff6@github.com>

On Mon, 28 Sep 2020 21:07:35 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> "Edit Thread Lanes" at top right corner and "Thread State Selection" button, both are opening the same pop up.
> 
> Just a suggestion, Should we keep one and skip the other?

I still think it'd be useful to keep the text on that button, otherwise the only way to reach that functionality is via
the context menu or by using the icon in the top right corner (which you would only know of the functionality from
prior knowledge, or by hovering and displaying the tooltip). The idea here is that the functionality is upfront and
readable, and doesn't require legacy knowledge to access.

The idea was to have a dropdown combobox that would allow for quickly toggling lane events and allowing for instant
chart redraws. Unfortunately after implementing this I found out that it wasn't working as intended on Windows & Mac
because of the way SWT was handling the actions of checking the combobox. In Linux, selecting a SWT combobox is enough
to trigger the action, however in Windows & Mac the behaviour is different and the action only triggers if both the
item is highlighted and checked. As a preventative measure there's a check that uses the dropdown lane filter if the OS
is Linux, but the regular dialog if it's Windows or Mac. If this functionality should be reverted to make it the same
across OS's that's okay, but personally I think it's a neat feature for now.

> I have tried to use the new improved version of threads page. But for many JFRs I am getting "Too much content" issue
> and the page is not loading properly.

This one is tricky, because the chart needs a certain amount of space to properly display all the lanes otherwise the
"Too much content" overlay appears. For example, here are a couple of screenshots of the "plain_recording.jfr" provided
for uitests. There are a lot of threads displayed, and the screenshots show the threshold of displaying the threads or
not.

This is the smallest I can make the chart without displaying the overlay,
![01-just-right](https://user-images.githubusercontent.com/10425301/96511328-f00a4d00-122c-11eb-9880-8f7748d7de2b.png)

and here's what it looks like when I drag the sash just a bit more. At this point there just isn't enough space to
display all of the threads on the screen, and I'd need to adjust my selection to suit the screen real estate.
![02-too-much](https://user-images.githubusercontent.com/10425301/96511332-f0a2e380-122c-11eb-9984-d11b54daf70f.png)

-------------

PR: https://git.openjdk.java.net/jmc/pull/27

From mwengner at openjdk.java.net  Tue Oct 20 11:06:18 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Tue, 20 Oct 2020 11:06:18 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v4]
In-Reply-To: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
References: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
Message-ID: <vuGvtvr9kwartATao5EgUfoTXB7QC1xhS6LORwgIgEs=.a4d44758-c30b-47db-94d5-a81a0926e94f@github.com>

> the Flameview shift fix during a fast scrolling over the selections: https://bugs.openjdk.java.net/browse/JMC-6542

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6542: typo correction

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/133/files
  - new: https://git.openjdk.java.net/jmc/pull/133/files/92f0f1d4..ab273605

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=133&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=133&range=02-03

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/133.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/133/head:pull/133

PR: https://git.openjdk.java.net/jmc/pull/133

From mwengner at openjdk.java.net  Tue Oct 20 13:00:21 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Tue, 20 Oct 2020 13:00:21 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v5]
In-Reply-To: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
References: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
Message-ID: <5tVc6yo1GHLIaEbBhNdxE9HCxrAMdoMspWiEGXCQLG8=.c0107c9d-e116-410d-82d8-f33e682ff4ac@github.com>

> the Flameview shift fix during a fast scrolling over the selections: https://bugs.openjdk.java.net/browse/JMC-6542

Miroslav Wengner has updated the pull request incrementally with two additional commits since the last revision:

 - 6542:  spotless needs
 - 6542: cleanup

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/133/files
  - new: https://git.openjdk.java.net/jmc/pull/133/files/ab273605..3d6ec196

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=133&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=133&range=03-04

  Stats: 66 lines in 1 file changed: 33 ins; 33 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/133.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/133/head:pull/133

PR: https://git.openjdk.java.net/jmc/pull/133

From mwengner at openjdk.java.net  Tue Oct 20 19:31:23 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Tue, 20 Oct 2020 19:31:23 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v6]
In-Reply-To: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
References: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
Message-ID: <qvQw0ZAt5b4Btu2c_Pf8UJQF7VDwXFe953_sDLyFh5g=.b0b72f15-f026-44f3-8829-fe1c7e7ee0f0@github.com>

> the Flameview shift fix during a fast scrolling over the selections: https://bugs.openjdk.java.net/browse/JMC-6542

Miroslav Wengner has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since
the last revision:

 - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6542_Improve_calls_to_render_in_the_flame_view
 - 6542:  spotless needs
 - 6542: cleanup
 - 6542: typo correction
 - 6542: correction to aboring callable
 - 6542: minor changes
 - 6542: comments model calculation cancelation
 - 6542: cleanup
 - 6542: correction flameview display,  model calculation separation

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/133/files
  - new: https://git.openjdk.java.net/jmc/pull/133/files/3d6ec196..3b517a22

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=133&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=133&range=04-05

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/133.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/133/head:pull/133

PR: https://git.openjdk.java.net/jmc/pull/133

From mwengner at openjdk.java.net  Tue Oct 20 19:41:20 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Tue, 20 Oct 2020 19:41:20 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v7]
In-Reply-To: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
References: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
Message-ID: <aYLPR5Hv8zVPoEn8WRRKgzU5NvWQvkhSbh35HM_Uegg=.807cb1ea-b0af-4684-ac2f-9613f9f05ce4@github.com>

> the Flameview shift fix during a fast scrolling over the selections: https://bugs.openjdk.java.net/browse/JMC-6542

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6542: renaming correction

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/133/files
  - new: https://git.openjdk.java.net/jmc/pull/133/files/3b517a22..bd4eb9e3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=133&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=133&range=05-06

  Stats: 4 lines in 1 file changed: 0 ins; 1 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/133.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/133/head:pull/133

PR: https://git.openjdk.java.net/jmc/pull/133

From hirt at openjdk.java.net  Tue Oct 20 19:41:22 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 20 Oct 2020 19:41:22 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v6]
In-Reply-To: <qvQw0ZAt5b4Btu2c_Pf8UJQF7VDwXFe953_sDLyFh5g=.b0b72f15-f026-44f3-8829-fe1c7e7ee0f0@github.com>
References: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
 <qvQw0ZAt5b4Btu2c_Pf8UJQF7VDwXFe953_sDLyFh5g=.b0b72f15-f026-44f3-8829-fe1c7e7ee0f0@github.com>
Message-ID: <IdP8HpFgwci3iYuf3GPpkdVsInoRxTlpu0ML7ldMJRM=.a7a4a9ab-efd0-4eb4-933b-251b24b0174d@github.com>

On Tue, 20 Oct 2020 19:31:23 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> the Flameview shift fix during a fast scrolling over the selections: https://bugs.openjdk.java.net/browse/JMC-6542
>
> Miroslav Wengner has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
> excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since
> the last revision:
>  - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6542_Improve_calls_to_render_in_the_flame_view
>  - 6542:  spotless needs
>  - 6542: cleanup
>  - 6542: typo correction
>  - 6542: correction to aboring callable
>  - 6542: minor changes
>  - 6542: comments model calculation cancelation
>  - 6542: cleanup
>  - 6542: correction flameview display,  model calculation separation

Changes requested by hirt (Lead).

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
line 285:

> 283: 	private static class ModelRebuildCallable implements Callable<Void> {
> 284:
> 285: 		private volatile boolean invalid;

Should probably be isInvalid.

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
line 290:

> 288:
> 289: 		private ModelRebuildCallable(FlameGraphView view, IItemCollection items) {
> 290: 			this.invalid = false;

This line should be removed.

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
line 387:

> 385: 		// Release old model calculation before building a new
> 386: 		if (modelCalculationFuture != null) {
> 387: 			modelRebuildCalllable.setInvalid();

One l too many.

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
line 170:

> 168: 	private IItemCollection currentItems;
> 169: 	private ModelState modelState = ModelState.NONE;
> 170: 	private ModelRebuildCallable modelRebuildCalllable;

One l too many.

-------------

PR: https://git.openjdk.java.net/jmc/pull/133

From mwengner at openjdk.java.net  Tue Oct 20 19:41:24 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Tue, 20 Oct 2020 19:41:24 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v6]
In-Reply-To: <IdP8HpFgwci3iYuf3GPpkdVsInoRxTlpu0ML7ldMJRM=.a7a4a9ab-efd0-4eb4-933b-251b24b0174d@github.com>
References: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
 <qvQw0ZAt5b4Btu2c_Pf8UJQF7VDwXFe953_sDLyFh5g=.b0b72f15-f026-44f3-8829-fe1c7e7ee0f0@github.com>
 <IdP8HpFgwci3iYuf3GPpkdVsInoRxTlpu0ML7ldMJRM=.a7a4a9ab-efd0-4eb4-933b-251b24b0174d@github.com>
Message-ID: <krkiXfDlHwl4WMS-TFqgpiXo8ZMLh2YTCuo5okts_no=.40aa8f62-522f-4dd8-9022-a4e2ed800e00@github.com>

On Tue, 20 Oct 2020 19:34:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since
>> the last revision:
>>  - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6542_Improve_calls_to_render_in_the_flame_view
>>  - 6542:  spotless needs
>>  - 6542: cleanup
>>  - 6542: typo correction
>>  - 6542: correction to aboring callable
>>  - 6542: minor changes
>>  - 6542: comments model calculation cancelation
>>  - 6542: cleanup
>>  - 6542: correction flameview display,  model calculation separation
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
> line 285:
>> 283: 	private static class ModelRebuildCallable implements Callable<Void> {
>> 284:
>> 285: 		private volatile boolean invalid;
> 
> Should probably be isInvalid.

done!

> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
> line 290:
>> 288:
>> 289: 		private ModelRebuildCallable(FlameGraphView view, IItemCollection items) {
>> 290: 			this.invalid = false;
> 
> This line should be removed.

done

-------------

PR: https://git.openjdk.java.net/jmc/pull/133

From mwengner at openjdk.java.net  Tue Oct 20 19:44:19 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Tue, 20 Oct 2020 19:44:19 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v8]
In-Reply-To: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
References: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
Message-ID: <5FAXdxxIZf1efKJw9dxISl9et40WLoCLUAE-pAfi6yc=.6f2bac1e-7191-4940-a2fd-c32a9fafe6ec@github.com>

> the Flameview shift fix during a fast scrolling over the selections: https://bugs.openjdk.java.net/browse/JMC-6542

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6542: naming fix

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/133/files
  - new: https://git.openjdk.java.net/jmc/pull/133/files/bd4eb9e3..dc8c5151

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=133&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=133&range=06-07

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/133.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/133/head:pull/133

PR: https://git.openjdk.java.net/jmc/pull/133

From mwengner at openjdk.java.net  Tue Oct 20 19:44:21 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Tue, 20 Oct 2020 19:44:21 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v6]
In-Reply-To: <IdP8HpFgwci3iYuf3GPpkdVsInoRxTlpu0ML7ldMJRM=.a7a4a9ab-efd0-4eb4-933b-251b24b0174d@github.com>
References: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
 <qvQw0ZAt5b4Btu2c_Pf8UJQF7VDwXFe953_sDLyFh5g=.b0b72f15-f026-44f3-8829-fe1c7e7ee0f0@github.com>
 <IdP8HpFgwci3iYuf3GPpkdVsInoRxTlpu0ML7ldMJRM=.a7a4a9ab-efd0-4eb4-933b-251b24b0174d@github.com>
Message-ID: <-Emy-SQEJaj0ThUiZRo-B1kciMFCrTfVnti5peBv0tA=.9d54ac4f-6bee-4eac-a2ac-923a531c25eb@github.com>

On Tue, 20 Oct 2020 19:35:52 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since
>> the last revision:
>>  - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6542_Improve_calls_to_render_in_the_flame_view
>>  - 6542:  spotless needs
>>  - 6542: cleanup
>>  - 6542: typo correction
>>  - 6542: correction to aboring callable
>>  - 6542: minor changes
>>  - 6542: comments model calculation cancelation
>>  - 6542: cleanup
>>  - 6542: correction flameview display,  model calculation separation
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
> line 170:
>> 168: 	private IItemCollection currentItems;
>> 169: 	private ModelState modelState = ModelState.NONE;
>> 170: 	private ModelRebuildCallable modelRebuildCalllable;
> 
> One l too many.

done

> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
> line 387:
>> 385: 		// Release old model calculation before building a new
>> 386: 		if (modelCalculationFuture != null) {
>> 387: 			modelRebuildCalllable.setInvalid();
> 
> One l too many.

done

-------------

PR: https://git.openjdk.java.net/jmc/pull/133

From hirt at openjdk.java.net  Tue Oct 20 20:17:11 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 20 Oct 2020 20:17:11 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v8]
In-Reply-To: <5FAXdxxIZf1efKJw9dxISl9et40WLoCLUAE-pAfi6yc=.6f2bac1e-7191-4940-a2fd-c32a9fafe6ec@github.com>
References: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
 <5FAXdxxIZf1efKJw9dxISl9et40WLoCLUAE-pAfi6yc=.6f2bac1e-7191-4940-a2fd-c32a9fafe6ec@github.com>
Message-ID: <vABPMzWKFWa13PfE8uTL1FQZtlrRngEL-rlpOBwfDbY=.f179c28a-ea7e-433f-a44e-470daf5c7021@github.com>

On Tue, 20 Oct 2020 19:44:19 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> the Flameview shift fix during a fast scrolling over the selections: https://bugs.openjdk.java.net/browse/JMC-6542
>
> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6542: naming fix

Marked as reviewed by hirt (Lead).

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/133

From hirt at openjdk.java.net  Tue Oct 20 20:19:09 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 20 Oct 2020 20:19:09 GMT
Subject: RFR: 6911: Third Party Upgrade to HdrHistogram 2.1.12
In-Reply-To: <otO8nTIinvc71vWiTAhXFBT9oovfgFDWFWwnXeLvIuU=.c782c9d5-49b0-4dc2-a512-711cd92c62fa@github.com>
References: <otO8nTIinvc71vWiTAhXFBT9oovfgFDWFWwnXeLvIuU=.c782c9d5-49b0-4dc2-a512-711cd92c62fa@github.com>
Message-ID: <PT8xIZBGTvDwtlae5_oWTQaiAWM0piTTOd-uyuFRzFA=.8132698b-a1e5-409a-a2bb-2c94e1ef37b8@github.com>

On Mon, 19 Oct 2020 20:15:20 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> As part of this enhancement, the third party HdrHistogram is upgraded from 2.1.11 to 2.1.12 (latest).
> 
> Please review the change.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/134

From schaturvedi at openjdk.java.net  Tue Oct 20 20:26:09 2020
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Tue, 20 Oct 2020 20:26:09 GMT
Subject: Integrated: 6911: Third Party Upgrade to HdrHistogram 2.1.12
In-Reply-To: <otO8nTIinvc71vWiTAhXFBT9oovfgFDWFWwnXeLvIuU=.c782c9d5-49b0-4dc2-a512-711cd92c62fa@github.com>
References: <otO8nTIinvc71vWiTAhXFBT9oovfgFDWFWwnXeLvIuU=.c782c9d5-49b0-4dc2-a512-711cd92c62fa@github.com>
Message-ID: <AZKltSNiGxk21PyIOIfSLXKGEe_Wio_Aa7IiQOhzgJk=.42c36c53-44f2-4183-ba3d-319da20f67bd@github.com>

On Mon, 19 Oct 2020 20:15:20 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> As part of this enhancement, the third party HdrHistogram is upgraded from 2.1.11 to 2.1.12 (latest).
> 
> Please review the change.

This pull request has now been integrated.

Changeset: 45449e95
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/45449e95
Stats:     5 lines in 5 files changed: 0 ins; 0 del; 5 mod

6911: Third Party Upgrade to HdrHistogram 2.1.12

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/134

From mwengner at openjdk.java.net  Tue Oct 20 20:32:08 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Tue, 20 Oct 2020 20:32:08 GMT
Subject: Integrated: 6542: Improve calls to render in the flame view
In-Reply-To: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
References: <lXqA88fkDCQfDqQALWxXAMcpiqU4CrOc0dgt_G5Nqww=.2ff12022-c30a-453a-acd0-cf48df91b0bb@github.com>
Message-ID: <VXvovKNV0HmjSxuqm2W4QrO5rNjKyzu4iPBfTysmTIg=.d73f4983-99a0-4411-b50e-b8f9db8433c0@github.com>

On Sun, 18 Oct 2020 20:43:56 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

> the Flameview shift fix during a fast scrolling over the selections: https://bugs.openjdk.java.net/browse/JMC-6542

This pull request has now been integrated.

Changeset: 16b3685d
Author:    Miroslav Wengner <mwengner at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/16b3685d
Stats:     110 lines in 1 file changed: 56 ins; 31 del; 23 mod

6542: Improve calls to render in the flame view

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/133

From mwengner at openjdk.java.net  Tue Oct 20 22:30:21 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Tue, 20 Oct 2020 22:30:21 GMT
Subject: RFR: 6669: FlameGraphView tree calculation should (probably) be
 interruptable
Message-ID: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>

fix to bug: https://bugs.openjdk.java.net/browse/JMC-6669

-------------

Commit messages:
 - 6669: spotless needs
 - 6669: model calculation cancelation

Changes: https://git.openjdk.java.net/jmc/pull/135/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=135&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6669
  Stats: 25 lines in 1 file changed: 12 ins; 2 del; 11 mod
  Patch: https://git.openjdk.java.net/jmc/pull/135.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/135/head:pull/135

PR: https://git.openjdk.java.net/jmc/pull/135

From reinhapa at openjdk.java.net  Wed Oct 21 05:51:13 2020
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Wed, 21 Oct 2020 05:51:13 GMT
Subject: RFR: 6944: build.sh does not correctly run UI tests due to not
 running p2 site
Message-ID: <e4AX1VS9iOoeFmdHUvx-6vYchwX0N8AIPKMkj1CrsCg=.df07949f-d661-4cfd-a35c-f45ae3b7dc3c@github.com>

- calculate BASEDIR only once
- moved p2site (jetty) startup to separate method

Signed-off-by: Patrick Reinhart <patrick at reini.net>

-------------

Commit messages:
 - 6944: moved p2site (jetty) startup to separate method

Changes: https://git.openjdk.java.net/jmc/pull/136/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=136&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6944
  Stats: 90 lines in 1 file changed: 46 ins; 42 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/136.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/136/head:pull/136

PR: https://git.openjdk.java.net/jmc/pull/136

From hirt at openjdk.java.net  Wed Oct 21 11:55:12 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 21 Oct 2020 11:55:12 GMT
Subject: RFR: 6669: FlameGraphView tree calculation should (probably) be
 interruptable
In-Reply-To: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
References: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
Message-ID: <Y8z9ZERbDPBpsilR9-z3Pn8XQ9PwutP9nIF-exjDfD8=.e5956f9f-8aa3-403a-bb27-81c077fc6ca0@github.com>

On Tue, 20 Oct 2020 22:26:05 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

> fix to bug: https://bugs.openjdk.java.net/browse/JMC-6669

Changes requested by hirt (Lead).

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 306:

> 304: 			}
> 305: 			TraceNode traceNode = TraceTreeUtils.createTree(root, model);
> 306: 			String jsonModel = view.toJSonModel(traceNode, isInvalid).toString();

Java is pass by value. You'll need to pass a reference to this (the ModelRebuildCallable) and query that for isInvalid(), otherwise you'll only have the value at the time of the invocation passed around.

-------------

PR: https://git.openjdk.java.net/jmc/pull/135

From mwengner at openjdk.java.net  Wed Oct 21 13:27:13 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 21 Oct 2020 13:27:13 GMT
Subject: RFR: 6669: FlameGraphView tree calculation should (probably) be
 interruptable
In-Reply-To: <Y8z9ZERbDPBpsilR9-z3Pn8XQ9PwutP9nIF-exjDfD8=.e5956f9f-8aa3-403a-bb27-81c077fc6ca0@github.com>
References: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
 <Y8z9ZERbDPBpsilR9-z3Pn8XQ9PwutP9nIF-exjDfD8=.e5956f9f-8aa3-403a-bb27-81c077fc6ca0@github.com>
Message-ID: <6pszmdASrV00u1HwTHXjpuGoFOz0PVUO8aIJeCUrYUE=.fc251b90-cf0c-427b-9399-250a4a8a1342@github.com>

On Wed, 21 Oct 2020 11:52:24 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> fix to bug: https://bugs.openjdk.java.net/browse/JMC-6669
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 306:
> 
>> 304: 			}
>> 305: 			TraceNode traceNode = TraceTreeUtils.createTree(root, model);
>> 306: 			String jsonModel = view.toJSonModel(traceNode, isInvalid).toString();
> 
> Java is pass by value. You'll need to pass a reference to this (the ModelRebuildCallable) and query that for isInvalid(), otherwise you'll only have the value at the time of the invocation passed around.

Correct! all object references are passed by value... should wait till morning to not overlook it.

-------------

PR: https://git.openjdk.java.net/jmc/pull/135

From mwengner at openjdk.java.net  Wed Oct 21 13:49:25 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 21 Oct 2020 13:49:25 GMT
Subject: RFR: 6669: FlameGraphView tree calculation should (probably) be
 interruptable [v2]
In-Reply-To: <6pszmdASrV00u1HwTHXjpuGoFOz0PVUO8aIJeCUrYUE=.fc251b90-cf0c-427b-9399-250a4a8a1342@github.com>
References: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
 <Y8z9ZERbDPBpsilR9-z3Pn8XQ9PwutP9nIF-exjDfD8=.e5956f9f-8aa3-403a-bb27-81c077fc6ca0@github.com>
 <6pszmdASrV00u1HwTHXjpuGoFOz0PVUO8aIJeCUrYUE=.fc251b90-cf0c-427b-9399-250a4a8a1342@github.com>
Message-ID: <T0riw-YMpSoD4dFNbAaPcsZxukjFc4ddlAG8w8MmKcQ=.bf5e2821-0997-40ed-9f67-3d089132c091@github.com>

On Wed, 21 Oct 2020 13:24:43 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 306:
>> 
>>> 304: 			}
>>> 305: 			TraceNode traceNode = TraceTreeUtils.createTree(root, model);
>>> 306: 			String jsonModel = view.toJSonModel(traceNode, isInvalid).toString();
>> 
>> Java is pass by value. You'll need to pass a reference to this (the ModelRebuildCallable) and query that for isInvalid(), otherwise you'll only have the value at the time of the invocation passed around.
>
> Correct! all object references are passed by value... should wait till morning to not overlook it.

corrected!

-------------

PR: https://git.openjdk.java.net/jmc/pull/135

From mwengner at openjdk.java.net  Wed Oct 21 13:49:24 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 21 Oct 2020 13:49:24 GMT
Subject: RFR: 6669: FlameGraphView tree calculation should (probably) be
 interruptable [v2]
In-Reply-To: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
References: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
Message-ID: <rkmG3XeM7cLrwxVXswZ_HqGvJl53a_XXRsNLNKAOuqk=.4390fd6e-8c20-47d3-987b-91b3cab1f839@github.com>

> fix to bug: https://bugs.openjdk.java.net/browse/JMC-6669

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6669: correction

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/135/files
  - new: https://git.openjdk.java.net/jmc/pull/135/files/1bd70bee..be5fc13d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=135&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=135&range=00-01

  Stats: 9 lines in 1 file changed: 0 ins; 1 del; 8 mod
  Patch: https://git.openjdk.java.net/jmc/pull/135.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/135/head:pull/135

PR: https://git.openjdk.java.net/jmc/pull/135

From hirt at openjdk.java.net  Wed Oct 21 14:14:13 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 21 Oct 2020 14:14:13 GMT
Subject: RFR: 6669: FlameGraphView tree calculation should (probably) be
 interruptable [v2]
In-Reply-To: <rkmG3XeM7cLrwxVXswZ_HqGvJl53a_XXRsNLNKAOuqk=.4390fd6e-8c20-47d3-987b-91b3cab1f839@github.com>
References: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
 <rkmG3XeM7cLrwxVXswZ_HqGvJl53a_XXRsNLNKAOuqk=.4390fd6e-8c20-47d3-987b-91b3cab1f839@github.com>
Message-ID: <ATBqz4Wp1s09ND3_w5KoNWGMe-gZMnulAxZfpFB4qvY=.a913787a-9b0f-4879-83e3-e93b3ce451f1@github.com>

On Wed, 21 Oct 2020 13:49:24 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> fix to bug: https://bugs.openjdk.java.net/browse/JMC-6669
>
> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6669: correction

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 282:

> 280: 	}
> 281: 
> 282: 	private static class ModelRebuildCallable implements Callable<Void> {

Does this really have to be callable? Would clean up the code if not.

-------------

PR: https://git.openjdk.java.net/jmc/pull/135

From ghb at openjdk.java.net  Wed Oct 21 16:40:14 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Wed, 21 Oct 2020 16:40:14 GMT
Subject: RFR: 6913: Add daemon thread information to the console threads
 view [v3]
In-Reply-To: <ei1SKv0P9WNgHWhcGnxZ4rQ1wR9BOkrAJTpFdIULIlw=.69826cf1-cb65-444f-bfc8-8d909f13d22d@github.com>
References: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
 <ei1SKv0P9WNgHWhcGnxZ4rQ1wR9BOkrAJTpFdIULIlw=.69826cf1-cb65-444f-bfc8-8d909f13d22d@github.com>
Message-ID: <d7TCAyrRVppYSIQofHQlDZ3FoejqYqnm14Y7_40-7fk=.0e3d04d8-e1c0-4619-86b8-64832e40a3a5@github.com>

On Mon, 19 Oct 2020 18:12:20 GMT, Jan S. <github.com+924885+jpstotz at openjdk.org> wrote:

>> I had an Java application which did not exit because of a non-daemon thread still running. Therefore I added a column to the treads view that displays if a thread is a daemon thread or not.
>> 
>> oca: has been signed on 2019-01-17 (got positive response from Dalibor Topic on 2019-01-23).
>
> Jan S. has updated the pull request incrementally with one additional commit since the last revision:
> 
>   message text corrected as requested

Looks good to me

-------------

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/110

From hirt at openjdk.java.net  Wed Oct 21 16:48:10 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 21 Oct 2020 16:48:10 GMT
Subject: RFR: 6913: Add daemon thread information to the console threads
 view [v3]
In-Reply-To: <d7TCAyrRVppYSIQofHQlDZ3FoejqYqnm14Y7_40-7fk=.0e3d04d8-e1c0-4619-86b8-64832e40a3a5@github.com>
References: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
 <ei1SKv0P9WNgHWhcGnxZ4rQ1wR9BOkrAJTpFdIULIlw=.69826cf1-cb65-444f-bfc8-8d909f13d22d@github.com>
 <d7TCAyrRVppYSIQofHQlDZ3FoejqYqnm14Y7_40-7fk=.0e3d04d8-e1c0-4619-86b8-64832e40a3a5@github.com>
Message-ID: <I97jmMZvJI5BnZyOYPnw1yVDJlhsZQEFWqOsx7nU7hc=.e6dd1af1-01e3-4d3c-8998-40ecc55cc0ce@github.com>

On Wed, 21 Oct 2020 16:36:10 GMT, Guru Hb <ghb at openjdk.org> wrote:

>> Jan S. has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   message text corrected as requested
>
> Looks good to me

@jpstotz - you can now type /integrate in a new message to integrate the changes. Thanks for your contribution!

-------------

PR: https://git.openjdk.java.net/jmc/pull/110

From hirt at openjdk.java.net  Wed Oct 21 16:49:09 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 21 Oct 2020 16:49:09 GMT
Subject: RFR: 6944: build.sh does not correctly run UI tests due to not
 running p2 site
In-Reply-To: <e4AX1VS9iOoeFmdHUvx-6vYchwX0N8AIPKMkj1CrsCg=.df07949f-d661-4cfd-a35c-f45ae3b7dc3c@github.com>
References: <e4AX1VS9iOoeFmdHUvx-6vYchwX0N8AIPKMkj1CrsCg=.df07949f-d661-4cfd-a35c-f45ae3b7dc3c@github.com>
Message-ID: <a9OGDNaiF7cPyh3xGBfGw8luru3CFNzk8hpCmoDNaw0=.0eae9a1e-c15f-4922-a25e-31d0cf168b23@github.com>

On Wed, 21 Oct 2020 05:47:43 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

> - calculate BASEDIR only once
> - moved p2site (jetty) startup to separate method
> 
> Signed-off-by: Patrick Reinhart <patrick at reini.net>

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/136

From mwengner at openjdk.java.net  Wed Oct 21 22:46:24 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 21 Oct 2020 22:46:24 GMT
Subject: RFR: 6669: FlameGraphView tree calculation should (probably) be
 interruptable [v3]
In-Reply-To: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
References: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
Message-ID: <n21ZQPxbBw9MYOxTrRvOERsGfVqM05KsOOxEFrTcJSM=.32e613b7-e771-4a8e-bf19-e82f6c11da75@github.com>

> fix to bug: https://bugs.openjdk.java.net/browse/JMC-6669

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6669: more executor threads,runnable, canceling threads, cleanup

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/135/files
  - new: https://git.openjdk.java.net/jmc/pull/135/files/be5fc13d..9b435a23

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=135&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=135&range=01-02

  Stats: 38 lines in 1 file changed: 9 ins; 8 del; 21 mod
  Patch: https://git.openjdk.java.net/jmc/pull/135.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/135/head:pull/135

PR: https://git.openjdk.java.net/jmc/pull/135

From mwengner at openjdk.java.net  Wed Oct 21 22:46:25 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 21 Oct 2020 22:46:25 GMT
Subject: RFR: 6669: FlameGraphView tree calculation should (probably) be
 interruptable [v2]
In-Reply-To: <ATBqz4Wp1s09ND3_w5KoNWGMe-gZMnulAxZfpFB4qvY=.a913787a-9b0f-4879-83e3-e93b3ce451f1@github.com>
References: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
 <rkmG3XeM7cLrwxVXswZ_HqGvJl53a_XXRsNLNKAOuqk=.4390fd6e-8c20-47d3-987b-91b3cab1f839@github.com>
 <ATBqz4Wp1s09ND3_w5KoNWGMe-gZMnulAxZfpFB4qvY=.a913787a-9b0f-4879-83e3-e93b3ce451f1@github.com>
Message-ID: <ei7GVi45WN--8CkztHyaHkAbZVKKZrvH-JNooRDW1Ho=.273cf95e-c872-410a-a7fb-6a2d0cb2e21d@github.com>

On Wed, 21 Oct 2020 14:11:18 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6669: correction
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 282:
> 
>> 280: 	}
>> 281: 
>> 282: 	private static class ModelRebuildCallable implements Callable<Void> {
> 
> Does this really have to be callable? Would clean up the code if not.

correct, removed callable -> runnable, more executor threads and additional cleanup

-------------

PR: https://git.openjdk.java.net/jmc/pull/135

From reinhapa at openjdk.java.net  Thu Oct 22 05:28:12 2020
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Thu, 22 Oct 2020 05:28:12 GMT
Subject: Integrated: 6944: build.sh does not correctly run UI tests due to not
 running p2 site
In-Reply-To: <e4AX1VS9iOoeFmdHUvx-6vYchwX0N8AIPKMkj1CrsCg=.df07949f-d661-4cfd-a35c-f45ae3b7dc3c@github.com>
References: <e4AX1VS9iOoeFmdHUvx-6vYchwX0N8AIPKMkj1CrsCg=.df07949f-d661-4cfd-a35c-f45ae3b7dc3c@github.com>
Message-ID: <2U69Z0oe2DLs6-lCkqFhiti0RRImTM84n7pcsLR8MHI=.97510eae-335d-4e77-879c-4889d489d8f3@github.com>

On Wed, 21 Oct 2020 05:47:43 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

> - calculate BASEDIR only once
> - moved p2site (jetty) startup to separate method
> 
> Signed-off-by: Patrick Reinhart <patrick at reini.net>

This pull request has now been integrated.

Changeset: e2e5171c
Author:    Patrick Reinhart <reinhapa at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/e2e5171c
Stats:     90 lines in 1 file changed: 46 ins; 42 del; 2 mod

6944: build.sh does not correctly run UI tests due to not running p2 site

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/136

From mwengner at openjdk.java.net  Thu Oct 22 07:30:25 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Thu, 22 Oct 2020 07:30:25 GMT
Subject: RFR: 6669: FlameGraphView tree calculation should (probably) be
 interruptable [v4]
In-Reply-To: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
References: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
Message-ID: <8cN5ad8pEsFlBPdkh3WIcMsRV0xOjOOdNf4hs9Xcbmw=.9bef8a11-d9ae-4d76-bbb8-19916ab483c2@github.com>

> fix to bug: https://bugs.openjdk.java.net/browse/JMC-6669

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6669: spotless needs

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/135/files
  - new: https://git.openjdk.java.net/jmc/pull/135/files/9b435a23..afc1ea66

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=135&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=135&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/135.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/135/head:pull/135

PR: https://git.openjdk.java.net/jmc/pull/135

From mwengner at openjdk.java.net  Thu Oct 22 08:07:21 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Thu, 22 Oct 2020 08:07:21 GMT
Subject: RFR: 6669: FlameGraphView tree calculation should (probably) be
 interruptable [v5]
In-Reply-To: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
References: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
Message-ID: <-Os_OpyHjuudTzfAU_3r3g3ypEWsMwv4ZfbGGFgIRQ4=.a571dc2e-93d3-40ee-934d-711779b3fa6a@github.com>

> fix to bug: https://bugs.openjdk.java.net/browse/JMC-6669

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6669: correction

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/135/files
  - new: https://git.openjdk.java.net/jmc/pull/135/files/afc1ea66..a9bcda0e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=135&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=135&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/135.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/135/head:pull/135

PR: https://git.openjdk.java.net/jmc/pull/135

From hirt at openjdk.java.net  Fri Oct 23 12:11:38 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 23 Oct 2020 12:11:38 GMT
Subject: RFR: 6669: FlameGraphView tree calculation should (probably) be
 interruptable [v5]
In-Reply-To: <-Os_OpyHjuudTzfAU_3r3g3ypEWsMwv4ZfbGGFgIRQ4=.a571dc2e-93d3-40ee-934d-711779b3fa6a@github.com>
References: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
 <-Os_OpyHjuudTzfAU_3r3g3ypEWsMwv4ZfbGGFgIRQ4=.a571dc2e-93d3-40ee-934d-711779b3fa6a@github.com>
Message-ID: <zsRfKpt79Opro1Dy0rPx7nUbhe66dh6M4noHHmIBLnM=.35a1a821-c0e5-4af4-9edc-57d4c960d854@github.com>

On Thu, 22 Oct 2020 08:07:21 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> fix to bug: https://bugs.openjdk.java.net/browse/JMC-6669
>
> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6669: correction

Changes requested by hirt (Lead).

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 172:

> 170: 	private ModelState modelState = ModelState.NONE;
> 171: 	private int activeModelRebuildThread;
> 172: 	private List<ModelRebuildRunable> modelRebuildRunnableList = new ArrayList<ModelRebuildRunable>(

Runnable with two n's.

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 392:

> 390: 		if (!modelRebuildRunnableList.isEmpty()) {
> 391: 			modelRebuildRunnableList.get(activeModelRebuildThread).setInvalid();
> 392: 			activeModelRebuildThread = (activeModelRebuildThread + 1) % MODEL_EXECUTOR_THREADS_NUMBER;

You don't need to keep track of the threads, do you? You just need to keep track of the latest runnable. If you get another request, you simply invalidate the current one (and then you don't care what happens with it, it will worst case continue for a little bit, and then fizzle out), and update the latest to be the one from the newest request.

I.e. the only reason we're having multiple threads, it so that we allow the discovery of the cancellation to take a little bit of time, during which we can already get going with the next one. There is only ever one calculation that will have a result we care about, and that is the latest one submitted.

-------------

PR: https://git.openjdk.java.net/jmc/pull/135

From mwengner at openjdk.java.net  Fri Oct 23 14:25:51 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Fri, 23 Oct 2020 14:25:51 GMT
Subject: RFR: 6669: FlameGraphView tree calculation should (probably) be
 interruptable [v6]
In-Reply-To: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
References: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
Message-ID: <7oUxLG1FrgG42bG1s7_-9klIG8kEewDBofr1wYtVLhI=.04debac9-695e-42b6-9fe1-d358207dda65@github.com>

> fix to bug: https://bugs.openjdk.java.net/browse/JMC-6669

Miroslav Wengner has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:

 - 6669: typo correction
 - 6669: only last thread, cleaned
 - Merge branch 'master' of https://github.com/openjdk/jmc into bugfix/6669_FlameGraphView_tree_calculation_should_probably_be_interruptable
 - 6669: correction
 - 6669: spotless needs
 - 6669: more executor threads,runnable, canceling threads, cleanup
 - 6669: correction
 - 6669: spotless needs
 - 6669: model calculation cancelation

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/135/files
  - new: https://git.openjdk.java.net/jmc/pull/135/files/a9bcda0e..3bba252f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=135&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=135&range=04-05

  Stats: 106 lines in 2 files changed: 46 ins; 47 del; 13 mod
  Patch: https://git.openjdk.java.net/jmc/pull/135.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/135/head:pull/135

PR: https://git.openjdk.java.net/jmc/pull/135

From mwengner at openjdk.java.net  Fri Oct 23 14:25:52 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Fri, 23 Oct 2020 14:25:52 GMT
Subject: RFR: 6669: FlameGraphView tree calculation should (probably) be
 interruptable [v5]
In-Reply-To: <zsRfKpt79Opro1Dy0rPx7nUbhe66dh6M4noHHmIBLnM=.35a1a821-c0e5-4af4-9edc-57d4c960d854@github.com>
References: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
 <-Os_OpyHjuudTzfAU_3r3g3ypEWsMwv4ZfbGGFgIRQ4=.a571dc2e-93d3-40ee-934d-711779b3fa6a@github.com>
 <zsRfKpt79Opro1Dy0rPx7nUbhe66dh6M4noHHmIBLnM=.35a1a821-c0e5-4af4-9edc-57d4c960d854@github.com>
Message-ID: <Sxm62pQyN4ZFtpZ0V11TQgaNZp2vJH7qzFvg4XdPKoU=.df699763-3bb8-41fa-b136-ea08ff2296e2@github.com>

On Fri, 23 Oct 2020 12:08:33 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6669: correction
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 392:
> 
>> 390: 		if (!modelRebuildRunnableList.isEmpty()) {
>> 391: 			modelRebuildRunnableList.get(activeModelRebuildThread).setInvalid();
>> 392: 			activeModelRebuildThread = (activeModelRebuildThread + 1) % MODEL_EXECUTOR_THREADS_NUMBER;
> 
> You don't need to keep track of the threads, do you? You just need to keep track of the latest runnable. If you get another request, you simply invalidate the current one (and then you don't care what happens with it, it will worst case continue for a little bit, and then fizzle out), and update the latest to be the one from the newest request.
> 
> I.e. the only reason we're having multiple threads, it so that we allow the discovery of the cancellation to take a little bit of time, during which we can already get going with the next one. There is only ever one calculation that will have a result we care about, and that is the latest one submitted.

correct, we don't need a references as the only valid one is the last one. We have stages and only the last active sample set is displayed even when other threads end properly. The thread number is equal stages as during a tests it got the best UI experience working with large samples set.

> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 172:
> 
>> 170: 	private ModelState modelState = ModelState.NONE;
>> 171: 	private int activeModelRebuildThread;
>> 172: 	private List<ModelRebuildRunable> modelRebuildRunnableList = new ArrayList<ModelRebuildRunable>(
> 
> Runnable with two n's.

corrected!

-------------

PR: https://git.openjdk.java.net/jmc/pull/135

From hirt at openjdk.java.net  Sat Oct 24 16:35:35 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 24 Oct 2020 16:35:35 GMT
Subject: RFR: 6913: Add daemon thread information to the console threads
 view [v3]
In-Reply-To: <d7TCAyrRVppYSIQofHQlDZ3FoejqYqnm14Y7_40-7fk=.0e3d04d8-e1c0-4619-86b8-64832e40a3a5@github.com>
References: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
 <ei1SKv0P9WNgHWhcGnxZ4rQ1wR9BOkrAJTpFdIULIlw=.69826cf1-cb65-444f-bfc8-8d909f13d22d@github.com>
 <d7TCAyrRVppYSIQofHQlDZ3FoejqYqnm14Y7_40-7fk=.0e3d04d8-e1c0-4619-86b8-64832e40a3a5@github.com>
Message-ID: <6vJ5qAsv4rOw02rGoW92KQuTY-CUp-7HGSs4BjDBgjQ=.9d2d7d88-1ddf-4e2f-8de5-d1e29e68d224@github.com>

On Wed, 21 Oct 2020 16:36:10 GMT, Guru Hb <ghb at openjdk.org> wrote:

>> Jan S. has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   message text corrected as requested
>
> Looks good to me

@guruhb - you can sponsor now.

-------------

PR: https://git.openjdk.java.net/jmc/pull/110

From github.com+4610701+jpbempel at openjdk.java.net  Sun Oct 25 09:57:40 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sun, 25 Oct 2020 09:57:40 GMT
Subject: RFR: 5700: Improve file and socket IO rule result texts
Message-ID: <83NoPIo-O0JZZxKSyRjA4gijUiWMJ26rAC_1DYn7wsY=.9556d109-0a98-40ed-9a9c-ef8b30b3fa40@github.com>

Add new information along with longest event:
 - report the total and average pauses for the entire recording.
 - report the sum of all IO events for that file or host of the longest event
Add also some mock classes for IItemCollection with some mock events

-------------

Commit messages:
 - 5700: Improve file and socket IO rule result texts

Changes: https://git.openjdk.java.net/jmc/pull/138/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=138&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-5700
  Stats: 463 lines in 12 files changed: 444 ins; 0 del; 19 mod
  Patch: https://git.openjdk.java.net/jmc/pull/138.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/138/head:pull/138

PR: https://git.openjdk.java.net/jmc/pull/138

From github.com+4610701+jpbempel at openjdk.java.net  Sun Oct 25 10:36:44 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sun, 25 Oct 2020 10:36:44 GMT
Subject: RFR: 5700: Improve file and socket IO rule result texts [v2]
In-Reply-To: <83NoPIo-O0JZZxKSyRjA4gijUiWMJ26rAC_1DYn7wsY=.9556d109-0a98-40ed-9a9c-ef8b30b3fa40@github.com>
References: <83NoPIo-O0JZZxKSyRjA4gijUiWMJ26rAC_1DYn7wsY=.9556d109-0a98-40ed-9a9c-ef8b30b3fa40@github.com>
Message-ID: <qNhzLOjrApKWGDQrym1z4SksmpGnlGbbaVdsuczTnMY=.8d864f19-7867-4a6f-bca2-45efb424d252@github.com>

> Add new information along with longest event:
>  - report the total and average pauses for the entire recording.
>  - report the sum of all IO events for that file or host of the longest event
> Add also some mock classes for IItemCollection with some mock events

Jean-Philippe Bempel has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  5700: Improve file and socket IO rule result texts
  
  Add new information along with longest event:
   - report the total and average pauses for the entire recording.
   - report the sum of all IO events for that file or host of the longest event
  Add also some mock classes for IItemCollection with some mock events

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/138/files
  - new: https://git.openjdk.java.net/jmc/pull/138/files/05d78da5..e57be671

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=138&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=138&range=00-01

  Stats: 236 lines in 8 files changed: 231 ins; 0 del; 5 mod
  Patch: https://git.openjdk.java.net/jmc/pull/138.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/138/head:pull/138

PR: https://git.openjdk.java.net/jmc/pull/138

From hirt at openjdk.java.net  Sun Oct 25 19:01:35 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 25 Oct 2020 19:01:35 GMT
Subject: RFR: 5700: Improve file and socket IO rule result texts [v2]
In-Reply-To: <qNhzLOjrApKWGDQrym1z4SksmpGnlGbbaVdsuczTnMY=.8d864f19-7867-4a6f-bca2-45efb424d252@github.com>
References: <83NoPIo-O0JZZxKSyRjA4gijUiWMJ26rAC_1DYn7wsY=.9556d109-0a98-40ed-9a9c-ef8b30b3fa40@github.com>
 <qNhzLOjrApKWGDQrym1z4SksmpGnlGbbaVdsuczTnMY=.8d864f19-7867-4a6f-bca2-45efb424d252@github.com>
Message-ID: <2NaQYpBE6BOARA4ZN6hG9f_3bWFQYlHiLL6UU2-mmq8=.0c0246bc-f00e-4b79-8f50-4d0a77182738@github.com>

On Sun, 25 Oct 2020 10:36:44 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> Add new information along with longest event:
>>  - report the total and average pauses for the entire recording.
>>  - report the sum of all IO events for that file or host of the longest event
>> Add also some mock classes for IItemCollection with some mock events
>
> Jean-Philippe Bempel has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 244:

> 242: FileReadRuleFactory_TEXT_WARN=There are long file read pauses in this recording (the longest is {0}).
> 243: # {0} is a time period, {1} is a time stamp, {2} is a size in bytes
> 244: FileReadRuleFactory_TEXT_WARN_LONG=The longest recorded file read took {0} to read {2} from {1}. Average time of all IO of the recording: {3}. Total time of all IO of the recording: {4}. Total time of all IO of the file {1}: {5}.

Maybe good to add "recorded". Average time of the recorded I/O, Total time of the recorded I/O, Total time of the recorded I/O for the file. May help emphasize that it is whatever was recorded that we're calculating over. "All I/O" my prime people to think that all I/O would be recorded, which is usually not true - most I/O related events will normally be thresholded to only record outliers.

-------------

PR: https://git.openjdk.java.net/jmc/pull/138

From hirt at openjdk.java.net  Sun Oct 25 19:31:37 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 25 Oct 2020 19:31:37 GMT
Subject: RFR: 6669: FlameGraphView tree calculation should (probably) be
 interruptable [v6]
In-Reply-To: <7oUxLG1FrgG42bG1s7_-9klIG8kEewDBofr1wYtVLhI=.04debac9-695e-42b6-9fe1-d358207dda65@github.com>
References: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
 <7oUxLG1FrgG42bG1s7_-9klIG8kEewDBofr1wYtVLhI=.04debac9-695e-42b6-9fe1-d358207dda65@github.com>
Message-ID: <RkHbkBvMXF198P2nd3gp_19c_8X6NyokT5QUk2Gl-0k=.18948401-6e43-4c1c-93d0-58fb8433c007@github.com>

On Fri, 23 Oct 2020 14:25:51 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> fix to bug: https://bugs.openjdk.java.net/browse/JMC-6669
>
> Miroslav Wengner has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
> 
>  - 6669: typo correction
>  - 6669: only last thread, cleaned
>  - Merge branch 'master' of https://github.com/openjdk/jmc into bugfix/6669_FlameGraphView_tree_calculation_should_probably_be_interruptable
>  - 6669: correction
>  - 6669: spotless needs
>  - 6669: more executor threads,runnable, canceling threads, cleanup
>  - 6669: correction
>  - 6669: spotless needs
>  - 6669: model calculation cancelation

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 157:

> 155: 
> 156: 	private static final int MODEL_EXECUTOR_THREADS_NUMBER = 3;
> 157: 	private static final ExecutorService MODEL_EXECUTOR = Executors.newFixedThreadPool(MODEL_EXECUTOR_THREADS_NUMBER);

Perhaps add a thread factory to make it easier to interpret recordings?

	private static final ExecutorService MODEL_EXECUTOR = Executors.newFixedThreadPool(MODEL_EXECUTOR_THREADS_NUMBER, new ThreadFactory() {
		private ThreadGroup threadGroup = new ThreadGroup("FlameGraphModelCalculatorGroup");
		private AtomicInteger threadCounter = new AtomicInteger();
		@Override
		public Thread newThread(Runnable r) {
			Thread t = new Thread(threadGroup, r, "FlameGraphModelCalculator-" + threadCounter.getAndIncrement());
			t.setDaemon(true);
			return t;
		}
	});

-------------

PR: https://git.openjdk.java.net/jmc/pull/135

From mwengner at openjdk.java.net  Sun Oct 25 20:46:48 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Sun, 25 Oct 2020 20:46:48 GMT
Subject: RFR: 6669: FlameGraphView tree calculation should (probably) be
 interruptable [v7]
In-Reply-To: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
References: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
Message-ID: <K8Qi4c90-AxQxYi1cQB487GJKWFZaIgNvg-xCWDdbmk=.4742c6e4-c522-4907-bcde-f9eb87b264a1@github.com>

> fix to bug: https://bugs.openjdk.java.net/browse/JMC-6669

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6669: add thread factory

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/135/files
  - new: https://git.openjdk.java.net/jmc/pull/135/files/3bba252f..1c53cac3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=135&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=135&range=05-06

  Stats: 14 lines in 1 file changed: 13 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/135.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/135/head:pull/135

PR: https://git.openjdk.java.net/jmc/pull/135

From mwengner at openjdk.java.net  Sun Oct 25 20:46:50 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Sun, 25 Oct 2020 20:46:50 GMT
Subject: RFR: 6669: FlameGraphView tree calculation should (probably) be
 interruptable [v6]
In-Reply-To: <RkHbkBvMXF198P2nd3gp_19c_8X6NyokT5QUk2Gl-0k=.18948401-6e43-4c1c-93d0-58fb8433c007@github.com>
References: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
 <7oUxLG1FrgG42bG1s7_-9klIG8kEewDBofr1wYtVLhI=.04debac9-695e-42b6-9fe1-d358207dda65@github.com>
 <RkHbkBvMXF198P2nd3gp_19c_8X6NyokT5QUk2Gl-0k=.18948401-6e43-4c1c-93d0-58fb8433c007@github.com>
Message-ID: <M87X5chgZUw20dJ4b6TSDYm1aHAT_wJRbfBvgL0N0Dk=.bbefcce4-6cd4-4913-91bb-9bb877ecb5af@github.com>

On Sun, 25 Oct 2020 19:28:37 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - 6669: typo correction
>>  - 6669: only last thread, cleaned
>>  - Merge branch 'master' of https://github.com/openjdk/jmc into bugfix/6669_FlameGraphView_tree_calculation_should_probably_be_interruptable
>>  - 6669: correction
>>  - 6669: spotless needs
>>  - 6669: more executor threads,runnable, canceling threads, cleanup
>>  - 6669: correction
>>  - 6669: spotless needs
>>  - 6669: model calculation cancelation
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 157:
> 
>> 155: 
>> 156: 	private static final int MODEL_EXECUTOR_THREADS_NUMBER = 3;
>> 157: 	private static final ExecutorService MODEL_EXECUTOR = Executors.newFixedThreadPool(MODEL_EXECUTOR_THREADS_NUMBER);
> 
> Perhaps add a thread factory to make it easier to interpret recordings?
> 
> 	private static final ExecutorService MODEL_EXECUTOR = Executors.newFixedThreadPool(MODEL_EXECUTOR_THREADS_NUMBER, new ThreadFactory() {
> 		private ThreadGroup threadGroup = new ThreadGroup("FlameGraphModelCalculatorGroup");
> 		private AtomicInteger threadCounter = new AtomicInteger();
> 		@Override
> 		public Thread newThread(Runnable r) {
> 			Thread t = new Thread(threadGroup, r, "FlameGraphModelCalculator-" + threadCounter.getAndIncrement());
> 			t.setDaemon(true);
> 			return t;
> 		}
> 	});

yeap, It will look better in the threads list ->  added!

-------------

PR: https://git.openjdk.java.net/jmc/pull/135

From hirt at openjdk.java.net  Mon Oct 26 09:10:36 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 26 Oct 2020 09:10:36 GMT
Subject: RFR: 6669: FlameGraphView tree calculation should (probably) be
 interruptable [v7]
In-Reply-To: <K8Qi4c90-AxQxYi1cQB487GJKWFZaIgNvg-xCWDdbmk=.4742c6e4-c522-4907-bcde-f9eb87b264a1@github.com>
References: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
 <K8Qi4c90-AxQxYi1cQB487GJKWFZaIgNvg-xCWDdbmk=.4742c6e4-c522-4907-bcde-f9eb87b264a1@github.com>
Message-ID: <vN231HSCzznTkgULe8oo5twNtuoxCFExKkTOqUEgAPU=.0d8e4444-ed25-43ba-8738-a2496441d1a4@github.com>

On Sun, 25 Oct 2020 20:46:48 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> fix to bug: https://bugs.openjdk.java.net/browse/JMC-6669
>
> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6669: add thread factory

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/135

From mwengner at openjdk.java.net  Mon Oct 26 09:14:36 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 26 Oct 2020 09:14:36 GMT
Subject: Integrated: 6669: FlameGraphView tree calculation should (probably)
 be interruptable
In-Reply-To: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
References: <YG_sKzXwC54lVEBnXAfkOP7vv2dm4qpIsM5eQzOg6TA=.9f77af94-51d5-41d4-a8d8-fafe860f52a1@github.com>
Message-ID: <DLQOZfeXbk3dXTxital3wkL43Q4S_IRZMUIuc6fmGZQ=.1cf0ff32-80f4-4ad7-99be-efddb24f0e1d@github.com>

On Tue, 20 Oct 2020 22:26:05 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

> fix to bug: https://bugs.openjdk.java.net/browse/JMC-6669

This pull request has now been integrated.

Changeset: 94fd9ff4
Author:    Miroslav Wengner <mwengner at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/94fd9ff4
Stats:     61 lines in 1 file changed: 28 ins; 11 del; 22 mod

6669: FlameGraphView tree calculation should (probably) be interruptable

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/135

From mwengner at openjdk.java.net  Mon Oct 26 09:57:13 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 26 Oct 2020 09:57:13 GMT
Subject: RFR: 5067: Content assist uses too much screen area
Message-ID: <nM2neHXi4KRS-Hk_0YTtuNCAdyySRJi3klLp4ROlY-8=.35ca97d2-6466-4c0c-b95e-d0a1a7b3fc98@github.com>

bug fix: https://bugs.openjdk.java.net/browse/JMC-5067

-------------

Commit messages:
 - Merge branch 'master' of https://github.com/openjdk/jmc into bugfix/5067_Content_assist_uses_too_much_screen_area
 - 5067: popup text helper size corrected

Changes: https://git.openjdk.java.net/jmc/pull/139/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=139&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-5067
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/139.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/139/head:pull/139

PR: https://git.openjdk.java.net/jmc/pull/139

From hirt at openjdk.java.net  Mon Oct 26 10:50:06 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 26 Oct 2020 10:50:06 GMT
Subject: RFR: 5067: Content assist uses too much screen area
In-Reply-To: <nM2neHXi4KRS-Hk_0YTtuNCAdyySRJi3klLp4ROlY-8=.35ca97d2-6466-4c0c-b95e-d0a1a7b3fc98@github.com>
References: <nM2neHXi4KRS-Hk_0YTtuNCAdyySRJi3klLp4ROlY-8=.35ca97d2-6466-4c0c-b95e-d0a1a7b3fc98@github.com>
Message-ID: <jzOwDp1yilHxB5tKJck5J2v1eS4hBcB8TZ_MzUS6bmc=.1f2caf73-177a-4329-9622-1d93d0d914d7@github.com>

On Mon, 26 Oct 2020 09:54:04 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

> bug fix: https://bugs.openjdk.java.net/browse/JMC-5067

I think the idea here was to set the size to be exactly the size needed to encompass all the unit alternatives for the kind of quantity that's being edited.

Either that, or resizing as the space of prefixes is constrained as you type - though that would probably be very flickery, and likely not a great idea.

Unless someone has a better idea, I'll go ahead and accept this as is.

-------------

PR: https://git.openjdk.java.net/jmc/pull/139

From github.com+4610701+jpbempel at openjdk.java.net  Mon Oct 26 13:22:21 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Mon, 26 Oct 2020 13:22:21 GMT
Subject: RFR: 5700: Improve file and socket IO rule result texts [v3]
In-Reply-To: <83NoPIo-O0JZZxKSyRjA4gijUiWMJ26rAC_1DYn7wsY=.9556d109-0a98-40ed-9a9c-ef8b30b3fa40@github.com>
References: <83NoPIo-O0JZZxKSyRjA4gijUiWMJ26rAC_1DYn7wsY=.9556d109-0a98-40ed-9a9c-ef8b30b3fa40@github.com>
Message-ID: <Uv0JIwSurqSL_sQrv96lRn_N3RhQeUDMzsGhLAYOQpo=.21eb2560-5b9d-4014-92ed-55304c53423a@github.com>

> Add new information along with longest event:
>  - report the total and average pauses for the entire recording.
>  - report the sum of all IO events for that file or host of the longest event
> Add also some mock classes for IItemCollection with some mock events

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  fix messages

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/138/files
  - new: https://git.openjdk.java.net/jmc/pull/138/files/e57be671..2b2c7ef6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=138&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=138&range=01-02

  Stats: 9 lines in 4 files changed: 0 ins; 0 del; 9 mod
  Patch: https://git.openjdk.java.net/jmc/pull/138.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/138/head:pull/138

PR: https://git.openjdk.java.net/jmc/pull/138

From mwengner at openjdk.java.net  Mon Oct 26 13:30:20 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 26 Oct 2020 13:30:20 GMT
Subject: RFR: 5067: Content assist uses too much screen area
In-Reply-To: <jzOwDp1yilHxB5tKJck5J2v1eS4hBcB8TZ_MzUS6bmc=.1f2caf73-177a-4329-9622-1d93d0d914d7@github.com>
References: <nM2neHXi4KRS-Hk_0YTtuNCAdyySRJi3klLp4ROlY-8=.35ca97d2-6466-4c0c-b95e-d0a1a7b3fc98@github.com>
 <jzOwDp1yilHxB5tKJck5J2v1eS4hBcB8TZ_MzUS6bmc=.1f2caf73-177a-4329-9622-1d93d0d914d7@github.com>
Message-ID: <dD8GdfK55S--7C57pmbW31zHx4sQW4nwdEeqP3K8nMM=.6c837428-1fbe-4659-9c54-1ec077dab48a@github.com>

On Mon, 26 Oct 2020 10:47:57 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> bug fix: https://bugs.openjdk.java.net/browse/JMC-5067
>
> I think the idea here was to set the size to be exactly the size needed to encompass all the unit alternatives for the kind of quantity that's being edited.
> 
> Either that, or resizing as the space of prefixes is constrained as you type - though that would probably be very flickery, and likely not a great idea.
> 
> Unless someone has a better idea, I'll go ahead and accept this as is.

I took a look at it a bit more. Now it's dynamic, looks a bit nicer, my personal feeling

-------------

PR: https://git.openjdk.java.net/jmc/pull/139

From mwengner at openjdk.java.net  Mon Oct 26 13:30:19 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 26 Oct 2020 13:30:19 GMT
Subject: RFR: 5067: Content assist uses too much screen area [v2]
In-Reply-To: <nM2neHXi4KRS-Hk_0YTtuNCAdyySRJi3klLp4ROlY-8=.35ca97d2-6466-4c0c-b95e-d0a1a7b3fc98@github.com>
References: <nM2neHXi4KRS-Hk_0YTtuNCAdyySRJi3klLp4ROlY-8=.35ca97d2-6466-4c0c-b95e-d0a1a7b3fc98@github.com>
Message-ID: <8wsokga3bI7qT28JWjWBuXtUEnMo6aFZN4B5-YgOP88=.9391fe17-9425-4bd0-a97b-0636be0d173f@github.com>

> bug fix: https://bugs.openjdk.java.net/browse/JMC-5067

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  5067: dynamic popup

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/139/files
  - new: https://git.openjdk.java.net/jmc/pull/139/files/39cc48a5..de5d5495

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=139&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=139&range=00-01

  Stats: 19 lines in 1 file changed: 17 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/139.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/139/head:pull/139

PR: https://git.openjdk.java.net/jmc/pull/139

From mwengner at openjdk.java.net  Mon Oct 26 17:25:21 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 26 Oct 2020 17:25:21 GMT
Subject: RFR: 4819: Improved tooltips and context menus for Stack Trace View
Message-ID: <oT9V1zmEwwNtC4yCJ-Gwm291J7j_bSYUpF_cfxDhe6o=.a0580d08-30aa-4ca2-9f9d-83e94c3c5f60@github.com>

bug fix: https://bugs.openjdk.java.net/browse/JMC-4819 tooltips

I'd propose, if not created yet, to create a ticket according to the correct behaviour of Stacktrace when treeView is selected (enabled/disabled) and switching over branches with enabled/disabled "Layout Option -> Reduce Tree Depth". Also when the current setup us saved and JMC reopened.

-------------

Commit messages:
 - 4819: tooltip text corrections,  Disable : "Reduce Tree Depth" when not tree view selected

Changes: https://git.openjdk.java.net/jmc/pull/140/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=140&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-4819
  Stats: 22 lines in 6 files changed: 9 ins; 0 del; 13 mod
  Patch: https://git.openjdk.java.net/jmc/pull/140.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/140/head:pull/140

PR: https://git.openjdk.java.net/jmc/pull/140

From hirt at openjdk.java.net  Mon Oct 26 17:46:21 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 26 Oct 2020 17:46:21 GMT
Subject: RFR: 5067: Content assist uses too much screen area [v2]
In-Reply-To: <8wsokga3bI7qT28JWjWBuXtUEnMo6aFZN4B5-YgOP88=.9391fe17-9425-4bd0-a97b-0636be0d173f@github.com>
References: <nM2neHXi4KRS-Hk_0YTtuNCAdyySRJi3klLp4ROlY-8=.35ca97d2-6466-4c0c-b95e-d0a1a7b3fc98@github.com>
 <8wsokga3bI7qT28JWjWBuXtUEnMo6aFZN4B5-YgOP88=.9391fe17-9425-4bd0-a97b-0636be0d173f@github.com>
Message-ID: <IJmozSKgdp8-Cc8HblDIee_7SVJC8Fy737IZFmjBmFA=.3e8a9d7c-f18f-4f41-ab3f-b96c64dc0bc2@github.com>

On Mon, 26 Oct 2020 13:30:19 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> bug fix: https://bugs.openjdk.java.net/browse/JMC-5067
>
> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
> 
>   5067: dynamic popup

application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/QuantityKindProposal.java line 60:

> 58: 
> 59: public class QuantityKindProposal {
> 60: 	private static final int POPUP_ROW_HEIGHT = 15;

How can you know this would be the height? This is font-related, no?

-------------

PR: https://git.openjdk.java.net/jmc/pull/139

From hirt at openjdk.java.net  Mon Oct 26 17:51:19 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 26 Oct 2020 17:51:19 GMT
Subject: RFR: 5700: Improve file and socket IO rule result texts [v3]
In-Reply-To: <Uv0JIwSurqSL_sQrv96lRn_N3RhQeUDMzsGhLAYOQpo=.21eb2560-5b9d-4014-92ed-55304c53423a@github.com>
References: <83NoPIo-O0JZZxKSyRjA4gijUiWMJ26rAC_1DYn7wsY=.9556d109-0a98-40ed-9a9c-ef8b30b3fa40@github.com>
 <Uv0JIwSurqSL_sQrv96lRn_N3RhQeUDMzsGhLAYOQpo=.21eb2560-5b9d-4014-92ed-55304c53423a@github.com>
Message-ID: <qkAaxg6ZBgMexhUkYWArRQK7PBS0FXX6UGyjuZdOpiQ=.99b74228-62a5-4644-ae8f-dcce78c36244@github.com>

On Mon, 26 Oct 2020 13:22:21 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> Add new information along with longest event:
>>  - report the total and average pauses for the entire recording.
>>  - report the sum of all IO events for that file or host of the longest event
>> Add also some mock classes for IItemCollection with some mock events
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix messages

Changes requested by hirt (Lead).

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 254:

> 252: FileWriteRuleFactory_TEXT_WARN=There are long file write pauses in this recording (the longest is {0}).
> 253: # {0} is a time period, {1} is a time stamp, {2} is a size in bytes
> 254: FileWriteRuleFactory_TEXT_WARN_LONG=The longest recorded file write took {0} to write {2} to {1}. Average time of recorded IO: {3}. Total time of recoded IO: {4}. Total time of recoded IO for the file {1}: {5}.

Typos (x2). recoded->recorded

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 572:

> 570: SocketReadRuleFactory_TEXT_WARN=There are long socket read pauses in this recording (the longest is {0}).
> 571: # {0} is a time period, {1} is a host name, {2} is a size in bytes
> 572: SocketReadRuleFactory_TEXT_WARN_LONG=The longest recorded socket read took {0} to read {2} from the host at {1}. Average time of recorded IO: {3}. Total time of recoded IO: {4}. Total time of recoded IO for the host {1}: {5}.

Typos. recoded->recorded

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 585:

> 583: SocketWriteRuleFactory_TEXT_WARN=There are long socket write pauses in this recording (the longest is {0}).
> 584: # {0} is a time period, {1} is a host name, {2} is a size in bytes
> 585: SocketWriteRuleFactory_TEXT_WARN_LONG=The longest recorded socket write took {0} to write {2} to the host at {1}. Average time of recroded IO: {3}. Total time of recorded IO: {4}. Total time of recorded IO for the host {1}: {5}.

Typo. recroded->recorded

-------------

PR: https://git.openjdk.java.net/jmc/pull/138

From github.com+4610701+jpbempel at openjdk.java.net  Mon Oct 26 18:29:27 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Mon, 26 Oct 2020 18:29:27 GMT
Subject: RFR: 5700: Improve file and socket IO rule result texts [v4]
In-Reply-To: <83NoPIo-O0JZZxKSyRjA4gijUiWMJ26rAC_1DYn7wsY=.9556d109-0a98-40ed-9a9c-ef8b30b3fa40@github.com>
References: <83NoPIo-O0JZZxKSyRjA4gijUiWMJ26rAC_1DYn7wsY=.9556d109-0a98-40ed-9a9c-ef8b30b3fa40@github.com>
Message-ID: <f11RH5gsrXSAT0mDFvL2pos3Ybc7VmNvxu3y3AGElmw=.a3f3837e-c326-4f7f-9fcb-1d4b048b078a@github.com>

> Add new information along with longest event:
>  - report the total and average pauses for the entire recording.
>  - report the sum of all IO events for that file or host of the longest event
> Add also some mock classes for IItemCollection with some mock events

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  fix typos

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/138/files
  - new: https://git.openjdk.java.net/jmc/pull/138/files/2b2c7ef6..409e3407

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=138&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=138&range=02-03

  Stats: 7 lines in 4 files changed: 0 ins; 0 del; 7 mod
  Patch: https://git.openjdk.java.net/jmc/pull/138.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/138/head:pull/138

PR: https://git.openjdk.java.net/jmc/pull/138

From hirt at openjdk.java.net  Mon Oct 26 21:29:16 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 26 Oct 2020 21:29:16 GMT
Subject: RFR: 5700: Improve file and socket IO rule result texts [v4]
In-Reply-To: <f11RH5gsrXSAT0mDFvL2pos3Ybc7VmNvxu3y3AGElmw=.a3f3837e-c326-4f7f-9fcb-1d4b048b078a@github.com>
References: <83NoPIo-O0JZZxKSyRjA4gijUiWMJ26rAC_1DYn7wsY=.9556d109-0a98-40ed-9a9c-ef8b30b3fa40@github.com>
 <f11RH5gsrXSAT0mDFvL2pos3Ybc7VmNvxu3y3AGElmw=.a3f3837e-c326-4f7f-9fcb-1d4b048b078a@github.com>
Message-ID: <kyvTK78KrkA7cRjw5ez-rTPOrFBeY6vXdaXdyTvN_4k=.af42f79d-5481-4134-847b-b3caa68daa87@github.com>

On Mon, 26 Oct 2020 18:29:27 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> Add new information along with longest event:
>>  - report the total and average pauses for the entire recording.
>>  - report the sum of all IO events for that file or host of the longest event
>> Add also some mock classes for IItemCollection with some mock events
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix typos

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/138

From mwengner at openjdk.java.net  Mon Oct 26 21:50:15 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 26 Oct 2020 21:50:15 GMT
Subject: RFR: 5067: Content assist uses too much screen area [v2]
In-Reply-To: <IJmozSKgdp8-Cc8HblDIee_7SVJC8Fy737IZFmjBmFA=.3e8a9d7c-f18f-4f41-ab3f-b96c64dc0bc2@github.com>
References: <nM2neHXi4KRS-Hk_0YTtuNCAdyySRJi3klLp4ROlY-8=.35ca97d2-6466-4c0c-b95e-d0a1a7b3fc98@github.com>
 <8wsokga3bI7qT28JWjWBuXtUEnMo6aFZN4B5-YgOP88=.9391fe17-9425-4bd0-a97b-0636be0d173f@github.com>
 <IJmozSKgdp8-Cc8HblDIee_7SVJC8Fy737IZFmjBmFA=.3e8a9d7c-f18f-4f41-ab3f-b96c64dc0bc2@github.com>
Message-ID: <Wlb5ofAOCZBlU3m8-J0fqvKuoIzvs6_YJmXTb75CuYo=.35bd1b91-ae06-4541-b5cd-bb02aec0964c@github.com>

On Mon, 26 Oct 2020 17:43:31 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   5067: dynamic popup
>
> application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/QuantityKindProposal.java line 60:
> 
>> 58: 
>> 59: public class QuantityKindProposal {
>> 60: 	private static final int POPUP_ROW_HEIGHT = 15;
> 
> How can you know this would be the height? This is font-related, no?

it's used for calculating a popup width and height : adapter.setPopupSize(new Point(POPUP_MAX_WIDTH, popupHeight)); I've not find a way how to get a font size. So I've estimated nice fit for the current setup, as previously was hardcoded everything. Do you think the name is not so good ?

-------------

PR: https://git.openjdk.java.net/jmc/pull/139

From github.com+4610701+jpbempel at openjdk.java.net  Tue Oct 27 03:25:16 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Tue, 27 Oct 2020 03:25:16 GMT
Subject: Integrated: 5700: Improve file and socket IO rule result texts
In-Reply-To: <83NoPIo-O0JZZxKSyRjA4gijUiWMJ26rAC_1DYn7wsY=.9556d109-0a98-40ed-9a9c-ef8b30b3fa40@github.com>
References: <83NoPIo-O0JZZxKSyRjA4gijUiWMJ26rAC_1DYn7wsY=.9556d109-0a98-40ed-9a9c-ef8b30b3fa40@github.com>
Message-ID: <D45iS8BgdK9e6eQbJkyT-E73vJ_JwGCibzS111yUeRQ=.59659df2-6cef-4af6-9d27-c4893d8d6e1c@github.com>

On Sun, 25 Oct 2020 09:53:33 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> Add new information along with longest event:
>  - report the total and average pauses for the entire recording.
>  - report the sum of all IO events for that file or host of the longest event
> Add also some mock classes for IItemCollection with some mock events

This pull request has now been integrated.

Changeset: 69101e83
Author:    Jean-Philippe Bempel <jean-philippe at bempel.fr>
Committer: Guru Hb <ghb at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/69101e83
Stats:     695 lines in 13 files changed: 675 ins; 0 del; 20 mod

5700: Improve file and socket IO rule result texts

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/138

From github.com+924885+jpstotz at openjdk.java.net  Tue Oct 27 03:26:16 2020
From: github.com+924885+jpstotz at openjdk.java.net (Jan S.)
Date: Tue, 27 Oct 2020 03:26:16 GMT
Subject: Integrated: 6913: Add daemon thread information to the console
 threads view
In-Reply-To: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
References: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
Message-ID: <b8-2w6Pp15MNmzhsVpBwFi-K10UQRivIsjiocJngsL0=.2bff739d-3f70-40ea-9472-39bad7367251@github.com>

On Thu, 17 Sep 2020 11:15:57 GMT, Jan S. <github.com+924885+jpstotz at openjdk.org> wrote:

> I had an Java application which did not exit because of a non-daemon thread still running. Therefore I added a column to the treads view that displays if a thread is a daemon thread or not.
> 
> oca: has been signed on 2019-01-17 (got positive response from Dalibor Topic on 2019-01-23).

This pull request has now been integrated.

Changeset: 47e197f8
Author:    Jan Peter Stotz <jpstotz at gmx.de>
Committer: Guru Hb <ghb at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/47e197f8
Stats:     21 lines in 4 files changed: 20 ins; 0 del; 1 mod

6913: Add daemon thread information to the console threads view

Reviewed-by: aptmac, ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/110

From ghb at openjdk.java.net  Tue Oct 27 08:51:21 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Tue, 27 Oct 2020 08:51:21 GMT
Subject: RFR: 6951: [core] Missing license.txt in core artifacts
Message-ID: <WdY_tAdkeWI4Uqtfv-Y_X4Jt-Nd66iczqARTRlnQoG0=.4c33bdb8-74f7-4e5c-92ac-a08fcf74fc1e@github.com>

jmc core library (common, flightrecorder*, jdp, and its test) should contain license.txt in its respective jar.

-------------

Commit messages:
 - 6951: [core] Missing license.txt in core artifacts

Changes: https://git.openjdk.java.net/jmc/pull/141/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=141&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6951
  Stats: 26 lines in 2 files changed: 25 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/141.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/141/head:pull/141

PR: https://git.openjdk.java.net/jmc/pull/141

From hirt at openjdk.java.net  Tue Oct 27 11:53:14 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 27 Oct 2020 11:53:14 GMT
Subject: RFR: 6951: [core] Missing license.txt in core artifacts
In-Reply-To: <WdY_tAdkeWI4Uqtfv-Y_X4Jt-Nd66iczqARTRlnQoG0=.4c33bdb8-74f7-4e5c-92ac-a08fcf74fc1e@github.com>
References: <WdY_tAdkeWI4Uqtfv-Y_X4Jt-Nd66iczqARTRlnQoG0=.4c33bdb8-74f7-4e5c-92ac-a08fcf74fc1e@github.com>
Message-ID: <dU2SZaKTwL3YyRSFvrn_Rl5fYDXqPf97590J-7gX0QM=.e2bc2346-f050-4374-acb0-f6696a2d9402@github.com>

On Tue, 27 Oct 2020 08:46:37 GMT, Guru Hb <ghb at openjdk.org> wrote:

> jmc core library (common, flightrecorder*, jdp, and its test) should contain license.txt in its respective jar.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/141

From hirt at openjdk.java.net  Tue Oct 27 11:57:18 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 27 Oct 2020 11:57:18 GMT
Subject: RFR: 5067: Content assist uses too much screen area [v2]
In-Reply-To: <Wlb5ofAOCZBlU3m8-J0fqvKuoIzvs6_YJmXTb75CuYo=.35bd1b91-ae06-4541-b5cd-bb02aec0964c@github.com>
References: <nM2neHXi4KRS-Hk_0YTtuNCAdyySRJi3klLp4ROlY-8=.35ca97d2-6466-4c0c-b95e-d0a1a7b3fc98@github.com>
 <8wsokga3bI7qT28JWjWBuXtUEnMo6aFZN4B5-YgOP88=.9391fe17-9425-4bd0-a97b-0636be0d173f@github.com>
 <IJmozSKgdp8-Cc8HblDIee_7SVJC8Fy737IZFmjBmFA=.3e8a9d7c-f18f-4f41-ab3f-b96c64dc0bc2@github.com>
 <Wlb5ofAOCZBlU3m8-J0fqvKuoIzvs6_YJmXTb75CuYo=.35bd1b91-ae06-4541-b5cd-bb02aec0964c@github.com>
Message-ID: <0oIKUlLFFvkbHNkwv8vqTKx55yHR20yNtwkhonYgLOI=.168914e3-371d-4fe3-a978-e0e0457e9436@github.com>

On Mon, 26 Oct 2020 21:47:28 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/QuantityKindProposal.java line 60:
>> 
>>> 58: 
>>> 59: public class QuantityKindProposal {
>>> 60: 	private static final int POPUP_ROW_HEIGHT = 15;
>> 
>> How can you know this would be the height? This is font-related, no?
>
> it's used for calculating a popup width and height : adapter.setPopupSize(new Point(POPUP_MAX_WIDTH, popupHeight)); I've not find a way how to get a font size. So I've estimated nice fit for the current setup, as previously was hardcoded everything. Do you think the name is not so good ?

I think this is a pseudo-implementation that may just be confusing. Personally I'd prefer the previous fixed size solution - that one will be understandable to all users, no matter the font settings. This one runs the risk of feeling slightly off / buggy to users depending on the font settings.

-------------

PR: https://git.openjdk.java.net/jmc/pull/139

From ghb at openjdk.java.net  Tue Oct 27 12:07:19 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Tue, 27 Oct 2020 12:07:19 GMT
Subject: Integrated: 6951: [core] Missing license.txt in core artifacts
In-Reply-To: <WdY_tAdkeWI4Uqtfv-Y_X4Jt-Nd66iczqARTRlnQoG0=.4c33bdb8-74f7-4e5c-92ac-a08fcf74fc1e@github.com>
References: <WdY_tAdkeWI4Uqtfv-Y_X4Jt-Nd66iczqARTRlnQoG0=.4c33bdb8-74f7-4e5c-92ac-a08fcf74fc1e@github.com>
Message-ID: <FJDwtchBh6qn2_JTR0rWp1CEokZop_qYOlyyZ59Wvzw=.ea8a052b-b22a-467b-b36b-e95ccf294244@github.com>

On Tue, 27 Oct 2020 08:46:37 GMT, Guru Hb <ghb at openjdk.org> wrote:

> jmc core library (common, flightrecorder*, jdp, and its test) should contain license.txt in its respective jar.

This pull request has now been integrated.

Changeset: e2ea7611
Author:    Guru Hb <ghb at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/e2ea7611
Stats:     26 lines in 2 files changed: 25 ins; 0 del; 1 mod

6951: [core] Missing license.txt in core artifacts

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/141

From jmatsuoka at openjdk.java.net  Tue Oct 27 14:28:26 2020
From: jmatsuoka at openjdk.java.net (Joshua Matsuoka)
Date: Tue, 27 Oct 2020 14:28:26 GMT
Subject: RFR: 6895: Agent Instrumentation fails to emit events when the
 instrumented class has a different/custom ClassLoader
Message-ID: <PPkfZ_H1CgxEz4CJaiMC8eoLwNxzX0EC4ZC8ASbvKJs=.3f57e48d-2e7d-42e7-9346-527b4712f5b9@github.com>

Hi,

This PR addresses JMC-6895, which made it so that the agent instrumentation would silently fail and not emit events when a class being instrumented was loaded by a custom classloader and its' methods were reflectively invoked.

The following is the sequence of events that caused this bug:

- When the class was initially loaded by the AppClassLoader the agent instruments it as we'd expect
- When the class was later loaded by the custom classloader, that classloader's loadClass call chain would lead to the agent being called to transform again
-- Since the transform had already been done once it was marked as complete and would not do anything
-- When the code for the class was later run, it would not emit the events due to a ClassNotFoundException on the injected event classes as they were not visible to the custom classloader

This patch resolves this and makes sure instrumentation is done with the custom classloader and that the event classes are visible to it. I've also included an integration test replicating the behavior that caused the bug.

-------------

Commit messages:
 - Merge remote-tracking branch 'upstream/master'
 - 6895: Agent Instrumentation fails to emit events when the instrumented class has a different/custom classloader

Changes: https://git.openjdk.java.net/jmc/pull/142/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=142&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6895
  Stats: 236 lines in 5 files changed: 223 ins; 9 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/142.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/142/head:pull/142

PR: https://git.openjdk.java.net/jmc/pull/142

From hirt at openjdk.java.net  Tue Oct 27 14:39:18 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 27 Oct 2020 14:39:18 GMT
Subject: RFR: 6895: Agent Instrumentation fails to emit events when the
 instrumented class has a different/custom ClassLoader
In-Reply-To: <PPkfZ_H1CgxEz4CJaiMC8eoLwNxzX0EC4ZC8ASbvKJs=.3f57e48d-2e7d-42e7-9346-527b4712f5b9@github.com>
References: <PPkfZ_H1CgxEz4CJaiMC8eoLwNxzX0EC4ZC8ASbvKJs=.3f57e48d-2e7d-42e7-9346-527b4712f5b9@github.com>
Message-ID: <WuosqWamvhll_f3anHuRsITaQvVg793Xu5GMS1vYKOM=.3692725e-0ca8-4a82-a440-ed4470d91f52@github.com>

On Tue, 27 Oct 2020 14:22:58 GMT, Joshua Matsuoka <jmatsuoka at openjdk.org> wrote:

> Hi,
> 
> This PR addresses JMC-6895, which made it so that the agent instrumentation would silently fail and not emit events when a class being instrumented was loaded by a custom classloader and its' methods were reflectively invoked.
> 
> The following is the sequence of events that caused this bug:
> 
> - When the class was initially loaded by the AppClassLoader the agent instruments it as we'd expect
> - When the class was later loaded by the custom classloader, that classloader's loadClass call chain would lead to the agent being called to transform again
> -- Since the transform had already been done once it was marked as complete and would not do anything
> -- When the code for the class was later run, it would not emit the events due to a ClassNotFoundException on the injected event classes as they were not visible to the custom classloader
> 
> This patch resolves this and makes sure instrumentation is done with the custom classloader and that the event classes are visible to it. I've also included an integration test replicating the behavior that caused the bug.

Formatting errors. :) Please run mvn spotless:apply.

-------------

PR: https://git.openjdk.java.net/jmc/pull/142

From jmatsuoka at openjdk.java.net  Tue Oct 27 18:39:25 2020
From: jmatsuoka at openjdk.java.net (Joshua Matsuoka)
Date: Tue, 27 Oct 2020 18:39:25 GMT
Subject: RFR: 6895: Agent Instrumentation fails to emit events when the
 instrumented class has a different/custom ClassLoader [v2]
In-Reply-To: <PPkfZ_H1CgxEz4CJaiMC8eoLwNxzX0EC4ZC8ASbvKJs=.3f57e48d-2e7d-42e7-9346-527b4712f5b9@github.com>
References: <PPkfZ_H1CgxEz4CJaiMC8eoLwNxzX0EC4ZC8ASbvKJs=.3f57e48d-2e7d-42e7-9346-527b4712f5b9@github.com>
Message-ID: <jYZ1gMmBkGA8MOo32ePYSLEfQQr7rBArF6ri1u3NZe4=.dff4ec1f-60bf-4e53-87e6-600d1931d8c4@github.com>

> Hi,
> 
> This PR addresses JMC-6895, which made it so that the agent instrumentation would silently fail and not emit events when a class being instrumented was loaded by a custom classloader and its' methods were reflectively invoked.
> 
> The following is the sequence of events that caused this bug:
> 
> - When the class was initially loaded by the AppClassLoader the agent instruments it as we'd expect
> - When the class was later loaded by the custom classloader, that classloader's loadClass call chain would lead to the agent being called to transform again
> -- Since the transform had already been done once it was marked as complete and would not do anything
> -- When the code for the class was later run, it would not emit the events due to a ClassNotFoundException on the injected event classes as they were not visible to the custom classloader
> 
> This patch resolves this and makes sure instrumentation is done with the custom classloader and that the event classes are visible to it. I've also included an integration test replicating the behavior that caused the bug.

Joshua Matsuoka has updated the pull request incrementally with two additional commits since the last revision:

 - Fixing copyright header
 - Fixing formatting issues

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/142/files
  - new: https://git.openjdk.java.net/jmc/pull/142/files/06f15a98..76cfaa57

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=142&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=142&range=00-01

  Stats: 37 lines in 3 files changed: 2 ins; 12 del; 23 mod
  Patch: https://git.openjdk.java.net/jmc/pull/142.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/142/head:pull/142

PR: https://git.openjdk.java.net/jmc/pull/142

From mwengner at openjdk.java.net  Tue Oct 27 20:09:15 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Tue, 27 Oct 2020 20:09:15 GMT
Subject: RFR: 5067: Content assist uses too much screen area [v2]
In-Reply-To: <0oIKUlLFFvkbHNkwv8vqTKx55yHR20yNtwkhonYgLOI=.168914e3-371d-4fe3-a978-e0e0457e9436@github.com>
References: <nM2neHXi4KRS-Hk_0YTtuNCAdyySRJi3klLp4ROlY-8=.35ca97d2-6466-4c0c-b95e-d0a1a7b3fc98@github.com>
 <8wsokga3bI7qT28JWjWBuXtUEnMo6aFZN4B5-YgOP88=.9391fe17-9425-4bd0-a97b-0636be0d173f@github.com>
 <IJmozSKgdp8-Cc8HblDIee_7SVJC8Fy737IZFmjBmFA=.3e8a9d7c-f18f-4f41-ab3f-b96c64dc0bc2@github.com>
 <Wlb5ofAOCZBlU3m8-J0fqvKuoIzvs6_YJmXTb75CuYo=.35bd1b91-ae06-4541-b5cd-bb02aec0964c@github.com>
 <0oIKUlLFFvkbHNkwv8vqTKx55yHR20yNtwkhonYgLOI=.168914e3-371d-4fe3-a978-e0e0457e9436@github.com>
Message-ID: <4xKvMaf_qwEaSO0HSPRMdoauphsskxGGkuMi9j-9Js0=.a2453547-bd4c-48eb-814d-e6cff1d5ada4@github.com>

On Tue, 27 Oct 2020 11:54:16 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> it's used for calculating a popup width and height : adapter.setPopupSize(new Point(POPUP_MAX_WIDTH, popupHeight)); I've not find a way how to get a font size. So I've estimated nice fit for the current setup, as previously was hardcoded everything. Do you think the name is not so good ?
>
> I think this is a pseudo-implementation that may just be confusing. Personally I'd prefer the previous fixed size solution - that one will be understandable to all users, no matter the font settings. This one runs the risk of feeling slightly off / buggy to users depending on the font settings.

I think it's quite reasonable, as the benefit of having it kind of "dynamic" is minimal. I'd personally also prefer the fixed size. I'll change it.

-------------

PR: https://git.openjdk.java.net/jmc/pull/139

From mwengner at openjdk.java.net  Tue Oct 27 20:22:26 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Tue, 27 Oct 2020 20:22:26 GMT
Subject: RFR: 5067: Content assist uses too much screen area [v3]
In-Reply-To: <nM2neHXi4KRS-Hk_0YTtuNCAdyySRJi3klLp4ROlY-8=.35ca97d2-6466-4c0c-b95e-d0a1a7b3fc98@github.com>
References: <nM2neHXi4KRS-Hk_0YTtuNCAdyySRJi3klLp4ROlY-8=.35ca97d2-6466-4c0c-b95e-d0a1a7b3fc98@github.com>
Message-ID: <8Jiquk7ifSOF8vWVtZecJPN_d-GhHuTW4m1yJt_vBcg=.c4e1d329-a51e-416b-a705-ea6579eaeb5e@github.com>

> bug fix: https://bugs.openjdk.java.net/browse/JMC-5067

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  5067: fixed popup size

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/139/files
  - new: https://git.openjdk.java.net/jmc/pull/139/files/de5d5495..64ffa44e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=139&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=139&range=01-02

  Stats: 19 lines in 1 file changed: 1 ins; 16 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/139.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/139/head:pull/139

PR: https://git.openjdk.java.net/jmc/pull/139

From mwengner at openjdk.java.net  Tue Oct 27 20:22:27 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Tue, 27 Oct 2020 20:22:27 GMT
Subject: RFR: 5067: Content assist uses too much screen area [v2]
In-Reply-To: <4xKvMaf_qwEaSO0HSPRMdoauphsskxGGkuMi9j-9Js0=.a2453547-bd4c-48eb-814d-e6cff1d5ada4@github.com>
References: <nM2neHXi4KRS-Hk_0YTtuNCAdyySRJi3klLp4ROlY-8=.35ca97d2-6466-4c0c-b95e-d0a1a7b3fc98@github.com>
 <8wsokga3bI7qT28JWjWBuXtUEnMo6aFZN4B5-YgOP88=.9391fe17-9425-4bd0-a97b-0636be0d173f@github.com>
 <IJmozSKgdp8-Cc8HblDIee_7SVJC8Fy737IZFmjBmFA=.3e8a9d7c-f18f-4f41-ab3f-b96c64dc0bc2@github.com>
 <Wlb5ofAOCZBlU3m8-J0fqvKuoIzvs6_YJmXTb75CuYo=.35bd1b91-ae06-4541-b5cd-bb02aec0964c@github.com>
 <0oIKUlLFFvkbHNkwv8vqTKx55yHR20yNtwkhonYgLOI=.168914e3-371d-4fe3-a978-e0e0457e9436@github.com>
 <4xKvMaf_qwEaSO0HSPRMdoauphsskxGGkuMi9j-9Js0=.a2453547-bd4c-48eb-814d-e6cff1d5ada4@github.com>
Message-ID: <r62szwU0kgRa0gQnRCWU6LQLHWoi7jbDsxkDGcGax6Q=.1a2accf2-298b-4074-a417-1f0614259c4a@github.com>

On Tue, 27 Oct 2020 20:06:34 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> I think this is a pseudo-implementation that may just be confusing. Personally I'd prefer the previous fixed size solution - that one will be understandable to all users, no matter the font settings. This one runs the risk of feeling slightly off / buggy to users depending on the font settings.
>
> I think it's quite reasonable, as the benefit of having it kind of "dynamic" is minimal. I'd personally also prefer the fixed size. I'll change it.

corrected!

-------------

PR: https://git.openjdk.java.net/jmc/pull/139

From hirt at openjdk.java.net  Tue Oct 27 21:22:18 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 27 Oct 2020 21:22:18 GMT
Subject: RFR: 6895: Agent Instrumentation fails to emit events when the
 instrumented class has a different/custom ClassLoader [v2]
In-Reply-To: <jYZ1gMmBkGA8MOo32ePYSLEfQQr7rBArF6ri1u3NZe4=.dff4ec1f-60bf-4e53-87e6-600d1931d8c4@github.com>
References: <PPkfZ_H1CgxEz4CJaiMC8eoLwNxzX0EC4ZC8ASbvKJs=.3f57e48d-2e7d-42e7-9346-527b4712f5b9@github.com>
 <jYZ1gMmBkGA8MOo32ePYSLEfQQr7rBArF6ri1u3NZe4=.dff4ec1f-60bf-4e53-87e6-600d1931d8c4@github.com>
Message-ID: <7TuqcRqSimISbAUwJyQDokdCoDTvxdczltzYIEeUq68=.ed1f433c-9b4b-4a45-96ab-8a0018383c77@github.com>

On Tue, 27 Oct 2020 18:39:25 GMT, Joshua Matsuoka <jmatsuoka at openjdk.org> wrote:

>> Hi,
>> 
>> This PR addresses JMC-6895, which made it so that the agent instrumentation would silently fail and not emit events when a class being instrumented was loaded by a custom classloader and its' methods were reflectively invoked.
>> 
>> The following is the sequence of events that caused this bug:
>> 
>> - When the class was initially loaded by the AppClassLoader the agent instruments it as we'd expect
>> - When the class was later loaded by the custom classloader, that classloader's loadClass call chain would lead to the agent being called to transform again
>> -- Since the transform had already been done once it was marked as complete and would not do anything
>> -- When the code for the class was later run, it would not emit the events due to a ClassNotFoundException on the injected event classes as they were not visible to the custom classloader
>> 
>> This patch resolves this and makes sure instrumentation is done with the custom classloader and that the event classes are visible to it. I've also included an integration test replicating the behavior that caused the bug.
>
> Joshua Matsuoka has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fixing copyright header
>  - Fixing formatting issues

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/142

From hirt at openjdk.java.net  Tue Oct 27 21:28:17 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 27 Oct 2020 21:28:17 GMT
Subject: RFR: 5067: Content assist uses too much screen area [v3]
In-Reply-To: <8Jiquk7ifSOF8vWVtZecJPN_d-GhHuTW4m1yJt_vBcg=.c4e1d329-a51e-416b-a705-ea6579eaeb5e@github.com>
References: <nM2neHXi4KRS-Hk_0YTtuNCAdyySRJi3klLp4ROlY-8=.35ca97d2-6466-4c0c-b95e-d0a1a7b3fc98@github.com>
 <8Jiquk7ifSOF8vWVtZecJPN_d-GhHuTW4m1yJt_vBcg=.c4e1d329-a51e-416b-a705-ea6579eaeb5e@github.com>
Message-ID: <pAw2ZsVGHo02xJzJ6aiIPakug0atY-K1KvzqaQqzktE=.5ae19b7d-f68f-4823-b837-4693a44f756f@github.com>

On Tue, 27 Oct 2020 20:22:26 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> bug fix: https://bugs.openjdk.java.net/browse/JMC-5067
>
> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
> 
>   5067: fixed popup size

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/139

From mwengner at openjdk.java.net  Tue Oct 27 21:35:14 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Tue, 27 Oct 2020 21:35:14 GMT
Subject: Integrated: 5067: Content assist uses too much screen area
In-Reply-To: <nM2neHXi4KRS-Hk_0YTtuNCAdyySRJi3klLp4ROlY-8=.35ca97d2-6466-4c0c-b95e-d0a1a7b3fc98@github.com>
References: <nM2neHXi4KRS-Hk_0YTtuNCAdyySRJi3klLp4ROlY-8=.35ca97d2-6466-4c0c-b95e-d0a1a7b3fc98@github.com>
Message-ID: <jSBwvIxq0lF0n96nLuYCPZjnAZff3CBaiW0Qz9rWoQM=.320e3f5e-5ae7-436f-b991-0099225f7676@github.com>

On Mon, 26 Oct 2020 09:54:04 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

> bug fix: https://bugs.openjdk.java.net/browse/JMC-5067

This pull request has now been integrated.

Changeset: 0ab31535
Author:    Miroslav Wengner <mwengner at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/0ab31535
Stats:     2 lines in 1 file changed: 1 ins; 0 del; 1 mod

5067: Content assist uses too much screen area

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/139

From github.com+4610701+jpbempel at openjdk.java.net  Tue Oct 27 22:50:21 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Tue, 27 Oct 2020 22:50:21 GMT
Subject: RFR: 4454: Other JMC launched after this JMC is listed as
 "-XX:+UseG1GC" =?UTF-8?B?aeKApg==?=
Message-ID: <QiDAgz8otGyM5UoOfGSSMR801-k5Nlb4FEVI87Y_1tQ=.a0c05a7a-9a67-4bcc-a926-5828c645b2a8@github.com>

?n JVM Browser

Add startLocalManagement to force finishing th init of the attached JVM

-------------

Commit messages:
 - 4454: Other JMC launched after this JMC is listed as "-XX:+UseG1GC" in JVM Browser

Changes: https://git.openjdk.java.net/jmc/pull/143/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=143&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-4454
  Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/143.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/143/head:pull/143

PR: https://git.openjdk.java.net/jmc/pull/143

From github.com+76791+alblue at openjdk.java.net  Wed Oct 28 00:35:20 2020
From: github.com+76791+alblue at openjdk.java.net (Alex Blewitt)
Date: Wed, 28 Oct 2020 00:35:20 GMT
Subject: RFR: 6947: Allow executable name to show up in JPS
Message-ID: <pc1QfvkO5uRZZMMVyyS5Ly80-lwRjTRJOkipgdV6NLM=.92a409e6-f112-42ed-b8a8-121f6021dab7@github.com>

When executing `jps` to view running Java applications, the displayed name
comes from a `sun.java.command` property. This is usually the name of the
Main-Class when executing it with `java` directly, but Eclipse starts the JVM
by using the native calls which bypasses this setting.

By adding a property definition `sun.java.command=JMC` then the application
will show up appropriately in JPS.

-------------

Commit messages:
 - Allow executable name to show up in JPS

Changes: https://git.openjdk.java.net/jmc/pull/137/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=137&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6947
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/137.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/137/head:pull/137

PR: https://git.openjdk.java.net/jmc/pull/137

From hirt at openjdk.java.net  Wed Oct 28 00:35:20 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 28 Oct 2020 00:35:20 GMT
Subject: RFR: 6947: Allow executable name to show up in JPS
In-Reply-To: <pc1QfvkO5uRZZMMVyyS5Ly80-lwRjTRJOkipgdV6NLM=.92a409e6-f112-42ed-b8a8-121f6021dab7@github.com>
References: <pc1QfvkO5uRZZMMVyyS5Ly80-lwRjTRJOkipgdV6NLM=.92a409e6-f112-42ed-b8a8-121f6021dab7@github.com>
Message-ID: <T7NwUYq4IpypSmh0tfFGQWZNw3FvIvnL5wyvedM3meM=.dcd59bb4-9024-4485-b6d0-d43dfc59e55e@github.com>

On Wed, 21 Oct 2020 10:28:05 GMT, Alex Blewitt <github.com+76791+alblue at openjdk.org> wrote:

> When executing `jps` to view running Java applications, the displayed name
> comes from a `sun.java.command` property. This is usually the name of the
> Main-Class when executing it with `java` directly, but Eclipse starts the JVM
> by using the native calls which bypasses this setting.
> 
> By adding a property definition `sun.java.command=JMC` then the application
> will show up appropriately in JPS.

Hi @alblue! Simply follow [the instructions](https://www.oracle.com/technetwork/community/oca-486395.html) in the bot message above to get the OCA signed. :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/137

From hirt at openjdk.java.net  Wed Oct 28 08:45:15 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 28 Oct 2020 08:45:15 GMT
Subject: RFR: 6947: Allow executable name to show up in JPS
In-Reply-To: <pc1QfvkO5uRZZMMVyyS5Ly80-lwRjTRJOkipgdV6NLM=.92a409e6-f112-42ed-b8a8-121f6021dab7@github.com>
References: <pc1QfvkO5uRZZMMVyyS5Ly80-lwRjTRJOkipgdV6NLM=.92a409e6-f112-42ed-b8a8-121f6021dab7@github.com>
Message-ID: <f2pYGQIJC7r049MxvvMT1ex68ss7vAbHxd657uP-xac=.14b9e653-7b7b-41c6-aa1b-74ed4e42def2@github.com>

On Wed, 21 Oct 2020 10:28:05 GMT, Alex Blewitt <github.com+76791+alblue at openjdk.org> wrote:

> When executing `jps` to view running Java applications, the displayed name
> comes from a `sun.java.command` property. This is usually the name of the
> Main-Class when executing it with `java` directly, but Eclipse starts the JVM
> by using the native calls which bypasses this setting.
> 
> By adding a property definition `sun.java.command=JMC` then the application
> will show up appropriately in JPS.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/137

From hirt at openjdk.java.net  Wed Oct 28 09:27:16 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 28 Oct 2020 09:27:16 GMT
Subject: RFR: 4454: Other JMC launched after this JMC is listed as
 "-XX:+UseG1GC" in JVM Browser
In-Reply-To: <QiDAgz8otGyM5UoOfGSSMR801-k5Nlb4FEVI87Y_1tQ=.a0c05a7a-9a67-4bcc-a926-5828c645b2a8@github.com>
References: <QiDAgz8otGyM5UoOfGSSMR801-k5Nlb4FEVI87Y_1tQ=.a0c05a7a-9a67-4bcc-a926-5828c645b2a8@github.com>
Message-ID: <7FJcackEelbiZ6FWOhLwpzd0yfXNMEZEYU7LnaQJJBk=.9f315072-0f30-4229-a153-be757c79ed6d@github.com>

On Tue, 27 Oct 2020 22:46:46 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> Add startLocalManagement to force finishing th init of the attached JVM

application/org.openjdk.jmc.browser.attach/src/main/java/org/openjdk/jmc/browser/attach/LocalJVMToolkit.java line 377:

> 375: 						try {
> 376: 							try {
> 377: 								// try to force finish init the attached JVM

Would be great to add "JMC-4454:" here, so that people can go search for context if needed.

-------------

PR: https://git.openjdk.java.net/jmc/pull/143

From ghb at openjdk.java.net  Wed Oct 28 09:54:17 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Wed, 28 Oct 2020 09:54:17 GMT
Subject: RFR: 6364: Improvements to the Thread Graph [v5]
In-Reply-To: <_QTxCrm30KMOH44baW13yNvSDfBCDVXJvR8xkuaGCS0=.78b1765b-11cb-4045-acbd-e187c719a542@github.com>
References: <3b_EN291IWMTMl6vId_3HM3r9b2p0Bjxd9QYH5qgDO8=.50cc047a-4486-469a-a341-5908f78bb6df@github.com>
 <_QTxCrm30KMOH44baW13yNvSDfBCDVXJvR8xkuaGCS0=.78b1765b-11cb-4045-acbd-e187c719a542@github.com>
Message-ID: <tujPkmv4LB-WfU6lqwgvDg50IW-pvKJ9n8r-0hScocM=.adaa8bba-d4d6-4889-8e0b-397660dab340@github.com>

On Mon, 19 Oct 2020 21:15:19 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> This patch addresses JMC-6364 [[0]](https://bugs.openjdk.java.net/browse/JMC-6364), the epic for tracking Improvements to the JFR Thread Graph. This RFR is also a follow-up to an RFC [[1]](http://mail.openjdk.java.net/pipermail/jmc-dev/2019-October/001454.html) that was posted to the jmc-dev list and incorporates the feedback that was brought up during discussion.
>> 
>> The new design and features was imagined in collaboration with our UX team, and the implementation has been a joint effort between myself and Jessye (@jessyec-s) - we had been originally collaborating on a fork of the old (unofficial) JMC GitHub repo. I've folded all the commits down into one because the older commits were merged using PRs with a similar format (e.g., `jmc/pull/23`) to this repo, so to avoid accidental noise (sorry about that) on other PRs I've just folded them away. If anyone is interested in the individual commits that got to this point, I've kept them around in the old repo [[2]](https://github.com/aptmac/jmc-old/commits/jfr-threads-page).
>> 
>> This PR aims to improve the usability and functionality of the JFR Threads Page by extending and enhancing existing classes. In an attempt to not clutter this PR with lots of images and explanatory text, I've created a gist [[3]](https://gist.github.com/aptmac/61808c89bfcf1888080884fc8a61bd36) that provides information and images/gifs of the new components and intended functionality.
>> 
>> Gist: https://gist.github.com/aptmac/61808c89bfcf1888080884fc8a61bd36
>> 
>> Summary of changes:
>> - Introduction of canvases to display the thread names (left) and timeline (bottom)
>> - Scrolled composites to house the text and chart canvases, for vertical scrolling of the chart area
>> - Timeline canvas (bottom) is draggable for panning the chart
>> - Current threads table has been re-located to a popup table
>> - New filter bar (top) which alters the chart view based on time ranges and desired visible activity lanes
>> - New display bar (right) which houses the zoom mechanics
>> - New zoom pan component for easily navigating the chart
>> - Introduction of a colour palette to increase contrast between neighbouring activity lanes
>> - Controls to change the height of the thread lanes
>> - updated and new uitests
>> 
>> Before:
>> ![before](https://i.imgur.com/TNfGrtJ.png)
>> 
>> After:
>> ![after](https://user-images.githubusercontent.com/10425301/71993902-dfd93200-3205-11ea-8249-cc50409a7a9f.png)
>> 
>> Let me know if you have any questions about the design & functionality.
>> 
>> [0] https://bugs.openjdk.java.net/browse/JMC-6364
>> [1] http://mail.openjdk.java.net/pipermail/jmc-dev/2019-October/001454.html
>> [2] https://github.com/aptmac/jmc-old/commits/jfr-threads-page
>> [3] https://gist.github.com/aptmac/61808c89bfcf1888080884fc8a61bd36
>
> Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 26 commits:
> 
>  - fix threads topic for legacy page
>  - run mvn:spotless for uitests
>  - chore: cleanup string usage and image for overview mode button
>  - chore: update layouts in ThreadsPageUILayout and minor cleanup
>  - chore(windows): fix a couple of bugs that were inhibiting proper display on Windows
>  - chore: update the license headers to 2020 + include third party licenses for FontAwesome and PatternFly
>  - feat: improve re-sizing and resetting of lane heights
>  - fix: run spotless and fix spotbugs errors
>  - test: include tests for the chart and table hiding actions
>  - feat: replace popup table with foldable sashform
>    
>    While an interesting feature, trying to persist settings and selections from the FilterEditor and table within the former popup table was not a realistic feat. After demoing the threads page work at the latest bi-weekly JMC hangout meeting, it was noted that it'd be nice to be able to easily interact with the table and update selections and filters. Based on this information, this commit replaces the popup table with a foldable sashform using controls proposed in JMC-6386. This allows the user to quickly hide and unhide both the table or chart based on their workflow.
>  - ... and 16 more: https://git.openjdk.java.net/jmc/compare/ea1b02c3...ae16dcb5

FlavourSelector.java :
	a. Duplicate : resetButton.addListener(SWT.Selection, new Listener() { 
	b. CLean up / delete few commented lines
	c. removed "void enableSelection()" : removed local variable enableSelection = true 
	d. removed local variable : getSelectedFlavor()  

For some of the files i have made some nit and copyright year change and attaching the diff for the same. Do apply this diff and please rebase with latest change. I will complete the review post the new changes. 

[6364_28Oct2020.zip](https://github.com/openjdk/jmc/files/5450963/6364_28Oct2020.zip)

-------------

PR: https://git.openjdk.java.net/jmc/pull/27

From github.com+4610701+jpbempel at openjdk.java.net  Wed Oct 28 11:59:56 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Wed, 28 Oct 2020 11:59:56 GMT
Subject: RFR: 4454: Other JMC launched after this JMC is listed as
 "-XX:+UseG1GC" in JVM Browser [v2]
In-Reply-To: <QiDAgz8otGyM5UoOfGSSMR801-k5Nlb4FEVI87Y_1tQ=.a0c05a7a-9a67-4bcc-a926-5828c645b2a8@github.com>
References: <QiDAgz8otGyM5UoOfGSSMR801-k5Nlb4FEVI87Y_1tQ=.a0c05a7a-9a67-4bcc-a926-5828c645b2a8@github.com>
Message-ID: <Ce7u0Z2QH39jd4rHekdxAho5DhGNpvK7GPPug4slEwM=.c2556dfd-b022-4ac7-9456-345f68ccb40d@github.com>

> Add startLocalManagement to force finishing th init of the attached JVM

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  add JIRA issue

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/143/files
  - new: https://git.openjdk.java.net/jmc/pull/143/files/0f1f55ea..d6a7be8f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=143&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=143&range=00-01

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/143.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/143/head:pull/143

PR: https://git.openjdk.java.net/jmc/pull/143

From jmatsuoka at openjdk.java.net  Wed Oct 28 16:24:52 2020
From: jmatsuoka at openjdk.java.net (Joshua Matsuoka)
Date: Wed, 28 Oct 2020 16:24:52 GMT
Subject: git: openjdk/jmc: 6895: Agent Instrumentation fails to emit events
 when the instrumented class has a different/custom ClassLoader
Message-ID: <b518c30e-c23a-4593-9bf8-2ad91252ff90@openjdk.org>

Changeset: 31619d6d
Author:    Joshua Matsuoka <jmatsuoka at openjdk.org>
Date:      2020-10-28 16:24:10 +0000
URL:       https://git.openjdk.java.net/jmc/commit/31619d6d

6895: Agent Instrumentation fails to emit events when the instrumented class has a different/custom ClassLoader

Reviewed-by: hirt

! agent/pom.xml
! agent/src/main/java/org/openjdk/jmc/agent/Transformer.java
! agent/src/main/java/org/openjdk/jmc/agent/jfrnext/impl/JFRNextClassVisitor.java
+ agent/src/test/java/org/openjdk/jmc/agent/test/TestCustomClassloader.java
+ agent/src/test/resources/org/openjdk/jmc/agent/test/jfrprobes_simple_2.xml


From jmatsuoka at openjdk.java.net  Wed Oct 28 16:27:42 2020
From: jmatsuoka at openjdk.java.net (Joshua Matsuoka)
Date: Wed, 28 Oct 2020 16:27:42 GMT
Subject: Integrated: 6895: Agent Instrumentation fails to emit events when the
 instrumented class has a different/custom ClassLoader
In-Reply-To: <PPkfZ_H1CgxEz4CJaiMC8eoLwNxzX0EC4ZC8ASbvKJs=.3f57e48d-2e7d-42e7-9346-527b4712f5b9@github.com>
References: <PPkfZ_H1CgxEz4CJaiMC8eoLwNxzX0EC4ZC8ASbvKJs=.3f57e48d-2e7d-42e7-9346-527b4712f5b9@github.com>
Message-ID: <9ktwWPo817yKHDg-f4FBp-431EtTghzl_GxoZUfSGeg=.4fa5fd06-5193-4235-8acf-c0112248dd22@github.com>

On Tue, 27 Oct 2020 14:22:58 GMT, Joshua Matsuoka <jmatsuoka at openjdk.org> wrote:

> Hi,
> 
> This PR addresses JMC-6895, which made it so that the agent instrumentation would silently fail and not emit events when a class being instrumented was loaded by a custom classloader and its' methods were reflectively invoked.
> 
> The following is the sequence of events that caused this bug:
> 
> - When the class was initially loaded by the AppClassLoader the agent instruments it as we'd expect
> - When the class was later loaded by the custom classloader, that classloader's loadClass call chain would lead to the agent being called to transform again
> -- Since the transform had already been done once it was marked as complete and would not do anything
> -- When the code for the class was later run, it would not emit the events due to a ClassNotFoundException on the injected event classes as they were not visible to the custom classloader
> 
> This patch resolves this and makes sure instrumentation is done with the custom classloader and that the event classes are visible to it. I've also included an integration test replicating the behavior that caused the bug.

This pull request has now been integrated.

Changeset: 31619d6d
Author:    Joshua Matsuoka <jmatsuoka at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/31619d6d
Stats:     229 lines in 5 files changed: 213 ins; 9 del; 7 mod

6895: Agent Instrumentation fails to emit events when the instrumented class has a different/custom ClassLoader

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/142

From github.com+76791+alblue at openjdk.java.net  Wed Oct 28 18:35:42 2020
From: github.com+76791+alblue at openjdk.java.net (Alex Blewitt)
Date: Wed, 28 Oct 2020 18:35:42 GMT
Subject: Integrated: 6947: Allow executable name to show up in JPS
In-Reply-To: <pc1QfvkO5uRZZMMVyyS5Ly80-lwRjTRJOkipgdV6NLM=.92a409e6-f112-42ed-b8a8-121f6021dab7@github.com>
References: <pc1QfvkO5uRZZMMVyyS5Ly80-lwRjTRJOkipgdV6NLM=.92a409e6-f112-42ed-b8a8-121f6021dab7@github.com>
Message-ID: <GNxmoqUkNVNEoZSKi5moARpd3kZh_URKFPyv7mXspKg=.be6dd5b0-eaa1-46cf-8f11-264edaf0f01a@github.com>

On Wed, 21 Oct 2020 10:28:05 GMT, Alex Blewitt <github.com+76791+alblue at openjdk.org> wrote:

> When executing `jps` to view running Java applications, the displayed name
> comes from a `sun.java.command` property. This is usually the name of the
> Main-Class when executing it with `java` directly, but Eclipse starts the JVM
> by using the native calls which bypasses this setting.
> 
> By adding a property definition `sun.java.command=JMC` then the application
> will show up appropriately in JPS.

This pull request has now been integrated.

Changeset: 84d1eb28
Author:    Alex Blewitt <alex.blewitt at gmail.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/84d1eb28
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

6947: Allow executable name to show up in JPS

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/137

From github.com+4610701+jpbempel at openjdk.java.net  Wed Oct 28 22:46:46 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Wed, 28 Oct 2020 22:46:46 GMT
Subject: RFR: 5709: Improve Biased lock revocation result text
Message-ID: <EAdM8dmMKRpnCr0wZWyx0SSmHI-XbTNmKMDdGvM5vyU=.ff7f970d-4d73-47e0-a1ae-d64814ff948e@github.com>

Improved explanation, stressing that the application is halted during revocation and explaining what are biased locking and revocation

-------------

Commit messages:
 - 5709: Improve Biased lock revocation result text

Changes: https://git.openjdk.java.net/jmc/pull/144/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=144&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-5709
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/144.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/144/head:pull/144

PR: https://git.openjdk.java.net/jmc/pull/144

From hirt at openjdk.java.net  Wed Oct 28 22:54:43 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 28 Oct 2020 22:54:43 GMT
Subject: RFR: 5709: Improve Biased lock revocation result text
In-Reply-To: <EAdM8dmMKRpnCr0wZWyx0SSmHI-XbTNmKMDdGvM5vyU=.ff7f970d-4d73-47e0-a1ae-d64814ff948e@github.com>
References: <EAdM8dmMKRpnCr0wZWyx0SSmHI-XbTNmKMDdGvM5vyU=.ff7f970d-4d73-47e0-a1ae-d64814ff948e@github.com>
Message-ID: <eNI_bJ4fTMfE37FB1_XExaVPtTMU9nIA0mZaq2QXpXU=.a8e4290d-d5b7-4354-84c6-0792843eb8e5@github.com>

On Wed, 28 Oct 2020 22:42:18 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> Improved explanation, stressing that the application is halted during revocation and explaining what are biased locking and revocation

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 87:

> 85: BiasedLockingRevocationPauseRule_CONFIG_WARNING_LIMIT_LONG=The total time spent on revoking biased locks needed to trigger a warning
> 86: BiasedLockingRevocationPauseRule_RULE_NAME=Biased Locking Revocation Pauses
> 87: BiasedLockingRevocationPauseRule_TEXT_INFO_LONG=Biased locks are an optimization for uncontended locks. When locks have contentions, optimization need to be revoked when application halts. To avoid this, either turn off biased Locking ('-XX:-UseBiasedLocking') or, if this occurs during startup, delay the use of biased Locking ('-XX:BiasedLockingStartupDelay').

Alternative wording:

Biased locking is an optimization for uncontended locks. If the locks become contended, this optimization must be revoked, which in turn cause application halts. To avoid this, either turn off biased locking ('-XX:-UseBiasedLocking') or, if this occurs during startup, delay the use of biased locking ('-XX:BiasedLockingStartupDelay').

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 89:

> 87: BiasedLockingRevocationPauseRule_TEXT_INFO_LONG=Biased locks are an optimization for uncontended locks. When locks have contentions, optimization need to be revoked when application halts. To avoid this, either turn off biased Locking ('-XX:-UseBiasedLocking') or, if this occurs during startup, delay the use of biased Locking ('-XX:BiasedLockingStartupDelay').
> 88: # {0} is a time period
> 89: BiasedLockingRevocationPauseRule_TEXT_MESSAGE=Application halts for a total time of {0} revoking biased locks.

How about "The application was halted for a total time of"?

-------------

PR: https://git.openjdk.java.net/jmc/pull/144

From schaturvedi at openjdk.java.net  Wed Oct 28 23:21:46 2020
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Wed, 28 Oct 2020 23:21:46 GMT
Subject: RFR: 6878: Update Spotbugs latest version in jmc 8.0.0 source
Message-ID: <rBPtgrev4Db_qBUyvexB2oyP-MB4GKiCCinYp4m14ps=.d76f196a-e9af-4b82-bf8a-e920de1b4a66@github.com>

Updating spotbugs version from 4.0.4 to 4.1.4 which is the latest available.

Please review the change.

-------------

Commit messages:
 - 6878: Update Spotbugs latest version in jmc 8.0.0 source

Changes: https://git.openjdk.java.net/jmc/pull/145/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=145&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6878
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/145.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/145/head:pull/145

PR: https://git.openjdk.java.net/jmc/pull/145

From github.com+4610701+jpbempel at openjdk.java.net  Thu Oct 29 12:17:51 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Thu, 29 Oct 2020 12:17:51 GMT
Subject: RFR: 5709: Improve Biased lock revocation result text [v2]
In-Reply-To: <EAdM8dmMKRpnCr0wZWyx0SSmHI-XbTNmKMDdGvM5vyU=.ff7f970d-4d73-47e0-a1ae-d64814ff948e@github.com>
References: <EAdM8dmMKRpnCr0wZWyx0SSmHI-XbTNmKMDdGvM5vyU=.ff7f970d-4d73-47e0-a1ae-d64814ff948e@github.com>
Message-ID: <ef1UiaId4kjx4lCJSIY93ymX4xL8l05uUY5iG4ZhX4I=.46f0ab4e-cfa7-4e2a-9859-f6b690a85c27@github.com>

> Improved explanation, stressing that the application is halted during revocation and explaining what are biased locking and revocation

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  fix wording

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/144/files
  - new: https://git.openjdk.java.net/jmc/pull/144/files/cc282fa0..fea9ef5e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=144&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=144&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/144.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/144/head:pull/144

PR: https://git.openjdk.java.net/jmc/pull/144

From hirt at openjdk.java.net  Thu Oct 29 16:19:40 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 29 Oct 2020 16:19:40 GMT
Subject: RFR: 6878: Update Spotbugs latest version in jmc 8.0.0 source
In-Reply-To: <rBPtgrev4Db_qBUyvexB2oyP-MB4GKiCCinYp4m14ps=.d76f196a-e9af-4b82-bf8a-e920de1b4a66@github.com>
References: <rBPtgrev4Db_qBUyvexB2oyP-MB4GKiCCinYp4m14ps=.d76f196a-e9af-4b82-bf8a-e920de1b4a66@github.com>
Message-ID: <AuEFP-MXQl9FrwazxdETS3BY28ohMoCpa1n6wCYgkl4=.95550192-c3f4-445f-9b89-be59bdd7437e@github.com>

On Wed, 28 Oct 2020 23:16:48 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Updating spotbugs version from 4.0.4 to 4.1.4 which is the latest available.
> 
> Please review the change.

Hi @Suchitainf - the upgrade makes the spot bugs tests fail. You need to either fix the newly found problems (if they are indeed problems), or exclude them in the spot bugs exclude file (with an explanation why it is no problem).

-------------

PR: https://git.openjdk.java.net/jmc/pull/145

From hirt at openjdk.java.net  Thu Oct 29 16:20:41 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 29 Oct 2020 16:20:41 GMT
Subject: RFR: 5709: Improve Biased lock revocation result text [v2]
In-Reply-To: <ef1UiaId4kjx4lCJSIY93ymX4xL8l05uUY5iG4ZhX4I=.46f0ab4e-cfa7-4e2a-9859-f6b690a85c27@github.com>
References: <EAdM8dmMKRpnCr0wZWyx0SSmHI-XbTNmKMDdGvM5vyU=.ff7f970d-4d73-47e0-a1ae-d64814ff948e@github.com>
 <ef1UiaId4kjx4lCJSIY93ymX4xL8l05uUY5iG4ZhX4I=.46f0ab4e-cfa7-4e2a-9859-f6b690a85c27@github.com>
Message-ID: <cTUfjH1Wm9uaNWlY4acePrispNInMQ4Y8Dm4pLCw9xM=.7abef404-1c1f-4ef8-b10c-b90e7033cd95@github.com>

On Thu, 29 Oct 2020 12:17:51 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> Improved explanation, stressing that the application is halted during revocation and explaining what are biased locking and revocation
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix wording

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/144

From aptmac at openjdk.java.net  Thu Oct 29 17:15:58 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Thu, 29 Oct 2020 17:15:58 GMT
Subject: RFR: 6364: Improvements to the Thread Graph [v6]
In-Reply-To: <3b_EN291IWMTMl6vId_3HM3r9b2p0Bjxd9QYH5qgDO8=.50cc047a-4486-469a-a341-5908f78bb6df@github.com>
References: <3b_EN291IWMTMl6vId_3HM3r9b2p0Bjxd9QYH5qgDO8=.50cc047a-4486-469a-a341-5908f78bb6df@github.com>
Message-ID: <j-3fFDSSGgQfzf_8qXpOuaLWOhj3uarSQdj7SYzfrUI=.0597d20a-cd86-451f-bde5-c0dbedababe1@github.com>

> This patch addresses JMC-6364 [[0]](https://bugs.openjdk.java.net/browse/JMC-6364), the epic for tracking Improvements to the JFR Thread Graph. This RFR is also a follow-up to an RFC [[1]](http://mail.openjdk.java.net/pipermail/jmc-dev/2019-October/001454.html) that was posted to the jmc-dev list and incorporates the feedback that was brought up during discussion.
> 
> The new design and features was imagined in collaboration with our UX team, and the implementation has been a joint effort between myself and Jessye (@jessyec-s) - we had been originally collaborating on a fork of the old (unofficial) JMC GitHub repo. I've folded all the commits down into one because the older commits were merged using PRs with a similar format (e.g., `jmc/pull/23`) to this repo, so to avoid accidental noise (sorry about that) on other PRs I've just folded them away. If anyone is interested in the individual commits that got to this point, I've kept them around in the old repo [[2]](https://github.com/aptmac/jmc-old/commits/jfr-threads-page).
> 
> This PR aims to improve the usability and functionality of the JFR Threads Page by extending and enhancing existing classes. In an attempt to not clutter this PR with lots of images and explanatory text, I've created a gist [[3]](https://gist.github.com/aptmac/61808c89bfcf1888080884fc8a61bd36) that provides information and images/gifs of the new components and intended functionality.
> 
> Gist: https://gist.github.com/aptmac/61808c89bfcf1888080884fc8a61bd36
> 
> Summary of changes:
> - Introduction of canvases to display the thread names (left) and timeline (bottom)
> - Scrolled composites to house the text and chart canvases, for vertical scrolling of the chart area
> - Timeline canvas (bottom) is draggable for panning the chart
> - Current threads table has been re-located to a popup table
> - New filter bar (top) which alters the chart view based on time ranges and desired visible activity lanes
> - New display bar (right) which houses the zoom mechanics
> - New zoom pan component for easily navigating the chart
> - Introduction of a colour palette to increase contrast between neighbouring activity lanes
> - Controls to change the height of the thread lanes
> - updated and new uitests
> 
> Before:
> ![before](https://i.imgur.com/TNfGrtJ.png)
> 
> After:
> ![after](https://user-images.githubusercontent.com/10425301/71993902-dfd93200-3205-11ea-8249-cc50409a7a9f.png)
> 
> Let me know if you have any questions about the design & functionality.
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-6364
> [1] http://mail.openjdk.java.net/pipermail/jmc-dev/2019-October/001454.html
> [2] https://github.com/aptmac/jmc-old/commits/jfr-threads-page
> [3] https://gist.github.com/aptmac/61808c89bfcf1888080884fc8a61bd36

Alex Macdonald has updated the pull request incrementally with two additional commits since the last revision:

 - applied patch from Guru
 - fix tests when chart gets reset

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/27/files
  - new: https://git.openjdk.java.net/jmc/pull/27/files/ae16dcb5..59923d03

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=27&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=27&range=04-05

  Stats: 28 lines in 12 files changed: 2 ins; 9 del; 17 mod
  Patch: https://git.openjdk.java.net/jmc/pull/27.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/27/head:pull/27

PR: https://git.openjdk.java.net/jmc/pull/27

From hirt at openjdk.java.net  Thu Oct 29 18:53:52 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 29 Oct 2020 18:53:52 GMT
Subject: git: openjdk/jmc: 5709: Improve Biased lock revocation result text
Message-ID: <cd16c4bc-16c4-4ec4-a3d1-a7f7085384e9@openjdk.org>

Changeset: ff759069
Author:    Jean-Philippe Bempel <jean-philippe at bempel.fr>
Committer: Marcus Hirt <hirt at openjdk.org>
Date:      2020-10-29 18:53:11 +0000
URL:       https://git.openjdk.java.net/jmc/commit/ff759069

5709: Improve Biased lock revocation result text

Reviewed-by: hirt

! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties


From hirt at openjdk.java.net  Thu Oct 29 18:55:42 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 29 Oct 2020 18:55:42 GMT
Subject: RFR: 4454: Other JMC launched after this JMC is listed as
 "-XX:+UseG1GC" in JVM Browser [v2]
In-Reply-To: <Ce7u0Z2QH39jd4rHekdxAho5DhGNpvK7GPPug4slEwM=.c2556dfd-b022-4ac7-9456-345f68ccb40d@github.com>
References: <QiDAgz8otGyM5UoOfGSSMR801-k5Nlb4FEVI87Y_1tQ=.a0c05a7a-9a67-4bcc-a926-5828c645b2a8@github.com>
 <Ce7u0Z2QH39jd4rHekdxAho5DhGNpvK7GPPug4slEwM=.c2556dfd-b022-4ac7-9456-345f68ccb40d@github.com>
Message-ID: <_kwXWwyr-zbUnELgRx4HMGVdWKVMCtmQ8HFI5jdjwy0=.ee12ecaf-58b5-4114-adb1-ddbf60d0a531@github.com>

On Wed, 28 Oct 2020 11:59:56 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> Add startLocalManagement to force finishing th init of the attached JVM
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add JIRA issue

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/143

From github.com+4610701+jpbempel at openjdk.java.net  Thu Oct 29 18:56:43 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Thu, 29 Oct 2020 18:56:43 GMT
Subject: Integrated: 5709: Improve Biased lock revocation result text
In-Reply-To: <EAdM8dmMKRpnCr0wZWyx0SSmHI-XbTNmKMDdGvM5vyU=.ff7f970d-4d73-47e0-a1ae-d64814ff948e@github.com>
References: <EAdM8dmMKRpnCr0wZWyx0SSmHI-XbTNmKMDdGvM5vyU=.ff7f970d-4d73-47e0-a1ae-d64814ff948e@github.com>
Message-ID: <AAudp0mg4KgLcHOSwmuAFOdROL715K1-88qSxz3BZlA=.e0e433db-369c-405a-88ab-39dc882ca0de@github.com>

On Wed, 28 Oct 2020 22:42:18 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> Improved explanation, stressing that the application is halted during revocation and explaining what are biased locking and revocation

This pull request has now been integrated.

Changeset: ff759069
Author:    Jean-Philippe Bempel <jean-philippe at bempel.fr>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/ff759069
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

5709: Improve Biased lock revocation result text

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/144

From hirt at openjdk.java.net  Thu Oct 29 20:08:44 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 29 Oct 2020 20:08:44 GMT
Subject: RFR: 4819: Improved tooltips and context menus for Stack Trace
 View
In-Reply-To: <oT9V1zmEwwNtC4yCJ-Gwm291J7j_bSYUpF_cfxDhe6o=.a0580d08-30aa-4ca2-9f9d-83e94c3c5f60@github.com>
References: <oT9V1zmEwwNtC4yCJ-Gwm291J7j_bSYUpF_cfxDhe6o=.a0580d08-30aa-4ca2-9f9d-83e94c3c5f60@github.com>
Message-ID: <HFu7tQ-2tSaYOSTHkFG89pXcr3iW_6I5ni7tdaeKHjo=.2e85c8b6-c185-447a-959e-77db036145e5@github.com>

On Mon, 26 Oct 2020 17:20:53 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

> bug fix: https://bugs.openjdk.java.net/browse/JMC-4819 tooltips
> 
> I'd propose, if not created yet, to create a ticket according to the correct behaviour of Stacktrace when treeView is selected (enabled/disabled) and switching over branches with enabled/disabled "Layout Option -> Reduce Tree Depth". Also when the current setup us saved and JMC reopened.

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java line 470:

> 468: 				if (!viewer.getControl().isDisposed()) {
> 469: 					setViewerInput(oldInput);
> 470: 					if (!reducedTree && oldInput != null) {

Don't get this. If we don't want to reduce - then reduce? Very strange behaviour.

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java line 448:

> 446: 			viewer.setContentProvider(createTreeContentProvider());
> 447: 		}
> 448: 		rebuildViewer();

This should not be necessary, right?

-------------

PR: https://git.openjdk.java.net/jmc/pull/140

From github.com+4610701+jpbempel at openjdk.java.net  Thu Oct 29 20:10:43 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Thu, 29 Oct 2020 20:10:43 GMT
Subject: Integrated: 4454: Other JMC launched after this JMC is listed as
 "-XX:+UseG1GC" in JVM Browser
In-Reply-To: <QiDAgz8otGyM5UoOfGSSMR801-k5Nlb4FEVI87Y_1tQ=.a0c05a7a-9a67-4bcc-a926-5828c645b2a8@github.com>
References: <QiDAgz8otGyM5UoOfGSSMR801-k5Nlb4FEVI87Y_1tQ=.a0c05a7a-9a67-4bcc-a926-5828c645b2a8@github.com>
Message-ID: <uhy5k8CAKnvOYm9iKUlal-p5BKcxkVVp-YrlQ-jgyXo=.05f1180d-6f4a-40a5-9dd9-c9a6b2435e7e@github.com>

On Tue, 27 Oct 2020 22:46:46 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> Add startLocalManagement to force finishing th init of the attached JVM

This pull request has now been integrated.

Changeset: 1a10759b
Author:    Jean-Philippe Bempel <jean-philippe at bempel.fr>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/1a10759b
Stats:     8 lines in 1 file changed: 8 ins; 0 del; 0 mod

4454: Other JMC launched after this JMC is listed as "-XX:+UseG1GC" in JVM Browser

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/143

From mwengner at openjdk.java.net  Fri Oct 30 11:39:46 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Fri, 30 Oct 2020 11:39:46 GMT
Subject: RFR: 4819: Improved tooltips and context menus for Stack Trace
 View
In-Reply-To: <HFu7tQ-2tSaYOSTHkFG89pXcr3iW_6I5ni7tdaeKHjo=.2e85c8b6-c185-447a-959e-77db036145e5@github.com>
References: <oT9V1zmEwwNtC4yCJ-Gwm291J7j_bSYUpF_cfxDhe6o=.a0580d08-30aa-4ca2-9f9d-83e94c3c5f60@github.com>
 <HFu7tQ-2tSaYOSTHkFG89pXcr3iW_6I5ni7tdaeKHjo=.2e85c8b6-c185-447a-959e-77db036145e5@github.com>
Message-ID: <q1msOocMxKmhwsFrcQZ3rSK0TAGjwLAZmgsnd0Fem5E=.a502ee8f-833b-4026-82e8-bb0ce99b9c09@github.com>

On Thu, 29 Oct 2020 20:03:46 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> bug fix: https://bugs.openjdk.java.net/browse/JMC-4819 tooltips
>> 
>> I'd propose, if not created yet, to create a ticket according to the correct behaviour of Stacktrace when treeView is selected (enabled/disabled) and switching over branches with enabled/disabled "Layout Option -> Reduce Tree Depth". Also when the current setup us saved and JMC reopened.
>
> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java line 470:
> 
>> 468: 				if (!viewer.getControl().isDisposed()) {
>> 469: 					setViewerInput(oldInput);
>> 470: 					if (!reducedTree && oldInput != null) {
> 
> Don't get this. If we don't want to reduce - then reduce? Very strange behaviour.

seems I've forgotten to revert it as I've been playing a bit more with it

-------------

PR: https://git.openjdk.java.net/jmc/pull/140

From mwengner at openjdk.java.net  Fri Oct 30 11:53:52 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Fri, 30 Oct 2020 11:53:52 GMT
Subject: RFR: 4819: Improved tooltips and context menus for Stack Trace
 View [v2]
In-Reply-To: <oT9V1zmEwwNtC4yCJ-Gwm291J7j_bSYUpF_cfxDhe6o=.a0580d08-30aa-4ca2-9f9d-83e94c3c5f60@github.com>
References: <oT9V1zmEwwNtC4yCJ-Gwm291J7j_bSYUpF_cfxDhe6o=.a0580d08-30aa-4ca2-9f9d-83e94c3c5f60@github.com>
Message-ID: <xnldkaKu1HetEYX9B7gxXsEbgGiB-lhaXYayzdmodyA=.ac86a037-f82c-4833-aca4-1a298938b04d@github.com>

> bug fix: https://bugs.openjdk.java.net/browse/JMC-4819 tooltips
> 
> I'd propose, if not created yet, to create a ticket according to the correct behaviour of Stacktrace when treeView is selected (enabled/disabled) and switching over branches with enabled/disabled "Layout Option -> Reduce Tree Depth". Also when the current setup us saved and JMC reopened.

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  4819: cleanup, uncessary code

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/140/files
  - new: https://git.openjdk.java.net/jmc/pull/140/files/e8cdb1da..dff28af4

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=140&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=140&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/140.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/140/head:pull/140

PR: https://git.openjdk.java.net/jmc/pull/140

From mwengner at openjdk.java.net  Fri Oct 30 11:53:53 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Fri, 30 Oct 2020 11:53:53 GMT
Subject: RFR: 4819: Improved tooltips and context menus for Stack Trace
 View [v2]
In-Reply-To: <HFu7tQ-2tSaYOSTHkFG89pXcr3iW_6I5ni7tdaeKHjo=.2e85c8b6-c185-447a-959e-77db036145e5@github.com>
References: <oT9V1zmEwwNtC4yCJ-Gwm291J7j_bSYUpF_cfxDhe6o=.a0580d08-30aa-4ca2-9f9d-83e94c3c5f60@github.com>
 <HFu7tQ-2tSaYOSTHkFG89pXcr3iW_6I5ni7tdaeKHjo=.2e85c8b6-c185-447a-959e-77db036145e5@github.com>
Message-ID: <Xg8YDjG5awi5KE695CFmcDY65vN9Qj_aC_xNTIOLC4U=.68af94bb-49ca-4c52-ad92-dcb385fe2f4b@github.com>

On Thu, 29 Oct 2020 20:05:58 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   4819: cleanup, uncessary code
>
> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java line 448:
> 
>> 446: 			viewer.setContentProvider(createTreeContentProvider());
>> 447: 		}
>> 448: 		rebuildViewer();
> 
> This should not be necessary, right?

correct, I've forgotten to remove as I've been playing with it. my bad

-------------

PR: https://git.openjdk.java.net/jmc/pull/140

From mwengner at openjdk.java.net  Fri Oct 30 12:41:08 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Fri, 30 Oct 2020 12:41:08 GMT
Subject: RFR: 4819: Improved tooltips and context menus for Stack Trace
 View [v3]
In-Reply-To: <oT9V1zmEwwNtC4yCJ-Gwm291J7j_bSYUpF_cfxDhe6o=.a0580d08-30aa-4ca2-9f9d-83e94c3c5f60@github.com>
References: <oT9V1zmEwwNtC4yCJ-Gwm291J7j_bSYUpF_cfxDhe6o=.a0580d08-30aa-4ca2-9f9d-83e94c3c5f60@github.com>
Message-ID: <144INovxlSnE3L0Osv9C9mH3Kf1PCUYrYTmnl5auR6g=.12732dee-fb9c-4aec-b36f-91b964527e07@github.com>

> bug fix: https://bugs.openjdk.java.net/browse/JMC-4819 tooltips
> 
> I'd propose, if not created yet, to create a ticket according to the correct behaviour of Stacktrace when treeView is selected (enabled/disabled) and switching over branches with enabled/disabled "Layout Option -> Reduce Tree Depth". Also when the current setup us saved and JMC reopened.

Miroslav Wengner has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' of https://github.com/openjdk/jmc into bugfix/4819_Improved_tooltips_and_context_menus_for_StackTraceView
 - 4819: cleanup, uncessary code
 - 4819: tooltip text corrections,  Disable : "Reduce Tree Depth" when not tree view selected

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/140/files
  - new: https://git.openjdk.java.net/jmc/pull/140/files/dff28af4..a76dd592

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=140&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=140&range=01-02

  Stats: 984 lines in 27 files changed: 943 ins; 9 del; 32 mod
  Patch: https://git.openjdk.java.net/jmc/pull/140.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/140/head:pull/140

PR: https://git.openjdk.java.net/jmc/pull/140

From github.com+28612+gunnarmorling at openjdk.java.net  Fri Oct 30 20:42:56 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Fri, 30 Oct 2020 20:42:56 GMT
Subject: RFR: 9999: Misc test fixes;
Message-ID: <9NOv9i3LROOSMB_fiXpt9UDigY7MSDZUwQ6GtmcIMos=.d05bad9a-06cc-4d50-96b9-0b8c2245f93b@github.com>

- AllTests suite caused duplicate event class definitions
- Version parsing code assumed presence of "." which isn't the case with JDK 9+
- Duplicate event class in TestIncorrectMethodDescriptor

-------------

Commit messages:
 - 9999: Misc test fixes;

Changes: https://git.openjdk.java.net/jmc/pull/146/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=146&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-9999
  Stats: 84 lines in 3 files changed: 15 ins; 48 del; 21 mod
  Patch: https://git.openjdk.java.net/jmc/pull/146.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/146/head:pull/146

PR: https://git.openjdk.java.net/jmc/pull/146

From github.com+28612+gunnarmorling at openjdk.java.net  Fri Oct 30 20:42:56 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Fri, 30 Oct 2020 20:42:56 GMT
Subject: RFR: 9999: Misc test fixes;
In-Reply-To: <9NOv9i3LROOSMB_fiXpt9UDigY7MSDZUwQ6GtmcIMos=.d05bad9a-06cc-4d50-96b9-0b8c2245f93b@github.com>
References: <9NOv9i3LROOSMB_fiXpt9UDigY7MSDZUwQ6GtmcIMos=.d05bad9a-06cc-4d50-96b9-0b8c2245f93b@github.com>
Message-ID: <NDzqUUmod641ioNRSdM2r4qyyozCHrnacLmxBxzuzZ8=.6100abf6-5aeb-40af-8ae8-f38b00507f7d@github.com>

On Fri, 30 Oct 2020 20:34:21 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> - AllTests suite caused duplicate event class definitions
> - Version parsing code assumed presence of "." which isn't the case with JDK 9+
> - Duplicate event class in TestIncorrectMethodDescriptor

Hey @thegreystone, I noticed a few stack traces when running the JMC Agent tests.

I'm not 100% sure about the removal of the `AllTests` suite class. I don't think it is needed, and it caused issues with the event classes being defined twice when running the build via Maven (once when a test is run itself, then another time via the suite class). Feedback on that welcome.

The other two changes remove a) a duplicated event definition within a test itself and b) an issue with parsing the Java version number. In general it'd be nice if those failures would have caused these tests to fail, but they don't (I suppose all exceptions are swallowed in the agent essentially, so to rather keep a program running without the agent instead of failing it).

Can you log an issue so I can attribute the commit to it? Thanks!

-------------

PR: https://git.openjdk.java.net/jmc/pull/146

From github.com+4610701+jpbempel at openjdk.java.net  Fri Oct 30 21:30:01 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Fri, 30 Oct 2020 21:30:01 GMT
Subject: RFR: 6945: Create build script for Windows
Message-ID: <gURgrb9i3dBClduebSEL8PPEemfbmg70liO-bGE_Qkw=.d49a8ea7-4438-4f0c-87c9-3b7969b3ab44@github.com>

Build script for windows mimics behavior of the *nix one

Special handling for Jetty server with killing it at the end of the action

-------------

Commit messages:
 - 6945: Create build script for Windows

Changes: https://git.openjdk.java.net/jmc/pull/147/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=147&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6945
  Stats: 139 lines in 1 file changed: 139 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/147.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/147/head:pull/147

PR: https://git.openjdk.java.net/jmc/pull/147

From hirt at openjdk.java.net  Fri Oct 30 23:28:52 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 30 Oct 2020 23:28:52 GMT
Subject: RFR: 6945: Create build script for Windows
In-Reply-To: <gURgrb9i3dBClduebSEL8PPEemfbmg70liO-bGE_Qkw=.d49a8ea7-4438-4f0c-87c9-3b7969b3ab44@github.com>
References: <gURgrb9i3dBClduebSEL8PPEemfbmg70liO-bGE_Qkw=.d49a8ea7-4438-4f0c-87c9-3b7969b3ab44@github.com>
Message-ID: <Lqk0zEUm4KSDyImhsh60IqVFplu9HdLxdEiB2a8vcBc=.713f36fe-b854-43a0-b55a-9886c7e5ab36@github.com>

On Fri, 30 Oct 2020 21:22:26 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> Build script for windows mimics behavior of the *nix one
> 
> Special handling for Jetty server with killing it at the end of the action

Hi JP!

I get the following when just running the script on a newly cloned repo:
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc>build.bat --packageJmc
 0:22:13,99 building p2:site - logging output to C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_ 02213.1.p2_site.log
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass (file:/C:/Users/Marcus/.m2/repository/org/codehaus/groovy/groovy-all/2.4.8/groovy-all-2.4.8.jar) to method java.lang.Object.finalize()
WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.CachedClass
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
 0:22:24,91 run jetty - logging output to C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_ 02213.2.jetty.log
Waiting for jetty server to start

Waiting for 0 seconds, press a key to continue ...
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] Scanning for projects...
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO]
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] ---------------< org.openjdk.jmc:external-dependencies >----------------
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] Building external-dependencies 8.0.0-SNAPSHOT
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] --------------------------------[ war ]---------------------------------
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] ------------------------------------------------------------------------
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] BUILD FAILURE
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] ------------------------------------------------------------------------
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] Total time: 0.183 s
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] Finished at: 2020-10-31T00:20:57+01:00
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] ------------------------------------------------------------------------
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[ERROR] Unknown lifecycle phase "02038.2.jetty.log". You must specify a valid lifecycle phase or a goal in the format <plugin-prefix>:<goal> or <plugin-group-id>:<plugin-artifact-id>[:<plugin-version>]:<goal>. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, generate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-clean, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1]
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[ERROR]
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[ERROR] Re-run Maven using the -X switch to enable full debug logging.
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[ERROR]
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[ERROR] For more information about the errors and possible solutions, please read the following articles:
C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/LifecyclePhaseNotFoundException
FINDSTR: Cannot open 02213.2.jetty.log
 0:22:25,17 jetty server up and running
 0:22:25,17 installing core artifacts - logging output to C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_ 02213.3.install.log
installing core artifacts failed!

-------------

PR: https://git.openjdk.java.net/jmc/pull/147

From hirt at openjdk.java.net  Fri Oct 30 23:28:52 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 30 Oct 2020 23:28:52 GMT
Subject: RFR: 6945: Create build script for Windows
In-Reply-To: <Lqk0zEUm4KSDyImhsh60IqVFplu9HdLxdEiB2a8vcBc=.713f36fe-b854-43a0-b55a-9886c7e5ab36@github.com>
References: <gURgrb9i3dBClduebSEL8PPEemfbmg70liO-bGE_Qkw=.d49a8ea7-4438-4f0c-87c9-3b7969b3ab44@github.com>
 <Lqk0zEUm4KSDyImhsh60IqVFplu9HdLxdEiB2a8vcBc=.713f36fe-b854-43a0-b55a-9886c7e5ab36@github.com>
Message-ID: <31Lz-F5X94JXth5Yda87ctzw1ToPdcB4o0b2YjU3Z5g=.5c5f95f9-6b44-4c00-8cd9-262a034da2bd@github.com>

On Fri, 30 Oct 2020 23:24:37 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Build script for windows mimics behavior of the *nix one
>> 
>> Special handling for Jetty server with killing it at the end of the action
>
> Hi JP!
> 
> I get the following when just running the script on a newly cloned repo:
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc>build.bat --packageJmc
>  0:22:13,99 building p2:site - logging output to C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_ 02213.1.p2_site.log
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass (file:/C:/Users/Marcus/.m2/repository/org/codehaus/groovy/groovy-all/2.4.8/groovy-all-2.4.8.jar) to method java.lang.Object.finalize()
> WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.CachedClass
> WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
> WARNING: All illegal access operations will be denied in a future release
>  0:22:24,91 run jetty - logging output to C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_ 02213.2.jetty.log
> Waiting for jetty server to start
> 
> Waiting for 0 seconds, press a key to continue ...
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] Scanning for projects...
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO]
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] ---------------< org.openjdk.jmc:external-dependencies >----------------
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] Building external-dependencies 8.0.0-SNAPSHOT
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] --------------------------------[ war ]---------------------------------
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] ------------------------------------------------------------------------
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] BUILD FAILURE
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] ------------------------------------------------------------------------
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] Total time: 0.183 s
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] Finished at: 2020-10-31T00:20:57+01:00
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[INFO] ------------------------------------------------------------------------
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[ERROR] Unknown lifecycle phase "02038.2.jetty.log". You must specify a valid lifecycle phase or a goal in the format <plugin-prefix>:<goal> or <plugin-group-id>:<plugin-artifact-id>[:<plugin-version>]:<goal>. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, generate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-clean, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1]
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[ERROR]
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[ERROR] Re-run Maven using the -X switch to enable full debug logging.
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[ERROR]
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[ERROR] For more information about the errors and possible solutions, please read the following articles:
> C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/LifecyclePhaseNotFoundException
> FINDSTR: Cannot open 02213.2.jetty.log
>  0:22:25,17 jetty server up and running
>  0:22:25,17 installing core artifacts - logging output to C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_ 02213.3.install.log
> installing core artifacts failed!

C:\Users\Marcus>more C:\Users\Marcus\git\jmcreviews\jpbempel\jmc\build_-1-3_ 02458.3.install.log
[INFO] Scanning for projects...
[INFO]
[INFO] ---------------< org.openjdk.jmc:external-dependencies >----------------
[INFO] Building external-dependencies 8.0.0-SNAPSHOT
[INFO] --------------------------------[ war ]---------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.207 s
[INFO] Finished at: 2020-10-31T00:25:10+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Unknown lifecycle phase "02458.2.jetty.log". You must specify a valid lifecycle phase or a goal in the format <plugin-prefix>:<goal> or <plugin-group-id>:<plugin-artifact-id>[:<plugin-version>]:<goal>. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, generate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-clean, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/LifecyclePhaseNotFoundException
Cannot access file C:\Users\Marcus\02458.3.install.log

-------------

PR: https://git.openjdk.java.net/jmc/pull/147

From hirt at openjdk.java.net  Fri Oct 30 23:34:52 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 30 Oct 2020 23:34:52 GMT
Subject: RFR: 6959: Fix agent tests
In-Reply-To: <NDzqUUmod641ioNRSdM2r4qyyozCHrnacLmxBxzuzZ8=.6100abf6-5aeb-40af-8ae8-f38b00507f7d@github.com>
References: <9NOv9i3LROOSMB_fiXpt9UDigY7MSDZUwQ6GtmcIMos=.d05bad9a-06cc-4d50-96b9-0b8c2245f93b@github.com>
 <NDzqUUmod641ioNRSdM2r4qyyozCHrnacLmxBxzuzZ8=.6100abf6-5aeb-40af-8ae8-f38b00507f7d@github.com>
Message-ID: <8fcLGvJEMcZYdV0IpVmSDcadn7PsryG5uXk5BKVR3X8=.ca1f2d96-942e-4212-a34b-0e932492747a@github.com>

On Fri, 30 Oct 2020 20:38:14 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> - AllTests suite caused duplicate event class definitions
>> - Version parsing code assumed presence of "." which isn't the case with JDK 9+
>> - Duplicate event class in TestIncorrectMethodDescriptor
>
> Hey @thegreystone, I noticed a few stack traces when running the JMC Agent tests.
> 
> I'm not 100% sure about the removal of the `AllTests` suite class. I don't think it is needed, and it caused issues with the event classes being defined twice when running the build via Maven (once when a test is run itself, then another time via the suite class). Feedback on that welcome.
> 
> The other two changes remove a) a duplicated event definition within a test itself and b) an issue with parsing the Java version number. In general it'd be nice if those failures would have caused these tests to fail, but they don't (I suppose all exceptions are swallowed in the agent essentially, so to rather keep a program running without the agent instead of failing it).
> 
> Can you log an issue so I can attribute the commit to it? Thanks!

Done!

-------------

PR: https://git.openjdk.java.net/jmc/pull/146

From ghb at openjdk.java.net  Sat Oct 31 07:36:00 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Sat, 31 Oct 2020 07:36:00 GMT
Subject: RFR: 6960: Update Copyright year and Welcome page
Message-ID: <QYdEnZt1_9Nn1Q6BEty1jNddxuH_XAKZqGeL1zuwB1E=.cc67e2c2-eb85-4e23-8090-1996deaf019d@github.com>

Fix contains : 
1. Updating Copy right year 
2. Copyright notice should now show "All rights reserved." (Text shows in JMC application -- About box, License detail etc.. and not in the source header). 
3. JOverflow was listed as addition / optional plugin , which is not true any more as it is distributed along with jmc product. 
4. Few html page had missing "JDK" prefix for "mission control". which is now shown as "JDK mission control" instead of "mission control"

-------------

Commit messages:
 - wqUpdated Copyright year and its text
 - 6960: Joverflow listed as install-able plug-in

Changes: https://git.openjdk.java.net/jmc/pull/149/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=149&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6960
  Stats: 121 lines in 39 files changed: 0 ins; 43 del; 78 mod
  Patch: https://git.openjdk.java.net/jmc/pull/149.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/149/head:pull/149

PR: https://git.openjdk.java.net/jmc/pull/149

From ghb at openjdk.java.net  Sat Oct 31 07:37:50 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Sat, 31 Oct 2020 07:37:50 GMT
Subject: RFR: 6945: Create build script for Windows
In-Reply-To: <gURgrb9i3dBClduebSEL8PPEemfbmg70liO-bGE_Qkw=.d49a8ea7-4438-4f0c-87c9-3b7969b3ab44@github.com>
References: <gURgrb9i3dBClduebSEL8PPEemfbmg70liO-bGE_Qkw=.d49a8ea7-4438-4f0c-87c9-3b7969b3ab44@github.com>
Message-ID: <_ULuLyYiukK8s2-17y-tdbCj9WYJYTnrwTEf1Cz8Pqk=.64cb1dbf-437d-45f4-9037-3f5550f07cdc@github.com>

On Fri, 30 Oct 2020 21:22:26 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> Build script for windows mimics behavior of the *nix one
> 
> Special handling for Jetty server with killing it at the end of the action

Let me check on Windows build and update my comments.

-------------

PR: https://git.openjdk.java.net/jmc/pull/147

From github.com+4610701+jpbempel at openjdk.java.net  Sat Oct 31 10:16:49 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sat, 31 Oct 2020 10:16:49 GMT
Subject: RFR: 6945: Create build script for Windows
In-Reply-To: <_ULuLyYiukK8s2-17y-tdbCj9WYJYTnrwTEf1Cz8Pqk=.64cb1dbf-437d-45f4-9037-3f5550f07cdc@github.com>
References: <gURgrb9i3dBClduebSEL8PPEemfbmg70liO-bGE_Qkw=.d49a8ea7-4438-4f0c-87c9-3b7969b3ab44@github.com>
 <_ULuLyYiukK8s2-17y-tdbCj9WYJYTnrwTEf1Cz8Pqk=.64cb1dbf-437d-45f4-9037-3f5550f07cdc@github.com>
Message-ID: <-aKfY_qGbgNPp6goqAsqjtPMDdNwyhttev2Y6uylEkE=.13b5d7d6-b63a-468a-aa62-8e37b4f7fa6d@github.com>

On Sat, 31 Oct 2020 07:35:16 GMT, Guru Hb <ghb at openjdk.org> wrote:

>> Build script for windows mimics behavior of the *nix one
>> 
>> Special handling for Jetty server with killing it at the end of the action
>
> Let me check on Windows build and update my comments.

@thegreystone I was afraid of that, but the way I generate a timestamp for the log files is fragile as it relies on date expressed in us format from `%date%` env var.
I need to find another way... :-/

-------------

PR: https://git.openjdk.java.net/jmc/pull/147

From hirt at openjdk.java.net  Sat Oct 31 12:17:51 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 31 Oct 2020 12:17:51 GMT
Subject: RFR: 6960: Update Copyright year and Welcome page
In-Reply-To: <QYdEnZt1_9Nn1Q6BEty1jNddxuH_XAKZqGeL1zuwB1E=.cc67e2c2-eb85-4e23-8090-1996deaf019d@github.com>
References: <QYdEnZt1_9Nn1Q6BEty1jNddxuH_XAKZqGeL1zuwB1E=.cc67e2c2-eb85-4e23-8090-1996deaf019d@github.com>
Message-ID: <7aF2HmuXohLHoELraOgIRlhZnoXYjUoGFCJpTyoh6G8=.b2fed50c-5466-4e8f-b4e9-458884399a78@github.com>

On Sat, 31 Oct 2020 07:32:32 GMT, Guru Hb <ghb at openjdk.org> wrote:

> Fix contains : 
> 1. Updating Copy right year 
> 2. Copyright notice should now show "All rights reserved." (Text shows in JMC application -- About box, License detail etc.. and not in the source header). 
> 3. JOverflow was listed as addition / optional plugin , which is not true any more as it is distributed along with jmc product. 
> 4. Few html page had missing "JDK" prefix for "mission control". which is now shown as "JDK mission control" instead of "mission control"

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/149

From github.com+4610701+jpbempel at openjdk.java.net  Sat Oct 31 16:06:02 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sat, 31 Oct 2020 16:06:02 GMT
Subject: RFR: 6945: Create build script for Windows [v2]
In-Reply-To: <gURgrb9i3dBClduebSEL8PPEemfbmg70liO-bGE_Qkw=.d49a8ea7-4438-4f0c-87c9-3b7969b3ab44@github.com>
References: <gURgrb9i3dBClduebSEL8PPEemfbmg70liO-bGE_Qkw=.d49a8ea7-4438-4f0c-87c9-3b7969b3ab44@github.com>
Message-ID: <KDiQ_ZOjJG-ZyypW5mPTfauQcZ8OVeHnTtlpn7Qe0qg=.d59d712a-d251-4af9-a7fa-4fcecd9f3bd6@github.com>

> Build script for windows mimics behavior of the *nix one
> 
> Special handling for Jetty server with killing it at the end of the action

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  Use another method to get timestamp
  
  also kill jetty when core installation fails
  reformatting code

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/147/files
  - new: https://git.openjdk.java.net/jmc/pull/147/files/a435fa9f..3d2c8134

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=147&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=147&range=00-01

  Stats: 17 lines in 1 file changed: 1 ins; 2 del; 14 mod
  Patch: https://git.openjdk.java.net/jmc/pull/147.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/147/head:pull/147

PR: https://git.openjdk.java.net/jmc/pull/147

From github.com+4610701+jpbempel at openjdk.java.net  Sat Oct 31 16:45:03 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sat, 31 Oct 2020 16:45:03 GMT
Subject: RFR: 6945: Create build script for Windows [v3]
In-Reply-To: <gURgrb9i3dBClduebSEL8PPEemfbmg70liO-bGE_Qkw=.d49a8ea7-4438-4f0c-87c9-3b7969b3ab44@github.com>
References: <gURgrb9i3dBClduebSEL8PPEemfbmg70liO-bGE_Qkw=.d49a8ea7-4438-4f0c-87c9-3b7969b3ab44@github.com>
Message-ID: <KDQUfi0-k1tpc7I2FGvEGydK42upqXKn2Ss5TLB5Lf8=.19c28f26-2d0f-49ba-8eba-bc758377a617@github.com>

> Build script for windows mimics behavior of the *nix one
> 
> Special handling for Jetty server with killing it at the end of the action

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  remove the skipTests

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/147/files
  - new: https://git.openjdk.java.net/jmc/pull/147/files/3d2c8134..3fe41846

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=147&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=147&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/147.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/147/head:pull/147

PR: https://git.openjdk.java.net/jmc/pull/147

From github.com+28612+gunnarmorling at openjdk.java.net  Sat Oct 31 17:58:03 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Sat, 31 Oct 2020 17:58:03 GMT
Subject: RFR: 6959: Fix agent tests [v2]
In-Reply-To: <9NOv9i3LROOSMB_fiXpt9UDigY7MSDZUwQ6GtmcIMos=.d05bad9a-06cc-4d50-96b9-0b8c2245f93b@github.com>
References: <9NOv9i3LROOSMB_fiXpt9UDigY7MSDZUwQ6GtmcIMos=.d05bad9a-06cc-4d50-96b9-0b8c2245f93b@github.com>
Message-ID: <KlAeYJDgI2mBU8GhpX78maX-_dNSuYGt4YuJJHa5vnI=.7b551d24-70ad-4b5a-a122-fdac15256884@github.com>

> - AllTests suite caused duplicate event class definitions
> - Version parsing code assumed presence of "." which isn't the case with JDK 9+
> - Duplicate event class in TestIncorrectMethodDescriptor

Gunnar Morling has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  6959: Misc test fixes;
  
  - AllTests suite caused duplicate event class definitions
  - Version parsing code assumed presence of "." which isn't the case with JDK 9+
  - Duplicate event class in TestIncorrectMethodDescriptor

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/146/files
  - new: https://git.openjdk.java.net/jmc/pull/146/files/f1e62cd3..7f4d01ea

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=146&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=146&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/146.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/146/head:pull/146

PR: https://git.openjdk.java.net/jmc/pull/146

From github.com+28612+gunnarmorling at openjdk.java.net  Sat Oct 31 17:58:03 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Sat, 31 Oct 2020 17:58:03 GMT
Subject: RFR: 6959: Fix agent tests
In-Reply-To: <8fcLGvJEMcZYdV0IpVmSDcadn7PsryG5uXk5BKVR3X8=.ca1f2d96-942e-4212-a34b-0e932492747a@github.com>
References: <9NOv9i3LROOSMB_fiXpt9UDigY7MSDZUwQ6GtmcIMos=.d05bad9a-06cc-4d50-96b9-0b8c2245f93b@github.com>
 <NDzqUUmod641ioNRSdM2r4qyyozCHrnacLmxBxzuzZ8=.6100abf6-5aeb-40af-8ae8-f38b00507f7d@github.com>
 <8fcLGvJEMcZYdV0IpVmSDcadn7PsryG5uXk5BKVR3X8=.ca1f2d96-942e-4212-a34b-0e932492747a@github.com>
Message-ID: <HcCitUp4sYtxtVwbjQZsdL62ImMDDBQN4pB5oa5VTI4=.c6e137af-6a46-4c39-a34e-007ad2f9c5f5@github.com>

On Fri, 30 Oct 2020 23:32:19 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Hey @thegreystone, I noticed a few stack traces when running the JMC Agent tests.
>> 
>> I'm not 100% sure about the removal of the `AllTests` suite class. I don't think it is needed, and it caused issues with the event classes being defined twice when running the build via Maven (once when a test is run itself, then another time via the suite class). Feedback on that welcome.
>> 
>> The other two changes remove a) a duplicated event definition within a test itself and b) an issue with parsing the Java version number. In general it'd be nice if those failures would have caused these tests to fail, but they don't (I suppose all exceptions are swallowed in the agent essentially, so to rather keep a program running without the agent instead of failing it).
>> 
>> Can you log an issue so I can attribute the commit to it? Thanks!
>
> Done!

Thx; reworded the commit message accordingly and force-pushed.

-------------

PR: https://git.openjdk.java.net/jmc/pull/146

From hirt at openjdk.java.net  Sat Oct 31 21:45:52 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 31 Oct 2020 21:45:52 GMT
Subject: RFR: 6959: Fix agent tests [v2]
In-Reply-To: <KlAeYJDgI2mBU8GhpX78maX-_dNSuYGt4YuJJHa5vnI=.7b551d24-70ad-4b5a-a122-fdac15256884@github.com>
References: <9NOv9i3LROOSMB_fiXpt9UDigY7MSDZUwQ6GtmcIMos=.d05bad9a-06cc-4d50-96b9-0b8c2245f93b@github.com>
 <KlAeYJDgI2mBU8GhpX78maX-_dNSuYGt4YuJJHa5vnI=.7b551d24-70ad-4b5a-a122-fdac15256884@github.com>
Message-ID: <VUr1UdnRxIkPfZFbUKM9nJjabTc_pzzgBZdP1PcOmOU=.f23cffc9-522d-493a-8bfb-ea3e2e14297b@github.com>

On Sat, 31 Oct 2020 17:58:03 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> - AllTests suite caused duplicate event class definitions
>> - Version parsing code assumed presence of "." which isn't the case with JDK 9+
>> - Duplicate event class in TestIncorrectMethodDescriptor
>
> Gunnar Morling has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/146

From github.com+4610701+jpbempel at openjdk.java.net  Sat Oct 31 21:56:56 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sat, 31 Oct 2020 21:56:56 GMT
Subject: RFR: 6948: Add union to QuantityRange
Message-ID: <qBU3MWBsKUYo5H5oP8AWuX5y-JCtg4mvsJhYNPR80Ts=.2027c98e-c662-4dc5-a8b0-ded306c99b90@github.com>

Add tests for intersetion & union

-------------

Commit messages:
 - 6948: Add union to QuantityRange

Changes: https://git.openjdk.java.net/jmc/pull/150/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=150&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6948
  Stats: 112 lines in 2 files changed: 112 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/150.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/150/head:pull/150

PR: https://git.openjdk.java.net/jmc/pull/150

From mwengner at openjdk.java.net  Sat Oct 31 22:11:04 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Sat, 31 Oct 2020 22:11:04 GMT
Subject: RFR: 4819: Improved tooltips and context menus for Stack Trace
 View [v4]
In-Reply-To: <oT9V1zmEwwNtC4yCJ-Gwm291J7j_bSYUpF_cfxDhe6o=.a0580d08-30aa-4ca2-9f9d-83e94c3c5f60@github.com>
References: <oT9V1zmEwwNtC4yCJ-Gwm291J7j_bSYUpF_cfxDhe6o=.a0580d08-30aa-4ca2-9f9d-83e94c3c5f60@github.com>
Message-ID: <VxDFRh35sSLYRw3MKA9X5cNbozbVcuoHyTzBdtIzPDw=.81bdd42f-136d-4c84-b682-3812af28af78@github.com>

> bug fix: https://bugs.openjdk.java.net/browse/JMC-4819 tooltips
> 
> I'd propose, if not created yet, to create a ticket according to the correct behaviour of Stacktrace when treeView is selected (enabled/disabled) and switching over branches with enabled/disabled "Layout Option -> Reduce Tree Depth". Also when the current setup us saved and JMC reopened.

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  4819: partial commit

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/140/files
  - new: https://git.openjdk.java.net/jmc/pull/140/files/a76dd592..e70f1789

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=140&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=140&range=02-03

  Stats: 4 lines in 1 file changed: 3 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/140.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/140/head:pull/140

PR: https://git.openjdk.java.net/jmc/pull/140

From github.com+4610701+jpbempel at openjdk.java.net  Sat Oct 31 22:16:01 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sat, 31 Oct 2020 22:16:01 GMT
Subject: RFR: 6948: Add union to QuantityRange [v2]
In-Reply-To: <qBU3MWBsKUYo5H5oP8AWuX5y-JCtg4mvsJhYNPR80Ts=.2027c98e-c662-4dc5-a8b0-ded306c99b90@github.com>
References: <qBU3MWBsKUYo5H5oP8AWuX5y-JCtg4mvsJhYNPR80Ts=.2027c98e-c662-4dc5-a8b0-ded306c99b90@github.com>
Message-ID: <YdRq3QrVPC9ZuufUOLEyWi9bXwymdjd9jGDHvd15-Ec=.3af4533c-913d-4132-b73c-deebc14eac7c@github.com>

> Add tests for intersetion & union

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  add license header

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/150/files
  - new: https://git.openjdk.java.net/jmc/pull/150/files/7263210a..593ecfa2

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=150&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=150&range=00-01

  Stats: 33 lines in 1 file changed: 33 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/150.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/150/head:pull/150

PR: https://git.openjdk.java.net/jmc/pull/150

From github.com+28612+gunnarmorling at openjdk.java.net  Sat Oct 31 22:16:02 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Sat, 31 Oct 2020 22:16:02 GMT
Subject: RFR: 6948: Add union to QuantityRange [v2]
In-Reply-To: <YdRq3QrVPC9ZuufUOLEyWi9bXwymdjd9jGDHvd15-Ec=.3af4533c-913d-4132-b73c-deebc14eac7c@github.com>
References: <qBU3MWBsKUYo5H5oP8AWuX5y-JCtg4mvsJhYNPR80Ts=.2027c98e-c662-4dc5-a8b0-ded306c99b90@github.com>
 <YdRq3QrVPC9ZuufUOLEyWi9bXwymdjd9jGDHvd15-Ec=.3af4533c-913d-4132-b73c-deebc14eac7c@github.com>
Message-ID: <2U7wWTCh9shD6gWIFeooohy9xrH0NmST6Wo8uf_wyt8=.860722e5-22d6-4d9b-81d3-baf4dc7e962c@github.com>

On Sat, 31 Oct 2020 22:12:53 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> Add tests for intersetion & union
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add license header

One comment inline.

core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/unit/QuantityRangeTest.java line 1:

> 1: package org.openjdk.jmc.common.test.unit;

Should there be a license header?

-------------

PR: https://git.openjdk.java.net/jmc/pull/150

From github.com+4610701+jpbempel at openjdk.java.net  Sat Oct 31 22:16:03 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sat, 31 Oct 2020 22:16:03 GMT
Subject: RFR: 6948: Add union to QuantityRange [v2]
In-Reply-To: <2U7wWTCh9shD6gWIFeooohy9xrH0NmST6Wo8uf_wyt8=.860722e5-22d6-4d9b-81d3-baf4dc7e962c@github.com>
References: <qBU3MWBsKUYo5H5oP8AWuX5y-JCtg4mvsJhYNPR80Ts=.2027c98e-c662-4dc5-a8b0-ded306c99b90@github.com>
 <YdRq3QrVPC9ZuufUOLEyWi9bXwymdjd9jGDHvd15-Ec=.3af4533c-913d-4132-b73c-deebc14eac7c@github.com>
 <2U7wWTCh9shD6gWIFeooohy9xrH0NmST6Wo8uf_wyt8=.860722e5-22d6-4d9b-81d3-baf4dc7e962c@github.com>
Message-ID: <0Ykrc3Ju2ZOpSwUPqTGb2M4ATQsF0Gzvf920mW_9xr0=.c6f125cd-e7ac-4641-b30e-8a8650813e50@github.com>

On Sat, 31 Oct 2020 22:07:51 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

>> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add license header
>
> core/tests/org.openjdk.jmc.common.test/src/test/java/org/openjdk/jmc/common/test/unit/QuantityRangeTest.java line 1:
> 
>> 1: package org.openjdk.jmc.common.test.unit;
> 
> Should there be a license header?

right

-------------

PR: https://git.openjdk.java.net/jmc/pull/150

From gunnar at hibernate.org  Sat Oct 31 22:29:10 2020
From: gunnar at hibernate.org (Gunnar Morling)
Date: Sat, 31 Oct 2020 23:29:10 +0100
Subject: [Agent] Avoiding need for Unsafe on Java 11+
Message-ID: <CADGJaX8uB6AwBgz5sBeyBEyUuQrWJpKp2W=-q0KiAgkSDufU_Q@mail.gmail.com>

Hey all,

I've been looking into ways for circumventing the need for using Unsafe for
creating the event types emitted by the agent, which requires the
--add-opens switch on Java 11+.

I first was hoping that Lookup#defineClass() could be used (see WIP PR
[1]), but this means event types would have to live under the same package
as the agent itself, as Lookup doesn't allow to create classes in another
package without support by code in that target package (which would have to
expose a lookup with "private access"). As Marcus pointed out to me, that'd
mean event types couldn't be GC-ed after unloading instrumented classes in
a dynamic environment.

Next option I considered is Java 15 hidden classes, but I'm having doubts
how feasible this actually is, as I can't find a good way for making the
generated hidden classes known to the instrumented methods (they cannot be
accessed symbolically). Plus, this would only work on Java 15+.

So what I'm wondering now: has it been considered to use dynamic JFR event
types [2] for the JMC agent? This should avoid the need for Unsafe in the
agent. IIUC, JFR generates event classes for these types internally. Would
that be an option to avoid the --add-opens switch?

Thanks,

--Gunnar

[1] https://github.com/openjdk/jmc/pull/148
[2]
https://docs.oracle.com/en/java/javase/11/docs/api/jdk.jfr/jdk/jfr/EventFactory.html

From hirt at openjdk.java.net  Sat Oct 31 23:33:58 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 31 Oct 2020 23:33:58 GMT
Subject: RFR: 6961: Fix rules test
Message-ID: <fBOktsWyhSzATIOPwJ-cuKb4300Xj3yyocbBmD-bIco=.761b6324-adc1-4721-8753-5678caa1ea4b@github.com>

Setting a fixed timezone so that the tests don't fail locally. Strange that this happened all of a sudden though.

-------------

Commit messages:
 - Forcing time-zone to GMT
 - 6961: Fix rules baseline

Changes: https://git.openjdk.java.net/jmc/pull/151/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=151&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6961
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/151.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/151/head:pull/151

PR: https://git.openjdk.java.net/jmc/pull/151

From github.com+28612+gunnarmorling at openjdk.java.net  Sat Oct 31 23:34:51 2020
From: github.com+28612+gunnarmorling at openjdk.java.net (Gunnar Morling)
Date: Sat, 31 Oct 2020 23:34:51 GMT
Subject: Integrated: 6959: Fix agent tests
In-Reply-To: <9NOv9i3LROOSMB_fiXpt9UDigY7MSDZUwQ6GtmcIMos=.d05bad9a-06cc-4d50-96b9-0b8c2245f93b@github.com>
References: <9NOv9i3LROOSMB_fiXpt9UDigY7MSDZUwQ6GtmcIMos=.d05bad9a-06cc-4d50-96b9-0b8c2245f93b@github.com>
Message-ID: <y1DubwKRrpxVxZ2NvPwVWW_UJCKOhGzg5Ejal_yBKHg=.f3b8efc2-2a36-4ef1-9c9c-bf9baf56c5ae@github.com>

On Fri, 30 Oct 2020 20:34:21 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:

> - AllTests suite caused duplicate event class definitions
> - Version parsing code assumed presence of "." which isn't the case with JDK 9+
> - Duplicate event class in TestIncorrectMethodDescriptor

This pull request has now been integrated.

Changeset: 849c9dd2
Author:    Gunnar Morling <gunnar.morling at googlemail.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/849c9dd2
Stats:     84 lines in 3 files changed: 15 ins; 48 del; 21 mod

6959: Fix agent tests

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/146

From mwengner at openjdk.java.net  Sat Oct 31 23:42:03 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Sat, 31 Oct 2020 23:42:03 GMT
Subject: RFR: 4819: Improved tooltips and context menus for Stack Trace
 View [v5]
In-Reply-To: <oT9V1zmEwwNtC4yCJ-Gwm291J7j_bSYUpF_cfxDhe6o=.a0580d08-30aa-4ca2-9f9d-83e94c3c5f60@github.com>
References: <oT9V1zmEwwNtC4yCJ-Gwm291J7j_bSYUpF_cfxDhe6o=.a0580d08-30aa-4ca2-9f9d-83e94c3c5f60@github.com>
Message-ID: <QH3NfCXcaM64w7qZalsHx_AP31vTOxjUuMQ4VCiisbw=.810b0c9e-37eb-4f8a-9228-2548d49c14b2@github.com>

> bug fix: https://bugs.openjdk.java.net/browse/JMC-4819 tooltips
> 
> I'd propose, if not created yet, to create a ticket according to the correct behaviour of Stacktrace when treeView is selected (enabled/disabled) and switching over branches with enabled/disabled "Layout Option -> Reduce Tree Depth". Also when the current setup us saved and JMC reopened.

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  4819: clean

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/140/files
  - new: https://git.openjdk.java.net/jmc/pull/140/files/e70f1789..9b1e1043

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=140&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=140&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/140.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/140/head:pull/140

PR: https://git.openjdk.java.net/jmc/pull/140