RFR: 6766: Add heap usage before and after GC to the Garbage Collections table [v2]

Marcus Hirt hirt at openjdk.java.net
Thu Oct 1 17:28:05 UTC 2020


On Thu, 1 Oct 2020 16:11:13 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> Columns are hidden for now
>> 
>> Here some screenshots of the changes:
>> 
>> ![JMC_UsedHeapBeforeAfterGC](https://user-images.githubusercontent.com/4610701/94465934-f030a300-01c0-11eb-8492-2b921f695833.png)
>> 
>> 
>> 
>> ![JMC_UsedHeapBeforeAfterGCColumns](https://user-images.githubusercontent.com/4610701/94465962-fc1c6500-01c0-11eb-8dc9-5b3346668381.png)
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix constant names with underscore

Marked as reviewed by hirt (Lead).

Changes requested by hirt (Lead).

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/GarbageCollectionsPage.java
line 322:

> 320: 						o -> ((GC) o).getRefCount(t)).style(SWT.RIGHT).build());
> 321: 			}
> 322: 			columns.add(new ColumnBuilder(Messages.GarbageCollectionsPage_USED_HEAP_BEFOREGC, "usedHeapBegoreGC",
> //$NON-NLS-1$

Forgot to update these.

-------------

PR: https://git.openjdk.java.net/jmc/pull/112


More information about the jmc-dev mailing list