RFR: 6905: Add rule for heap dumps [v3]

[Marcus Hirt]

On Fri, 2 Oct 2020 15:36:51 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> Rule based on ne JDK15 jdk.HeapDump event.
>> If at least on heap dump is performed, rule indicates it as information, score 50.
>> For test added a new JFR file containing an example where 2 dumps were performed
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix formatting

Changes requested by hirt (Lead).

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/HeapDumpRule.java
line 1:

> 1: package org.openjdk.jmc.flightrecorder.rules.jdk.memory;

Must have copyright notice - look for one with Datadog in it to copy. Should have Oracle first, Datadog next, 2020.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/HeapDumpRule.java
line 1:

> 1: package org.openjdk.jmc.flightrecorder.rules.jdk.memory;

Needs copyright notice. Copy one which includes Datadog, ensure year is set to 2020. (The Datadog part is not added
retroactively to files initiated by Oracle, but for entirely new files, like this one, we should add it.)

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties
line 322:

> 320: HeapContentRuleFactory_TEXT_OK=No problems were found with the heap content.
> 321: HeapInspectionGcRuleFactory_RULE_NAME=GCs Caused by Heap Inspection
> 322: HeapDumpRule_RULE_NAME=Heap Dump

Update copyright year. Should be "2018, 2020, ".

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/Messages.java
line 299:

> 297: 	public static final String HeapContentRuleFactory_TEXT_OK = "HeapContentRuleFactory_TEXT_OK"; //$NON-NLS-1$
> 298: 	public static final String HeapContentRule_AGGR_CLASS_SCORE = "HeapContentRule_AGGR_CLASS_SCORE"; //$NON-NLS-1$
> 299: 	public static final String HeapDumpRule_RULE_NAME = "HeapDumpRule_RULE_NAME"; //$NON-NLS-1$

Update copyright year. Should be "2018, 2020, ".

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/META-INF/services/org.openjdk.jmc.flightrecorder.rules.IRule
line 80:

> 78: org.openjdk.jmc.flightrecorder.rules.jdk.memory.GcPauseRatioRule
> 79: org.openjdk.jmc.flightrecorder.rules.jdk.memory.HeapContentRule
> 80: org.openjdk.jmc.flightrecorder.rules.jdk.memory.HeapDumpRule

Update copyright year. Should be "2018, 2020, ".

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkTypeIDs.java line 201:

> 199:
> 200: 	public static final String NATIVE_LIBRARY = PREFIX + "NativeLibrary";
> 201:

Copyright year in this file should be updated to "2018, 2020".

-------------

PR: https://git.openjdk.java.net/jmc/pull/113