RFR: 6542: Improve calls to render in the flame view [v20]

[Marcus Hirt]

On Tue, 22 Sep 2020 21:01:24 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> stable flameview generation
>
> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6542: more cleanup

Changes requested by hirt (Lead).

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceNode.java
line 102:

> 100: 			return false;
> 101: 		if (packageName == null) {
> 102: 			if (other.packageName != null)

This file should be reverted. All “if” scopes should have brackets.

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
line 378:

> 376:
> 377: 			TraceNode root = TraceTreeUtils.createRootWithDescription(items, rootFork.getBranchCount());
> 378: 			if (Thread.currentThread().isAlive()) {

I don’t get these thread changes. The current thread is executing your code, and is therefore always alive. Also, if
you want to make these calculations abortable, I’d much prefer an API for it. Maybe an Abortable interface, or perhaps
even better, providing some sort of a progress interface where progress could be reported to and checked against
whether it should abort every now and then. We can discuss which alternative makes most sense.

-------------

PR: https://git.openjdk.java.net/jmc/pull/78