RFR: 6542: Improve calls to render in the flame view [v2]

Miroslav Wengner mwengner at openjdk.java.net
Mon Oct 19 09:32:25 UTC 2020


On Mon, 19 Oct 2020 09:19:16 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6542: minor changes
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
> line 385:
>> 383:
>> 384: 			this.modelState = ModelState.READY;
>> 385: 			DisplayToolkit.inDisplayThread().execute(() -> this.setModel(items, jsonModelBuilder.toString()));
> 
> Want to get the string first, outside of the lambda?

done!

> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java
> line 350:
>> 348: 	}
>> 349:
>> 350: 	private void rebuildModel(IItemCollection items) {
> 
> Maybe rename to submitRebuildTask or something?

triggerRebuildTask ?

-------------

PR: https://git.openjdk.java.net/jmc/pull/133


More information about the jmc-dev mailing list