RFR: 6913: Add daemon thread information to the console threads view [v2]

Jan S. github.com+924885+jpstotz at openjdk.java.net
Mon Oct 19 18:12:22 UTC 2020


On Mon, 19 Oct 2020 18:02:12 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Jan S. has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   show error message for Java 8 VMs and older that do not provide isDaemon() in java.lang.management.ThreadInfo
>
> @jpstotz Thank you for the revision, this is what I had in mind. I think the code looks good, and I verified that the
> correct messages are showing on a jdk8 jvm vs. a jdk11 jvm.
> One minor nit is that the message texts don't usually end in a period, so other than that needing being changed this
> looks okay to me.

@aptmac I fixed the message text as you suggested.

-------------

PR: https://git.openjdk.java.net/jmc/pull/110


More information about the jmc-dev mailing list