RFR: 6669: FlameGraphView tree calculation should (probably) be interruptable [v2]

Miroslav Wengner mwengner at openjdk.java.net
Wed Oct 21 22:46:25 UTC 2020


On Wed, 21 Oct 2020 14:11:18 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6669: correction
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/views/FlameGraphView.java line 282:
> 
>> 280: 	}
>> 281: 
>> 282: 	private static class ModelRebuildCallable implements Callable<Void> {
> 
> Does this really have to be callable? Would clean up the code if not.

correct, removed callable -> runnable, more executor threads and additional cleanup

-------------

PR: https://git.openjdk.java.net/jmc/pull/135


More information about the jmc-dev mailing list