RFR: 5700: Improve file and socket IO rule result texts [v2]

Marcus Hirt hirt at openjdk.java.net
Sun Oct 25 19:01:35 UTC 2020


On Sun, 25 Oct 2020 10:36:44 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> Add new information along with longest event:
>>  - report the total and average pauses for the entire recording.
>>  - report the sum of all IO events for that file or host of the longest event
>> Add also some mock classes for IItemCollection with some mock events
>
> Jean-Philippe Bempel has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 244:

> 242: FileReadRuleFactory_TEXT_WARN=There are long file read pauses in this recording (the longest is {0}).
> 243: # {0} is a time period, {1} is a time stamp, {2} is a size in bytes
> 244: FileReadRuleFactory_TEXT_WARN_LONG=The longest recorded file read took {0} to read {2} from {1}. Average time of all IO of the recording: {3}. Total time of all IO of the recording: {4}. Total time of all IO of the file {1}: {5}.

Maybe good to add "recorded". Average time of the recorded I/O, Total time of the recorded I/O, Total time of the recorded I/O for the file. May help emphasize that it is whatever was recorded that we're calculating over. "All I/O" my prime people to think that all I/O would be recorded, which is usually not true - most I/O related events will normally be thresholded to only record outliers.

-------------

PR: https://git.openjdk.java.net/jmc/pull/138


More information about the jmc-dev mailing list