RFR: 5700: Improve file and socket IO rule result texts [v3]

Marcus Hirt hirt at openjdk.java.net
Mon Oct 26 17:51:19 UTC 2020


On Mon, 26 Oct 2020 13:22:21 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

>> Add new information along with longest event:
>>  - report the total and average pauses for the entire recording.
>>  - report the sum of all IO events for that file or host of the longest event
>> Add also some mock classes for IItemCollection with some mock events
>
> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix messages

Changes requested by hirt (Lead).

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 254:

> 252: FileWriteRuleFactory_TEXT_WARN=There are long file write pauses in this recording (the longest is {0}).
> 253: # {0} is a time period, {1} is a time stamp, {2} is a size in bytes
> 254: FileWriteRuleFactory_TEXT_WARN_LONG=The longest recorded file write took {0} to write {2} to {1}. Average time of recorded IO: {3}. Total time of recoded IO: {4}. Total time of recoded IO for the file {1}: {5}.

Typos (x2). recoded->recorded

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 572:

> 570: SocketReadRuleFactory_TEXT_WARN=There are long socket read pauses in this recording (the longest is {0}).
> 571: # {0} is a time period, {1} is a host name, {2} is a size in bytes
> 572: SocketReadRuleFactory_TEXT_WARN_LONG=The longest recorded socket read took {0} to read {2} from the host at {1}. Average time of recorded IO: {3}. Total time of recoded IO: {4}. Total time of recoded IO for the host {1}: {5}.

Typos. recoded->recorded

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 585:

> 583: SocketWriteRuleFactory_TEXT_WARN=There are long socket write pauses in this recording (the longest is {0}).
> 584: # {0} is a time period, {1} is a host name, {2} is a size in bytes
> 585: SocketWriteRuleFactory_TEXT_WARN_LONG=The longest recorded socket write took {0} to write {2} to the host at {1}. Average time of recroded IO: {3}. Total time of recorded IO: {4}. Total time of recorded IO for the host {1}: {5}.

Typo. recroded->recorded

-------------

PR: https://git.openjdk.java.net/jmc/pull/138


More information about the jmc-dev mailing list