RFR: 5067: Content assist uses too much screen area [v2]

[Miroslav Wengner]

On Mon, 26 Oct 2020 17:43:31 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   5067: dynamic popup
>
> application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/QuantityKindProposal.java line 60:
> 
>> 58: 
>> 59: public class QuantityKindProposal {
>> 60: 	private static final int POPUP_ROW_HEIGHT = 15;
> 
> How can you know this would be the height? This is font-related, no?

it's used for calculating a popup width and height : adapter.setPopupSize(new Point(POPUP_MAX_WIDTH, popupHeight)); I've not find a way how to get a font size. So I've estimated nice fit for the current setup, as previously was hardcoded everything. Do you think the name is not so good ?

-------------

PR: https://git.openjdk.java.net/jmc/pull/139