RFR: 5067: Content assist uses too much screen area [v2]

Miroslav Wengner mwengner at openjdk.java.net
Tue Oct 27 20:09:15 UTC 2020


On Tue, 27 Oct 2020 11:54:16 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> it's used for calculating a popup width and height : adapter.setPopupSize(new Point(POPUP_MAX_WIDTH, popupHeight)); I've not find a way how to get a font size. So I've estimated nice fit for the current setup, as previously was hardcoded everything. Do you think the name is not so good ?
>
> I think this is a pseudo-implementation that may just be confusing. Personally I'd prefer the previous fixed size solution - that one will be understandable to all users, no matter the font settings. This one runs the risk of feeling slightly off / buggy to users depending on the font settings.

I think it's quite reasonable, as the benefit of having it kind of "dynamic" is minimal. I'd personally also prefer the fixed size. I'll change it.

-------------

PR: https://git.openjdk.java.net/jmc/pull/139


More information about the jmc-dev mailing list