RFR: 5709: Improve Biased lock revocation result text

Marcus Hirt hirt at openjdk.java.net
Wed Oct 28 22:54:43 UTC 2020


On Wed, 28 Oct 2020 22:42:18 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> Improved explanation, stressing that the application is halted during revocation and explaining what are biased locking and revocation

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 87:

> 85: BiasedLockingRevocationPauseRule_CONFIG_WARNING_LIMIT_LONG=The total time spent on revoking biased locks needed to trigger a warning
> 86: BiasedLockingRevocationPauseRule_RULE_NAME=Biased Locking Revocation Pauses
> 87: BiasedLockingRevocationPauseRule_TEXT_INFO_LONG=Biased locks are an optimization for uncontended locks. When locks have contentions, optimization need to be revoked when application halts. To avoid this, either turn off biased Locking ('-XX:-UseBiasedLocking') or, if this occurs during startup, delay the use of biased Locking ('-XX:BiasedLockingStartupDelay').

Alternative wording:

Biased locking is an optimization for uncontended locks. If the locks become contended, this optimization must be revoked, which in turn cause application halts. To avoid this, either turn off biased locking ('-XX:-UseBiasedLocking') or, if this occurs during startup, delay the use of biased locking ('-XX:BiasedLockingStartupDelay').

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 89:

> 87: BiasedLockingRevocationPauseRule_TEXT_INFO_LONG=Biased locks are an optimization for uncontended locks. When locks have contentions, optimization need to be revoked when application halts. To avoid this, either turn off biased Locking ('-XX:-UseBiasedLocking') or, if this occurs during startup, delay the use of biased Locking ('-XX:BiasedLockingStartupDelay').
> 88: # {0} is a time period
> 89: BiasedLockingRevocationPauseRule_TEXT_MESSAGE=Application halts for a total time of {0} revoking biased locks.

How about "The application was halted for a total time of"?

-------------

PR: https://git.openjdk.java.net/jmc/pull/144


More information about the jmc-dev mailing list