RFR: 4819: Improved tooltips and context menus for Stack Trace View

[Marcus Hirt]

On Mon, 26 Oct 2020 17:20:53 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

> bug fix: https://bugs.openjdk.java.net/browse/JMC-4819 tooltips
> 
> I'd propose, if not created yet, to create a ticket according to the correct behaviour of Stacktrace when treeView is selected (enabled/disabled) and switching over branches with enabled/disabled "Layout Option -> Reduce Tree Depth". Also when the current setup us saved and JMC reopened.

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java line 470:

> 468: 				if (!viewer.getControl().isDisposed()) {
> 469: 					setViewerInput(oldInput);
> 470: 					if (!reducedTree && oldInput != null) {

Don't get this. If we don't want to reduce - then reduce? Very strange behaviour.

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java line 448:

> 446: 			viewer.setContentProvider(createTreeContentProvider());
> 447: 		}
> 448: 		rebuildViewer();

This should not be necessary, right?

-------------

PR: https://git.openjdk.java.net/jmc/pull/140