RFR: 6959: Fix agent tests
Marcus Hirt
hirt at openjdk.java.net
Fri Oct 30 23:34:52 UTC 2020
On Fri, 30 Oct 2020 20:38:14 GMT, Gunnar Morling <github.com+28612+gunnarmorling at openjdk.org> wrote:
>> - AllTests suite caused duplicate event class definitions
>> - Version parsing code assumed presence of "." which isn't the case with JDK 9+
>> - Duplicate event class in TestIncorrectMethodDescriptor
>
> Hey @thegreystone, I noticed a few stack traces when running the JMC Agent tests.
>
> I'm not 100% sure about the removal of the `AllTests` suite class. I don't think it is needed, and it caused issues with the event classes being defined twice when running the build via Maven (once when a test is run itself, then another time via the suite class). Feedback on that welcome.
>
> The other two changes remove a) a duplicated event definition within a test itself and b) an issue with parsing the Java version number. In general it'd be nice if those failures would have caused these tests to fail, but they don't (I suppose all exceptions are swallowed in the agent essentially, so to rather keep a program running without the agent instead of failing it).
>
> Can you log an issue so I can attribute the commit to it? Thanks!
Done!
-------------
PR: https://git.openjdk.java.net/jmc/pull/146
More information about the jmc-dev
mailing list