From kxu at redhat.com  Tue Sep  1 01:51:36 2020
From: kxu at redhat.com (Arvin Kangcheng Xu)
Date: Mon, 31 Aug 2020 18:51:36 -0700
Subject: Jessye and Arvin
In-Reply-To: <759f74ba-0761-c736-e120-8a4331173181@redhat.com>
References: <CAOpWGx0h3yQAwPDrhjUTaHNkg+KUt_AoXKfH1fFihqc+8dyLVQ@mail.gmail.com>
 <759f74ba-0761-c736-e120-8a4331173181@redhat.com>
Message-ID: <CA+tA26vHKoOuq_kD2DEm1NjH7bBsbkU0=NrHi3n0zgkE21G2Pg@mail.gmail.com>

Hello Marcus,

Today is officially my last day at Red Hat so I'm going over unread
emails. Sorry for the late reply.

I'd like to thank Marcus, Mario, Andrew and many other people in my
team and in the community for your support. I couldn't possibly do
these without your help!

The 16-month internship at Red Hat provided me with opportunities to
actually participate and become a part of the open-source communities,
and I'll still be even after I leave. Thus, as I've talked to Marcus
and Mario, I'm signing the OCA as an individual.

Again, thank you very much!

Regards,
Arvin

On Thu, 20 Aug 2020 at 09:03, Andrew Dinn <adinn at redhat.com> wrote:
>
> On 20/08/2020 14:55, Marcus Hirt wrote:
> > Jessye's and Arvin's internship at Red Hat is ending now in August, and I
> > just wanted to take this opportunity to thank them both for all the hard
> > work that they've put into helping the community. JMC is better for it!
> >
> > Kudos and thank you both! :)
> Yes, indeed. Our Toronto office seems to have the knack of finding
> outstanding interns. Many thanks to Jessye and Arvin for making a really
> significant contribution to the project.
>
> regards,
>
>
> Andrew Dinn
> -----------
> Red Hat Distinguished Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill
>


From marcus.hirt at datadoghq.com  Tue Sep  1 14:57:50 2020
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Tue, 1 Sep 2020 16:57:50 +0200
Subject: Jessye and Arvin
In-Reply-To: <CA+tA26vHKoOuq_kD2DEm1NjH7bBsbkU0=NrHi3n0zgkE21G2Pg@mail.gmail.com>
References: <CAOpWGx0h3yQAwPDrhjUTaHNkg+KUt_AoXKfH1fFihqc+8dyLVQ@mail.gmail.com>
 <759f74ba-0761-c736-e120-8a4331173181@redhat.com>
 <CA+tA26vHKoOuq_kD2DEm1NjH7bBsbkU0=NrHi3n0zgkE21G2Pg@mail.gmail.com>
Message-ID: <CAOpWGx3D2SEasscS+wWXiUVBSPSLE_kkyNbWb=1Xt2S=X3466w@mail.gmail.com>

Hi Arvin,

I'm really excited that you have decided to remain part of the community
even after leaving! Please let me know if you need any help with the OCA
process!

Kind regards,
Marcus

On Tue, Sep 1, 2020 at 3:51 AM Arvin Kangcheng Xu <kxu at redhat.com> wrote:

> Hello Marcus,
>
> Today is officially my last day at Red Hat so I'm going over unread
> emails. Sorry for the late reply.
>
> I'd like to thank Marcus, Mario, Andrew and many other people in my
> team and in the community for your support. I couldn't possibly do
> these without your help!
>
> The 16-month internship at Red Hat provided me with opportunities to
> actually participate and become a part of the open-source communities,
> and I'll still be even after I leave. Thus, as I've talked to Marcus
> and Mario, I'm signing the OCA as an individual.
>
> Again, thank you very much!
>
> Regards,
> Arvin
>
> On Thu, 20 Aug 2020 at 09:03, Andrew Dinn <adinn at redhat.com> wrote:
> >
> > On 20/08/2020 14:55, Marcus Hirt wrote:
> > > Jessye's and Arvin's internship at Red Hat is ending now in August,
> and I
> > > just wanted to take this opportunity to thank them both for all the
> hard
> > > work that they've put into helping the community. JMC is better for it!
> > >
> > > Kudos and thank you both! :)
> > Yes, indeed. Our Toronto office seems to have the knack of finding
> > outstanding interns. Many thanks to Jessye and Arvin for making a really
> > significant contribution to the project.
> >
> > regards,
> >
> >
> > Andrew Dinn
> > -----------
> > Red Hat Distinguished Engineer
> > Red Hat UK Ltd
> > Registered in England and Wales under Company Registration No. 03798903
> > Directors: Michael Cunningham, Michael ("Mike") O'Neill
> >
>
>

From hirt at openjdk.java.net  Wed Sep  2 13:16:07 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 2 Sep 2020 13:16:07 GMT
Subject: RFR: 6898: Installing from IDE update site complains about missing
 LZ4 plug-in
Message-ID: <fIZ8EzJO2IoI5h8AuslrUT2NyvHjmkzG2tODiAAVZ24=.e82caf9b-cf26-42cb-9eaf-ecce1d721e91@github.com>

This is due to the LZ4 plug-in not included in the appropriate features.

-------------

Commit messages:
 - 6898: Installing from IDE update site complains about missing LZ4 plug-in

Changes: https://git.openjdk.java.net/jmc/pull/107/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=107&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6898
  Stats: 14 lines in 2 files changed: 14 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/107.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/107/head:pull/107

PR: https://git.openjdk.java.net/jmc/pull/107

From ghb at openjdk.java.net  Wed Sep  2 13:38:41 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Wed, 2 Sep 2020 13:38:41 GMT
Subject: RFR: 6898: Installing from IDE update site complains about
 missing LZ4 plug-in
In-Reply-To: <fIZ8EzJO2IoI5h8AuslrUT2NyvHjmkzG2tODiAAVZ24=.e82caf9b-cf26-42cb-9eaf-ecce1d721e91@github.com>
References: <fIZ8EzJO2IoI5h8AuslrUT2NyvHjmkzG2tODiAAVZ24=.e82caf9b-cf26-42cb-9eaf-ecce1d721e91@github.com>
Message-ID: <nCJ3jFt519vyfFS-ybraIr1PVhlh1-fwLJOk7T1ZA9Y=.375fe77e-f514-4312-a79c-1c401fd0cd52@github.com>

On Wed, 2 Sep 2020 13:11:15 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> This is due to the LZ4 plug-in not included in the appropriate features.

Looks good to me

-------------

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/107

From hirt at openjdk.java.net  Wed Sep  2 14:14:55 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 2 Sep 2020 14:14:55 GMT
Subject: Integrated: 6898: Installing from IDE update site complains about
 missing LZ4 plug-in
In-Reply-To: <fIZ8EzJO2IoI5h8AuslrUT2NyvHjmkzG2tODiAAVZ24=.e82caf9b-cf26-42cb-9eaf-ecce1d721e91@github.com>
References: <fIZ8EzJO2IoI5h8AuslrUT2NyvHjmkzG2tODiAAVZ24=.e82caf9b-cf26-42cb-9eaf-ecce1d721e91@github.com>
Message-ID: <yrkuLxibUGhNIqFSablA-zCA0cPpAWpflFrkoHO2EZ4=.198c87ca-8e2b-4a8e-b66c-e47c49aa117b@github.com>

On Wed, 2 Sep 2020 13:11:15 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> This is due to the LZ4 plug-in not included in the appropriate features.

This pull request has now been integrated.

Changeset: d0be2161
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/d0be2161
Stats:     14 lines in 2 files changed: 0 ins; 14 del; 0 mod

6898: Installing from IDE update site complains about missing LZ4 plug-in

Reviewed-by: ghb

-------------

PR: https://git.openjdk.java.net/jmc/pull/107

From hirt at openjdk.java.net  Wed Sep  2 14:42:16 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 2 Sep 2020 14:42:16 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
In-Reply-To: <v-KsBg37x7Jp6oEyYJLH0prAiCcG3iMX9gDTW3-wKGM=.dbf84713-4586-4848-ae36-cd5ad03453e0@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
 <v-KsBg37x7Jp6oEyYJLH0prAiCcG3iMX9gDTW3-wKGM=.dbf84713-4586-4848-ae36-cd5ad03453e0@github.com>
Message-ID: <UlIY7c2i7QyXvOBnMtN1lDv5JxGm02cQZpKsfngctWc=.59359258-caf1-46f1-b227-dfdb8bcd147d@github.com>

On Thu, 20 Aug 2020 13:32:58 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Second try, I signed the OCA last week (also I do not have any response).
>> 
>> This script provides an easy way to package JMC by just calling a single command.
>
> We should ensure that the script works on both Mac and Linux. Check $OSTYPE. If it starts with darwin, then MacOS X.
> 
> One thing that I see beginners struggling with is running the built product. Perhaps adding a --run which simply launch
> the latest build? And perhaps launch with -vm $JAVA_HOME/bin added?
> For Mac:
> target/products/org.openjdk.jmc/macosx/cocoa/x86_64/JDK\ Mission\ Control.app/Contents/MacOS/jmc -vm $JAVA_HOME/bin
> 
> For Linux:
> target/products/org.openjdk.jmc/linux/gtk/x86_64/jmc -vm $JAVA_HOME/bin

Hi @Schalli1987! Just wanted to check if you need any assistance with bringing this one home.

-------------

PR: https://git.openjdk.java.net/jmc/pull/100

From hirt at openjdk.java.net  Wed Sep  2 18:41:55 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 2 Sep 2020 18:41:55 GMT
Subject: RFR: 6897: Remove unused javax imports
In-Reply-To: <UgRlYcsvTJfwZ7nZqPERKzYXg2d3hO9pqbNgTkFH2-E=.525ea57d-5f72-4262-8757-5eda30c3b599@github.com>
References: <UgRlYcsvTJfwZ7nZqPERKzYXg2d3hO9pqbNgTkFH2-E=.525ea57d-5f72-4262-8757-5eda30c3b599@github.com>
Message-ID: <ewhf20xDX1T4mD31AUXZOK2p9LeOdJTJMGb1sYXAQ9Y=.93f834ab-453c-45cd-a91b-f83b936404e5@github.com>

On Wed, 26 Aug 2020 18:20:01 GMT, Jie Kang <jkang at openjdk.org> wrote:

> JMC seemed to run fine with this patch. I was able to use the MXBeanBrowser, dump a flight recording of JMC and view
> the flight recording.

Marked as reviewed by hirt (Lead).

Found an unrelated bug when trying it out, but it seems this is ok.

-------------

PR: https://git.openjdk.java.net/jmc/pull/106

From jkang at openjdk.java.net  Wed Sep  2 19:15:11 2020
From: jkang at openjdk.java.net (Jie Kang)
Date: Wed, 2 Sep 2020 19:15:11 GMT
Subject: Integrated: 6897: Remove unused javax imports
In-Reply-To: <UgRlYcsvTJfwZ7nZqPERKzYXg2d3hO9pqbNgTkFH2-E=.525ea57d-5f72-4262-8757-5eda30c3b599@github.com>
References: <UgRlYcsvTJfwZ7nZqPERKzYXg2d3hO9pqbNgTkFH2-E=.525ea57d-5f72-4262-8757-5eda30c3b599@github.com>
Message-ID: <PyNS5tltmiEynmdALut1TRyJ2-xwWACT5EesItZ_j2o=.9f9286a8-bbb2-469b-be02-c595ad97ea95@github.com>

On Wed, 26 Aug 2020 18:20:01 GMT, Jie Kang <jkang at openjdk.org> wrote:

> JMC seemed to run fine with this patch. I was able to use the MXBeanBrowser, dump a flight recording of JMC and view
> the flight recording.

This pull request has now been integrated.

Changeset: 15f6ccad
Author:    Jie Kang <jkang at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/15f6ccad
Stats:     4 lines in 2 files changed: 3 ins; 0 del; 1 mod

6897: Remove unused javax imports

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/106

From hirt at openjdk.java.net  Wed Sep  2 19:16:26 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 2 Sep 2020 19:16:26 GMT
Subject: RFR: 6902: Console plug-ins with icons not found will fail
Message-ID: <3P4LEoaTsD3i_3HrTFf-onCb6EleGCR4gOG95mCWJew=.4d239588-c455-448e-b69d-4f0c9881fc26@github.com>

The tab will get a null pointer during initialization and not show up at all. Currently the PDE plug-in will not
properly include icon resources in the generated projects. That's a separate issue that will have to be looked into.

-------------

Commit messages:
 - 6902: Console plug-ins with icons not found will fail

Changes: https://git.openjdk.java.net/jmc/pull/108/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=108&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6902
  Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/108.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/108/head:pull/108

PR: https://git.openjdk.java.net/jmc/pull/108

From mwengner at openjdk.java.net  Sat Sep  5 18:31:39 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Sat, 5 Sep 2020 18:31:39 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v8]
In-Reply-To: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
Message-ID: <Yl9VxE8tc36t0XumstJ5Wi4mF4PArnWceX3DO1Na_1A=.bd538f51-4217-4c2a-bf93-eb0565e85599@github.com>

> stable flameview generation

Miroslav Wengner has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
excludes the unrelated changes brought in by the merge/rebase. The pull request contains 19 additional commits since
the last revision:

 - 6542: partial commit
 - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6542_Improve_calls_to_render_in_the_flame_view
 - 6542: cleanup
 - 6542: partial commit stable
 - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6542_Improve_calls_to_render_in_the_flame_view
 - Merge branch 'master' into feature/6542_Improve_calls_to_render_in_the_flame_view
 - 6542: correction spotless
 - 6542: clean up, correction
 - 6542: partial update
 - 6542: flameview cancelling
 - ... and 9 more: https://git.openjdk.java.net/jmc/compare/665b1118...1821950e

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/78/files
  - new: https://git.openjdk.java.net/jmc/pull/78/files/bf84149c..1821950e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=06-07

  Stats: 4315 lines in 60 files changed: 4108 ins; 128 del; 79 mod
  Patch: https://git.openjdk.java.net/jmc/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78

PR: https://git.openjdk.java.net/jmc/pull/78

From hdafgard at openjdk.java.net  Mon Sep  7 17:56:07 2020
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Mon, 7 Sep 2020 17:56:07 GMT
Subject: RFR: 6902: Console plug-ins with icons not found will fail
In-Reply-To: <3P4LEoaTsD3i_3HrTFf-onCb6EleGCR4gOG95mCWJew=.4d239588-c455-448e-b69d-4f0c9881fc26@github.com>
References: <3P4LEoaTsD3i_3HrTFf-onCb6EleGCR4gOG95mCWJew=.4d239588-c455-448e-b69d-4f0c9881fc26@github.com>
Message-ID: <uiUAGL7e-DoqgRP9cReqWtetSWYlFuwLU0MNcQoJsDs=.52c2d457-b3e5-4c0d-b655-35f37163009f@github.com>

On Wed, 2 Sep 2020 19:12:00 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> The tab will get a null pointer during initialization and not show up at all. Currently the PDE plug-in will not
> properly include icon resources in the generated projects. That's a separate issue that will have to be looked into.

LGTM!

-------------

Marked as reviewed by hdafgard (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/108

From hdafgard at openjdk.java.net  Mon Sep  7 17:57:07 2020
From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=)
Date: Mon, 7 Sep 2020 17:57:07 GMT
Subject: RFR: 6487: The TOPIC word in topic constants should either be the
 first word or removed [v2]
In-Reply-To: <6hsBBeAvvYFuxLBe11LG4rw7AmBzRbzDBv__RGRgw3w=.7688b257-c2f2-4174-8a17-32572d94ac7e@github.com>
References: <uY00FWQGH-mnpTKUyosgsWELoNukX1zFWALgeGOK-rs=.65b70f2a-c309-4897-a647-8740702a9430@github.com>
 <6hsBBeAvvYFuxLBe11LG4rw7AmBzRbzDBv__RGRgw3w=.7688b257-c2f2-4174-8a17-32572d94ac7e@github.com>
Message-ID: <kdMXSyd5DdMqYSXdQO6KCOSLXboX2pCZZ4AYCcHikes=.50642f22-836f-4780-b995-6875c64c3f2f@github.com>

On Tue, 18 Aug 2020 17:27:47 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Simply removed "_TOPIC".
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Making spotless happy

Fair enough, no more RAS Syndrome, or Department of Redundancy Department.

-------------

Marked as reviewed by hdafgard (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/102

From hirt at openjdk.java.net  Mon Sep  7 18:01:34 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 7 Sep 2020 18:01:34 GMT
Subject: Integrated: 6902: Console plug-ins with icons not found will fail
In-Reply-To: <3P4LEoaTsD3i_3HrTFf-onCb6EleGCR4gOG95mCWJew=.4d239588-c455-448e-b69d-4f0c9881fc26@github.com>
References: <3P4LEoaTsD3i_3HrTFf-onCb6EleGCR4gOG95mCWJew=.4d239588-c455-448e-b69d-4f0c9881fc26@github.com>
Message-ID: <3vOgH9OndiFIKFv0Q9JZ51BtcLwv3DUZ41hYUqFq_x4=.a71d9249-486d-4298-8466-c713b559dff6@github.com>

On Wed, 2 Sep 2020 19:12:00 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> The tab will get a null pointer during initialization and not show up at all. Currently the PDE plug-in will not
> properly include icon resources in the generated projects. That's a separate issue that will have to be looked into.

This pull request has now been integrated.

Changeset: 9cac6ab0
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/9cac6ab0
Stats:     8 lines in 1 file changed: 0 ins; 7 del; 1 mod

6902: Console plug-ins with icons not found will fail

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.java.net/jmc/pull/108

From hirt at openjdk.java.net  Mon Sep  7 18:04:33 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 7 Sep 2020 18:04:33 GMT
Subject: Integrated: 6487: The TOPIC word in topic constants should either be
 the first word or removed
In-Reply-To: <uY00FWQGH-mnpTKUyosgsWELoNukX1zFWALgeGOK-rs=.65b70f2a-c309-4897-a647-8740702a9430@github.com>
References: <uY00FWQGH-mnpTKUyosgsWELoNukX1zFWALgeGOK-rs=.65b70f2a-c309-4897-a647-8740702a9430@github.com>
Message-ID: <ShobsvYNJgcjxwNDHrLukPPwqtU8l5RxIpqXr90jfss=.b980e507-e44e-47a7-a370-5cb8b51c2616@github.com>

On Fri, 31 Jul 2020 12:54:53 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Simply removed "_TOPIC".

This pull request has now been integrated.

Changeset: ea46b653
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/ea46b653
Stats:     136 lines in 83 files changed: 29 ins; 24 del; 83 mod

6487: The TOPIC word in topic constants should either be the first word or removed

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.java.net/jmc/pull/102

From mwengner at openjdk.java.net  Mon Sep  7 21:59:04 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Mon, 7 Sep 2020 21:59:04 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v9]
In-Reply-To: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
Message-ID: <9wLGLvnKiQo4mru6HzXFUTfaJdqQxAZag6BI6DC2Vtc=.64d424c3-f988-41ea-9484-9d7190f11c42@github.com>

> stable flameview generation

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6542: small cleanup

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/78/files
  - new: https://git.openjdk.java.net/jmc/pull/78/files/1821950e..6c78deb9

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=08
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=07-08

  Stats: 68 lines in 2 files changed: 8 ins; 43 del; 17 mod
  Patch: https://git.openjdk.java.net/jmc/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78

PR: https://git.openjdk.java.net/jmc/pull/78

From mwengner at openjdk.java.net  Tue Sep  8 21:58:23 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Tue, 8 Sep 2020 21:58:23 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v10]
In-Reply-To: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
Message-ID: <K_NuRAxHiSAz64BgsGG-JPSkTX64Ks625gIOARQfDlg=.e42b3a50-369d-4541-8ab4-bdc71e5bbd37@github.com>

> stable flameview generation

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6542: cleanup

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/78/files
  - new: https://git.openjdk.java.net/jmc/pull/78/files/6c78deb9..6c307ea3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=09
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=08-09

  Stats: 60 lines in 1 file changed: 1 ins; 47 del; 12 mod
  Patch: https://git.openjdk.java.net/jmc/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78

PR: https://git.openjdk.java.net/jmc/pull/78

From hirt at openjdk.java.net  Wed Sep  9 01:41:59 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 9 Sep 2020 01:41:59 GMT
Subject: RFR: 6542: Improve calls to render in the flame view
In-Reply-To: <Re_m7C9QnG8itdk_salJil_1LLfX4uD8eK0Iw_WUyVM=.87eb6f80-72c3-4c1b-9918-5527b59939c4@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
 <AwnItgcFOUehmt4u2kFdj6adE-Vk8iJ8lqs5teVxOXU=.59f3b502-7695-4ceb-8fa9-78c5f2231f28@github.com>
 <bYCwH3TnEUVchdQi_D2dCKddPX3hfG-kAHQZXl8dzUA=.11fe64a5-e88b-4478-b84c-ddf8dc6a4675@github.com>
 <Re_m7C9QnG8itdk_salJil_1LLfX4uD8eK0Iw_WUyVM=.87eb6f80-72c3-4c1b-9918-5527b59939c4@github.com>
Message-ID: <S4RZzW6hkVYt-4PFCu6e5-qwGJRWb2TvTycmvbv70WY=.ab416a35-1577-4c84-b451-4797324158b3@github.com>

On Tue, 9 Jun 2020 21:59:47 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> I've add a fix.
>
> maybe we can increase the Executor treads in FlameView, I've observed improvements. But calculating the model is still
> expensive.

Seems formatting fails.

-------------

PR: https://git.openjdk.java.net/jmc/pull/78

From mwengner at openjdk.java.net  Wed Sep  9 15:55:33 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 9 Sep 2020 15:55:33 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v11]
In-Reply-To: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
Message-ID: <Fu5GNOjJF_rqVLt8jYIEI8g95OmzrKg6J51Oo_ssG0g=.703f5d10-4539-4e26-bb92-2b0bf17b3719@github.com>

> stable flameview generation

Miroslav Wengner has updated the pull request incrementally with two additional commits since the last revision:

 - 6542: additional cleanup
 - 6542: cleanup

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/78/files
  - new: https://git.openjdk.java.net/jmc/pull/78/files/6c307ea3..92cff07b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=10
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=09-10

  Stats: 71 lines in 3 files changed: 0 ins; 25 del; 46 mod
  Patch: https://git.openjdk.java.net/jmc/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78

PR: https://git.openjdk.java.net/jmc/pull/78

From mwengner at openjdk.java.net  Wed Sep  9 16:15:18 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 9 Sep 2020 16:15:18 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v12]
In-Reply-To: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
Message-ID: <BVxPAeMhV_G8456U_UWuYSGz0HQmGiwfQYBaZaTgm7k=.8ff9076e-4a5b-4c4a-9c15-ce607133ed09@github.com>

> stable flameview generation

Miroslav Wengner has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
excludes the unrelated changes brought in by the merge/rebase. The pull request contains 24 additional commits since
the last revision:

 - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6542_Improve_calls_to_render_in_the_flame_view
 - 6542: additional cleanup
 - 6542: cleanup
 - 6542: cleanup
 - 6542: small cleanup
 - 6542: partial commit
 - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6542_Improve_calls_to_render_in_the_flame_view
 - 6542: cleanup
 - 6542: partial commit stable
 - Merge branch 'master' of https://github.com/openjdk/jmc into feature/6542_Improve_calls_to_render_in_the_flame_view
 - ... and 14 more: https://git.openjdk.java.net/jmc/compare/89d5c3da...5981dbf4

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/78/files
  - new: https://git.openjdk.java.net/jmc/pull/78/files/92cff07b..5981dbf4

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=11
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=10-11

  Stats: 559 lines in 101 files changed: 386 ins; 52 del; 121 mod
  Patch: https://git.openjdk.java.net/jmc/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78

PR: https://git.openjdk.java.net/jmc/pull/78

From mwengner at openjdk.java.net  Wed Sep  9 18:44:17 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 9 Sep 2020 18:44:17 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v13]
In-Reply-To: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
Message-ID: <AuQ-5D5PJo24hvz64pOeJOxCW4s_NxAwQyj2e3lVwxQ=.6f2d839b-9fa6-46ef-8e81-31db2e104522@github.com>

> stable flameview generation

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6542: correction

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/78/files
  - new: https://git.openjdk.java.net/jmc/pull/78/files/5981dbf4..c4123513

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=12
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=11-12

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78

PR: https://git.openjdk.java.net/jmc/pull/78

From mwengner at openjdk.java.net  Thu Sep 10 08:46:22 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Thu, 10 Sep 2020 08:46:22 GMT
Subject: RFR: 6542: Improve calls to render in the flame view
In-Reply-To: <S4RZzW6hkVYt-4PFCu6e5-qwGJRWb2TvTycmvbv70WY=.ab416a35-1577-4c84-b451-4797324158b3@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
 <AwnItgcFOUehmt4u2kFdj6adE-Vk8iJ8lqs5teVxOXU=.59f3b502-7695-4ceb-8fa9-78c5f2231f28@github.com>
 <bYCwH3TnEUVchdQi_D2dCKddPX3hfG-kAHQZXl8dzUA=.11fe64a5-e88b-4478-b84c-ddf8dc6a4675@github.com>
 <Re_m7C9QnG8itdk_salJil_1LLfX4uD8eK0Iw_WUyVM=.87eb6f80-72c3-4c1b-9918-5527b59939c4@github.com>
 <S4RZzW6hkVYt-4PFCu6e5-qwGJRWb2TvTycmvbv70WY=.ab416a35-1577-4c84-b451-4797324158b3@github.com>
Message-ID: <lozRz2RUEKb-QA-H20_XXk8UV3iKgET93bOi1fuO0Zs=.0617ceb7-391f-485c-aab5-dccfeb8975c7@github.com>

On Wed, 9 Sep 2020 01:39:33 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> maybe we can increase the Executor treads in FlameView, I've observed improvements. But calculating the model is still
>> expensive.
>
> Seems formatting fails.

JMC-6669 ticket, can be most probably also closed by this branch https://bugs.openjdk.java.net/browse/JMC-6669

-------------

PR: https://git.openjdk.java.net/jmc/pull/78

From mwengner at openjdk.java.net  Thu Sep 10 10:10:03 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Thu, 10 Sep 2020 10:10:03 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v14]
In-Reply-To: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
Message-ID: <wUpA0oRZGnHU8EYPdRN0rEv11EEDGL3N3rTxzoMoCbY=.3b0a4ffc-971e-423a-bb76-f1db5d9926c6@github.com>

> stable flameview generation

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6542: cleanup improvements

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/78/files
  - new: https://git.openjdk.java.net/jmc/pull/78/files/c4123513..aeb29190

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=13
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=12-13

  Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78

PR: https://git.openjdk.java.net/jmc/pull/78

From mwengner at openjdk.java.net  Thu Sep 10 14:30:11 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Thu, 10 Sep 2020 14:30:11 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v15]
In-Reply-To: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
Message-ID: <2mijjqt7B9O27-SMyEVxvRV-zcpQCZCQ0Uf8wrWaycc=.d7871778-1bc3-4bc7-aada-877642cb713f@github.com>

> stable flameview generation

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6542: small correction

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/78/files
  - new: https://git.openjdk.java.net/jmc/pull/78/files/aeb29190..3de0f0e1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=14
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=13-14

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78

PR: https://git.openjdk.java.net/jmc/pull/78

From github.com+11866488+Schalli1987 at openjdk.java.net  Sat Sep 12 18:49:29 2020
From: github.com+11866488+Schalli1987 at openjdk.java.net (Schalli1987)
Date: Sat, 12 Sep 2020 18:49:29 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v2]
In-Reply-To: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
Message-ID: <U0qtiD30BwPs1YTkaiJ926WQ-WZEMZvUj9tq9M-rOIs=.28fa0d94-f676-453d-b2a1-e4545d1bc985@github.com>

> Second try, I signed the OCA last week (also I do not have any response).
> 
> This script provides an easy way to package JMC by just calling a single command.

Schalli1987 has updated the pull request incrementally with one additional commit since the last revision:

  Add OSTYPE and run option to build script

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/100/files
  - new: https://git.openjdk.java.net/jmc/pull/100/files/dc6fc5e8..e45021b2

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=100&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=100&range=00-01

  Stats: 57 lines in 1 file changed: 45 ins; 0 del; 12 mod
  Patch: https://git.openjdk.java.net/jmc/pull/100.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/100/head:pull/100

PR: https://git.openjdk.java.net/jmc/pull/100

From github.com+11866488+Schalli1987 at openjdk.java.net  Sat Sep 12 18:49:30 2020
From: github.com+11866488+Schalli1987 at openjdk.java.net (Schalli1987)
Date: Sat, 12 Sep 2020 18:49:30 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v2]
In-Reply-To: <UlIY7c2i7QyXvOBnMtN1lDv5JxGm02cQZpKsfngctWc=.59359258-caf1-46f1-b227-dfdb8bcd147d@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
 <v-KsBg37x7Jp6oEyYJLH0prAiCcG3iMX9gDTW3-wKGM=.dbf84713-4586-4848-ae36-cd5ad03453e0@github.com>
 <UlIY7c2i7QyXvOBnMtN1lDv5JxGm02cQZpKsfngctWc=.59359258-caf1-46f1-b227-dfdb8bcd147d@github.com>
Message-ID: <CG29bZ4aQ3-1baWsA8j5E_ZJf3eboLY1Lb17L6YWyxA=.fb85f542-0b89-4721-9bf3-5b09f729be94@github.com>

On Wed, 2 Sep 2020 14:40:01 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> We should ensure that the script works on both Mac and Linux. Check $OSTYPE. If it starts with darwin, then MacOS X.
>> 
>> One thing that I see beginners struggling with is running the built product. Perhaps adding a --run which simply launch
>> the latest build? And perhaps launch with -vm $JAVA_HOME/bin added?
>> For Mac:
>> target/products/org.openjdk.jmc/macosx/cocoa/x86_64/JDK\ Mission\ Control.app/Contents/MacOS/jmc -vm $JAVA_HOME/bin
>> 
>> For Linux:
>> target/products/org.openjdk.jmc/linux/gtk/x86_64/jmc -vm $JAVA_HOME/bin
>
> Hi @Schalli1987! Just wanted to check if you need any assistance with bringing this one home.

Sorry it's been a while...
Finally I added OSTYPE checks (can someone with a MAC confirm that its working?) and some preconditions for java and
maven. Also a --run option was added that can be called after --packageJmc.
Since JAVA_HOME is no longer set in JDK 11 and above, I'd use the system executable java instead.

-------------

PR: https://git.openjdk.java.net/jmc/pull/100

From hirt at openjdk.java.net  Sat Sep 12 21:57:28 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 12 Sep 2020 21:57:28 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v2]
In-Reply-To: <U0qtiD30BwPs1YTkaiJ926WQ-WZEMZvUj9tq9M-rOIs=.28fa0d94-f676-453d-b2a1-e4545d1bc985@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
 <U0qtiD30BwPs1YTkaiJ926WQ-WZEMZvUj9tq9M-rOIs=.28fa0d94-f676-453d-b2a1-e4545d1bc985@github.com>
Message-ID: <KNnqafV5QEzuJq4MZGylNCVj4SaAN0Q9JOQ_YpoG4bk=.481d1c1a-ed14-4d51-82fe-f82a68f90420@github.com>

On Sat, 12 Sep 2020 18:49:29 GMT, Schalli1987 <github.com+11866488+Schalli1987 at openjdk.org> wrote:

>> Second try, I signed the OCA last week (also I do not have any response).
>> 
>> This script provides an easy way to package JMC by just calling a single command.
>
> Schalli1987 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add OSTYPE and run option to build script

build.sh line 193:

> 191: function checkPreconditions() {
> 192:     if ! command -v   mvn &> /dev/null ; then
> 193:         err_log "It seems you do not have maven installed. Please ensure you have it installend and executable as
> \"mvn\"."

Typo "installend" -> "installed".

build.sh line 198:

> 196:
> 197:     if ! command -v   java &> /dev/null ; then
> 198:         err_log "It seems you do not have java installed. Please ensure you have it installend and executable as
> \"java\"."

Typo "installend" -> "installed".

build.sh line 105:

> 103:
> 104:     if [[ "${OSTYPE}" =~ "linux"* ]]; then
> 105:         echo "You can now run jmc by calling ${BASEDIR}/products/org.openjdk.jmc/linux/gtk/x86_64/JDK\ Mission\
> Control/jmc"

Perhaps refer to --run? You can now run jmc by calling this script with --run, or by calling...

-------------

PR: https://git.openjdk.java.net/jmc/pull/100

From github.com+11866488+Schalli1987 at openjdk.java.net  Sun Sep 13 13:51:56 2020
From: github.com+11866488+Schalli1987 at openjdk.java.net (Schalli1987)
Date: Sun, 13 Sep 2020 13:51:56 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v3]
In-Reply-To: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
Message-ID: <wQWBMZZmKkLo83Plspc-x9-i0tMReSgYfcmwV928U2Q=.9ac19b34-eb56-42ce-8efe-83a97aa1b7f6@github.com>

> Second try, I signed the OCA last week (also I do not have any response).
> 
> This script provides an easy way to package JMC by just calling a single command.

Schalli1987 has updated the pull request incrementally with two additional commits since the last revision:

 - fix subprocessed pid of jetty server
 - fix typos, add --run hint after --packageJmc

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/100/files
  - new: https://git.openjdk.java.net/jmc/pull/100/files/e45021b2..e051a310

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=100&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=100&range=01-02

  Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/jmc/pull/100.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/100/head:pull/100

PR: https://git.openjdk.java.net/jmc/pull/100

From hirt at openjdk.java.net  Mon Sep 14 12:09:57 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 14 Sep 2020 12:09:57 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v3]
In-Reply-To: <CG29bZ4aQ3-1baWsA8j5E_ZJf3eboLY1Lb17L6YWyxA=.fb85f542-0b89-4721-9bf3-5b09f729be94@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
 <v-KsBg37x7Jp6oEyYJLH0prAiCcG3iMX9gDTW3-wKGM=.dbf84713-4586-4848-ae36-cd5ad03453e0@github.com>
 <UlIY7c2i7QyXvOBnMtN1lDv5JxGm02cQZpKsfngctWc=.59359258-caf1-46f1-b227-dfdb8bcd147d@github.com>
 <CG29bZ4aQ3-1baWsA8j5E_ZJf3eboLY1Lb17L6YWyxA=.fb85f542-0b89-4721-9bf3-5b09f729be94@github.com>
Message-ID: <MXMFvTV1zg20aQGTMHpf-PRycbph4_E3nC0DmjAJVDc=.91a63fc3-7574-482f-9ec4-3ffefe448d36@github.com>

On Sat, 12 Sep 2020 18:46:28 GMT, Schalli1987 <github.com+11866488+Schalli1987 at openjdk.org> wrote:

>> Hi @Schalli1987! Just wanted to check if you need any assistance with bringing this one home.
>
> Sorry it's been a while...
> Finally I added OSTYPE checks (can someone with a MAC confirm that its working?) and some preconditions for java and
> maven. Also a --run option was added that can be called after --packageJmc.
> Since JAVA_HOME is no longer set in JDK 11 and above, I'd use the system executable java instead.

Tried running on Mac:
14:06:23 building p2:site - logging output to
/Users/marcus.hirt/git/myrepos/jmcreviews/Schalli1987/jmc/target/build_20200914140619.1.p2_site.log WARNING: An illegal
reflective access operation has occurred WARNING: Illegal reflective access by
org.codehaus.groovy.reflection.CachedClass
(file:/Users/marcus.hirt/.m2/repository/org/codehaus/groovy/groovy-all/2.4.8/groovy-all-2.4.8.jar) to method
java.lang.Object.finalize() WARNING: Please consider reporting this to the maintainers of
org.codehaus.groovy.reflection.CachedClass WARNING: Use --illegal-access=warn to enable warnings of further illegal
reflective access operations WARNING: All illegal access operations will be denied in a future release 14:06:33 run
jetty - logging output to
/Users/marcus.hirt/git/myrepos/jmcreviews/Schalli1987/jmc/target/build_20200914140619.2.jetty.log ps: illegal
option -- - usage: ps [-AaCcEefhjlMmrSTvwXx] [-O fmt | -o fmt] [-G gid[,gid...]]
          [-g grp[,grp...]] [-u [uid,uid...]]
          [-p pid[,pid...]] [-t tty[,tty...]] [-U user[,user...]]
       ps [-L]

-------------

PR: https://git.openjdk.java.net/jmc/pull/100

From ghb at openjdk.java.net  Mon Sep 14 13:46:32 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Mon, 14 Sep 2020 13:46:32 GMT
Subject: RFR: 6882: Method Profiling lacks icon in the Java Application View
Message-ID: <DdNRJiGSgA3GtX_Hm2dZPC6cr3fGhqH9PjfsszRi5l0=.ba39105d-e4fe-4e17-9830-d5602447e864@github.com>

Root Cause : Image Should not be disposed outside the ImageDataProvider scope.
Solution : Image are created inside the ImageDataProvider (inside the lambda expression).

-------------

Commit messages:
 - 6882: Method Profiling lacks icon in the Java Application View

Changes: https://git.openjdk.java.net/jmc/pull/109/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=109&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6882
  Stats: 17 lines in 1 file changed: 3 ins; 0 del; 14 mod
  Patch: https://git.openjdk.java.net/jmc/pull/109.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/109/head:pull/109

PR: https://git.openjdk.java.net/jmc/pull/109

From hirt at openjdk.java.net  Mon Sep 14 17:17:21 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 14 Sep 2020 17:17:21 GMT
Subject: RFR: 6882: Method Profiling lacks icon in the Java Application
 View
In-Reply-To: <DdNRJiGSgA3GtX_Hm2dZPC6cr3fGhqH9PjfsszRi5l0=.ba39105d-e4fe-4e17-9830-d5602447e864@github.com>
References: <DdNRJiGSgA3GtX_Hm2dZPC6cr3fGhqH9PjfsszRi5l0=.ba39105d-e4fe-4e17-9830-d5602447e864@github.com>
Message-ID: <g03brhYGQUxMy2K0PCkaKQnGrrgoHymHvRkWLYsQrP8=.c4e5142c-cdf3-476d-96fa-7c168781c48e@github.com>

On Mon, 14 Sep 2020 13:41:41 GMT, Guru Hb <ghb at openjdk.org> wrote:

> Root Cause : Image Should not be disposed outside the ImageDataProvider scope.
> Solution : Image are created inside the ImageDataProvider (inside the lambda expression).

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/109

From ghb at openjdk.java.net  Tue Sep 15 02:23:45 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Tue, 15 Sep 2020 02:23:45 GMT
Subject: Integrated: 6882: Method Profiling lacks icon in the Java Application
 View
In-Reply-To: <DdNRJiGSgA3GtX_Hm2dZPC6cr3fGhqH9PjfsszRi5l0=.ba39105d-e4fe-4e17-9830-d5602447e864@github.com>
References: <DdNRJiGSgA3GtX_Hm2dZPC6cr3fGhqH9PjfsszRi5l0=.ba39105d-e4fe-4e17-9830-d5602447e864@github.com>
Message-ID: <2T_eSq3h7dfrRKyRu9gKUYxMphj1fawGVIZa14zpTD4=.623a6da4-1cc9-4feb-98ea-12decaad3a63@github.com>

On Mon, 14 Sep 2020 13:41:41 GMT, Guru Hb <ghb at openjdk.org> wrote:

> Root Cause : Image Should not be disposed outside the ImageDataProvider scope.
> Solution : Image are created inside the ImageDataProvider (inside the lambda expression).

This pull request has now been integrated.

Changeset: 16513ca1
Author:    Guru Hb <ghb at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/16513ca1
Stats:     17 lines in 1 file changed: 0 ins; 3 del; 14 mod

6882: Method Profiling lacks icon in the Java Application View

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/109

From aptmac at openjdk.java.net  Tue Sep 15 14:46:57 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Tue, 15 Sep 2020 14:46:57 GMT
Subject: RFR: 6364: Improvements to the Thread Graph
In-Reply-To: <s8PRQ3LPX5LFCZGk47tfu4T8JfguQGuKNOu6ysh3eo8=.5062e28b-b947-45b7-aaff-4e52f01c3a92@github.com>
References: <3b_EN291IWMTMl6vId_3HM3r9b2p0Bjxd9QYH5qgDO8=.50cc047a-4486-469a-a341-5908f78bb6df@github.com>
 <9z2_Fmh0wzUWsp9Tu1bEudv8_BvAjeAC6RVPPe76FRQ=.1d13e3bc-3d48-4a9b-831f-40b784d57106@github.com>
 <RzkGUXMijABPraKoBm2yRnh7490ldPx8R1pVnLkZuQo=.49c6a560-d0bc-4870-8fc8-6b16c31a4edf@github.com>
 <VtxWPdJ5lCNJANcyQQKDpUAc6oMz6sIIl4AdCngGzNY=.3e9e164a-aeca-4a31-9c0d-90b32e505e1f@github.com>
 <WlsAE5WBZzvaJ7y6s_9776LfwPZxInEyw-9tHkR8BYQ=.cac2ca35-320a-4955-b4ad-9f03cf91e67d@github.com>
 <W46pwscvWVhGWOQ7fZuohiPU3PDSr_fTBcjsYEHZX9U=.3ded4679-f3c5-4fa0-8d3f-febe4b5ff1ae@github.com>
 <PkxbYIW2PTQI6EKSG2QBPXGZsLN_4YAmK8tBzom9Zcc=.6ac6a27f-cb8f-4d40-b910-8f209468280b@github.com>
 <1rFwH_fS08Lr6VT09rAPl5aOjeoDyyfAK1l1DaktMB8=.e94b0d05-4244-46b2-848e-c83f7aa3917a@github.com>
 <m106gabj2MTdvJuIG-7VzB4GU0GwsWw8FvwMStXJvzM=.60dbba90-bc44-4759-9e45-4cc07727fb54@github.com>
 <uGE8OtyeKVfipTGVyNCcHDrlfaxDEBGqhCdPhqjlv8o=.43a35c17-ad84-4831-87ad-740cfbdd7ed1@github.com>
 <jO40oBcEPc8zoPazOkBHqUm813eWjRpi5RJ
 qYv_QCeU=.976e6cb5-a240-4e7d-b2e7-307a66903740@github.com>
 <s8PRQ3LPX5LFCZGk47tfu4T8JfguQGuKNOu6ysh3eo8=.5062e28b-b947-45b7-aaff-4e52f01c3a92@github.com>
Message-ID: <te05v9SDdp77tUGnpxxtE4WvBeHTsoyZK1xxITVaAXE=.094e17e2-1599-4d6f-89c8-1311786ab932@github.com>

On Sun, 30 Aug 2020 13:12:29 GMT, Brice Dutheil <github.com+803621+bric3 at openjdk.org> wrote:

>> Hi, I noticed that when selecting a part of thread lane, like an event, then the cell/label is half dimed :
>> 
>> <img width="797" alt="JFR thread top half"
>> src="https://user-images.githubusercontent.com/803621/91659293-3665ea00-eacf-11ea-9fa7-0b86db536590.png"> <img
>> width="684" alt="JFR thread bottom half"
>> src="https://user-images.githubusercontent.com/803621/91659298-37971700-eacf-11ea-8c53-d99cf9e1f4ea.png">
>
> I also noticed that the overview mode indicates "too much content", for recording of applications having a high number
> of threads. And when the display area is not big enough, e.g. on 13 inches laptop or when the thread table is expanded.
>  
> ![too much content on overview, thread table
> expanded](https://user-images.githubusercontent.com/803621/91659801-7a0e2300-ead2-11ea-911b-ebf4e79d3228.png)
> ![overview ok, external screen, thread table
> hidden](https://user-images.githubusercontent.com/803621/91659799-72e71500-ead2-11ea-8ebf-7433031fae2b.png)
> _Of course the application has a design issue (with this manyfold threads) but the point remain in my opinion._
> 
> The new view works great otherwise.
> 
> I'll be happy to sharemy private startup and continuous JFR files if needed. Here's those of JMC when I took these
> snapshots. [startup-thread-view.zip](https://github.com/openjdk/jmc/files/5146861/startup-thread-view.zip)

Hi @bric3! Thanks for taking a look at this PR and providing your feedback, the screenshots and jfr files you attached
were also very much appreciated!

> Hi, I noticed that when selecting a part of thread lane, like an event, then the cell/label is half dimed :

Good find, I'll poke around and see what I can do to get that to highlight the rest of the lane name.

> I also noticed that the overview mode indicates "too much content", for recording of applications having a high number
> of threads. And when the display area is not big enough, e.g. on 13 inches laptop or when the thread table is expanded.

Thanks for finding this and sharing your jfr file too. I'll have to poke around with some different screen sizes and
see what adjustments can be made here. The "too much content" overlay happens to the current threads page lanes under
size restrictions, it looks like having the table above the chart causes it to reach this state a bit earlier than
before.

-------------

PR: https://git.openjdk.java.net/jmc/pull/27

From github.com+11866488+Schalli1987 at openjdk.java.net  Tue Sep 15 19:57:03 2020
From: github.com+11866488+Schalli1987 at openjdk.java.net (Schalli1987)
Date: Tue, 15 Sep 2020 19:57:03 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v3]
In-Reply-To: <MXMFvTV1zg20aQGTMHpf-PRycbph4_E3nC0DmjAJVDc=.91a63fc3-7574-482f-9ec4-3ffefe448d36@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
 <v-KsBg37x7Jp6oEyYJLH0prAiCcG3iMX9gDTW3-wKGM=.dbf84713-4586-4848-ae36-cd5ad03453e0@github.com>
 <UlIY7c2i7QyXvOBnMtN1lDv5JxGm02cQZpKsfngctWc=.59359258-caf1-46f1-b227-dfdb8bcd147d@github.com>
 <CG29bZ4aQ3-1baWsA8j5E_ZJf3eboLY1Lb17L6YWyxA=.fb85f542-0b89-4721-9bf3-5b09f729be94@github.com>
 <MXMFvTV1zg20aQGTMHpf-PRycbph4_E3nC0DmjAJVDc=.91a63fc3-7574-482f-9ec4-3ffefe448d36@github.com>
Message-ID: <7tkjs_xkme7anPIBV2ScujR_EJnFw8JOlsVz-r20iwE=.002745a4-8d4a-4f9d-a4fc-e4ddcb6ede2a@github.com>

On Mon, 14 Sep 2020 12:07:42 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Sorry it's been a while...
>> Finally I added OSTYPE checks (can someone with a MAC confirm that its working?) and some preconditions for java and
>> maven. Also a --run option was added that can be called after --packageJmc.
>> Since JAVA_HOME is no longer set in JDK 11 and above, I'd use the system executable java instead.
>
> Tried running on Mac:
> 14:06:23 building p2:site - logging output to
> /Users/marcus.hirt/git/myrepos/jmcreviews/Schalli1987/jmc/target/build_20200914140619.1.p2_site.log WARNING: An illegal
> reflective access operation has occurred WARNING: Illegal reflective access by
> org.codehaus.groovy.reflection.CachedClass
> (file:/Users/marcus.hirt/.m2/repository/org/codehaus/groovy/groovy-all/2.4.8/groovy-all-2.4.8.jar) to method
> java.lang.Object.finalize() WARNING: Please consider reporting this to the maintainers of
> org.codehaus.groovy.reflection.CachedClass WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations WARNING: All illegal access operations will be denied in a future release 14:06:33 run
> jetty - logging output to
> /Users/marcus.hirt/git/myrepos/jmcreviews/Schalli1987/jmc/target/build_20200914140619.2.jetty.log ps: illegal
> option -- - usage: ps [-AaCcEefhjlMmrSTvwXx] [-O fmt | -o fmt] [-G gid[,gid...]]
>           [-g grp[,grp...]] [-u [uid,uid...]]
>           [-p pid[,pid...]] [-t tty[,tty...]] [-U user[,user...]]
>        ps [-L]

Which version of ps do you use?
I have
$ ps --version
ps from procps-ng 3.3.16
The `--ppid` option was added in 3.1.6 back in 2003?

-------------

PR: https://git.openjdk.java.net/jmc/pull/100

From hirt at openjdk.java.net  Wed Sep 16 08:02:58 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 16 Sep 2020 08:02:58 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v3]
In-Reply-To: <7tkjs_xkme7anPIBV2ScujR_EJnFw8JOlsVz-r20iwE=.002745a4-8d4a-4f9d-a4fc-e4ddcb6ede2a@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
 <v-KsBg37x7Jp6oEyYJLH0prAiCcG3iMX9gDTW3-wKGM=.dbf84713-4586-4848-ae36-cd5ad03453e0@github.com>
 <UlIY7c2i7QyXvOBnMtN1lDv5JxGm02cQZpKsfngctWc=.59359258-caf1-46f1-b227-dfdb8bcd147d@github.com>
 <CG29bZ4aQ3-1baWsA8j5E_ZJf3eboLY1Lb17L6YWyxA=.fb85f542-0b89-4721-9bf3-5b09f729be94@github.com>
 <MXMFvTV1zg20aQGTMHpf-PRycbph4_E3nC0DmjAJVDc=.91a63fc3-7574-482f-9ec4-3ffefe448d36@github.com>
 <7tkjs_xkme7anPIBV2ScujR_EJnFw8JOlsVz-r20iwE=.002745a4-8d4a-4f9d-a4fc-e4ddcb6ede2a@github.com>
Message-ID: <HQnuLGvwxpPE8gpOSQltw4DesW5KYeNsjA7auhJX68A=.1044fee0-d96f-4660-aca9-a10c9aaa48b1@github.com>

On Tue, 15 Sep 2020 19:54:21 GMT, Schalli1987 <github.com+11866488+Schalli1987 at openjdk.org> wrote:

> Which version of ps do you use?

This is the Mac version of ps, which seems to have slightly different parameter set. I'm running on Catalina 10.15.6.

-------------

PR: https://git.openjdk.java.net/jmc/pull/100

From mwengner at openjdk.java.net  Wed Sep 16 17:54:57 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 16 Sep 2020 17:54:57 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v16]
In-Reply-To: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
Message-ID: <tWtdMr17_2aXPF-9fhScxZ9QJVXgbGwsi2VbdCCYnSw=.76e7dfeb-2bef-4ef8-831c-f72f3bce6460@github.com>

> stable flameview generation

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6542: code clean up

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/78/files
  - new: https://git.openjdk.java.net/jmc/pull/78/files/3de0f0e1..8d849ca5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=15
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=14-15

  Stats: 166 lines in 2 files changed: 85 ins; 33 del; 48 mod
  Patch: https://git.openjdk.java.net/jmc/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78

PR: https://git.openjdk.java.net/jmc/pull/78

From mwengner at openjdk.java.net  Wed Sep 16 18:00:37 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Wed, 16 Sep 2020 18:00:37 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v17]
In-Reply-To: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
Message-ID: <OiJpR8M05Kntr2EFtTmvImfmsWlCqhV5bkmSqRKyKuE=.fa185a0f-409b-48ac-b43d-82131fb02414@github.com>

> stable flameview generation

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6542: checkstyle

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/78/files
  - new: https://git.openjdk.java.net/jmc/pull/78/files/8d849ca5..534edf37

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=16
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=15-16

  Stats: 32 lines in 2 files changed: 2 ins; 2 del; 28 mod
  Patch: https://git.openjdk.java.net/jmc/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78

PR: https://git.openjdk.java.net/jmc/pull/78

From github.com+11866488+Schalli1987 at openjdk.java.net  Wed Sep 16 19:12:53 2020
From: github.com+11866488+Schalli1987 at openjdk.java.net (Schalli1987)
Date: Wed, 16 Sep 2020 19:12:53 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v4]
In-Reply-To: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
Message-ID: <rh0q0du_zA7kzrKc1MqmfHTU8HVK95-VLNCMeGwplBc=.509c57b8-2c90-4c0f-8c95-8fd66ae5a4ad@github.com>

> Second try, I signed the OCA last week (also I do not have any response).
> 
> This script provides an easy way to package JMC by just calling a single command.

Schalli1987 has updated the pull request incrementally with one additional commit since the last revision:

  kill jetty parent including child processes

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/100/files
  - new: https://git.openjdk.java.net/jmc/pull/100/files/e051a310..805cd6c3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=100&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=100&range=02-03

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/100.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/100/head:pull/100

PR: https://git.openjdk.java.net/jmc/pull/100

From github.com+11866488+Schalli1987 at openjdk.java.net  Wed Sep 16 19:12:53 2020
From: github.com+11866488+Schalli1987 at openjdk.java.net (Schalli1987)
Date: Wed, 16 Sep 2020 19:12:53 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v4]
In-Reply-To: <HQnuLGvwxpPE8gpOSQltw4DesW5KYeNsjA7auhJX68A=.1044fee0-d96f-4660-aca9-a10c9aaa48b1@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
 <v-KsBg37x7Jp6oEyYJLH0prAiCcG3iMX9gDTW3-wKGM=.dbf84713-4586-4848-ae36-cd5ad03453e0@github.com>
 <UlIY7c2i7QyXvOBnMtN1lDv5JxGm02cQZpKsfngctWc=.59359258-caf1-46f1-b227-dfdb8bcd147d@github.com>
 <CG29bZ4aQ3-1baWsA8j5E_ZJf3eboLY1Lb17L6YWyxA=.fb85f542-0b89-4721-9bf3-5b09f729be94@github.com>
 <MXMFvTV1zg20aQGTMHpf-PRycbph4_E3nC0DmjAJVDc=.91a63fc3-7574-482f-9ec4-3ffefe448d36@github.com>
 <7tkjs_xkme7anPIBV2ScujR_EJnFw8JOlsVz-r20iwE=.002745a4-8d4a-4f9d-a4fc-e4ddcb6ede2a@github.com>
 <HQnuLGvwxpPE8gpOSQltw4DesW5KYeNsjA7auhJX68A=.1044fee0-d96f-4660-aca9-a10c9aaa48b1@github.com>
Message-ID: <CPkW6NVs7TXwCqHnAjEpcKlDjLcNr3y9jdxnwJBEnf8=.c1fd8fc4-9892-4cf5-b87e-020506725238@github.com>

On Wed, 16 Sep 2020 08:00:36 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Which version of ps do you use?
>> I have
>> $ ps --version
>> ps from procps-ng 3.3.16
>> The `--ppid` option was added in 3.1.6 back in 2003?
>
>> Which version of ps do you use?
> 
> This is the Mac version of ps, which seems to have slightly different parameter set. I'm running on Catalina 10.15.6.

Tried another way to terminate jetty server, please check again.

-------------

PR: https://git.openjdk.java.net/jmc/pull/100

From hirt at openjdk.java.net  Thu Sep 17 09:03:07 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 17 Sep 2020 09:03:07 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v4]
In-Reply-To: <CPkW6NVs7TXwCqHnAjEpcKlDjLcNr3y9jdxnwJBEnf8=.c1fd8fc4-9892-4cf5-b87e-020506725238@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
 <v-KsBg37x7Jp6oEyYJLH0prAiCcG3iMX9gDTW3-wKGM=.dbf84713-4586-4848-ae36-cd5ad03453e0@github.com>
 <UlIY7c2i7QyXvOBnMtN1lDv5JxGm02cQZpKsfngctWc=.59359258-caf1-46f1-b227-dfdb8bcd147d@github.com>
 <CG29bZ4aQ3-1baWsA8j5E_ZJf3eboLY1Lb17L6YWyxA=.fb85f542-0b89-4721-9bf3-5b09f729be94@github.com>
 <MXMFvTV1zg20aQGTMHpf-PRycbph4_E3nC0DmjAJVDc=.91a63fc3-7574-482f-9ec4-3ffefe448d36@github.com>
 <7tkjs_xkme7anPIBV2ScujR_EJnFw8JOlsVz-r20iwE=.002745a4-8d4a-4f9d-a4fc-e4ddcb6ede2a@github.com>
 <HQnuLGvwxpPE8gpOSQltw4DesW5KYeNsjA7auhJX68A=.1044fee0-d96f-4660-aca9-a10c9aaa48b1@github.com>
 <CPkW6NVs7TXwCqHnAjEpcKlDjLcNr3y9jdxnwJBEnf8=.c1fd8fc4-9892-4cf5-b87e-020506725238@github.com>
Message-ID: <azg5FlpsfXPxGA8syOyk6bp-GFALzF_SH572xH6wIUg=.fe27e235-3276-498f-9307-7a7783366fd3@github.com>

On Wed, 16 Sep 2020 19:10:01 GMT, Schalli1987 <github.com+11866488+Schalli1987 at openjdk.org> wrote:

>>> Which version of ps do you use?
>> 
>> This is the Mac version of ps, which seems to have slightly different parameter set. I'm running on Catalina 10.15.6.
>
> Tried another way to terminate jetty server, please check again.

Hi @Schalli1987 - it will now wait indefinitely for the jetty server to start:

HIRTMAC:jmc marcus.hirt$ ./build.sh --packageJmc
10:36:42 building p2:site - logging output to
/Users/marcus.hirt/git/myrepos/jmcreviews/Schalli1987/jmc/target/build_20200917103639.1.p2_site.log 10:36:53 run
jetty - logging output to
/Users/marcus.hirt/git/myrepos/jmcreviews/Schalli1987/jmc/target/build_20200917103639.2.jetty.log 10:36:53 waiting for
jetty server to start 10:36:55 waiting for jetty server to start 10:36:56 waiting for jetty server to start
10:36:57 waiting for jetty server to start
10:36:58 waiting for jetty server to start
10:36:59 waiting for jetty server to start
10:37:00 waiting for jetty server to start
10:37:01 waiting for jetty server to start
10:37:02 waiting for jetty server to start
10:37:03 waiting for jetty server to start

It seems to be because after the line [INFO] Started Jetty Server, I also get these:
[INFO] Using Non-Native Java sun.nio.fs.PollingWatchService
[WARNING] Quiet Time is too low for non-native WatchService [sun.nio.fs.PollingWatchService]: 1000 < 5000 ms
(defaulting to 5000 ms)

Also - currently JMC requires Java 8 to build. Perhaps java -version could be checked to ensure that it is JDK 8?
Otherwise you get a whole bunch of cryptic illegal reflective access warnings:

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass
(file:/Users/marcus.hirt/.m2/repository/org/codehaus/groovy/groovy-all/2.4.8/groovy-all-2.4.8.jar) to method
java.lang.Object.finalize() WARNING: Please consider reporting this to the maintainers of
org.codehaus.groovy.reflection.CachedClass WARNING: Use --illegal-access=warn to enable warnings of further illegal
reflective access operations WARNING: All illegal access operations will be denied in a future release

Exiting with a message about switching to JDK 8 would be friendlier.

-------------

PR: https://git.openjdk.java.net/jmc/pull/100

From marcus.hirt at datadoghq.com  Thu Sep 17 15:45:48 2020
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Thu, 17 Sep 2020 17:45:48 +0200
Subject: Upgrading to Eclipse 2020-09 / requiring JDK 11
Message-ID: <CAOpWGx3U=V0a+sLKE2meiTQQ1vkkkyf4Cre-p3f5twVfjn8SGw@mail.gmail.com>

Hi all,

I propose that we adopt the latest Eclipse platform (2020-09 / 4.17). Since
2020-09 requires JDK 11, I therefore also propose requiring JDK 11 to run
the RCP application.

Please let me know your thoughts!

Kind regards,
Marcus

From marcus.hirt at datadoghq.com  Thu Sep 17 16:29:27 2020
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Thu, 17 Sep 2020 18:29:27 +0200
Subject: Core going JDK 8.
Message-ID: <CAOpWGx2A_znwVnknsK-gF+c8iZPte4d+YJJMyEbOncOe2pF3KA@mail.gmail.com>

Hi all,

Just a friendly reminder that we're going to move the core libraries up to
requiring JDK 8 for JMC 8 (nope, the JMC version number being 8 has nothing
to do with it, other than it being a major release where we can, for
example, drop support for older JDK releases).

Please let me know if you have any thoughts or concerns!

Kind regards,
Marcus

From github.com+11866488+Schalli1987 at openjdk.java.net  Thu Sep 17 18:08:13 2020
From: github.com+11866488+Schalli1987 at openjdk.java.net (Schalli1987)
Date: Thu, 17 Sep 2020 18:08:13 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v5]
In-Reply-To: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
Message-ID: <k8MGZUdhLCJ6FRyMEhNW791AJW0zCnHbD35IFulfbzs=.1680f6d2-854c-40b2-893e-4cea253ab421@github.com>

> Second try, I signed the OCA last week (also I do not have any response).
> 
> This script provides an easy way to package JMC by just calling a single command.

Schalli1987 has updated the pull request incrementally with one additional commit since the last revision:

  check entire jetty log for start messeage instead of only last line

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/100/files
  - new: https://git.openjdk.java.net/jmc/pull/100/files/805cd6c3..a0d6c435

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=100&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=100&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/100.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/100/head:pull/100

PR: https://git.openjdk.java.net/jmc/pull/100

From github.com+11866488+Schalli1987 at openjdk.java.net  Thu Sep 17 18:10:40 2020
From: github.com+11866488+Schalli1987 at openjdk.java.net (Schalli1987)
Date: Thu, 17 Sep 2020 18:10:40 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v5]
In-Reply-To: <azg5FlpsfXPxGA8syOyk6bp-GFALzF_SH572xH6wIUg=.fe27e235-3276-498f-9307-7a7783366fd3@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
 <v-KsBg37x7Jp6oEyYJLH0prAiCcG3iMX9gDTW3-wKGM=.dbf84713-4586-4848-ae36-cd5ad03453e0@github.com>
 <UlIY7c2i7QyXvOBnMtN1lDv5JxGm02cQZpKsfngctWc=.59359258-caf1-46f1-b227-dfdb8bcd147d@github.com>
 <CG29bZ4aQ3-1baWsA8j5E_ZJf3eboLY1Lb17L6YWyxA=.fb85f542-0b89-4721-9bf3-5b09f729be94@github.com>
 <MXMFvTV1zg20aQGTMHpf-PRycbph4_E3nC0DmjAJVDc=.91a63fc3-7574-482f-9ec4-3ffefe448d36@github.com>
 <7tkjs_xkme7anPIBV2ScujR_EJnFw8JOlsVz-r20iwE=.002745a4-8d4a-4f9d-a4fc-e4ddcb6ede2a@github.com>
 <HQnuLGvwxpPE8gpOSQltw4DesW5KYeNsjA7auhJX68A=.1044fee0-d96f-4660-aca9-a10c9aaa48b1@github.com>
 <CPkW6NVs7TXwCqHnAjEpcKlDjLcNr3y9jdxnwJBEnf8=.c1fd8fc4-9892-4cf5-b87e-020506725238@github.com>
 <azg5FlpsfXPxGA8syOyk6bp-GFALzF_SH572xH6wIUg=.fe27e235-3276-498f-9307-7a7783366fd3@github.com>
Message-ID: <TJUBGekQX-xoftR67fISQx2jOT40F8thg7V8CgRHNCY=.e7d0bfb7-3b28-42fd-ab93-b1a268447f95@github.com>

On Thu, 17 Sep 2020 09:00:19 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Tried another way to terminate jetty server, please check again.
>
> Hi @Schalli1987 - it will now wait indefinitely for the jetty server to start:
> 
> HIRTMAC:jmc marcus.hirt$ ./build.sh --packageJmc
> 10:36:42 building p2:site - logging output to
> /Users/marcus.hirt/git/myrepos/jmcreviews/Schalli1987/jmc/target/build_20200917103639.1.p2_site.log 10:36:53 run
> jetty - logging output to
> /Users/marcus.hirt/git/myrepos/jmcreviews/Schalli1987/jmc/target/build_20200917103639.2.jetty.log 10:36:53 waiting for
> jetty server to start 10:36:55 waiting for jetty server to start 10:36:56 waiting for jetty server to start
> 10:36:57 waiting for jetty server to start
> 10:36:58 waiting for jetty server to start
> 10:36:59 waiting for jetty server to start
> 10:37:00 waiting for jetty server to start
> 10:37:01 waiting for jetty server to start
> 10:37:02 waiting for jetty server to start
> 10:37:03 waiting for jetty server to start
> 
> It seems to be because after the line [INFO] Started Jetty Server, I also get these:
> [INFO] Using Non-Native Java sun.nio.fs.PollingWatchService
> [WARNING] Quiet Time is too low for non-native WatchService [sun.nio.fs.PollingWatchService]: 1000 < 5000 ms
> (defaulting to 5000 ms)
> Also - currently JMC requires Java 8 to build. Perhaps java -version could be checked to ensure that it is JDK 8?
> Otherwise you get a whole bunch of cryptic illegal reflective access warnings:
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass
> (file:/Users/marcus.hirt/.m2/repository/org/codehaus/groovy/groovy-all/2.4.8/groovy-all-2.4.8.jar) to method
> java.lang.Object.finalize() WARNING: Please consider reporting this to the maintainers of
> org.codehaus.groovy.reflection.CachedClass WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations WARNING: All illegal access operations will be denied in a future release
> Exiting with a message about switching to JDK 8 would be friendlier.

You're right, I didn't expect to be more output there, changed to check entire file.
I'm building and running JMC using JDK 11 without any issues, so I think there should be no enforcement for downgrading
to JDK 8. The illegal reflective access warnings shouldn't bother here.

-------------

PR: https://git.openjdk.java.net/jmc/pull/100

From hirt at openjdk.java.net  Thu Sep 17 18:38:14 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 17 Sep 2020 18:38:14 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v5]
In-Reply-To: <k8MGZUdhLCJ6FRyMEhNW791AJW0zCnHbD35IFulfbzs=.1680f6d2-854c-40b2-893e-4cea253ab421@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
 <k8MGZUdhLCJ6FRyMEhNW791AJW0zCnHbD35IFulfbzs=.1680f6d2-854c-40b2-893e-4cea253ab421@github.com>
Message-ID: <AUd5rTaTGLyY3RDHDXXKFkyE40fvrXXha9X9hQuMQCg=.a97166da-8a52-4e9c-9cbe-22efc66f6333@github.com>

On Thu, 17 Sep 2020 18:08:13 GMT, Schalli1987 <github.com+11866488+Schalli1987 at openjdk.org> wrote:

>> Second try, I signed the OCA last week (also I do not have any response).
>> 
>> This script provides an easy way to package JMC by just calling a single command.
>
> Schalli1987 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   check entire jetty log for start messeage instead of only last line

Just a small typo left, then we're good to go! :)

build.sh line 94:

> 92:     }
> 93:
> 94:     echo "$(date +%T) installing core artfacts - logging output to ${installLog}"

Typo. artfacts -> artifacts.

-------------

Changes requested by hirt (Lead).

PR: https://git.openjdk.java.net/jmc/pull/100

From github.com+11866488+Schalli1987 at openjdk.java.net  Fri Sep 18 19:26:07 2020
From: github.com+11866488+Schalli1987 at openjdk.java.net (Schalli1987)
Date: Fri, 18 Sep 2020 19:26:07 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v6]
In-Reply-To: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
Message-ID: <36J5BJiYZsBA2OWx4YHb0IYw1VVWLZYZAK4JuWvlKL4=.287f820b-5b3a-4885-bccf-53325997a8c3@github.com>

> Second try, I signed the OCA last week (also I do not have any response).
> 
> This script provides an easy way to package JMC by just calling a single command.

Schalli1987 has updated the pull request incrementally with one additional commit since the last revision:

  Fix typo

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/100/files
  - new: https://git.openjdk.java.net/jmc/pull/100/files/a0d6c435..fce3dfae

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=100&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=100&range=04-05

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/100.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/100/head:pull/100

PR: https://git.openjdk.java.net/jmc/pull/100

From hirt at openjdk.java.net  Fri Sep 18 19:43:40 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 18 Sep 2020 19:43:40 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v6]
In-Reply-To: <36J5BJiYZsBA2OWx4YHb0IYw1VVWLZYZAK4JuWvlKL4=.287f820b-5b3a-4885-bccf-53325997a8c3@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
 <36J5BJiYZsBA2OWx4YHb0IYw1VVWLZYZAK4JuWvlKL4=.287f820b-5b3a-4885-bccf-53325997a8c3@github.com>
Message-ID: <SKZi9NaTNJ_J_9XZhgyW1e1Pd0TLjU1d9j5LxowhaZg=.65dd7027-500e-4025-b553-f03a34504462@github.com>

On Fri, 18 Sep 2020 19:26:07 GMT, Schalli1987 <github.com+11866488+Schalli1987 at openjdk.org> wrote:

>> Second try, I signed the OCA last week (also I do not have any response).
>> 
>> This script provides an easy way to package JMC by just calling a single command.
>
> Schalli1987 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix typo

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/100

From hirt at openjdk.java.net  Fri Sep 18 19:48:00 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 18 Sep 2020 19:48:00 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v6]
In-Reply-To: <SKZi9NaTNJ_J_9XZhgyW1e1Pd0TLjU1d9j5LxowhaZg=.65dd7027-500e-4025-b553-f03a34504462@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
 <36J5BJiYZsBA2OWx4YHb0IYw1VVWLZYZAK4JuWvlKL4=.287f820b-5b3a-4885-bccf-53325997a8c3@github.com>
 <SKZi9NaTNJ_J_9XZhgyW1e1Pd0TLjU1d9j5LxowhaZg=.65dd7027-500e-4025-b553-f03a34504462@github.com>
Message-ID: <3nlwEpi6LsCJSKpfOk51FHpa5Zi-zrdO_PTjyMzOwgI=.d4d343a0-fdaa-42f1-a408-6e99d8cd28c8@github.com>

On Fri, 18 Sep 2020 19:40:39 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Schalli1987 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo
>
> Marked as reviewed by hirt (Lead).

JCheck seems to be failing:
"?? For contributors who are not existing OpenJDK Authors, commit attribution will be taken from the commits in the PR.
However, the commits in this PR have inconsistent user names and/or email addresses. Please amend the commits."

-------------

PR: https://git.openjdk.java.net/jmc/pull/100

From hirt at openjdk.java.net  Fri Sep 18 19:51:19 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 18 Sep 2020 19:51:19 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v6]
In-Reply-To: <3nlwEpi6LsCJSKpfOk51FHpa5Zi-zrdO_PTjyMzOwgI=.d4d343a0-fdaa-42f1-a408-6e99d8cd28c8@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
 <36J5BJiYZsBA2OWx4YHb0IYw1VVWLZYZAK4JuWvlKL4=.287f820b-5b3a-4885-bccf-53325997a8c3@github.com>
 <SKZi9NaTNJ_J_9XZhgyW1e1Pd0TLjU1d9j5LxowhaZg=.65dd7027-500e-4025-b553-f03a34504462@github.com>
 <3nlwEpi6LsCJSKpfOk51FHpa5Zi-zrdO_PTjyMzOwgI=.d4d343a0-fdaa-42f1-a408-6e99d8cd28c8@github.com>
Message-ID: <GtOt0IKepmdCIl3x52HTBPzHs0sH6j1Aq38lHJOB3EI=.a405eb37-070b-4ba0-b1a1-1da7b649e1d8@github.com>

On Fri, 18 Sep 2020 19:45:15 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Marked as reviewed by hirt (Lead).
>
> JCheck seems to be failing:
> "?? For contributors who are not existing OpenJDK Authors, commit attribution will be taken from the commits in the PR.
> However, the commits in this PR have inconsistent user names and/or email addresses. Please amend the commits."

Ugh:
Last commit:
Author: Schalli1987 <github at schal.li>
vs. other commits:
Author: Andreas Schaller <schalli1987 at gmail.com>

-------------

PR: https://git.openjdk.java.net/jmc/pull/100

From hirt at openjdk.java.net  Fri Sep 18 19:54:34 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 18 Sep 2020 19:54:34 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v6]
In-Reply-To: <GtOt0IKepmdCIl3x52HTBPzHs0sH6j1Aq38lHJOB3EI=.a405eb37-070b-4ba0-b1a1-1da7b649e1d8@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
 <36J5BJiYZsBA2OWx4YHb0IYw1VVWLZYZAK4JuWvlKL4=.287f820b-5b3a-4885-bccf-53325997a8c3@github.com>
 <SKZi9NaTNJ_J_9XZhgyW1e1Pd0TLjU1d9j5LxowhaZg=.65dd7027-500e-4025-b553-f03a34504462@github.com>
 <3nlwEpi6LsCJSKpfOk51FHpa5Zi-zrdO_PTjyMzOwgI=.d4d343a0-fdaa-42f1-a408-6e99d8cd28c8@github.com>
 <GtOt0IKepmdCIl3x52HTBPzHs0sH6j1Aq38lHJOB3EI=.a405eb37-070b-4ba0-b1a1-1da7b649e1d8@github.com>
Message-ID: <h2hCvRMNIj0ZOHUAFOr7ONHW_NArqRTGJiI4VdyHavk=.03be9404-d838-496e-8a3f-71335496bdb0@github.com>

On Fri, 18 Sep 2020 19:48:41 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> JCheck seems to be failing:
>> "?? For contributors who are not existing OpenJDK Authors, commit attribution will be taken from the commits in the PR.
>> However, the commits in this PR have inconsistent user names and/or email addresses. Please amend the commits."
>
> Ugh:
> Last commit:
> Author: Schalli1987 <github at schal.li>
> vs. other commits:
> Author: Andreas Schaller <schalli1987 at gmail.com>

@Schalli1987 - can you force push an amend?

-------------

PR: https://git.openjdk.java.net/jmc/pull/100

From github.com+11866488+Schalli1987 at openjdk.java.net  Sat Sep 19 08:07:04 2020
From: github.com+11866488+Schalli1987 at openjdk.java.net (Schalli1987)
Date: Sat, 19 Sep 2020 08:07:04 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v7]
In-Reply-To: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
Message-ID: <KCTYaCRH2b4KNC_gm1iEmcAnkMaG47rn-QYO4BzrENw=.04038bd0-25ef-4cc1-aa99-8df946234f60@github.com>

> Second try, I signed the OCA last week (also I do not have any response).
> 
> This script provides an easy way to package JMC by just calling a single command.

Schalli1987 has refreshed the contents of this pull request, and previous commits have been removed. The incremental
views will show differences compared to the previous content of the PR. The pull request contains one new commit since
the last revision:

  Fix typo

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/100/files
  - new: https://git.openjdk.java.net/jmc/pull/100/files/fce3dfae..deb105d3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=100&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=100&range=05-06

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/100.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/100/head:pull/100

PR: https://git.openjdk.java.net/jmc/pull/100

From github.com+11866488+Schalli1987 at openjdk.java.net  Sat Sep 19 08:07:04 2020
From: github.com+11866488+Schalli1987 at openjdk.java.net (Schalli1987)
Date: Sat, 19 Sep 2020 08:07:04 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v6]
In-Reply-To: <h2hCvRMNIj0ZOHUAFOr7ONHW_NArqRTGJiI4VdyHavk=.03be9404-d838-496e-8a3f-71335496bdb0@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
 <36J5BJiYZsBA2OWx4YHb0IYw1VVWLZYZAK4JuWvlKL4=.287f820b-5b3a-4885-bccf-53325997a8c3@github.com>
 <SKZi9NaTNJ_J_9XZhgyW1e1Pd0TLjU1d9j5LxowhaZg=.65dd7027-500e-4025-b553-f03a34504462@github.com>
 <3nlwEpi6LsCJSKpfOk51FHpa5Zi-zrdO_PTjyMzOwgI=.d4d343a0-fdaa-42f1-a408-6e99d8cd28c8@github.com>
 <GtOt0IKepmdCIl3x52HTBPzHs0sH6j1Aq38lHJOB3EI=.a405eb37-070b-4ba0-b1a1-1da7b649e1d8@github.com>
 <h2hCvRMNIj0ZOHUAFOr7ONHW_NArqRTGJiI4VdyHavk=.03be9404-d838-496e-8a3f-71335496bdb0@github.com>
Message-ID: <uttXU9Zqm6_uXwb2_3btwBIA0gf7w0e2YVXIiNvnLlU=.3986688e-e6f8-4394-a937-0cdbf619e602@github.com>

On Fri, 18 Sep 2020 19:51:59 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Ugh:
>> Last commit:
>> Author: Schalli1987 <github at schal.li>
>> vs. other commits:
>> Author: Andreas Schaller <schalli1987 at gmail.com>
>
> @Schalli1987 - can you force push an amend?

Done ??

-------------

PR: https://git.openjdk.java.net/jmc/pull/100

From hirt at openjdk.java.net  Sat Sep 19 18:56:09 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 19 Sep 2020 18:56:09 GMT
Subject: RFR: 6889: Provide build script for making it easier to build JMC
 [v6]
In-Reply-To: <uttXU9Zqm6_uXwb2_3btwBIA0gf7w0e2YVXIiNvnLlU=.3986688e-e6f8-4394-a937-0cdbf619e602@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
 <36J5BJiYZsBA2OWx4YHb0IYw1VVWLZYZAK4JuWvlKL4=.287f820b-5b3a-4885-bccf-53325997a8c3@github.com>
 <SKZi9NaTNJ_J_9XZhgyW1e1Pd0TLjU1d9j5LxowhaZg=.65dd7027-500e-4025-b553-f03a34504462@github.com>
 <3nlwEpi6LsCJSKpfOk51FHpa5Zi-zrdO_PTjyMzOwgI=.d4d343a0-fdaa-42f1-a408-6e99d8cd28c8@github.com>
 <GtOt0IKepmdCIl3x52HTBPzHs0sH6j1Aq38lHJOB3EI=.a405eb37-070b-4ba0-b1a1-1da7b649e1d8@github.com>
 <h2hCvRMNIj0ZOHUAFOr7ONHW_NArqRTGJiI4VdyHavk=.03be9404-d838-496e-8a3f-71335496bdb0@github.com>
 <uttXU9Zqm6_uXwb2_3btwBIA0gf7w0e2YVXIiNvnLlU=.3986688e-e6f8-4394-a937-0cdbf619e602@github.com>
Message-ID: <-pEnXTUx05hvDlFJDqy1O9z4vA-fwoWf8aWe4dsMpnM=.971fedd4-7fe6-47f2-97dc-d9eb4a3e22bb@github.com>

On Sat, 19 Sep 2020 08:00:54 GMT, Schalli1987 <github.com+11866488+Schalli1987 at openjdk.org> wrote:

>> @Schalli1987 - can you force push an amend?
>
> Done ??

Thank you @Schalli1987 for your contribution! ??

-------------

PR: https://git.openjdk.java.net/jmc/pull/100

From github.com+11866488+Schalli1987 at openjdk.java.net  Sat Sep 19 18:56:10 2020
From: github.com+11866488+Schalli1987 at openjdk.java.net (Schalli1987)
Date: Sat, 19 Sep 2020 18:56:10 GMT
Subject: Integrated: 6889: Provide build script for making it easier to build
 JMC
In-Reply-To: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
References: <8SDd3AYfWvUS7ewAym4GIU4-YuX9gkQPoiL3_Jznpgs=.2aceb975-6bd4-417b-b04a-559f021d351c@github.com>
Message-ID: <ZgHbfulcoOgxJn6MXsszduf9OER4wlI1ue7fTzoaVZY=.92ceada9-c6c3-4871-93d7-abbc6de059a9@github.com>

On Sat, 25 Jul 2020 16:17:18 GMT, Schalli1987 <github.com+11866488+Schalli1987 at openjdk.org> wrote:

> Second try, I signed the OCA last week (also I do not have any response).
> 
> This script provides an easy way to package JMC by just calling a single command.

This pull request has now been integrated.

Changeset: f17d3a9a
Author:    Andreas Schaller <schalli1987 at gmail.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/f17d3a9a
Stats:     215 lines in 2 files changed: 0 ins; 215 del; 0 mod

6889: Provide build script for making it easier to build JMC

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/100

From hirt at openjdk.java.net  Sat Sep 19 18:58:24 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 19 Sep 2020 18:58:24 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v17]
In-Reply-To: <OiJpR8M05Kntr2EFtTmvImfmsWlCqhV5bkmSqRKyKuE=.fa185a0f-409b-48ac-b43d-82131fb02414@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
 <OiJpR8M05Kntr2EFtTmvImfmsWlCqhV5bkmSqRKyKuE=.fa185a0f-409b-48ac-b43d-82131fb02414@github.com>
Message-ID: <gc3hxtvTEFsrNvUNvAD8nesRDU9l5wI36ak_d7vQfS4=.d6b68614-5a32-4190-a3f3-83d1666ec767@github.com>

On Wed, 16 Sep 2020 18:00:37 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> stable flameview generation
>
> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6542: checkstyle

application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceNode.java
line 45:

> 43: 	private final String packageName;
> 44: 	private final List<TraceNode> children = new ArrayList<>();
> 45: 	private boolean valid = true;

This is a weird abstraction. Is this really necessary?

-------------

PR: https://git.openjdk.java.net/jmc/pull/78

From mwengner at openjdk.java.net  Sun Sep 20 15:53:25 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Sun, 20 Sep 2020 15:53:25 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v18]
In-Reply-To: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
Message-ID: <0iaCTzmCKizlQQ9ywZ8d2EfxDTwS0Gc6nKhgS77h56E=.21f133e8-7188-48ee-8e32-7237758ef2d9@github.com>

> stable flameview generation

Miroslav Wengner has updated the pull request incrementally with two additional commits since the last revision:

 - 6542: cleanup unsused abstractions
 - 6542: correction, to speed up

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/78/files
  - new: https://git.openjdk.java.net/jmc/pull/78/files/534edf37..6968ba1c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=17
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=16-17

  Stats: 55 lines in 2 files changed: 9 ins; 36 del; 10 mod
  Patch: https://git.openjdk.java.net/jmc/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78

PR: https://git.openjdk.java.net/jmc/pull/78

From mwengner at openjdk.java.net  Sun Sep 20 20:04:17 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Sun, 20 Sep 2020 20:04:17 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v19]
In-Reply-To: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
Message-ID: <lG2uWO2R_sMV7yB0SrXnhdO3DF0aATTaxSlbKgpPSGc=.0b9c4a4a-bcac-4459-8acc-eb962ce06e69@github.com>

> stable flameview generation

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6542: clean up

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/78/files
  - new: https://git.openjdk.java.net/jmc/pull/78/files/6968ba1c..0a43d122

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=18
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=17-18

  Stats: 125 lines in 3 files changed: 7 ins; 84 del; 34 mod
  Patch: https://git.openjdk.java.net/jmc/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78

PR: https://git.openjdk.java.net/jmc/pull/78

From mwengner at openjdk.java.net  Sun Sep 20 20:04:18 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Sun, 20 Sep 2020 20:04:18 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v17]
In-Reply-To: <gc3hxtvTEFsrNvUNvAD8nesRDU9l5wI36ak_d7vQfS4=.d6b68614-5a32-4190-a3f3-83d1666ec767@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
 <OiJpR8M05Kntr2EFtTmvImfmsWlCqhV5bkmSqRKyKuE=.fa185a0f-409b-48ac-b43d-82131fb02414@github.com>
 <gc3hxtvTEFsrNvUNvAD8nesRDU9l5wI36ak_d7vQfS4=.d6b68614-5a32-4190-a3f3-83d1666ec767@github.com>
Message-ID: <JrUjasO9T9rsp4uGw4btlqiLj9VYfaNZoH9JGExDHqM=.747d6e24-8da6-4268-81f9-5505b0d6e446@github.com>

On Sat, 19 Sep 2020 18:55:44 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6542: checkstyle
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceNode.java
> line 45:
>> 43: 	private final String packageName;
>> 44: 	private final List<TraceNode> children = new ArrayList<>();
>> 45: 	private boolean valid = true;
> 
> This is a weird abstraction. Is this really necessary?

I've done a cleanup

-------------

PR: https://git.openjdk.java.net/jmc/pull/78

From github.com+65551+retronym at openjdk.java.net  Sun Sep 20 23:22:51 2020
From: github.com+65551+retronym at openjdk.java.net (Jason Zaugg)
Date: Sun, 20 Sep 2020 23:22:51 GMT
Subject: RFR: 6531: Make the flame chart view render labels on windows
In-Reply-To: <D6JGgBMlCbrFpxTTiOHRGI-4VTNmsOvYFMAsdS15Xg4=.8b73a5c5-7b02-49da-9a47-e13900361786@github.com>
References: <3T-jxid_jLmDFkY3ptEU22aLNooOUXnQhFEnAgI7ng8=.1467f94f-878e-41d1-a80c-0314da77ca50@github.com>
 <rQWhAfUNrrv9EZ1MJnai-yph6rBCN9j7nCK952DeU7Y=.ff750587-48e1-4eec-935d-ac24342b5592@github.com>
 <68acjbRMLklP3EHVSDntqrgJpPbAMXc_HVPpWxdUL2E=.1d2c78f4-ddda-4a33-ab00-e7cd1b116e80@github.com>
 <f0SFQCwQapl0oPglBdeITvNqyEyLVlMVSvu64MEEEEY=.5a18f0a1-6f5a-4860-81c8-29be08e444c3@github.com>
 <0eEKXCG5d03xu_ImemcyQ5KLGlJ3sQr55gGz6VljGJU=.0f85c639-7e93-446d-bc95-16b30849b38f@github.com>
 <B9U_4nf7rlcEdIKYkv1PC5fEJjNax4_vr1i2y5peneU=.a8a29aa1-255f-46fc-839e-be88c4fa4c64@github.com>
 <ivqR6SHKQaTTLSBQvLwmUhYhP99r1aOpbcbAqqKgb9E=.3d87afa0-eb46-4da5-917a-04e06ef6801a@github.com>
 <dhqwrkYmSw-_S8X3cjdgm255hRvRj6QiJuYb2tHxwxc=.71022587-a601-485a-90be-4b788804c826@github.com>
 <itkPmgiko2hsdljIYUwUBlR7NrUydkfJmtQ6MW27Z3c=.58ebe3f4-9770-4ce0-8c65-d329722c9f59@github.com>
 <opva9CslSAJIo73UhX2buH8NF-eSx65NrByRGolLSz4=.d17812ef-c6ae-4269-8041-c9217e474a87@github.com>
 <Vh6y9PFfZPHx57kQa0QA-mcV_68mk4jm72D
 4-TMwiqE=.2df41d2a-530f-4334-8797-cd558464bea6@github.com>
 <gpGSErP1mGcoi0VDtFKAORTmv9DGAsRy3EdmCXlEiOI=.2f4acfb4-4fb6-4a64-b2ed-fc3532089783@github.com>
 <EJ47e3EhcpBSxmL0RBR-VqFhkB8AI35h0hxnLWHQZRM=.8ee67b45-67b8-4d12-9c0f-bc691ae7ec28@github.com>
 <NbYWtojbROg8OHnZyVQLHxZohwADqCl_MtfbtgFLn10=.fe20c608-7ff7-4640-8815-91d9a683d2f1@github.com>
 <D6JGgBMlCbrFpxTTiOHRGI-4VTNmsOvYFMAsdS15Xg4=.8b73a5c5-7b02-49da-9a47-e13900361786@github.com>
Message-ID: <bQzUWow6NaSmRM7xsybEjWF-lDeqnkGJ1PcbGLNb0Ns=.e7148ad1-9611-415c-94f9-b8ec90838c14@github.com>

On Tue, 25 Aug 2020 14:20:05 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> :'(
>
> Chromium support has been added to SWT, and the Flamegraph should be able to display once configured.
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=549585
> As such, there is no specific support required for Windows, and this PR can be dropped.

Eclipse 2020-09-16 is now available which includes the upstream fix. @thegreystone Is upgrading just a matter of
replicated the previous upgrade in 0a1c4b38617cb77d16da33f2f0798926db23d7e9 ?

-------------

PR: https://git.openjdk.java.net/jmc/pull/41

From hirt at openjdk.java.net  Mon Sep 21 10:45:19 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 21 Sep 2020 10:45:19 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09
Message-ID: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>

Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
be the default.

-------------

Commit messages:
 - Adding Eclipse project
 - 6909: Upgrade to Eclipse 2020-09

Changes: https://git.openjdk.java.net/jmc/pull/111/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6909
  Stats: 94 lines in 6 files changed: 82 ins; 1 del; 11 mod
  Patch: https://git.openjdk.java.net/jmc/pull/111.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/111/head:pull/111

PR: https://git.openjdk.java.net/jmc/pull/111

From neugens at redhat.com  Mon Sep 21 11:05:11 2020
From: neugens at redhat.com (Mario Torre)
Date: Mon, 21 Sep 2020 13:05:11 +0200
Subject: Upgrading to Eclipse 2020-09 / requiring JDK 11
In-Reply-To: <CAOpWGx3U=V0a+sLKE2meiTQQ1vkkkyf4Cre-p3f5twVfjn8SGw@mail.gmail.com>
References: <CAOpWGx3U=V0a+sLKE2meiTQQ1vkkkyf4Cre-p3f5twVfjn8SGw@mail.gmail.com>
Message-ID: <CAJwKKmayPsU-hwNn=74NizMA+x=HFBG94CM20sMgUQ1azk8KWA@mail.gmail.com>

I think we should not require 11.

If we do, it means we can't support older Eclipse, I believe at this
stage the minimum version of Eclipse for JMC is still Photon? While I
recognise this is old at this point, if we bump to 2020-09 to be the
minimum supported we're stuck on getting the latest in every
distribution, which means everyone will need to have a JDK 11 to run
JMC, which isn't really an attractive option.

Perhaps this is something we can do with JMC 9 instead?

Cheers,
Mario

On Thu, Sep 17, 2020 at 5:47 PM Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
>
> Hi all,
>
> I propose that we adopt the latest Eclipse platform (2020-09 / 4.17). Since
> 2020-09 requires JDK 11, I therefore also propose requiring JDK 11 to run
> the RCP application.
>
> Please let me know your thoughts!
>
> Kind regards,
> Marcus
>


-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898


From marcus.hirt at datadoghq.com  Mon Sep 21 11:30:54 2020
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Mon, 21 Sep 2020 13:30:54 +0200
Subject: Upgrading to Eclipse 2020-09 / requiring JDK 11
In-Reply-To: <CAJwKKmayPsU-hwNn=74NizMA+x=HFBG94CM20sMgUQ1azk8KWA@mail.gmail.com>
References: <CAOpWGx3U=V0a+sLKE2meiTQQ1vkkkyf4Cre-p3f5twVfjn8SGw@mail.gmail.com>
 <CAJwKKmayPsU-hwNn=74NizMA+x=HFBG94CM20sMgUQ1azk8KWA@mail.gmail.com>
Message-ID: <CAOpWGx3cA+YzFOxXjehEGPSeqy=OJEWVbGYhm49mvWh2wLW3dA@mail.gmail.com>

Hi Mario,

You're quite right. I should have been more precise in my wording. 2020-09
is not the minimum, but the default. And if building with 2020-09 as the
platform, the resulting build will require JDK 11 to run.

If someone wants to build with 2020-06 or 2020-03, that will still be
possible for now. That said, 2020-09 should be the default, as there is
functionality there that we need, such as the chromium based embedded
browser without which the Flame Graph View will not work on Windows.

Requiring JDK 11 for the JMC application _code_ can wait for JMC 9.

Kind regards,
Marcus

On Mon, Sep 21, 2020 at 1:05 PM Mario Torre <neugens at redhat.com> wrote:

> I think we should not require 11.
>
> If we do, it means we can't support older Eclipse, I believe at this
> stage the minimum version of Eclipse for JMC is still Photon? While I
> recognise this is old at this point, if we bump to 2020-09 to be the
> minimum supported we're stuck on getting the latest in every
> distribution, which means everyone will need to have a JDK 11 to run
> JMC, which isn't really an attractive option.
>
> Perhaps this is something we can do with JMC 9 instead?
>
> Cheers,
> Mario
>
> On Thu, Sep 17, 2020 at 5:47 PM Marcus Hirt <marcus.hirt at datadoghq.com>
> wrote:
> >
> > Hi all,
> >
> > I propose that we adopt the latest Eclipse platform (2020-09 / 4.17).
> Since
> > 2020-09 requires JDK 11, I therefore also propose requiring JDK 11 to run
> > the RCP application.
> >
> > Please let me know your thoughts!
> >
> > Kind regards,
> > Marcus
> >
>
>
> --
> Mario Torre
> Associate Manager, Software Engineering
> Red Hat GmbH <https://www.redhat.com>
> 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
>
>

From neugens at openjdk.java.net  Mon Sep 21 11:58:48 2020
From: neugens at openjdk.java.net (Mario Torre)
Date: Mon, 21 Sep 2020 11:58:48 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09
In-Reply-To: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
Message-ID: <IhxAHakK5FML-vjivow0tpy8yMoybmqfpU_jXoBYo2s=.dd67ac6d-6bb4-46a5-86b8-0a2ddff71c0e@github.com>

On Mon, 21 Sep 2020 10:38:50 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
> be the default.

Looks good!

-------------

Marked as reviewed by neugens (Committer).

PR: https://git.openjdk.java.net/jmc/pull/111

From neugens at redhat.com  Mon Sep 21 11:58:14 2020
From: neugens at redhat.com (Mario Torre)
Date: Mon, 21 Sep 2020 13:58:14 +0200
Subject: Upgrading to Eclipse 2020-09 / requiring JDK 11
In-Reply-To: <CAOpWGx3cA+YzFOxXjehEGPSeqy=OJEWVbGYhm49mvWh2wLW3dA@mail.gmail.com>
References: <CAOpWGx3U=V0a+sLKE2meiTQQ1vkkkyf4Cre-p3f5twVfjn8SGw@mail.gmail.com>
 <CAJwKKmayPsU-hwNn=74NizMA+x=HFBG94CM20sMgUQ1azk8KWA@mail.gmail.com>
 <CAOpWGx3cA+YzFOxXjehEGPSeqy=OJEWVbGYhm49mvWh2wLW3dA@mail.gmail.com>
Message-ID: <CAJwKKmaorv=nEwZLQjNP2C7rv0DMeyQUBjupQaq8PwhvYJL=cA@mail.gmail.com>

On Mon, Sep 21, 2020 at 1:31 PM Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
>
> Hi Mario,
>
> You're quite right. I should have been more precise in my wording. 2020-09 is not the minimum, but the default. And if building with 2020-09 as the platform, the resulting build will require JDK 11 to run.
>
> If someone wants to build with 2020-06 or 2020-03, that will still be possible for now. That said, 2020-09 should be the default, as there is functionality there that we need, such as the chromium based embedded browser without which the Flame Graph View will not work on Windows.
>
> Requiring JDK 11 for the JMC application _code_ can wait for JMC 9.

Ah, that sounds better :)

I guess this is your https://github.com/openjdk/jmc/pull/111 then? I
just approved it.

Cheers,
Mario


-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898


From hirt at openjdk.java.net  Mon Sep 21 12:22:50 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 21 Sep 2020 12:22:50 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v2]
In-Reply-To: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
Message-ID: <lwBOb6d6Zth_T4HPCF-w2fka6Nw3PKSXvbd5BTBQoiQ=.d9adde27-9322-44a1-8fa4-00dd0a411f41@github.com>

> Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
> be the default.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Trying using JDK 11 to launch

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/111/files
  - new: https://git.openjdk.java.net/jmc/pull/111/files/366b8405..260ae180

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=00-01

  Stats: 12 lines in 1 file changed: 12 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/111.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/111/head:pull/111

PR: https://git.openjdk.java.net/jmc/pull/111

From ghb at openjdk.java.net  Mon Sep 21 14:40:04 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Mon, 21 Sep 2020 14:40:04 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v2]
In-Reply-To: <lwBOb6d6Zth_T4HPCF-w2fka6Nw3PKSXvbd5BTBQoiQ=.d9adde27-9322-44a1-8fa4-00dd0a411f41@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
 <lwBOb6d6Zth_T4HPCF-w2fka6Nw3PKSXvbd5BTBQoiQ=.d9adde27-9322-44a1-8fa4-00dd0a411f41@github.com>
Message-ID: <bKowDjWQ76N-ELAl-NoKuhYqBFsoteChW_WsXe7Np44=.098efdd2-0aec-4d05-8bb3-aabc1b6b3b3a@github.com>

On Mon, 21 Sep 2020 12:22:50 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
>> be the default.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Trying using JDK 11 to launch

Marked as reviewed by ghb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/111

From hirt at openjdk.java.net  Tue Sep 22 19:13:11 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 22 Sep 2020 19:13:11 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v3]
In-Reply-To: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
Message-ID: <VfFjGq2EepYe1-SUUxNKaovCmRE9ZU0EAmE2OqMdLl4=.95864219-ff3e-414c-aab8-80fdc2c0e923@github.com>

> Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
> be the default.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Switching to Tycho 2.0.0 for building, also fixing some annoying unused imports

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/111/files
  - new: https://git.openjdk.java.net/jmc/pull/111/files/260ae180..9c8daec6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=01-02

  Stats: 17 lines in 7 files changed: 1 ins; 13 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/111.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/111/head:pull/111

PR: https://git.openjdk.java.net/jmc/pull/111

From aptmac at openjdk.java.net  Tue Sep 22 20:32:24 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Tue, 22 Sep 2020 20:32:24 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v2]
In-Reply-To: <bKowDjWQ76N-ELAl-NoKuhYqBFsoteChW_WsXe7Np44=.098efdd2-0aec-4d05-8bb3-aabc1b6b3b3a@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
 <lwBOb6d6Zth_T4HPCF-w2fka6Nw3PKSXvbd5BTBQoiQ=.d9adde27-9322-44a1-8fa4-00dd0a411f41@github.com>
 <bKowDjWQ76N-ELAl-NoKuhYqBFsoteChW_WsXe7Np44=.098efdd2-0aec-4d05-8bb3-aabc1b6b3b3a@github.com>
Message-ID: <66n4er2bxT2VNQCZil7U4CVm8_B44a4NZ5q7MKTYecQ=.78e3feaf-4981-439e-82b1-8b680343230e@github.com>

On Mon, 21 Sep 2020 14:37:22 GMT, Guru Hb <ghb at openjdk.org> wrote:

>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Trying using JDK 11 to launch
>
> Marked as reviewed by ghb (Reviewer).

The current build failures are because `application/pom.xml` contains `-XX:+UnlockCommercialFeatures` in the
`jfr.vmargs` that gets used by jfr-related unit tests. [0]

However, the fix for jdk11 isn't as easy as just removing that arg, because the unit tests that use JFR were set-up for
an older version it would appear, and formatting causes many tests to fail:
https://api.travis-ci.org/v3/job/699425288/log.txt

[0] https://github.com/openjdk/jmc/blob/master/application/pom.xml#L49

-------------

PR: https://git.openjdk.java.net/jmc/pull/111

From mwengner at openjdk.java.net  Tue Sep 22 21:01:24 2020
From: mwengner at openjdk.java.net (Miroslav Wengner)
Date: Tue, 22 Sep 2020 21:01:24 GMT
Subject: RFR: 6542: Improve calls to render in the flame view [v20]
In-Reply-To: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
References: <c3FGcM26-hI82YXG5PwHRmZrFZT6R2fdnw1TtxOib1I=.932e4c55-d47d-4cc3-88e5-f5abb7d62f22@github.com>
Message-ID: <Xmof_RKkV8zx6k0SNx707jOO1Z8GFQD1d6FtbcFBBso=.78a2f05f-8518-49d9-ada1-53eedddd85d3@github.com>

> stable flameview generation

Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:

  6542: more cleanup

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/78/files
  - new: https://git.openjdk.java.net/jmc/pull/78/files/0a43d122..0a72a815

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=19
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=78&range=18-19

  Stats: 9 lines in 2 files changed: 1 ins; 6 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/78.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/78/head:pull/78

PR: https://git.openjdk.java.net/jmc/pull/78

From hirt at openjdk.java.net  Wed Sep 23 22:19:45 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 23 Sep 2020 22:19:45 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v2]
In-Reply-To: <66n4er2bxT2VNQCZil7U4CVm8_B44a4NZ5q7MKTYecQ=.78e3feaf-4981-439e-82b1-8b680343230e@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
 <lwBOb6d6Zth_T4HPCF-w2fka6Nw3PKSXvbd5BTBQoiQ=.d9adde27-9322-44a1-8fa4-00dd0a411f41@github.com>
 <bKowDjWQ76N-ELAl-NoKuhYqBFsoteChW_WsXe7Np44=.098efdd2-0aec-4d05-8bb3-aabc1b6b3b3a@github.com>
 <66n4er2bxT2VNQCZil7U4CVm8_B44a4NZ5q7MKTYecQ=.78e3feaf-4981-439e-82b1-8b680343230e@github.com>
Message-ID: <XOf1FqM_Q7JcI-oPdof3zQmCgUFJwWtgTrCEayturh0=.55ae1a66-615a-4bdc-a54f-43f5c41c15c2@github.com>

On Tue, 22 Sep 2020 20:29:39 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Marked as reviewed by ghb (Reviewer).
>
> The current build failures are because `application/pom.xml` contains `-XX:+UnlockCommercialFeatures` in the
> `jfr.vmargs` that gets used by jfr-related unit tests. [0]
> However, the fix for jdk11 isn't as easy as just removing that arg, because the unit tests that use JFR were set-up for
> an older version it would appear, and formatting causes many tests to fail:
> https://api.travis-ci.org/v3/job/699425288/log.txt  [0]
> https://github.com/openjdk/jmc/blob/master/application/pom.xml#L49

Yups. Will be taking a closer look as soon as I find a few minutes of peace and quiet.

-------------

PR: https://git.openjdk.java.net/jmc/pull/111

From hirt at openjdk.java.net  Thu Sep 24 01:37:12 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 24 Sep 2020 01:37:12 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v4]
In-Reply-To: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
Message-ID: <qf2W__hbR-1WhcuNjPFBIxGWMjhbHUdxUGB06iskQ64=.d2b629a5-8c04-4fa2-ad86-99d098b03be0@github.com>

> Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
> be the default.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Updating JFR tests to run on OpenJDK / JFR 2.0

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/111/files
  - new: https://git.openjdk.java.net/jmc/pull/111/files/9c8daec6..8623d9a5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=02-03

  Stats: 682 lines in 16 files changed: 61 ins; 9 del; 612 mod
  Patch: https://git.openjdk.java.net/jmc/pull/111.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/111/head:pull/111

PR: https://git.openjdk.java.net/jmc/pull/111

From hirt at openjdk.java.net  Thu Sep 24 02:04:24 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 24 Sep 2020 02:04:24 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v5]
In-Reply-To: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
Message-ID: <xHRy316taldtuSuaBNCjiZ03K-voB0PfevrN3zFMcUM=.7cce5fa4-8654-40ad-97eb-ca3fd849564f@github.com>

> Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
> be the default.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Formatting

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/111/files
  - new: https://git.openjdk.java.net/jmc/pull/111/files/8623d9a5..71607b75

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=03-04

  Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/111.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/111/head:pull/111

PR: https://git.openjdk.java.net/jmc/pull/111

From hirt at openjdk.java.net  Thu Sep 24 02:35:10 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Thu, 24 Sep 2020 02:35:10 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v6]
In-Reply-To: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
Message-ID: <ATaEcP4VocNZCJ_Lv6u27O-YB_OEMNoZCFphLpSC3NQ=.d4e65d91-810b-4ae6-8da6-e94f26c8436e@github.com>

> Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
> be the default.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Assume OpenJDK

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/111/files
  - new: https://git.openjdk.java.net/jmc/pull/111/files/71607b75..07b4e10f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=04-05

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/111.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/111/head:pull/111

PR: https://git.openjdk.java.net/jmc/pull/111

From marcus.hirt at datadoghq.com  Thu Sep 24 12:06:59 2020
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Thu, 24 Sep 2020 14:06:59 +0200
Subject: Moving the jmc7 repo to Git / GitHub / Skara?
Message-ID: <CAOpWGx0ShDupdxu431JS1uqmy6Gonw+-HdmdSFMy2e5_QGe_CA@mail.gmail.com>

Hi all,

Erik Helin just offered to move the jmc7 repo to Skara. What do you think?

Kind regards,
Marcus

From jkang at redhat.com  Thu Sep 24 18:51:43 2020
From: jkang at redhat.com (Jie Kang)
Date: Thu, 24 Sep 2020 14:51:43 -0400
Subject: Moving the jmc7 repo to Git / GitHub / Skara?
In-Reply-To: <CAOpWGx0ShDupdxu431JS1uqmy6Gonw+-HdmdSFMy2e5_QGe_CA@mail.gmail.com>
References: <CAOpWGx0ShDupdxu431JS1uqmy6Gonw+-HdmdSFMy2e5_QGe_CA@mail.gmail.com>
Message-ID: <CAEBeOcpBmTJhUXZCPTxHhceYTfb9HzV4qUvMgLnNbdkZgPMQ5A@mail.gmail.com>

I'd find it more convenient to have all the jmc repositories using the
same version control system, in this case Git.


Regards,
Jie Kang
Senior Software Engineer, Red Hat Canada

On Thu, Sep 24, 2020 at 8:07 AM Marcus Hirt <marcus.hirt at datadoghq.com> wrote:
>
> Hi all,
>
> Erik Helin just offered to move the jmc7 repo to Skara. What do you think?
>
> Kind regards,
> Marcus
>


From hirt at openjdk.java.net  Fri Sep 25 18:52:57 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 25 Sep 2020 18:52:57 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v7]
In-Reply-To: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
Message-ID: <65o03iuI5DKALpuFryFY3KSuuc9gcLtCrCMzQHoVy-A=.dbbb1cc2-5418-4afc-838c-160ccbd52aa8@github.com>

> Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
> be the default.

Marcus Hirt has updated the pull request incrementally with two additional commits since the last revision:

 - Update for running the UI-tests
 - Fixing UI-tests

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/111/files
  - new: https://git.openjdk.java.net/jmc/pull/111/files/07b4e10f..482e8e6d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=05-06

  Stats: 14 lines in 2 files changed: 1 ins; 6 del; 7 mod
  Patch: https://git.openjdk.java.net/jmc/pull/111.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/111/head:pull/111

PR: https://git.openjdk.java.net/jmc/pull/111

From github.com+924885+jpstotz at openjdk.java.net  Mon Sep 28 12:02:00 2020
From: github.com+924885+jpstotz at openjdk.java.net (Jan S.)
Date: Mon, 28 Sep 2020 12:02:00 GMT
Subject: RFR: 6913: Add daemon thread information to the console threads view
Message-ID: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>

I had an Java application which did not exit because of a non-daemon thread still running. Therefore I added a column
to the treads view that displays if a thread is a daemon thread or not.

oca: has been signed on 2019-01-17 (got positive response from Dalibor Topic on 2019-01-23).

-------------

Commit messages:
 - code formatting
 - Threads view: "deamon" column added

Changes: https://git.openjdk.java.net/jmc/pull/110/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=110&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6913
  Stats: 11 lines in 4 files changed: 10 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/110.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/110/head:pull/110

PR: https://git.openjdk.java.net/jmc/pull/110

From aptmac at openjdk.java.net  Mon Sep 28 12:02:04 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 28 Sep 2020 12:02:04 GMT
Subject: RFR: 6913: Add daemon thread information to the console threads
 view
In-Reply-To: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
References: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
Message-ID: <NsHuTOvfH63q1O1AdYKmcYXeQw_R8tGScIHGque-r44=.0944bcd3-cc8d-48ff-83e0-9ee75e3d934e@github.com>

On Thu, 17 Sep 2020 11:15:57 GMT, Jan S. <github.com+924885+jpstotz at openjdk.org> wrote:

> I had an Java application which did not exit because of a non-daemon thread still running. Therefore I added a column
> to the treads view that displays if a thread is a daemon thread or not.
> oca: has been signed on 2019-01-17 (got positive response from Dalibor Topic on 2019-01-23).

Hi @jpstotz !

The new daemon column looks okay and works well. Having said that, this won't work on jvms running on jdk8 [0]; the
daemon information is added to `java.lang.management.ThreadInfo` as of jdk9 [1], and trying to use this column on a
jdk8 jvm results in an error dialog (which when paired with the polling nature of the console pages makes this rather
difficult to close jmc).

Let me know if you need a JIRA issue created for this PR and I can set one up.

[0] https://docs.oracle.com/javase/8/docs/api/java/lang/management/ThreadInfo.html
[1] https://docs.oracle.com/javase/9/docs/api/index.html?java/lang/management/ThreadInfo.html

-------------

PR: https://git.openjdk.java.net/jmc/pull/110

From github.com+924885+jpstotz at openjdk.java.net  Mon Sep 28 12:02:08 2020
From: github.com+924885+jpstotz at openjdk.java.net (Jan S.)
Date: Mon, 28 Sep 2020 12:02:08 GMT
Subject: RFR: 6913: Add daemon thread information to the console threads
 view
In-Reply-To: <NsHuTOvfH63q1O1AdYKmcYXeQw_R8tGScIHGque-r44=.0944bcd3-cc8d-48ff-83e0-9ee75e3d934e@github.com>
References: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
 <NsHuTOvfH63q1O1AdYKmcYXeQw_R8tGScIHGque-r44=.0944bcd3-cc8d-48ff-83e0-9ee75e3d934e@github.com>
Message-ID: <Ud2TC1JU4GMe7g3PdioqKO5BLCoBOq_YL-Vr6xFrXKg=.111d7cb3-ac83-467c-abd4-23d087d6386b@github.com>

On Wed, 23 Sep 2020 21:15:43 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> I had an Java application which did not exit because of a non-daemon thread still running. Therefore I added a column
>> to the treads view that displays if a thread is a daemon thread or not.
>> oca: has been signed on 2019-01-17 (got positive response from Dalibor Topic on 2019-01-23).
>
> Hi @jpstotz !
> 
> The new daemon column looks okay and works well. Having said that, this won't work on jvms running on jdk8 [0]; the
> daemon information is added to `java.lang.management.ThreadInfo` as of jdk9 [1], and trying to use this column on a
> jdk8 jvm results in an error dialog (which when paired with the polling nature of the console pages makes this rather
> difficult to close jmc).  Let me know if you need a JIRA issue created for this PR and I can set one up.
> [0] https://docs.oracle.com/javase/8/docs/api/java/lang/management/ThreadInfo.html
> [1] https://docs.oracle.com/javase/9/docs/api/index.html?java/lang/management/ThreadInfo.html

@aptmac Thanks for reviewing my patch.
I had not noticed that there is a Java version restriction on the used ThreadInfo class. As (daemon) threads are
nothing new in Java this is really a surprise to me that this information is not available on Java 8. But now it makes
perfectly sense why jmc did not already provide such a column.

As mitigation I would assume that the best way would be to check the Java version number before adding the `isDaemon`
in `org.openjdk.jmc.console.ui.tabs.threads.ThreadTableSectionPart`. Hopefully the other definitions in
ThreadInfoCompositeSupport don't cause any problems if not used.

I will check this out and update my patch.

Regarding the JIRA issue this would be nice of you.

-------------

PR: https://git.openjdk.java.net/jmc/pull/110

From aptmac at openjdk.java.net  Mon Sep 28 12:02:10 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 28 Sep 2020 12:02:10 GMT
Subject: RFR: 6913: Add daemon thread information to the console threads
 view
In-Reply-To: <Ud2TC1JU4GMe7g3PdioqKO5BLCoBOq_YL-Vr6xFrXKg=.111d7cb3-ac83-467c-abd4-23d087d6386b@github.com>
References: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
 <NsHuTOvfH63q1O1AdYKmcYXeQw_R8tGScIHGque-r44=.0944bcd3-cc8d-48ff-83e0-9ee75e3d934e@github.com>
 <Ud2TC1JU4GMe7g3PdioqKO5BLCoBOq_YL-Vr6xFrXKg=.111d7cb3-ac83-467c-abd4-23d087d6386b@github.com>
Message-ID: <OLlVTAq4VJdEegCFMs1GZRkklE1Y5PfEfgjmimfEyBk=.db2a17d9-9ca7-49da-8ea2-0ab72336ca76@github.com>

On Thu, 24 Sep 2020 08:27:59 GMT, Jan S. <github.com+924885+jpstotz at openjdk.org> wrote:

>> Hi @jpstotz !
>> 
>> The new daemon column looks okay and works well. Having said that, this won't work on jvms running on jdk8 [0]; the
>> daemon information is added to `java.lang.management.ThreadInfo` as of jdk9 [1], and trying to use this column on a
>> jdk8 jvm results in an error dialog (which when paired with the polling nature of the console pages makes this rather
>> difficult to close jmc).  Let me know if you need a JIRA issue created for this PR and I can set one up.
>> [0] https://docs.oracle.com/javase/8/docs/api/java/lang/management/ThreadInfo.html
>> [1] https://docs.oracle.com/javase/9/docs/api/index.html?java/lang/management/ThreadInfo.html
>
> @aptmac Thanks for reviewing my patch.
> I had not noticed that there is a Java version restriction on the used ThreadInfo class. As (daemon) threads are
> nothing new in Java this is really a surprise to me that this information is not available on Java 8. But now it makes
> perfectly sense why jmc did not already provide such a column.   As mitigation I would assume that the best way would
> be to check the Java version number before adding the `isDaemon` in
> `org.openjdk.jmc.console.ui.tabs.threads.ThreadTableSectionPart`. Hopefully the other definitions in
> ThreadInfoCompositeSupport don't cause any problems if not used.   I will check this out and update my patch.
> 
> Regarding the JIRA issue this would be nice of you.

@jpstotz Great, I've created a JIRA issue for this enhancement, it can be found at:
https://bugs.openjdk.java.net/browse/JMC-6913

-------------

PR: https://git.openjdk.java.net/jmc/pull/110

From github.com+924885+jpstotz at openjdk.java.net  Mon Sep 28 12:02:13 2020
From: github.com+924885+jpstotz at openjdk.java.net (Jan S.)
Date: Mon, 28 Sep 2020 12:02:13 GMT
Subject: RFR: 6913: Add daemon thread information to the console threads
 view
In-Reply-To: <OLlVTAq4VJdEegCFMs1GZRkklE1Y5PfEfgjmimfEyBk=.db2a17d9-9ca7-49da-8ea2-0ab72336ca76@github.com>
References: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
 <NsHuTOvfH63q1O1AdYKmcYXeQw_R8tGScIHGque-r44=.0944bcd3-cc8d-48ff-83e0-9ee75e3d934e@github.com>
 <Ud2TC1JU4GMe7g3PdioqKO5BLCoBOq_YL-Vr6xFrXKg=.111d7cb3-ac83-467c-abd4-23d087d6386b@github.com>
 <OLlVTAq4VJdEegCFMs1GZRkklE1Y5PfEfgjmimfEyBk=.db2a17d9-9ca7-49da-8ea2-0ab72336ca76@github.com>
Message-ID: <kTGd9ZQCb39I5QRV4pw6AkTbZyWikSrDlHNeywOzXHI=.f7311509-c89f-4bda-bcff-136030f9c786@github.com>

On Thu, 24 Sep 2020 14:11:46 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> @aptmac Thanks for reviewing my patch.
>> I had not noticed that there is a Java version restriction on the used ThreadInfo class. As (daemon) threads are
>> nothing new in Java this is really a surprise to me that this information is not available on Java 8. But now it makes
>> perfectly sense why jmc did not already provide such a column.   As mitigation I would assume that the best way would
>> be to check the Java version number before adding the `isDaemon` in
>> `org.openjdk.jmc.console.ui.tabs.threads.ThreadTableSectionPart`. Hopefully the other definitions in
>> ThreadInfoCompositeSupport don't cause any problems if not used.   I will check this out and update my patch.
>> 
>> Regarding the JIRA issue this would be nice of you.
>
> @jpstotz Great, I've created a JIRA issue for this enhancement, it can be found at:
> https://bugs.openjdk.java.net/browse/JMC-6913

@aptmac I just noticed that you were not talking about the JVM running JMC but about the JVM JMC is connected to. That
makes a version check a bit more complicated, at least I don't see a way to do so with my limited knowledge on JMC.

My current approach uses a Getter in `org.openjdk.jmc.console.ui.tabs.threads.ThreadInfoCompositeSupport` that catches
potential `InvalidKeyException` that occur when enabling the Daemon column on a Java 8 VM.  In such a case a defined
error string like "Data not available" is returned and shown for each thread as value in the Daemon column.

Do you think this is a suitable approach?

-------------

PR: https://git.openjdk.java.net/jmc/pull/110

From github.com+4610701+jpbempel at openjdk.java.net  Mon Sep 28 17:59:42 2020
From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Mon, 28 Sep 2020 17:59:42 GMT
Subject: RFR: 6766: Add heap usage before and after GC to the GC table
Message-ID: <FmGNJ1AJayDV_PlfvZQ6z6ReoHNWx4QeaDOpHJJa0cg=.8e7ea41d-d0ab-4aaf-9334-88c183c25512@github.com>

Columns are hidden for now

Here some screenshots of the changes:

![JMC_UsedHeapBeforeAfterGC](https://user-images.githubusercontent.com/4610701/94465934-f030a300-01c0-11eb-8492-2b921f695833.png)



![JMC_UsedHeapBeforeAfterGCColumns](https://user-images.githubusercontent.com/4610701/94465962-fc1c6500-01c0-11eb-8dc9-5b3346668381.png)

-------------

Commit messages:
 - Add heap usage before and after GC to the GC table

Changes: https://git.openjdk.java.net/jmc/pull/112/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=112&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6766
  Stats: 16 lines in 3 files changed: 14 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/112.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/112/head:pull/112

PR: https://git.openjdk.java.net/jmc/pull/112

From hirt at openjdk.java.net  Mon Sep 28 18:03:22 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 28 Sep 2020 18:03:22 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v8]
In-Reply-To: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
Message-ID: <SzaWpHZielUCaI4P5wrRPhrq-ii-4M6N8LlwU3HzVII=.c6d55ae5-37ad-40d5-b433-e3b1e16893a6@github.com>

> Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
> be the default.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Making tests pass with the Oracle JDK

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/111/files
  - new: https://git.openjdk.java.net/jmc/pull/111/files/482e8e6d..c4af215e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=06-07

  Stats: 95 lines in 2 files changed: 79 ins; 12 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/111.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/111/head:pull/111

PR: https://git.openjdk.java.net/jmc/pull/111

From hirt at openjdk.java.net  Mon Sep 28 18:37:29 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 28 Sep 2020 18:37:29 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v9]
In-Reply-To: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
Message-ID: <51NVMfAPnDgcYkY-6bWU9ganEZj6IaTRDr6MikkXFZE=.5f3383a3-47a3-47e7-8a38-819038208f05@github.com>

> Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
> be the default.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Updating the binary location for Windows

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/111/files
  - new: https://git.openjdk.java.net/jmc/pull/111/files/c4af215e..53dd5528

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=08
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=07-08

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/111.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/111/head:pull/111

PR: https://git.openjdk.java.net/jmc/pull/111

From hirt at openjdk.java.net  Mon Sep 28 20:50:16 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 28 Sep 2020 20:50:16 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v10]
In-Reply-To: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
Message-ID: <8gOmjuh4j_Ci0wusclHY6fbIRx5XqMCfZUpq9FQjPhY=.44e25bbf-7b3f-4fb5-8e5a-ce7ce0f1ea46@github.com>

> Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
> be the default.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Updating the linux path to the executable in the readme

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/111/files
  - new: https://git.openjdk.java.net/jmc/pull/111/files/53dd5528..fe8e7dc4

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=09
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=08-09

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/111.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/111/head:pull/111

PR: https://git.openjdk.java.net/jmc/pull/111

From hirt at openjdk.java.net  Mon Sep 28 20:58:59 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 28 Sep 2020 20:58:59 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v11]
In-Reply-To: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
Message-ID: <xv2fo6mK3JOybJvem5Ibe7PED6e-MH4rPD9lo-kCiJI=.e40ef7b7-c9ac-49d9-a16b-e565043bfb4a@github.com>

> Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
> be the default.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Upgrading the version of the maven download plug-in

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/111/files
  - new: https://git.openjdk.java.net/jmc/pull/111/files/fe8e7dc4..6e5a56c3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=10
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=09-10

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/111.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/111/head:pull/111

PR: https://git.openjdk.java.net/jmc/pull/111

From schaturvedi at openjdk.java.net  Mon Sep 28 21:10:28 2020
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Mon, 28 Sep 2020 21:10:28 GMT
Subject: RFR: 6364: Improvements to the Thread Graph
In-Reply-To: <te05v9SDdp77tUGnpxxtE4WvBeHTsoyZK1xxITVaAXE=.094e17e2-1599-4d6f-89c8-1311786ab932@github.com>
References: <3b_EN291IWMTMl6vId_3HM3r9b2p0Bjxd9QYH5qgDO8=.50cc047a-4486-469a-a341-5908f78bb6df@github.com>
 <9z2_Fmh0wzUWsp9Tu1bEudv8_BvAjeAC6RVPPe76FRQ=.1d13e3bc-3d48-4a9b-831f-40b784d57106@github.com>
 <RzkGUXMijABPraKoBm2yRnh7490ldPx8R1pVnLkZuQo=.49c6a560-d0bc-4870-8fc8-6b16c31a4edf@github.com>
 <VtxWPdJ5lCNJANcyQQKDpUAc6oMz6sIIl4AdCngGzNY=.3e9e164a-aeca-4a31-9c0d-90b32e505e1f@github.com>
 <WlsAE5WBZzvaJ7y6s_9776LfwPZxInEyw-9tHkR8BYQ=.cac2ca35-320a-4955-b4ad-9f03cf91e67d@github.com>
 <W46pwscvWVhGWOQ7fZuohiPU3PDSr_fTBcjsYEHZX9U=.3ded4679-f3c5-4fa0-8d3f-febe4b5ff1ae@github.com>
 <PkxbYIW2PTQI6EKSG2QBPXGZsLN_4YAmK8tBzom9Zcc=.6ac6a27f-cb8f-4d40-b910-8f209468280b@github.com>
 <1rFwH_fS08Lr6VT09rAPl5aOjeoDyyfAK1l1DaktMB8=.e94b0d05-4244-46b2-848e-c83f7aa3917a@github.com>
 <m106gabj2MTdvJuIG-7VzB4GU0GwsWw8FvwMStXJvzM=.60dbba90-bc44-4759-9e45-4cc07727fb54@github.com>
 <uGE8OtyeKVfipTGVyNCcHDrlfaxDEBGqhCdPhqjlv8o=.43a35c17-ad84-4831-87ad-740cfbdd7ed1@github.com>
 <jO40oBcEPc8zoPazOkBHqUm813eWjRpi5RJ
 qYv_QCeU=.976e6cb5-a240-4e7d-b2e7-307a66903740@github.com>
 <s8PRQ3LPX5LFCZGk47tfu4T8JfguQGuKNOu6ysh3eo8=.5062e28b-b947-45b7-aaff-4e52f01c3a92@github.com>
 <te05v9SDdp77tUGnpxxtE4WvBeHTsoyZK1xxITVaAXE=.094e17e2-1599-4d6f-89c8-1311786ab932@github.com>
Message-ID: <gAZnxXu30whSmrmWEqfVRZczClOSfJ3pRT0IImh3gak=.38917981-4205-4c56-9726-608dbb19e1f5@github.com>

On Tue, 15 Sep 2020 14:44:41 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> I also noticed that the overview mode indicates "too much content", for recording of applications having a high number
>> of threads. And when the display area is not big enough, e.g. on 13 inches laptop or when the thread table is expanded.
>>  
>> ![too much content on overview, thread table
>> expanded](https://user-images.githubusercontent.com/803621/91659801-7a0e2300-ead2-11ea-911b-ebf4e79d3228.png)
>> ![overview ok, external screen, thread table
>> hidden](https://user-images.githubusercontent.com/803621/91659799-72e71500-ead2-11ea-8ebf-7433031fae2b.png)
>> _Of course the application has a design issue (with this manyfold threads) but the point remain in my opinion._
>> 
>> The new view works great otherwise.
>> 
>> I'll be happy to sharemy private startup and continuous JFR files if needed. Here's those of JMC when I took these
>> snapshots. [startup-thread-view.zip](https://github.com/openjdk/jmc/files/5146861/startup-thread-view.zip)
>
> Hi @bric3! Thanks for taking a look at this PR and providing your feedback, the screenshots and jfr files you attached
> were also very much appreciated!
>> Hi, I noticed that when selecting a part of thread lane, like an event, then the cell/label is half dimed :
> 
> Good find, I'll poke around and see what I can do to get that to highlight the rest of the lane name.
> 
>> I also noticed that the overview mode indicates "too much content", for recording of applications having a high number
>> of threads. And when the display area is not big enough, e.g. on 13 inches laptop or when the thread table is expanded.
> 
> Thanks for finding this and sharing your jfr file too. I'll have to poke around with some different screen sizes and
> see what adjustments can be made here. The "too much content" overlay happens to the current threads page lanes under
> size restrictions, it looks like having the table above the chart causes it to reach this state a bit earlier than
> before.

"Edit Thread Lanes" at top right corner and "Thread State Selection" button, both are opening the same pop up.

Just a suggestion, Should we keep one and skip the other?

-------------

PR: https://git.openjdk.java.net/jmc/pull/27

From hirt at openjdk.java.net  Tue Sep 29 12:42:27 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 29 Sep 2020 12:42:27 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v12]
In-Reply-To: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
Message-ID: <mtP-9BNww6HYfDvp-6mabJMrmI9C7CcIU-VKlJETyBg=.1be90677-44ed-49cf-85ab-83e44de9ba57@github.com>

> Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
> be the default.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Fixing some connection leaks in tests and adding debuggability features

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/111/files
  - new: https://git.openjdk.java.net/jmc/pull/111/files/6e5a56c3..88f6e093

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=11
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=10-11

  Stats: 381 lines in 3 files changed: 194 ins; 173 del; 14 mod
  Patch: https://git.openjdk.java.net/jmc/pull/111.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/111/head:pull/111

PR: https://git.openjdk.java.net/jmc/pull/111

From hirt at openjdk.java.net  Tue Sep 29 13:47:37 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 29 Sep 2020 13:47:37 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v13]
In-Reply-To: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
Message-ID: <PkKBW8gz1-iGYZXEwSs8GgJbCeznZjSzYA5s_q8E6vM=.10722998-e116-466f-8fc7-1c17e89c413c@github.com>

> Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
> be the default.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Formatting

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/111/files
  - new: https://git.openjdk.java.net/jmc/pull/111/files/88f6e093..e0711d6f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=12
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=111&range=11-12

  Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/111.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/111/head:pull/111

PR: https://git.openjdk.java.net/jmc/pull/111

From aptmac at openjdk.java.net  Tue Sep 29 16:03:00 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Tue, 29 Sep 2020 16:03:00 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v13]
In-Reply-To: <PkKBW8gz1-iGYZXEwSs8GgJbCeznZjSzYA5s_q8E6vM=.10722998-e116-466f-8fc7-1c17e89c413c@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
 <PkKBW8gz1-iGYZXEwSs8GgJbCeznZjSzYA5s_q8E6vM=.10722998-e116-466f-8fc7-1c17e89c413c@github.com>
Message-ID: <les4C7Fk15L281nsKLrCbamsuuB6O0D4scz7gekw__g=.1a09752d-b4df-44ef-9731-f8a608a06cf8@github.com>

On Tue, 29 Sep 2020 13:47:37 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
>> be the default.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Formatting

lgtm; tested on both linux & windows.

Linux: unit tests pass
Windows: unit & uitests complete and pass

-------------

Marked as reviewed by aptmac (Committer).

PR: https://git.openjdk.java.net/jmc/pull/111

From hirt at openjdk.java.net  Tue Sep 29 17:05:36 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 29 Sep 2020 17:05:36 GMT
Subject: RFR: 6766: Add heap usage before and after GC to the Garbage
 Collections table
In-Reply-To: <FmGNJ1AJayDV_PlfvZQ6z6ReoHNWx4QeaDOpHJJa0cg=.8e7ea41d-d0ab-4aaf-9334-88c183c25512@github.com>
References: <FmGNJ1AJayDV_PlfvZQ6z6ReoHNWx4QeaDOpHJJa0cg=.8e7ea41d-d0ab-4aaf-9334-88c183c25512@github.com>
Message-ID: <QZiegjW9wKEh3RRkR17h2XYHgiG_kK1OJc5LXsc8-SA=.61d7e850-594f-48e9-98ad-2cc46fcfdef4@github.com>

On Mon, 28 Sep 2020 17:30:35 GMT, Jean-Philippe Bempel <github.com+4610701+jpbempel at openjdk.org> wrote:

> Columns are hidden for now
> 
> Here some screenshots of the changes:
> 
> ![JMC_UsedHeapBeforeAfterGC](https://user-images.githubusercontent.com/4610701/94465934-f030a300-01c0-11eb-8492-2b921f695833.png)
> 
> 
> 
> ![JMC_UsedHeapBeforeAfterGCColumns](https://user-images.githubusercontent.com/4610701/94465962-fc1c6500-01c0-11eb-8dc9-5b3346668381.png)

Changes requested by hirt (Lead).

application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties
line 298:

> 296: GarbageCollectionsPage_ROW_PAUSE_PHASES_DESC=Phases of the garbage collection pauses
> 297: GarbageCollectionsPage_TIMELINE_SELECTION=Garbage Collections Timeline Selection
> 298: GarbageCollectionsPage_USED_HEAP_AFTERGC=Used Heap After GC

Underscore between AFTER and GC, and BEFORE and GC. See e.g. HEAP_SUMMARY_BEFORE_GC. Otherwise all looks fine! ??

-------------

PR: https://git.openjdk.java.net/jmc/pull/112

From aptmac at openjdk.java.net  Tue Sep 29 21:06:48 2020
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Tue, 29 Sep 2020 21:06:48 GMT
Subject: RFR: 6913: Add daemon thread information to the console threads
 view
In-Reply-To: <kTGd9ZQCb39I5QRV4pw6AkTbZyWikSrDlHNeywOzXHI=.f7311509-c89f-4bda-bcff-136030f9c786@github.com>
References: <rgx1CIbr7_mIY2kFZUAeBA21NnhMFachfkar8rxatuY=.eae29d4e-9714-4664-bbcf-cc0c9d01e427@github.com>
 <NsHuTOvfH63q1O1AdYKmcYXeQw_R8tGScIHGque-r44=.0944bcd3-cc8d-48ff-83e0-9ee75e3d934e@github.com>
 <Ud2TC1JU4GMe7g3PdioqKO5BLCoBOq_YL-Vr6xFrXKg=.111d7cb3-ac83-467c-abd4-23d087d6386b@github.com>
 <OLlVTAq4VJdEegCFMs1GZRkklE1Y5PfEfgjmimfEyBk=.db2a17d9-9ca7-49da-8ea2-0ab72336ca76@github.com>
 <kTGd9ZQCb39I5QRV4pw6AkTbZyWikSrDlHNeywOzXHI=.f7311509-c89f-4bda-bcff-136030f9c786@github.com>
Message-ID: <ac5V29xE9j7rjNh4jYIBOLagiIh8Z3J_OpTUms81Lbw=.009172e8-4149-4407-b1a4-f194c69c9466@github.com>

On Thu, 24 Sep 2020 16:06:29 GMT, Jan S. <github.com+924885+jpstotz at openjdk.org> wrote:

> My current approach uses a Getter in `org.openjdk.jmc.console.ui.tabs.threads.ThreadInfoCompositeSupport` that catches
> potential `InvalidKeyException` that occur when enabling the Daemon column on a Java 8 VM. In such a case a defined
> error string like "Data not available" is returned and shown for each thread as value in the Daemon column.
> Do you think this is a suitable approach?

Yes, catching the exception in the `Getter.getMember()` could work. Alternatively, it might be cleaner to implement
this like `IS_DEADLOCKED` or `GET_ALLOCATED_BYTES`, which also perform a check to see if the feature is enabled or not.

-------------

PR: https://git.openjdk.java.net/jmc/pull/110

From ghb at openjdk.java.net  Wed Sep 30 11:41:39 2020
From: ghb at openjdk.java.net (Guru Hb)
Date: Wed, 30 Sep 2020 11:41:39 GMT
Subject: RFR: 6909: Upgrade to Eclipse 2020-09 [v13]
In-Reply-To: <PkKBW8gz1-iGYZXEwSs8GgJbCeznZjSzYA5s_q8E6vM=.10722998-e116-466f-8fc7-1c17e89c413c@github.com>
References: <F_QeZD0kXkWPlwfG3jJpMbvk56DR6jWuEVY_YlGw0ek=.0e4dab9e-35d2-4240-b735-aa8c48fe2de2@github.com>
 <PkKBW8gz1-iGYZXEwSs8GgJbCeznZjSzYA5s_q8E6vM=.10722998-e116-466f-8fc7-1c17e89c413c@github.com>
Message-ID: <iLKO7-FFSOfUW28qfw6FdWryecP0d9JNUagrnABVI8k=.898638ae-bcad-4f78-9d12-7e0610b21d97@github.com>

On Tue, 29 Sep 2020 13:47:37 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Adds the Eclipse 2020-09 platform, upgrades 2020-09 and 2020-06 to use the 2020-06 babel bundles, and sets 2020-09 to
>> be the default.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Formatting

Looks good to me, Verified unittest on windows and linux.

-------------

Marked as reviewed by ghb (Reviewer).

PR: https://git.openjdk.java.net/jmc/pull/111

From hirt at openjdk.java.net  Wed Sep 30 17:42:47 2020
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 30 Sep 2020 17:42:47 GMT
Subject: RFR: 6364: Improvements to the Thread Graph
In-Reply-To: <gAZnxXu30whSmrmWEqfVRZczClOSfJ3pRT0IImh3gak=.38917981-4205-4c56-9726-608dbb19e1f5@github.com>
References: <3b_EN291IWMTMl6vId_3HM3r9b2p0Bjxd9QYH5qgDO8=.50cc047a-4486-469a-a341-5908f78bb6df@github.com>
 <9z2_Fmh0wzUWsp9Tu1bEudv8_BvAjeAC6RVPPe76FRQ=.1d13e3bc-3d48-4a9b-831f-40b784d57106@github.com>
 <RzkGUXMijABPraKoBm2yRnh7490ldPx8R1pVnLkZuQo=.49c6a560-d0bc-4870-8fc8-6b16c31a4edf@github.com>
 <VtxWPdJ5lCNJANcyQQKDpUAc6oMz6sIIl4AdCngGzNY=.3e9e164a-aeca-4a31-9c0d-90b32e505e1f@github.com>
 <WlsAE5WBZzvaJ7y6s_9776LfwPZxInEyw-9tHkR8BYQ=.cac2ca35-320a-4955-b4ad-9f03cf91e67d@github.com>
 <W46pwscvWVhGWOQ7fZuohiPU3PDSr_fTBcjsYEHZX9U=.3ded4679-f3c5-4fa0-8d3f-febe4b5ff1ae@github.com>
 <PkxbYIW2PTQI6EKSG2QBPXGZsLN_4YAmK8tBzom9Zcc=.6ac6a27f-cb8f-4d40-b910-8f209468280b@github.com>
 <1rFwH_fS08Lr6VT09rAPl5aOjeoDyyfAK1l1DaktMB8=.e94b0d05-4244-46b2-848e-c83f7aa3917a@github.com>
 <m106gabj2MTdvJuIG-7VzB4GU0GwsWw8FvwMStXJvzM=.60dbba90-bc44-4759-9e45-4cc07727fb54@github.com>
 <uGE8OtyeKVfipTGVyNCcHDrlfaxDEBGqhCdPhqjlv8o=.43a35c17-ad84-4831-87ad-740cfbdd7ed1@github.com>
 <jO40oBcEPc8zoPazOkBHqUm813eWjRpi5RJ
 qYv_QCeU=.976e6cb5-a240-4e7d-b2e7-307a66903740@github.com>
 <s8PRQ3LPX5LFCZGk47tfu4T8JfguQGuKNOu6ysh3eo8=.5062e28b-b947-45b7-aaff-4e52f01c3a92@github.com>
 <te05v9SDdp77tUGnpxxtE4WvBeHTsoyZK1xxITVaAXE=.094e17e2-1599-4d6f-89c8-1311786ab932@github.com>
 <gAZnxXu30whSmrmWEqfVRZczClOSfJ3pRT0IImh3gak=.38917981-4205-4c56-9726-608dbb19e1f5@github.com>
Message-ID: <PrIx9JRSzJv5-338n2kxEG2thm9pLRRUeeCuuYCz208=.122c1e7d-8f9c-40e3-b0f3-0354cd49bd79@github.com>

On Mon, 28 Sep 2020 21:07:35 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> Hi @bric3! Thanks for taking a look at this PR and providing your feedback, the screenshots and jfr files you attached
>> were also very much appreciated!
>>> Hi, I noticed that when selecting a part of thread lane, like an event, then the cell/label is half dimed :
>> 
>> Good find, I'll poke around and see what I can do to get that to highlight the rest of the lane name.
>> 
>>> I also noticed that the overview mode indicates "too much content", for recording of applications having a high number
>>> of threads. And when the display area is not big enough, e.g. on 13 inches laptop or when the thread table is expanded.
>> 
>> Thanks for finding this and sharing your jfr file too. I'll have to poke around with some different screen sizes and
>> see what adjustments can be made here. The "too much content" overlay happens to the current threads page lanes under
>> size restrictions, it looks like having the table above the chart causes it to reach this state a bit earlier than
>> before.
>
> "Edit Thread Lanes" at top right corner and "Thread State Selection" button, both are opening the same pop up.
> 
> Just a suggestion, Should we keep one and skip the other?

@guruhb - do you and/or Suchita want to review this PR?

-------------

PR: https://git.openjdk.java.net/jmc/pull/27