RFR: 6889: Provide build script for making it easier to build JMC [v2]

Marcus Hirt hirt at openjdk.java.net
Sat Sep 12 21:57:28 UTC 2020


On Sat, 12 Sep 2020 18:49:29 GMT, Schalli1987 <github.com+11866488+Schalli1987 at openjdk.org> wrote:

>> Second try, I signed the OCA last week (also I do not have any response).
>> 
>> This script provides an easy way to package JMC by just calling a single command.
>
> Schalli1987 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add OSTYPE and run option to build script

build.sh line 193:

> 191: function checkPreconditions() {
> 192:     if ! command -v   mvn &> /dev/null ; then
> 193:         err_log "It seems you do not have maven installed. Please ensure you have it installend and executable as
> \"mvn\"."

Typo "installend" -> "installed".

build.sh line 198:

> 196:
> 197:     if ! command -v   java &> /dev/null ; then
> 198:         err_log "It seems you do not have java installed. Please ensure you have it installend and executable as
> \"java\"."

Typo "installend" -> "installed".

build.sh line 105:

> 103:
> 104:     if [[ "${OSTYPE}" =~ "linux"* ]]; then
> 105:         echo "You can now run jmc by calling ${BASEDIR}/products/org.openjdk.jmc/linux/gtk/x86_64/JDK\ Mission\
> Control/jmc"

Perhaps refer to --run? You can now run jmc by calling this script with --run, or by calling...

-------------

PR: https://git.openjdk.java.net/jmc/pull/100


More information about the jmc-dev mailing list