RFR: 6889: Provide build script for making it easier to build JMC [v4]

[Marcus Hirt]

On Wed, 16 Sep 2020 19:10:01 GMT, Schalli1987 <github.com+11866488+Schalli1987 at openjdk.org> wrote:

>>> Which version of ps do you use?
>> 
>> This is the Mac version of ps, which seems to have slightly different parameter set. I'm running on Catalina 10.15.6.
>
> Tried another way to terminate jetty server, please check again.

Hi @Schalli1987 - it will now wait indefinitely for the jetty server to start:

HIRTMAC:jmc marcus.hirt$ ./build.sh --packageJmc
10:36:42 building p2:site - logging output to
/Users/marcus.hirt/git/myrepos/jmcreviews/Schalli1987/jmc/target/build_20200917103639.1.p2_site.log 10:36:53 run
jetty - logging output to
/Users/marcus.hirt/git/myrepos/jmcreviews/Schalli1987/jmc/target/build_20200917103639.2.jetty.log 10:36:53 waiting for
jetty server to start 10:36:55 waiting for jetty server to start 10:36:56 waiting for jetty server to start
10:36:57 waiting for jetty server to start
10:36:58 waiting for jetty server to start
10:36:59 waiting for jetty server to start
10:37:00 waiting for jetty server to start
10:37:01 waiting for jetty server to start
10:37:02 waiting for jetty server to start
10:37:03 waiting for jetty server to start

It seems to be because after the line [INFO] Started Jetty Server, I also get these:
[INFO] Using Non-Native Java sun.nio.fs.PollingWatchService
[WARNING] Quiet Time is too low for non-native WatchService [sun.nio.fs.PollingWatchService]: 1000 < 5000 ms
(defaulting to 5000 ms)

Also - currently JMC requires Java 8 to build. Perhaps java -version could be checked to ensure that it is JDK 8?
Otherwise you get a whole bunch of cryptic illegal reflective access warnings:

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass
(file:/Users/marcus.hirt/.m2/repository/org/codehaus/groovy/groovy-all/2.4.8/groovy-all-2.4.8.jar) to method
java.lang.Object.finalize() WARNING: Please consider reporting this to the maintainers of
org.codehaus.groovy.reflection.CachedClass WARNING: Use --illegal-access=warn to enable warnings of further illegal
reflective access operations WARNING: All illegal access operations will be denied in a future release

Exiting with a message about switching to JDK 8 would be friendlier.

-------------

PR: https://git.openjdk.java.net/jmc/pull/100