RFR: 6542: Improve calls to render in the flame view [v17]

Miroslav Wengner mwengner at openjdk.java.net
Sun Sep 20 20:04:18 UTC 2020


On Sat, 19 Sep 2020 18:55:44 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6542: checkstyle
>
> application/org.openjdk.jmc.flightrecorder.flameview/src/main/java/org/openjdk/jmc/flightrecorder/flameview/tree/TraceNode.java
> line 45:
>> 43: 	private final String packageName;
>> 44: 	private final List<TraceNode> children = new ArrayList<>();
>> 45: 	private boolean valid = true;
> 
> This is a weird abstraction. Is this really necessary?

I've done a cleanup

-------------

PR: https://git.openjdk.java.net/jmc/pull/78


More information about the jmc-dev mailing list