RFR: 6364: Improvements to the Thread Graph
Marcus Hirt
hirt at openjdk.java.net
Wed Sep 30 17:42:47 UTC 2020
On Mon, 28 Sep 2020 21:07:35 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:
>> Hi @bric3! Thanks for taking a look at this PR and providing your feedback, the screenshots and jfr files you attached
>> were also very much appreciated!
>>> Hi, I noticed that when selecting a part of thread lane, like an event, then the cell/label is half dimed :
>>
>> Good find, I'll poke around and see what I can do to get that to highlight the rest of the lane name.
>>
>>> I also noticed that the overview mode indicates "too much content", for recording of applications having a high number
>>> of threads. And when the display area is not big enough, e.g. on 13 inches laptop or when the thread table is expanded.
>>
>> Thanks for finding this and sharing your jfr file too. I'll have to poke around with some different screen sizes and
>> see what adjustments can be made here. The "too much content" overlay happens to the current threads page lanes under
>> size restrictions, it looks like having the table above the chart causes it to reach this state a bit earlier than
>> before.
>
> "Edit Thread Lanes" at top right corner and "Thread State Selection" button, both are opening the same pop up.
>
> Just a suggestion, Should we keep one and skip the other?
@guruhb - do you and/or Suchita want to review this PR?
-------------
PR: https://git.openjdk.java.net/jmc/pull/27
More information about the jmc-dev
mailing list