From marcus.hirt at datadoghq.com Thu Apr 1 10:46:03 2021 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Thu, 1 Apr 2021 12:46:03 +0200 Subject: Result: New jmc Committer: Jean-Phillippe Bempel Message-ID: Voting for Jean-Phillippe Bempel [1] is now closed. Yes: 7 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Kind regards, Marcus [1] https://mail.openjdk.java.net/pipermail/jmc-dev/2021-March/003437.html (Date typo correction: https://mail.openjdk.java.net/pipermail/jmc-dev/2021-March/003439.html.) From ghb at openjdk.java.net Thu Apr 1 15:28:23 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Thu, 1 Apr 2021 15:28:23 GMT Subject: RFR: 7162: Stop using the chromium library based browser component Message-ID: Removed Chromium library usage on Windows ------------- Commit messages: - 7162: Stop using the chromium library based browser component Changes: https://git.openjdk.java.net/jmc/pull/234/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=234&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7162 Stats: 32 lines in 7 files changed: 0 ins; 31 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/234.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/234/head:pull/234 PR: https://git.openjdk.java.net/jmc/pull/234 From hirt at openjdk.java.net Thu Apr 1 21:35:10 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 1 Apr 2021 21:35:10 GMT Subject: RFR: 7162: Stop using the chromium library based browser component In-Reply-To: References: Message-ID: On Thu, 1 Apr 2021 15:24:09 GMT, Guru Hb wrote: > Removed Chromium library usage on Windows Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/234 From hirt at openjdk.java.net Fri Apr 2 00:11:33 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 2 Apr 2021 00:11:33 GMT Subject: RFR: 7046: Update to the 2021-03 platform Message-ID: Also updating to latest babel for the platform versions that are available in 0.18.3. Depending on if #234 gets in before or after this one, either this one will need to be updated to remove the chromium entry, or #234 will need to be updated to do it. (Is it just me, or does JMC start really fast on 4.19? :) ) ------------- Commit messages: - 7046: Update to the 2021-03 platform Changes: https://git.openjdk.java.net/jmc/pull/235/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=235&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7046 Stats: 110 lines in 6 files changed: 93 ins; 3 del; 14 mod Patch: https://git.openjdk.java.net/jmc/pull/235.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/235/head:pull/235 PR: https://git.openjdk.java.net/jmc/pull/235 From ghb at openjdk.java.net Fri Apr 2 07:27:17 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Fri, 2 Apr 2021 07:27:17 GMT Subject: RFR: 7046: Update to the 2021-03 platform In-Reply-To: References: Message-ID: On Fri, 2 Apr 2021 00:05:51 GMT, Marcus Hirt wrote: > Also updating to latest babel for the platform versions that are available in 0.18.3. > > Depending on if #234 gets in before or after this one, either this one will need to be updated to remove the chromium entry, or #234 will need to be updated to do it. > > (Is it just me, or does JMC start really fast on 4.19? :) ) Compiled on Ubuntu, Mac and Windows did some basic sanity test. Looks good to me. ------------- Marked as reviewed by ghb (Reviewer). PR: https://git.openjdk.java.net/jmc/pull/235 From ghb at openjdk.java.net Fri Apr 2 07:29:07 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Fri, 2 Apr 2021 07:29:07 GMT Subject: Integrated: 7162: Stop using the chromium library based browser component In-Reply-To: References: Message-ID: On Thu, 1 Apr 2021 15:24:09 GMT, Guru Hb wrote: > Removed Chromium library usage on Windows This pull request has now been integrated. Changeset: f1a63ecf Author: Guru Hb URL: https://git.openjdk.java.net/jmc/commit/f1a63ecf Stats: 32 lines in 7 files changed: 0 ins; 31 del; 1 mod 7162: Stop using the chromium library based browser component Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/234 From github.com+4610701+jpbempel at openjdk.java.net Fri Apr 2 07:50:40 2021 From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Fri, 2 Apr 2021 07:50:40 GMT Subject: RFR: 7031: Build a constant pool explorer page [v2] In-Reply-To: References: Message-ID: > Add under Recording a new Page for ConstantPools > Help to visualize what's inside constant pools part of a JFR recording > > ![JMC_ConstantPoolsPage](https://user-images.githubusercontent.com/4610701/110855759-13569700-82b7-11eb-9981-deb0b8b5e185.png) > > *Draft* > - Icon is copy/paste from recording. If you have idea about how to replace it... > - I have limited the tables to the search toolbar, visible by default > - a hidden count column for constant values helps you find out when you duplicates constant (for OldObjectSample event issue) should not be useful otherwise Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: load state for SASH ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/228/files - new: https://git.openjdk.java.net/jmc/pull/228/files/a3a17f91..7069d49f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=228&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=228&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/228.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/228/head:pull/228 PR: https://git.openjdk.java.net/jmc/pull/228 From github.com+4610701+jpbempel at openjdk.java.net Fri Apr 2 08:16:07 2021 From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Fri, 2 Apr 2021 08:16:07 GMT Subject: RFR: 7031: Build a constant pool explorer page [v2] In-Reply-To: References: Message-ID: On Mon, 29 Mar 2021 20:07:03 GMT, Henrik Dafg?rd wrote: >> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: >> >> load state for SASH > > application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ConstantPoolsPage.java line 178: > >> 176: @Override >> 177: public void saveTo(IWritableState writableState) { >> 178: PersistableSashForm.saveState(sash, writableState.createChild(SASH_ELEMENT)); > > This saves the state of the SashForm, but that state isn't loaded in the IPageUI constructor, so the value used will only be the default for a SashForm. > > E.g. `PersistableSashForm.loadState(sash, state.getChild(SASH));` done ------------- PR: https://git.openjdk.java.net/jmc/pull/228 From hirt at openjdk.java.net Fri Apr 2 10:54:31 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 2 Apr 2021 10:54:31 GMT Subject: RFR: 7046: Update to the 2021-03 platform [v2] In-Reply-To: References: Message-ID: > Also updating to latest babel for the platform versions that are available in 0.18.3. > > Depending on if #234 gets in before or after this one, either this one will need to be updated to remove the chromium entry, or #234 will need to be updated to do it. > > (Is it just me, or does JMC start really fast on 4.19? :) ) Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into 7046-update-2021-03 - Removing chromium - 7046: Update to the 2021-03 platform ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/235/files - new: https://git.openjdk.java.net/jmc/pull/235/files/7c2d7155..004195df Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=235&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=235&range=00-01 Stats: 204 lines in 21 files changed: 111 ins; 37 del; 56 mod Patch: https://git.openjdk.java.net/jmc/pull/235.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/235/head:pull/235 PR: https://git.openjdk.java.net/jmc/pull/235 From ghb at openjdk.java.net Fri Apr 2 13:51:16 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Fri, 2 Apr 2021 13:51:16 GMT Subject: RFR: 7046: Update to the 2021-03 platform [v2] In-Reply-To: References: Message-ID: On Fri, 2 Apr 2021 10:54:31 GMT, Marcus Hirt wrote: >> Also updating to latest babel for the platform versions that are available in 0.18.3. >> >> Depending on if #234 gets in before or after this one, either this one will need to be updated to remove the chromium entry, or #234 will need to be updated to do it. >> >> (Is it just me, or does JMC start really fast on 4.19? :) ) > > Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into 7046-update-2021-03 > - Removing chromium > - 7046: Update to the 2021-03 platform Marked as reviewed by ghb (Reviewer). ------------- PR: https://git.openjdk.java.net/jmc/pull/235 From github.com+803621+bric3 at openjdk.java.net Fri Apr 2 16:41:32 2021 From: github.com+803621+bric3 at openjdk.java.net (Brice Dutheil) Date: Fri, 2 Apr 2021 16:41:32 GMT Subject: RFR: 7195: GC confguration with GC Flags Message-ID: This pull request proposes to display related garbage collector flags. **Motivation** When turning the GC flag knobs, it is useful to be able to quickly see the GC configuration, however the _GC configuration_ page only show 3 events, if one wants to have a look at flags he has to either check the command line or inspect the _JVM internal_ page to find relevant GC flags. Therefore having these flags right there is useful to get a quick picture of the current configuration. **Current limitations** 1. At this time the selected flags depends on the GC algorithm which is derived from the name of the old collector name. This is simple, however it prevents to identify EpsilonGC because whose old collector name is `SerialOld`, which is the same as SerialGC. 2. There are some global flags in `gc/shared/gc_globals.hpp` that I didn't include as I didn't use most of them. I'm not sure these flags are seen much in the wild. **Remarks** As mentionned above the use of the OldCollector name may not be the best choice, I would like to refactor this part to use the `Use*GC` flags instead. I am a bit unsure at this time how to use the existing API. ------------- Commit messages: - 7195: Refactor GC dsicovery mechanism - 7195: Upgrades copyright header years - GC conf, spotless:apply - GC conf, refactor UI in a IPageUI - GC conf, adds flags for Serial/Parallel/CMS - GC conf, additional flags for each GC - GC conf, Profiles may not have GC config/flags events - GC conf, select flags with Collector Name - GC conf, pre-filters GC flags on substring - Introduces GC flags in GC configuration page Changes: https://git.openjdk.java.net/jmc/pull/230/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=230&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7195 Stats: 312 lines in 4 files changed: 256 ins; 1 del; 55 mod Patch: https://git.openjdk.java.net/jmc/pull/230.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/230/head:pull/230 PR: https://git.openjdk.java.net/jmc/pull/230 From hirt at openjdk.java.net Fri Apr 2 16:41:32 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 2 Apr 2021 16:41:32 GMT Subject: RFR: 7195: GC confguration with GC Flags In-Reply-To: References: Message-ID: On Thu, 18 Mar 2021 16:30:12 GMT, Brice Dutheil wrote: > This pull request proposes to display related garbage collector flags. > > **Motivation** > > When turning the GC flag knobs, it is useful to be able to quickly see > the GC configuration, however the _GC configuration_ page only show 3 > events, if one wants to have a look at flags he has to either check > the command line or inspect the _JVM internal_ page to find relevant > GC flags. Therefore having these flags right there is useful to get > a quick picture of the current configuration. > > **Current limitations** > > 1. At this time the selected flags depends on the GC algorithm which is > derived from the name of the old collector name. This is simple, > however it prevents to identify EpsilonGC because whose old > collector name is `SerialOld`, which is the same as SerialGC. > > 2. There are some global flags in `gc/shared/gc_globals.hpp` that > I didn't include as I didn't use most of them. I'm not sure these > flags are seen much in the wild. > > > **Remarks** > > As mentionned above the use of the OldCollector name may not be the > best choice, I would like to refactor this part to use the `Use*GC` > flags instead. I am a bit unsure at this time how to use the > existing API. Don't forget to update the copyright header years. If you need to add a year to make a year range, simply add a comma and the new year, e.g. like so: Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/GCConfigurationPage.java line 281: > 279: // TODO Cannot discover EpsilonGC via the old collector name, because Epsilon reports the same as SerialGC > 280: // case "Epsilon": > 281: // // from https://github.com/openjdk/jdk11u/blob/6c31ac2acdc2b2efa63fe92de8368ab964d847e9/src/hotspot/share/gc/epsilon/epsilon_globals.hpp Dead code. Want to try some other means of discovery? ------------- PR: https://git.openjdk.java.net/jmc/pull/230 From github.com+803621+bric3 at openjdk.java.net Fri Apr 2 16:41:34 2021 From: github.com+803621+bric3 at openjdk.java.net (Brice Dutheil) Date: Fri, 2 Apr 2021 16:41:34 GMT Subject: RFR: 7195: GC confguration with GC Flags In-Reply-To: References: Message-ID: On Mon, 29 Mar 2021 18:54:35 GMT, Marcus Hirt wrote: >> This pull request proposes to display related garbage collector flags. >> >> **Motivation** >> >> When turning the GC flag knobs, it is useful to be able to quickly see >> the GC configuration, however the _GC configuration_ page only show 3 >> events, if one wants to have a look at flags he has to either check >> the command line or inspect the _JVM internal_ page to find relevant >> GC flags. Therefore having these flags right there is useful to get >> a quick picture of the current configuration. >> >> **Current limitations** >> >> 1. At this time the selected flags depends on the GC algorithm which is >> derived from the name of the old collector name. This is simple, >> however it prevents to identify EpsilonGC because whose old >> collector name is `SerialOld`, which is the same as SerialGC. >> >> 2. There are some global flags in `gc/shared/gc_globals.hpp` that >> I didn't include as I didn't use most of them. I'm not sure these >> flags are seen much in the wild. >> >> >> **Remarks** >> >> As mentionned above the use of the OldCollector name may not be the >> best choice, I would like to refactor this part to use the `Use*GC` >> flags instead. I am a bit unsure at this time how to use the >> existing API. > > application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/GCConfigurationPage.java line 281: > >> 279: // TODO Cannot discover EpsilonGC via the old collector name, because Epsilon reports the same as SerialGC >> 280: // case "Epsilon": >> 281: // // from https://github.com/openjdk/jdk11u/blob/6c31ac2acdc2b2efa63fe92de8368ab964d847e9/src/hotspot/share/gc/epsilon/epsilon_globals.hpp > > Dead code. Want to try some other means of discovery? Yes, I'd like to, as I am not satisfied with the current approach. @thegreystone Finally I got some time to rework the discovery. I'd like your input however : 1. I created a class `GCFlagFilters` however I wonder if it makes sens to move it to `org.openjdk.jmc.flightrecorder` module in the `org.openjdk.jmc.flightrecorder.jdk` ? 2. I am not sure how to write tests. I have been playing with `org.openjdk.jmc.flightrecorder.uitest` module, but it's a bit slow to use, and I was only able to run them via maven command line. ------------- PR: https://git.openjdk.java.net/jmc/pull/230 From hirt at openjdk.java.net Sat Apr 3 11:35:07 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Sat, 3 Apr 2021 11:35:07 GMT Subject: Integrated: 7046: Update to the 2021-03 platform In-Reply-To: References: Message-ID: On Fri, 2 Apr 2021 00:05:51 GMT, Marcus Hirt wrote: > Also updating to latest babel for the platform versions that are available in 0.18.3. > > Depending on if #234 gets in before or after this one, either this one will need to be updated to remove the chromium entry, or #234 will need to be updated to do it. > > (Is it just me, or does JMC start really fast on 4.19? :) ) This pull request has now been integrated. Changeset: a2f6b15c Author: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/a2f6b15c Stats: 106 lines in 6 files changed: 89 ins; 3 del; 14 mod 7046: Update to the 2021-03 platform Reviewed-by: ghb ------------- PR: https://git.openjdk.java.net/jmc/pull/235 From hdafgard at openjdk.java.net Mon Apr 5 20:58:09 2021 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Mon, 5 Apr 2021 20:58:09 GMT Subject: RFR: 7031: Build a constant pool explorer page [v2] In-Reply-To: References: Message-ID: On Fri, 2 Apr 2021 07:50:40 GMT, Jean-Philippe Bempel wrote: >> Add under Recording a new Page for ConstantPools >> Help to visualize what's inside constant pools part of a JFR recording >> >> ![JMC_ConstantPoolsPage](https://user-images.githubusercontent.com/4610701/110855759-13569700-82b7-11eb-9981-deb0b8b5e185.png) >> >> *Draft* >> - Icon is copy/paste from recording. If you have idea about how to replace it... >> - I have limited the tables to the search toolbar, visible by default >> - a hidden count column for constant values helps you find out when you duplicates constant (for OldObjectSample event issue) should not be useful otherwise > > Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: > > load state for SASH Marked as reviewed by hdafgard (Reviewer). ------------- PR: https://git.openjdk.java.net/jmc/pull/228 From hdafgard at openjdk.java.net Tue Apr 6 17:26:08 2021 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Tue, 6 Apr 2021 17:26:08 GMT Subject: RFR: 7225: Add workflow badge to the readme In-Reply-To: References: Message-ID: On Wed, 31 Mar 2021 09:49:15 GMT, Marcus Hirt wrote: > Trying a PR to see if it works. Marked as reviewed by hdafgard (Reviewer). ------------- PR: https://git.openjdk.java.net/jmc/pull/233 From marcus.hirt at datadoghq.com Tue Apr 6 20:03:20 2021 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Tue, 6 Apr 2021 22:03:20 +0200 Subject: JMC 8.1.0 plan Message-ID: Hi all, This is the timeline for the 8.1.0 (source) GA release: Release Milestone Date =============================== 8.1.0 RDS 2021-06-02 8.1.0 RDP2 2021-07-02 8.1.0 GA 2021-08-02 Here's a wiki page explaining the milestones: https://wiki.openjdk.java.net/display/jmc/JMC+Development+Process+FAQ Please let me know if you have any questions or concerns! Kind regards, Marcus From hirt at openjdk.java.net Tue Apr 6 20:13:10 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 6 Apr 2021 20:13:10 GMT Subject: Integrated: 7225: Add workflow badge to the readme In-Reply-To: References: Message-ID: On Wed, 31 Mar 2021 09:49:15 GMT, Marcus Hirt wrote: > Trying a PR to see if it works. This pull request has now been integrated. Changeset: b46be35e Author: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/b46be35e Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod 7225: Add workflow badge to the readme Reviewed-by: hdafgard ------------- PR: https://git.openjdk.java.net/jmc/pull/233 From github.com+4610701+jpbempel at openjdk.java.net Tue Apr 6 20:14:13 2021 From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Tue, 6 Apr 2021 20:14:13 GMT Subject: Integrated: 7031: Build a constant pool explorer page In-Reply-To: References: Message-ID: On Thu, 11 Mar 2021 21:16:35 GMT, Jean-Philippe Bempel wrote: > Add under Recording a new Page for ConstantPools > Help to visualize what's inside constant pools part of a JFR recording > > ![JMC_ConstantPoolsPage](https://user-images.githubusercontent.com/4610701/110855759-13569700-82b7-11eb-9981-deb0b8b5e185.png) > > *Draft* > - Icon is copy/paste from recording. If you have idea about how to replace it... > - I have limited the tables to the search toolbar, visible by default > - a hidden count column for constant values helps you find out when you duplicates constant (for OldObjectSample event issue) should not be useful otherwise This pull request has now been integrated. Changeset: f25df12e Author: Jean-Philippe Bempel Committer: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/f25df12e Stats: 523 lines in 20 files changed: 508 ins; 1 del; 14 mod 7031: Build a constant pool explorer page Reviewed-by: hirt, hdafgard ------------- PR: https://git.openjdk.java.net/jmc/pull/228 From github.com+29914148+docwarems at openjdk.java.net Wed Apr 7 16:43:45 2021 From: github.com+29914148+docwarems at openjdk.java.net (Michael S.) Date: Wed, 7 Apr 2021 16:43:45 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful Message-ID: The message refers to the FAQ to question "Q: I cannot see any locally running JVMs in the JVM browser!" Suggestion for new answer A3: Are you running a JDK <11? You must specify a JDK >=11 either via PATH of by adding "-vm" parameter in jmc.ini (before -vmargs parameter; value is path to JDK bin folder) ------------- Commit messages: - 7194: added JDK <11 as reason for not finding local JVMs - Revert "7194: moved and renamed FAQ from html to MD format; replaced content by current OpenJDK Wiki FAQ at https://wiki.openjdk.java.net/display/jmc/JMC+FAQ" - 7194: moved and renamed FAQ from html to MD format; replaced content by current OpenJDK Wiki FAQ at https://wiki.openjdk.java.net/display/jmc/JMC+FAQ - 7194: add JDK <11 as reason to startup hint for not finding local JVM Changes: https://git.openjdk.java.net/jmc/pull/232/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=232&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7194 Stats: 3 lines in 2 files changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/232.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/232/head:pull/232 PR: https://git.openjdk.java.net/jmc/pull/232 From hirt at openjdk.java.net Wed Apr 7 16:43:45 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 7 Apr 2021 16:43:45 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful In-Reply-To: References: Message-ID: <3CFUY01z3xMZuB1yU0wcEZdibq9fZLQDE8uVSf7Ga84=.9b98b794-7df5-41c9-9a55-521faf253ff2@github.com> On Fri, 19 Mar 2021 17:31:04 GMT, Michael S. wrote: > The message refers to the FAQ to question > "Q: I cannot see any locally running JVMs in the JVM browser!" > Suggestion for new answer > A3: Are you running a JDK <11? You must specify a JDK >=11 either via PATH of by adding "-vm" parameter in jmc.ini (before -vmargs parameter; value is path to JDK bin folder) Hi there! There is a suggestion to update the FAQ (https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.docs/html/GUID-3EC7E6C3-6A64-4659-B99E-CA675A9F6E0A.htm), there is however no update to that html file present in the PR. ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From github.com+29914148+docwarems at openjdk.java.net Wed Apr 7 16:43:46 2021 From: github.com+29914148+docwarems at openjdk.java.net (Michael S.) Date: Wed, 7 Apr 2021 16:43:46 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful In-Reply-To: <3CFUY01z3xMZuB1yU0wcEZdibq9fZLQDE8uVSf7Ga84=.9b98b794-7df5-41c9-9a55-521faf253ff2@github.com> References: <3CFUY01z3xMZuB1yU0wcEZdibq9fZLQDE8uVSf7Ga84=.9b98b794-7df5-41c9-9a55-521faf253ff2@github.com> Message-ID: On Fri, 19 Mar 2021 18:59:43 GMT, Marcus Hirt wrote: > There is a suggestion to update the FAQ OK, but the content of ths repo file is different from the FAQs content I found by Google, to which my PR description refers. https://wiki.openjdk.java.net/display/jmc/JMC+FAQ https://community.oracle.com/tech/developers/discussion/2579717/jmc-frequently-asked-questions ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From hirt at openjdk.java.net Wed Apr 7 16:43:46 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 7 Apr 2021 16:43:46 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful In-Reply-To: References: <3CFUY01z3xMZuB1yU0wcEZdibq9fZLQDE8uVSf7Ga84=.9b98b794-7df5-41c9-9a55-521faf253ff2@github.com> Message-ID: On Sat, 20 Mar 2021 09:03:58 GMT, Michael S. wrote: >> Hi there! >> >> There is a suggestion to update the FAQ (https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.docs/html/GUID-3EC7E6C3-6A64-4659-B99E-CA675A9F6E0A.htm), there is however no update to that html file present in the PR. > >> There is a suggestion to update the FAQ > > OK, but the content of ths repo file is different from the FAQs content I found by Google, to which my PR description refers. > > https://wiki.openjdk.java.net/display/jmc/JMC+FAQ > https://community.oracle.com/tech/developers/discussion/2579717/jmc-frequently-asked-questions Feel free to update the JMC-included documentation if you feel it improves it. :) The project itself mostly concerns itself with the included documentation, not the Oracle-hosted FAQ. ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From github.com+29914148+docwarems at openjdk.java.net Wed Apr 7 16:43:47 2021 From: github.com+29914148+docwarems at openjdk.java.net (Michael S.) Date: Wed, 7 Apr 2021 16:43:47 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful In-Reply-To: References: <3CFUY01z3xMZuB1yU0wcEZdibq9fZLQDE8uVSf7Ga84=.9b98b794-7df5-41c9-9a55-521faf253ff2@github.com> Message-ID: On Tue, 23 Mar 2021 15:42:27 GMT, Marcus Hirt wrote: >>> There is a suggestion to update the FAQ >> >> OK, but the content of ths repo file is different from the FAQs content I found by Google, to which my PR description refers. >> >> https://wiki.openjdk.java.net/display/jmc/JMC+FAQ >> https://community.oracle.com/tech/developers/discussion/2579717/jmc-frequently-asked-questions > > Feel free to update the JMC-included documentation if you feel it improves it. :) The project itself mostly concerns itself with the included documentation, not the Oracle-hosted FAQ. OK, IMO we have this situation: https://wiki.openjdk.java.net/display/jmc/JMC+FAQ (last updated 02/2020) is the location for publishing the FAQ currently and in the future. It's a Confluence system, and there's no way to sync this with a Git document, because Confluence has it's own versioning. That means the purpose of the repo FAQ (last update 01/2019) could be not more than for saving the raw content (the HTML format is only used for better reading, otherwise it could be even plain text). Is my view correct? To me the published FAQ looks much more useful than the repo FAQ. If you ask me, I would replace the repo with the content from the published FAQ, and add the answer from this PR. At least we have the content of both in sync then. ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From hirt at openjdk.java.net Wed Apr 7 16:43:48 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 7 Apr 2021 16:43:48 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful In-Reply-To: References: <3CFUY01z3xMZuB1yU0wcEZdibq9fZLQDE8uVSf7Ga84=.9b98b794-7df5-41c9-9a55-521faf253ff2@github.com> Message-ID: On Tue, 23 Mar 2021 17:09:45 GMT, Michael S. wrote: >> Feel free to update the JMC-included documentation if you feel it improves it. :) The project itself mostly concerns itself with the included documentation, not the Oracle-hosted FAQ. > > OK, IMO we have this situation: > > https://wiki.openjdk.java.net/display/jmc/JMC+FAQ (last updated 02/2020) is the location for publishing the FAQ currently and in the future. It's a Confluence system, and there's no way to sync this with a Git document, because Confluence has it's own versioning. > That means the purpose of the repo FAQ (last update 01/2019) could be not more than for saving the raw content (the HTML format is only used for better reading, otherwise it could be even plain text). > > Is my view correct? > > To me the published FAQ looks much more useful than the repo FAQ. If you ask me, I would replace the repo with the content from the published FAQ, and add the answer from this PR. > > At least we have the content of both in sync then. Does this render OK in the help browser? 1. Start JMC. 2. Go to Help | JDK Mission Control Help. 3. Click Frequently Asked Questions (at the bottom of the TOC). ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From github.com+29914148+docwarems at openjdk.java.net Wed Apr 7 16:43:50 2021 From: github.com+29914148+docwarems at openjdk.java.net (Michael S.) Date: Wed, 7 Apr 2021 16:43:50 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful In-Reply-To: References: <3CFUY01z3xMZuB1yU0wcEZdibq9fZLQDE8uVSf7Ga84=.9b98b794-7df5-41c9-9a55-521faf253ff2@github.com> Message-ID: On Fri, 26 Mar 2021 21:37:20 GMT, Marcus Hirt wrote: > Does this render OK in the help browser? Probably not ;-) But from my previous comments it could have become obviuos that I wasn't aware of the repo FAQ shown elsewhere. Now that I know that it's parts of the included help, I reverted the commit and added just my new answer. How will we get rid of the extra commits? Have I to re-push the branch again or is there a squash functionality when the PR will be merged. Sorry, I need help here because it's my first contribution to a GitHub project. ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From hdafgard at openjdk.java.net Wed Apr 7 16:43:50 2021 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Wed, 7 Apr 2021 16:43:50 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful In-Reply-To: References: <3CFUY01z3xMZuB1yU0wcEZdibq9fZLQDE8uVSf7Ga84=.9b98b794-7df5-41c9-9a55-521faf253ff2@github.com> Message-ID: On Sat, 27 Mar 2021 09:48:09 GMT, Michael S. wrote: > How will we get rid of the extra commits? Have I to re-push the branch again or is there a squash functionality when the PR will be merged. Sorry, I need help here because it's my first contribution to a GitHub project. When the PR is integrated all commits will be squashed, so you don't really need to do anything particular here. ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From hirt at openjdk.java.net Wed Apr 7 19:19:11 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 7 Apr 2021 19:19:11 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful In-Reply-To: References: <3CFUY01z3xMZuB1yU0wcEZdibq9fZLQDE8uVSf7Ga84=.9b98b794-7df5-41c9-9a55-521faf253ff2@github.com> Message-ID: On Tue, 30 Mar 2021 14:32:06 GMT, Henrik Dafg?rd wrote: >>> Does this render OK in the help browser? >> >> Probably not ;-) >> >> But from my previous comments it could have become obviuos that I wasn't aware of the repo FAQ shown elsewhere. Now that I know that it's parts of the included help, I reverted the commit and added just my new answer. >> >> How will we get rid of the extra commits? Have I to re-push the branch again or is there a squash functionality when the PR will be merged. Sorry, I need help here because it's my first contribution to a GitHub project. > >> How will we get rid of the extra commits? Have I to re-push the branch again or is there a squash functionality when the PR will be merged. Sorry, I need help here because it's my first contribution to a GitHub project. > > When the PR is integrated all commits will be squashed, so you don't really need to do anything particular here. As Henrik said - it's all part of the Skara workflow. It will all automatically be squashed into one neat commit in the end. :) ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From hirt at openjdk.java.net Wed Apr 7 19:19:12 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 7 Apr 2021 19:19:12 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful In-Reply-To: References: Message-ID: On Fri, 19 Mar 2021 17:31:04 GMT, Michael S. wrote: > The message refers to the FAQ to question > "Q: I cannot see any locally running JVMs in the JVM browser!" > Suggestion for new answer > A3: Are you running a JDK <11? You must specify a JDK >=11 either via PATH of by adding "-vm" parameter in jmc.ini (before -vmargs parameter; value is path to JDK bin folder) application/org.openjdk.jmc.browser/src/main/resources/org/openjdk/jmc/browser/views/messages.properties line 60: > 58: # JVMBrowserView_NO_LOCAL_JVMS_WARN_CAUSE has newlines placed so that the rows doesn't get too long. It would be > 59: # great if the translation also contains newlines so the rows get about the same length. > 60: JVMBrowserView_NO_LOCAL_JVMS_WARN_CAUSE=Local JVMs will not be detected if the JDK Mission Control Client is run with a JRE instead of a JDK, if the JDK is <11, or if the hsperfdata_ folder in TMP is not writable. See the FAQ help section for more information. Perhaps instead spell out the less than and expand to JDK version? Like so ", if the JDK version is less than 11, " ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From hirt at openjdk.java.net Wed Apr 7 19:22:14 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 7 Apr 2021 19:22:14 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful In-Reply-To: References: Message-ID: On Fri, 19 Mar 2021 17:31:04 GMT, Michael S. wrote: > The message refers to the FAQ to question > "Q: I cannot see any locally running JVMs in the JVM browser!" > Suggestion for new answer > A3: Are you running a JDK <11? You must specify a JDK >=11 either via PATH of by adding "-vm" parameter in jmc.ini (before -vmargs parameter; value is path to JDK bin folder) application/org.openjdk.jmc.docs/html/GUID-3EC7E6C3-6A64-4659-B99E-CA675A9F6E0A.htm line 82: > 80:
  • Make sure that there is a directory named hsperfdata_username in the system's tmp directory, that it is writable by the user running JMC, and that the file system supports access control lists (ACLs).

    > 81:
  • > 82:
  • Make sure you are you running a JDK >= 11. You can set the JDK bin directory either by PATH environment variable, or by adding -vm parameter to jmc.ini file (must be inserted before -vmargs section).

    How about making explicit that it is Mission Control that should be running on the proposed version? "Make sure you are running Mission Control on " ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From github.com+29914148+docwarems at openjdk.java.net Thu Apr 8 15:36:38 2021 From: github.com+29914148+docwarems at openjdk.java.net (Michael S.) Date: Thu, 8 Apr 2021 15:36:38 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful [v2] In-Reply-To: References: Message-ID: > The message refers to the FAQ to question > "Q: I cannot see any locally running JVMs in the JVM browser!" > Suggestion for new answer > A3: Are you running a JDK <11? You must specify a JDK >=11 either via PATH of by adding "-vm" parameter in jmc.ini (before -vmargs parameter; value is path to JDK bin folder) Michael S. has updated the pull request incrementally with one additional commit since the last revision: 7194: text improved ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/232/files - new: https://git.openjdk.java.net/jmc/pull/232/files/c3eb33a7..5014130b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=232&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=232&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/232.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/232/head:pull/232 PR: https://git.openjdk.java.net/jmc/pull/232 From github.com+29914148+docwarems at openjdk.java.net Thu Apr 8 15:36:38 2021 From: github.com+29914148+docwarems at openjdk.java.net (Michael S.) Date: Thu, 8 Apr 2021 15:36:38 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful [v2] In-Reply-To: References: Message-ID: On Wed, 7 Apr 2021 19:19:27 GMT, Marcus Hirt wrote: >> Michael S. has updated the pull request incrementally with one additional commit since the last revision: >> >> 7194: text improved > > application/org.openjdk.jmc.docs/html/GUID-3EC7E6C3-6A64-4659-B99E-CA675A9F6E0A.htm line 82: > >> 80:
  • Make sure that there is a directory named hsperfdata_username in the system's tmp directory, that it is writable by the user running JMC, and that the file system supports access control lists (ACLs).

    >> 81:
  • >> 82:
  • Make sure you are you running a JDK >= 11. You can set the JDK bin directory either by PATH environment variable, or by adding -vm parameter to jmc.ini file (must be inserted before -vmargs section).

    > > How about making explicit that it is Mission Control that should be running on the proposed version? "Make sure you are running Mission Control on " +1 done ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From github.com+29914148+docwarems at openjdk.java.net Thu Apr 8 15:41:34 2021 From: github.com+29914148+docwarems at openjdk.java.net (Michael S.) Date: Thu, 8 Apr 2021 15:41:34 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful [v3] In-Reply-To: References: Message-ID: > The message refers to the FAQ to question > "Q: I cannot see any locally running JVMs in the JVM browser!" > Suggestion for new answer > A3: Are you running a JDK <11? You must specify a JDK >=11 either via PATH of by adding "-vm" parameter in jmc.ini (before -vmargs parameter; value is path to JDK bin folder) Michael S. has updated the pull request incrementally with one additional commit since the last revision: 7194: text improved ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/232/files - new: https://git.openjdk.java.net/jmc/pull/232/files/5014130b..5fd8944d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=232&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=232&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/232.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/232/head:pull/232 PR: https://git.openjdk.java.net/jmc/pull/232 From github.com+29914148+docwarems at openjdk.java.net Thu Apr 8 15:41:35 2021 From: github.com+29914148+docwarems at openjdk.java.net (Michael S.) Date: Thu, 8 Apr 2021 15:41:35 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful [v3] In-Reply-To: References: Message-ID: On Wed, 7 Apr 2021 19:16:46 GMT, Marcus Hirt wrote: >> Michael S. has updated the pull request incrementally with one additional commit since the last revision: >> >> 7194: text improved > > application/org.openjdk.jmc.browser/src/main/resources/org/openjdk/jmc/browser/views/messages.properties line 60: > >> 58: # JVMBrowserView_NO_LOCAL_JVMS_WARN_CAUSE has newlines placed so that the rows doesn't get too long. It would be >> 59: # great if the translation also contains newlines so the rows get about the same length. >> 60: JVMBrowserView_NO_LOCAL_JVMS_WARN_CAUSE=Local JVMs will not be detected if the JDK Mission Control Client is run with a JRE instead of a JDK, if the JDK is <11, or if the hsperfdata_ folder in TMP is not writable. See the FAQ help section for more information. > > Perhaps instead spell out the less than and expand to JDK version? Like so ", if the JDK version is less than 11, " Ok, this one too. Saw this first comment to late -> two commits ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From hirt at openjdk.java.net Thu Apr 8 17:32:08 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 8 Apr 2021 17:32:08 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful [v3] In-Reply-To: References: Message-ID: On Thu, 8 Apr 2021 15:41:34 GMT, Michael S. wrote: >> The message refers to the FAQ to question >> "Q: I cannot see any locally running JVMs in the JVM browser!" >> Suggestion for new answer >> A3: Are you running a JDK <11? You must specify a JDK >=11 either via PATH of by adding "-vm" parameter in jmc.ini (before -vmargs parameter; value is path to JDK bin folder) > > Michael S. has updated the pull request incrementally with one additional commit since the last revision: > > 7194: text improved Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From hirt at openjdk.java.net Thu Apr 8 17:32:09 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 8 Apr 2021 17:32:09 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful [v3] In-Reply-To: References: Message-ID: On Thu, 8 Apr 2021 15:38:35 GMT, Michael S. wrote: >> application/org.openjdk.jmc.browser/src/main/resources/org/openjdk/jmc/browser/views/messages.properties line 60: >> >>> 58: # JVMBrowserView_NO_LOCAL_JVMS_WARN_CAUSE has newlines placed so that the rows doesn't get too long. It would be >>> 59: # great if the translation also contains newlines so the rows get about the same length. >>> 60: JVMBrowserView_NO_LOCAL_JVMS_WARN_CAUSE=Local JVMs will not be detected if the JDK Mission Control Client is run with a JRE instead of a JDK, if the JDK is <11, or if the hsperfdata_ folder in TMP is not writable. See the FAQ help section for more information. >> >> Perhaps instead spell out the less than and expand to JDK version? Like so ", if the JDK version is less than 11, " > > Ok, this one too. Saw this first comment to late -> two commits No problem. You can have a gazillion commits - the friendly neighborhood Skara-bot will automatically squash. :) ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From hirt at openjdk.java.net Thu Apr 8 17:44:09 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 8 Apr 2021 17:44:09 GMT Subject: RFR: 7195: GC confguration with GC Flags In-Reply-To: References: Message-ID: On Fri, 2 Apr 2021 16:37:06 GMT, Brice Dutheil wrote: >> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/GCConfigurationPage.java line 281: >> >>> 279: // TODO Cannot discover EpsilonGC via the old collector name, because Epsilon reports the same as SerialGC >>> 280: // case "Epsilon": >>> 281: // // from https://github.com/openjdk/jdk11u/blob/6c31ac2acdc2b2efa63fe92de8368ab964d847e9/src/hotspot/share/gc/epsilon/epsilon_globals.hpp >> >> Dead code. Want to try some other means of discovery? > > @thegreystone Finally I got some time to rework the discovery. > > I'd like your input however : > 1. I created a class `GCFlagFilters` however I wonder if it makes sens to move it to `org.openjdk.jmc.flightrecorder` module in the `org.openjdk.jmc.flightrecorder.jdk` ? > 2. I am not sure how to write tests. I have been playing with `org.openjdk.jmc.flightrecorder.uitest` module, but it's a bit slow to use, and I was only able to run them via maven command line. 1. I think it is fine where it is, but you can strike up a conversion in the JMC slack/the jmc-dev list, and if there is enough interest, moving it to core could be a separate PR. 2. There is a launcher in org.openjdk.jmc.flightrecorder.uitest that should allow you to run only the flight recorder uitests from within Eclipse. ------------- PR: https://git.openjdk.java.net/jmc/pull/230 From hirt at openjdk.java.net Thu Apr 8 18:00:11 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 8 Apr 2021 18:00:11 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful [v3] In-Reply-To: References: Message-ID: On Thu, 8 Apr 2021 15:41:34 GMT, Michael S. wrote: >> The message refers to the FAQ to question >> "Q: I cannot see any locally running JVMs in the JVM browser!" >> Suggestion for new answer >> A3: Are you running a JDK <11? You must specify a JDK >=11 either via PATH of by adding "-vm" parameter in jmc.ini (before -vmargs parameter; value is path to JDK bin folder) > > Michael S. has updated the pull request incrementally with one additional commit since the last revision: > > 7194: text improved Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From hirt at openjdk.java.net Fri Apr 9 11:37:06 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 9 Apr 2021 11:37:06 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful In-Reply-To: References: Message-ID: On Fri, 19 Mar 2021 17:31:04 GMT, Michael S. wrote: > The message refers to the FAQ to question > "Q: I cannot see any locally running JVMs in the JVM browser!" > Suggestion for new answer > A3: Are you running a JDK <11? You must specify a JDK >=11 either via PATH of by adding "-vm" parameter in jmc.ini (before -vmargs parameter; value is path to JDK bin folder) Hi @docwarems! Please read the comments above from the bot. It contains instruction on how to proceed with integrating the PR. Let me know if you need any help! ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From hirt at openjdk.java.net Fri Apr 9 11:43:24 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 9 Apr 2021 11:43:24 GMT Subject: RFR: 7235: Some writer cleanup Message-ID: <7AZSRYnc3qbH8SP8xRmPbEOmEBea5JFT9iPgUAXQzFI=.eeb3b832-d3a8-46aa-83a1-e0130d24de6b@github.com> Just getting rid of a few annoying warnings. I'll add an issue once JBS is up again. ------------- Commit messages: - Some writer cleanup Changes: https://git.openjdk.java.net/jmc/pull/237/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=237&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7235 Stats: 5 lines in 3 files changed: 0 ins; 5 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/237.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/237/head:pull/237 PR: https://git.openjdk.java.net/jmc/pull/237 From hirt at openjdk.java.net Fri Apr 9 11:45:25 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 9 Apr 2021 11:45:25 GMT Subject: RFR: 7236: Adding project specific settings to ignore forbidden references Message-ID: <-F4p-qsIU3xWfoCfoARA06ZugDBr6Zf8s-cFwqBV-rU=.6cfe18aa-f45c-4f42-85a4-3aaac7a43ab7@github.com> Since JBS is down for maintenance, I'll add an issue once it's up and happy again. Update: added issue. ------------- Commit messages: - Adding project specific settings to ignore forbidden references Changes: https://git.openjdk.java.net/jmc/pull/236/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=236&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7236 Stats: 102 lines in 1 file changed: 102 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/236.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/236/head:pull/236 PR: https://git.openjdk.java.net/jmc/pull/236 From jbachorik at openjdk.java.net Fri Apr 9 14:38:10 2021 From: jbachorik at openjdk.java.net (Jaroslav Bachorik) Date: Fri, 9 Apr 2021 14:38:10 GMT Subject: RFR: 7235: Some writer cleanup In-Reply-To: <7AZSRYnc3qbH8SP8xRmPbEOmEBea5JFT9iPgUAXQzFI=.eeb3b832-d3a8-46aa-83a1-e0130d24de6b@github.com> References: <7AZSRYnc3qbH8SP8xRmPbEOmEBea5JFT9iPgUAXQzFI=.eeb3b832-d3a8-46aa-83a1-e0130d24de6b@github.com> Message-ID: On Thu, 8 Apr 2021 19:47:02 GMT, Marcus Hirt wrote: > Just getting rid of a few annoying warnings. I'll add an issue once JBS is up again. Marked as reviewed by jbachorik (Author). ------------- PR: https://git.openjdk.java.net/jmc/pull/237 From aptmac at openjdk.java.net Fri Apr 9 15:39:27 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Fri, 9 Apr 2021 15:39:27 GMT Subject: RFR: 6939: Time range indicator isn't updated when setting the time range Message-ID: This PR addresses JMC-6939 [[0]](https://bugs.openjdk.java.net/browse/JMC-6939), in which the time range indicator does not update when setting a time range. The issue here is that visible range of the chart is not updated when a new range is selected. In `onFlavorSelected()`, the table is updated with the new selection, but the chart is not. Here I've added a line to set the visible range with the new selection values. Additionally, I've tweaked the if-statement so that when "No Selection" is selected in the flavor selector the table & chart display the default selection. Previously if the "No Selection" option was selected after viewing a different selection, because `selectionItems` is null there would be no update to the table or chart; now it is really showing "No Selection". There was also a problem with the time range indicator in the flavor selector not updating properly when a selection is chosen. The issue seems to be the `layout()` call not resulting in a redraw of the canvas, so it has been changed to `redraw()` instead. [0] https://bugs.openjdk.java.net/browse/JMC-6939 ### Gif examples: **Before** The table updates correctly, but the chart doesn't. The flavor selector time range indicator doesn't redraw as expected. ![6939-before](https://user-images.githubusercontent.com/10425301/114095984-2051b080-988c-11eb-97a7-64f90465049d.gif) **After** The chart updates to the selected time range, and the flavor selector redraws as expected. ![6939-after](https://user-images.githubusercontent.com/10425301/114096008-2a73af00-988c-11eb-9a77-196bd47f9ef7.gif) ------------- Commit messages: - 6939: Time range indicator isn't updated when setting the time range Changes: https://git.openjdk.java.net/jmc/pull/238/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=238&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-6939 Stats: 17 lines in 3 files changed: 2 ins; 4 del; 11 mod Patch: https://git.openjdk.java.net/jmc/pull/238.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/238/head:pull/238 PR: https://git.openjdk.java.net/jmc/pull/238 From hirt at openjdk.java.net Fri Apr 9 16:39:09 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 9 Apr 2021 16:39:09 GMT Subject: RFR: 6939: Time range indicator isn't updated when setting the time range In-Reply-To: References: Message-ID: On Fri, 9 Apr 2021 15:35:34 GMT, Alex Macdonald wrote: > This PR addresses JMC-6939 [[0]](https://bugs.openjdk.java.net/browse/JMC-6939), in which the time range indicator does not update when setting a time range. > > The issue here is that visible range of the chart is not updated when a new range is selected. In `onFlavorSelected()`, the table is updated with the new selection, but the chart is not. Here I've added a line to set the visible range with the new selection values. Additionally, I've tweaked the if-statement so that when "No Selection" is selected in the flavor selector the table & chart display the default selection. Previously if the "No Selection" option was selected after viewing a different selection, because `selectionItems` is null there would be no update to the table or chart; now it is really showing "No Selection". > > There was also a problem with the time range indicator in the flavor selector not updating properly when a selection is chosen. The issue seems to be the `layout()` call not resulting in a redraw of the canvas, so it has been changed to `redraw()` instead. > > [0] https://bugs.openjdk.java.net/browse/JMC-6939 > > ### Gif examples: > > **Before** > The table updates correctly, but the chart doesn't. > The flavor selector time range indicator doesn't redraw as expected. > ![6939-before](https://user-images.githubusercontent.com/10425301/114095984-2051b080-988c-11eb-97a7-64f90465049d.gif) > > **After** > The chart updates to the selected time range, and the flavor selector redraws as expected. > ![6939-after](https://user-images.githubusercontent.com/10425301/114096008-2a73af00-988c-11eb-9a77-196bd47f9ef7.gif) Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/238 From aptmac at openjdk.java.net Fri Apr 9 17:21:29 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Fri, 9 Apr 2021 17:21:29 GMT Subject: RFR: 7105: Unable to open graph-view if JMC is booted with JDK 8 Message-ID: This one-liner PR addresses JMC-7105 [[0]](https://bugs.openjdk.java.net/browse/JMC-7105), in which the GraphView is unable to open when JMC is launched with JDK 8. The problem here is the usage of `List.of()` [[1]](https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.flightrecorder.graphview/src/main/java/org/openjdk/jmc/flightrecorder/graphview/views/GraphView.java#L186), which is supported in JDK 9+ [[2]](https://docs.oracle.com/javase/9/docs/api/java/util/List.html#of--), but not available in JDK 8 [[3]](https://docs.oracle.com/javase/8/docs/api/java/util/List.html). This PR simply changes `List.of()` to `Arrays.asList()` to make it JDK 8 compliant. [0] https://bugs.openjdk.java.net/browse/JMC-7105 [1] https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.flightrecorder.graphview/src/main/java/org/openjdk/jmc/flightrecorder/graphview/views/GraphView.java#L186 [2] https://docs.oracle.com/javase/9/docs/api/java/util/List.html#of-- [3] https://docs.oracle.com/javase/8/docs/api/java/util/List.html ------------- Commit messages: - 7105: Unable to open graph-view if JMC is booted with JDK 8 Changes: https://git.openjdk.java.net/jmc/pull/239/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=239&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7105 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/239.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/239/head:pull/239 PR: https://git.openjdk.java.net/jmc/pull/239 From hirt at openjdk.java.net Fri Apr 9 18:04:11 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 9 Apr 2021 18:04:11 GMT Subject: RFR: 7105: Unable to open graph-view if JMC is booted with JDK 8 In-Reply-To: References: Message-ID: On Fri, 9 Apr 2021 17:17:19 GMT, Alex Macdonald wrote: > This one-liner PR addresses JMC-7105 [[0]](https://bugs.openjdk.java.net/browse/JMC-7105), in which the GraphView is unable to open when JMC is launched with JDK 8. > > The problem here is the usage of `List.of()` [[1]](https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.flightrecorder.graphview/src/main/java/org/openjdk/jmc/flightrecorder/graphview/views/GraphView.java#L186), which is supported in JDK 9+ [[2]](https://docs.oracle.com/javase/9/docs/api/java/util/List.html#of--), but not available in JDK 8 [[3]](https://docs.oracle.com/javase/8/docs/api/java/util/List.html). > > This PR simply changes `List.of()` to `Arrays.asList()` to make it JDK 8 compliant. > > [0] https://bugs.openjdk.java.net/browse/JMC-7105 > [1] https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.flightrecorder.graphview/src/main/java/org/openjdk/jmc/flightrecorder/graphview/views/GraphView.java#L186 > [2] https://docs.oracle.com/javase/9/docs/api/java/util/List.html#of-- > [3] https://docs.oracle.com/javase/8/docs/api/java/util/List.html Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/239 From github.com+29914148+docwarems at openjdk.java.net Sat Apr 10 09:42:08 2021 From: github.com+29914148+docwarems at openjdk.java.net (Michael S.) Date: Sat, 10 Apr 2021 09:42:08 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful In-Reply-To: References: Message-ID: On Fri, 9 Apr 2021 11:34:46 GMT, Marcus Hirt wrote: >> The message refers to the FAQ to question >> "Q: I cannot see any locally running JVMs in the JVM browser!" >> Suggestion for new answer >> A3: Are you running a JDK <11? You must specify a JDK >=11 either via PATH of by adding "-vm" parameter in jmc.ini (before -vmargs parameter; value is path to JDK bin folder) > > Hi @docwarems! Please read the comments above from the bot. It contains instruction on how to proceed with integrating the PR. Let me know if you need any help! I have problems fixing the user name for my commit as described by the bot. The command gives me this error with my Git client: fatal: Option -m cannot be combined with -c/-C/-F. If I omit the -m option it gives me the error fatal: could not lookup commit user.name=Michael Sdkamp This is my user name as obtained from "git config --list". As you can see it has an escaped german character. I also tried without success with the unescaped name and with umlaut character replaced by ASCII. What can I do? ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From hirt at openjdk.java.net Sat Apr 10 17:01:10 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Sat, 10 Apr 2021 17:01:10 GMT Subject: RFR: 7194 : No local JVMs found message could be more helpful In-Reply-To: References: Message-ID: On Sat, 10 Apr 2021 09:39:52 GMT, Michael S. wrote: >> Hi @docwarems! Please read the comments above from the bot. It contains instruction on how to proceed with integrating the PR. Let me know if you need any help! > > I have problems fixing the user name for my commit as described by the bot. > The command gives me this error with my Git client: > fatal: Option -m cannot be combined with -c/-C/-F. > > If I omit the -m option it gives me the error > fatal: could not lookup commit user.name=Michael Sdkamp > > This is my user name as obtained from "git config --list". As you can see it has an escaped german character. I also tried without success with the unescaped name and with umlaut character replaced by ASCII. > What can I do? Don?t worry too much then. If you are happy with how your name looks in the commits, then simply write /integrate in a comment. ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From github.com+29914148+docwarems at openjdk.java.net Mon Apr 12 20:59:34 2021 From: github.com+29914148+docwarems at openjdk.java.net (Michael =?UTF-8?B?U8O8ZGthbXA=?=) Date: Mon, 12 Apr 2021 20:59:34 GMT Subject: Integrated: 7194 : No local JVMs found message could be more helpful In-Reply-To: References: Message-ID: On Fri, 19 Mar 2021 17:31:04 GMT, Michael S?dkamp wrote: > The message refers to the FAQ to question > "Q: I cannot see any locally running JVMs in the JVM browser!" > Suggestion for new answer > A3: Are you running a JDK <11? You must specify a JDK >=11 either via PATH of by adding "-vm" parameter in jmc.ini (before -vmargs parameter; value is path to JDK bin folder) This pull request has now been integrated. Changeset: 84fc9370 Author: Michael S?dkamp Committer: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/84fc9370 Stats: 3 lines in 2 files changed: 2 ins; 0 del; 1 mod 7194: No local JVMs found message could be more helpful Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/232 From aptmac at openjdk.java.net Tue Apr 13 14:29:16 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Tue, 13 Apr 2021 14:29:16 GMT Subject: Integrated: 6939: Time range indicator isn't updated when setting the time range In-Reply-To: References: Message-ID: On Fri, 9 Apr 2021 15:35:34 GMT, Alex Macdonald wrote: > This PR addresses JMC-6939 [[0]](https://bugs.openjdk.java.net/browse/JMC-6939), in which the time range indicator does not update when setting a time range. > > The issue here is that visible range of the chart is not updated when a new range is selected. In `onFlavorSelected()`, the table is updated with the new selection, but the chart is not. Here I've added a line to set the visible range with the new selection values. Additionally, I've tweaked the if-statement so that when "No Selection" is selected in the flavor selector the table & chart display the default selection. Previously if the "No Selection" option was selected after viewing a different selection, because `selectionItems` is null there would be no update to the table or chart; now it is really showing "No Selection". > > There was also a problem with the time range indicator in the flavor selector not updating properly when a selection is chosen. The issue seems to be the `layout()` call not resulting in a redraw of the canvas, so it has been changed to `redraw()` instead. > > [0] https://bugs.openjdk.java.net/browse/JMC-6939 > > ### Gif examples: > > **Before** > The table updates correctly, but the chart doesn't. > The flavor selector time range indicator doesn't redraw as expected. > ![6939-before](https://user-images.githubusercontent.com/10425301/114095984-2051b080-988c-11eb-97a7-64f90465049d.gif) > > **After** > The chart updates to the selected time range, and the flavor selector redraws as expected. > ![6939-after](https://user-images.githubusercontent.com/10425301/114096008-2a73af00-988c-11eb-9a77-196bd47f9ef7.gif) This pull request has now been integrated. Changeset: 033cc933 Author: Alex Macdonald URL: https://git.openjdk.java.net/jmc/commit/033cc933 Stats: 17 lines in 3 files changed: 2 ins; 4 del; 11 mod 6939: Time range indicator isn't updated when setting the time range Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/238 From aptmac at openjdk.java.net Tue Apr 13 14:30:58 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Tue, 13 Apr 2021 14:30:58 GMT Subject: Integrated: 7105: Unable to open graph-view if JMC is booted with JDK 8 In-Reply-To: References: Message-ID: On Fri, 9 Apr 2021 17:17:19 GMT, Alex Macdonald wrote: > This one-liner PR addresses JMC-7105 [[0]](https://bugs.openjdk.java.net/browse/JMC-7105), in which the GraphView is unable to open when JMC is launched with JDK 8. > > The problem here is the usage of `List.of()` [[1]](https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.flightrecorder.graphview/src/main/java/org/openjdk/jmc/flightrecorder/graphview/views/GraphView.java#L186), which is supported in JDK 9+ [[2]](https://docs.oracle.com/javase/9/docs/api/java/util/List.html#of--), but not available in JDK 8 [[3]](https://docs.oracle.com/javase/8/docs/api/java/util/List.html). > > This PR simply changes `List.of()` to `Arrays.asList()` to make it JDK 8 compliant. > > [0] https://bugs.openjdk.java.net/browse/JMC-7105 > [1] https://github.com/openjdk/jmc/blob/master/application/org.openjdk.jmc.flightrecorder.graphview/src/main/java/org/openjdk/jmc/flightrecorder/graphview/views/GraphView.java#L186 > [2] https://docs.oracle.com/javase/9/docs/api/java/util/List.html#of-- > [3] https://docs.oracle.com/javase/8/docs/api/java/util/List.html This pull request has now been integrated. Changeset: 7732a7c5 Author: Alex Macdonald URL: https://git.openjdk.java.net/jmc/commit/7732a7c5 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 7105: Unable to open graph-view if JMC is booted with JDK 8 Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/239 From reinhapa at openjdk.java.net Wed Apr 14 17:52:50 2021 From: reinhapa at openjdk.java.net (Patrick Reinhart) Date: Wed, 14 Apr 2021 17:52:50 GMT Subject: RFR: 7241: Adjust main pom.xml to more align for 3th party builds Message-ID: Signed-off-by: Patrick Reinhart ------------- Commit messages: - 7241: Adjust main pom.xml to more align for 3th party builds Changes: https://git.openjdk.java.net/jmc/pull/241/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=241&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7241 Stats: 14 lines in 1 file changed: 4 ins; 10 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/241.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/241/head:pull/241 PR: https://git.openjdk.java.net/jmc/pull/241 From schaturvedi at openjdk.java.net Sun Apr 18 14:02:05 2021 From: schaturvedi at openjdk.java.net (Suchita Chaturvedi) Date: Sun, 18 Apr 2021 14:02:05 GMT Subject: RFR: 7242: Adding new JDK Events to core API Message-ID: This PR will address these missing events and add them to core API. jdk.ThreadCPULoad jdk.NativeMethodSample jdk.ThreadStart jdk.ThreadEnd ------------- Commit messages: - 7242: Adding new JDK Events to core API Changes: https://git.openjdk.java.net/jmc/pull/242/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=242&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7242 Stats: 24 lines in 5 files changed: 22 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jmc/pull/242.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/242/head:pull/242 PR: https://git.openjdk.java.net/jmc/pull/242 From schaturvedi at openjdk.java.net Sun Apr 18 14:43:37 2021 From: schaturvedi at openjdk.java.net (Suchita Chaturvedi) Date: Sun, 18 Apr 2021 14:43:37 GMT Subject: Withdrawn: 7242: Adding new JDK Events to core API In-Reply-To: References: Message-ID: On Sun, 18 Apr 2021 13:57:51 GMT, Suchita Chaturvedi wrote: > This PR will address these missing events and add them to core API. > > jdk.ThreadCPULoad > > jdk.NativeMethodSample > > jdk.ThreadStart > > jdk.ThreadEnd This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jmc/pull/242 From hirt at openjdk.java.net Mon Apr 19 17:40:36 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 19 Apr 2021 17:40:36 GMT Subject: RFR: 7167: Agent Plugin In-Reply-To: References: Message-ID: On Wed, 10 Mar 2021 22:58:07 GMT, Joshua Matsuoka wrote: > This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets. > > There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :) application/org.openjdk.jmc.console.ext.agent/META-INF/MANIFEST.MF line 5: > 3: Bundle-Name: JMC Agent Plugin > 4: Bundle-SymbolicName: org.openjdk.jmc.console.ext.agent;singleton:=true > 5: Bundle-Version: 8.0.0.qualifier 8.1.0 now. ;) ------------- PR: https://git.openjdk.java.net/jmc/pull/226 From hirt at openjdk.java.net Mon Apr 19 17:44:35 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 19 Apr 2021 17:44:35 GMT Subject: RFR: 7167: Agent Plugin In-Reply-To: References: Message-ID: On Wed, 10 Mar 2021 22:58:07 GMT, Joshua Matsuoka wrote: > This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets. > > There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :) Since this is part of the core rcp distribution (not an optional downloadable plug-in), I think you can skip the "ext". ------------- PR: https://git.openjdk.java.net/jmc/pull/226 From ts.stadler at gmx.de Tue Apr 20 14:48:09 2021 From: ts.stadler at gmx.de (Tobias Stadler) Date: Tue, 20 Apr 2021 16:48:09 +0200 Subject: ClassCastException when opening heap dump Message-ID: ?Hi everyone, I have a heap dump file which I cannot open in JDK Mission Control. However I can open it in VisualVM. Here is the exception I am getting: java.lang.ClassCastException: class java.lang.Integer cannot be cast to class org.openjdk.jmc.joverflow.heap.model.JavaHeapObject (java.lang.Integer is in module java.base of loader 'bootstrap'; org.openjdk.jmc.joverflow.heap.model.JavaHeapObject is in unnamed module of loader org.eclipse.osgi.internal.loader.EquinoxClassLoader @718ad3a6) at org.openjdk.jmc.joverflow.heap.model.Snapshot.getObjectForId(Snapshot.java:208) at org.openjdk.jmc.joverflow.heap.model.Snapshot.dereferenceField(Snapshot.java:311) at org.openjdk.jmc.joverflow.heap.model.JavaObject.parseFields(JavaObject.java:253) at org.openjdk.jmc.joverflow.heap.model.JavaObject.getFields(JavaObject.java:83) at org.openjdk.jmc.joverflow.stats.BreadthFirstHeapScanner.scanObjectsFromRootObj(BreadthFirstHeapScanner.java:110) at org.openjdk.jmc.joverflow.stats.HeapScaner.analyzeViaAllObjectsEnum(HeapScaner.java:132) at org.openjdk.jmc.joverflow.stats.DetailedStatsCalculator.calculate(DetailedStatsCalculator.java:142) at org.openjdk.jmc.joverflow.stats.StandardStatsCalculator.calculate(StandardStatsCalculator.java:74) at org.openjdk.jmc.joverflow.ui.model.ModelLoader.run(ModelLoader.java:103) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829) I am using JDK Mission Control 8.0.0+b13. The heap dump was created JVM running Amazon Corretto 1.8.0_272. I can open the file with the following diff diff --git a/application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/heap/model/Snapshot.java b/application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/heap/model/Snapshot.java index 16f56b57..64330571 100644 --- a/application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/heap/model/Snapshot.java +++ b/application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/heap/model/Snapshot.java @@ -771,7 +771,7 @@ public class Snapshot { } // Create fake instance class - return new JavaClass(name, 0, 0, 0, 0, fields, JavaClass.NO_FIELDS, JavaClass.NO_VALUES, instSize, + return new JavaClass(classID, name, 0, 0, 0, 0, fields, JavaClass.NO_FIELDS, JavaClass.NO_VALUES, instSize, getInMemoryInstanceSize(instSize)); } Regards Tobias From marcus at hirt.se Tue Apr 20 18:49:41 2021 From: marcus at hirt.se (Marcus Hirt) Date: Tue, 20 Apr 2021 20:49:41 +0200 Subject: Sv: ClassCastException when opening heap dump In-Reply-To: References: Message-ID: <043101d73615$ec37ec20$c4a7c460$@hirt.se> Hi Tobias, Thank you for reporting this! This would make a perfect PR! :) https://github.com/openjdk/jmc Let me know if I can help facilitate the process! I've opened an issue here: https://bugs.openjdk.java.net/browse/JMC-7246 Kind regards, Marcus -----Ursprungligt meddelande----- Fr?n: jmc-dev F?r Tobias Stadler Skickat: den 20 april 2021 16:48 Till: jmc-dev at openjdk.java.net ?mne: ClassCastException when opening heap dump ?Hi everyone, I have a heap dump file which I cannot open in JDK Mission Control. However I can open it in VisualVM. Here is the exception I am getting: java.lang.ClassCastException: class java.lang.Integer cannot be cast to class org.openjdk.jmc.joverflow.heap.model.JavaHeapObject (java.lang.Integer is in module java.base of loader 'bootstrap'; org.openjdk.jmc.joverflow.heap.model.JavaHeapObject is in unnamed module of loader org.eclipse.osgi.internal.loader.EquinoxClassLoader @718ad3a6) at org.openjdk.jmc.joverflow.heap.model.Snapshot.getObjectForId(Snapshot.java:208) at org.openjdk.jmc.joverflow.heap.model.Snapshot.dereferenceField(Snapshot.java:311) at org.openjdk.jmc.joverflow.heap.model.JavaObject.parseFields(JavaObject.java:253) at org.openjdk.jmc.joverflow.heap.model.JavaObject.getFields(JavaObject.java:83) at org.openjdk.jmc.joverflow.stats.BreadthFirstHeapScanner.scanObjectsFromRootObj(BreadthFirstHeapScanner.java:110) at org.openjdk.jmc.joverflow.stats.HeapScaner.analyzeViaAllObjectsEnum(HeapScaner.java:132) at org.openjdk.jmc.joverflow.stats.DetailedStatsCalculator.calculate(DetailedStatsCalculator.java:142) at org.openjdk.jmc.joverflow.stats.StandardStatsCalculator.calculate(StandardStatsCalculator.java:74) at org.openjdk.jmc.joverflow.ui.model.ModelLoader.run(ModelLoader.java:103) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829) I am using JDK Mission Control 8.0.0+b13. The heap dump was created JVM running Amazon Corretto 1.8.0_272. I can open the file with the following diff diff --git a/application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/heap/model/Snapshot.java b/application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/heap/model/Snapshot.java index 16f56b57..64330571 100644 --- a/application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/heap/model/Snapshot.java +++ b/application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/heap/model/Snapshot.java @@ -771,7 +771,7 @@ public class Snapshot { } // Create fake instance class - return new JavaClass(name, 0, 0, 0, 0, fields, JavaClass.NO_FIELDS, JavaClass.NO_VALUES, instSize, + return new JavaClass(classID, name, 0, 0, 0, 0, fields, JavaClass.NO_FIELDS, JavaClass.NO_VALUES, instSize, getInMemoryInstanceSize(instSize)); } Regards Tobias From github.com+22965777+tobiasstadler at openjdk.java.net Thu Apr 22 11:43:28 2021 From: github.com+22965777+tobiasstadler at openjdk.java.net (Tobias Stadler) Date: Thu, 22 Apr 2021 11:43:28 GMT Subject: RFR: 7246: ClassCastException when opening heap dump Message-ID: <_EvlM7_RoLXOwgxep6iMfU2hCxCzj3aaifYEZA-ju54=.4c1cac8f-3b1f-46f2-a255-cbeee3947a77@github.com> Signed-off-by: Tobias Stadler ------------- Commit messages: - 7246: ClassCastException when opening heap dump Changes: https://git.openjdk.java.net/jmc/pull/243/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=243&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7246 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/243.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/243/head:pull/243 PR: https://git.openjdk.java.net/jmc/pull/243 From hirt at openjdk.java.net Thu Apr 22 11:56:22 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 22 Apr 2021 11:56:22 GMT Subject: RFR: 7246: ClassCastException when opening heap dump In-Reply-To: <_EvlM7_RoLXOwgxep6iMfU2hCxCzj3aaifYEZA-ju54=.4c1cac8f-3b1f-46f2-a255-cbeee3947a77@github.com> References: <_EvlM7_RoLXOwgxep6iMfU2hCxCzj3aaifYEZA-ju54=.4c1cac8f-3b1f-46f2-a255-cbeee3947a77@github.com> Message-ID: <05ornOvNLHSBqsstZTTTj-zMJFbGbdi5WfeZhSmi-9Y=.170648e2-5315-4815-ba2b-ad6cbf6e76e3@github.com> On Wed, 21 Apr 2021 06:08:58 GMT, Tobias Stadler wrote: > Signed-off-by: Tobias Stadler Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/243 From hirt at openjdk.java.net Fri Apr 23 17:33:25 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 23 Apr 2021 17:33:25 GMT Subject: RFR: 7246: ClassCastException when opening heap dump In-Reply-To: <_EvlM7_RoLXOwgxep6iMfU2hCxCzj3aaifYEZA-ju54=.4c1cac8f-3b1f-46f2-a255-cbeee3947a77@github.com> References: <_EvlM7_RoLXOwgxep6iMfU2hCxCzj3aaifYEZA-ju54=.4c1cac8f-3b1f-46f2-a255-cbeee3947a77@github.com> Message-ID: On Wed, 21 Apr 2021 06:08:58 GMT, Tobias Stadler wrote: > Signed-off-by: Tobias Stadler Thank you for the contribution @tobiasstadler! :) ------------- PR: https://git.openjdk.java.net/jmc/pull/243 From github.com+22965777+tobiasstadler at openjdk.java.net Sun Apr 25 09:27:40 2021 From: github.com+22965777+tobiasstadler at openjdk.java.net (Tobias Stadler) Date: Sun, 25 Apr 2021 09:27:40 GMT Subject: Integrated: 7246: ClassCastException when opening heap dump In-Reply-To: <_EvlM7_RoLXOwgxep6iMfU2hCxCzj3aaifYEZA-ju54=.4c1cac8f-3b1f-46f2-a255-cbeee3947a77@github.com> References: <_EvlM7_RoLXOwgxep6iMfU2hCxCzj3aaifYEZA-ju54=.4c1cac8f-3b1f-46f2-a255-cbeee3947a77@github.com> Message-ID: On Wed, 21 Apr 2021 06:08:58 GMT, Tobias Stadler wrote: > Signed-off-by: Tobias Stadler This pull request has now been integrated. Changeset: 917a95c4 Author: Tobias Stadler Committer: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/917a95c4 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 7246: ClassCastException when opening heap dump Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/243 From marcus.hirt at datadoghq.com Mon Apr 26 08:44:13 2021 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Mon, 26 Apr 2021 10:44:13 +0200 Subject: JMC 8.1.0 important dates Message-ID: Hi all, Here comes a friendly reminder of the milestone dates for JMC 8.1.0: 8.1.0 RDS: 2021-06-02 8.1.0 RDP2: 2021-07-02 8.1.0 GA*: 2021-08-02 Let me know if you have any questions or concerns! Kind regards, Marcus * Source release - downstream vendors release binaries on their own time schedule. From github.com+4610701+jpbempel at openjdk.java.net Tue Apr 27 07:21:50 2021 From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Tue, 27 Apr 2021 07:21:50 GMT Subject: RFR: 7124: Support the new JDK 16 allocation profiling event Message-ID: Add support of ObjectAllocationSample event in HeapPage ------------- Commit messages: - 7124: Support the new JDK 16 allocation profiling event Changes: https://git.openjdk.java.net/jmc/pull/244/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=244&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7124 Stats: 57 lines in 7 files changed: 36 ins; 13 del; 8 mod Patch: https://git.openjdk.java.net/jmc/pull/244.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/244/head:pull/244 PR: https://git.openjdk.java.net/jmc/pull/244 From jmatsuoka at openjdk.java.net Tue Apr 27 13:24:24 2021 From: jmatsuoka at openjdk.java.net (Joshua Matsuoka) Date: Tue, 27 Apr 2021 13:24:24 GMT Subject: RFR: 7167: Agent Plugin [v2] In-Reply-To: References: Message-ID: > This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets. > > There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :) Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision: Removing ext from agent plugin identifier, fixing bundle version ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/226/files - new: https://git.openjdk.java.net/jmc/pull/226/files/789298d7..a87cbb7d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=226&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=226&range=00-01 Stats: 377 lines in 61 files changed: 115 ins; 115 del; 147 mod Patch: https://git.openjdk.java.net/jmc/pull/226.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/226/head:pull/226 PR: https://git.openjdk.java.net/jmc/pull/226 From jmatsuoka at openjdk.java.net Tue Apr 27 19:12:23 2021 From: jmatsuoka at openjdk.java.net (Joshua Matsuoka) Date: Tue, 27 Apr 2021 19:12:23 GMT Subject: RFR: 7167: Agent Plugin [v3] In-Reply-To: References: Message-ID: > This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets. > > There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :) Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision: Fixing build issues, cleanup ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/226/files - new: https://git.openjdk.java.net/jmc/pull/226/files/a87cbb7d..11b1fb15 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=226&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=226&range=01-02 Stats: 77 lines in 74 files changed: 19 ins; 17 del; 41 mod Patch: https://git.openjdk.java.net/jmc/pull/226.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/226/head:pull/226 PR: https://git.openjdk.java.net/jmc/pull/226 From jmatsuoka at openjdk.java.net Tue Apr 27 19:16:02 2021 From: jmatsuoka at openjdk.java.net (Joshua Matsuoka) Date: Tue, 27 Apr 2021 19:16:02 GMT Subject: RFR: 7167: Agent Plugin [v4] In-Reply-To: References: Message-ID: > This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets. > > There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :) Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision: cleanup ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/226/files - new: https://git.openjdk.java.net/jmc/pull/226/files/11b1fb15..cebd5e4c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=226&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=226&range=02-03 Stats: 35 lines in 1 file changed: 0 ins; 35 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/226.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/226/head:pull/226 PR: https://git.openjdk.java.net/jmc/pull/226 From hirt at openjdk.java.net Tue Apr 27 20:23:05 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 27 Apr 2021 20:23:05 GMT Subject: RFR: 7167: Agent Plugin [v4] In-Reply-To: References: Message-ID: On Tue, 27 Apr 2021 19:16:02 GMT, Joshua Matsuoka wrote: >> This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets. >> >> There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :) > > Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision: > > cleanup Failing validation checks. ------------- PR: https://git.openjdk.java.net/jmc/pull/226 From jmatsuoka at openjdk.java.net Wed Apr 28 17:27:26 2021 From: jmatsuoka at openjdk.java.net (Joshua Matsuoka) Date: Wed, 28 Apr 2021 17:27:26 GMT Subject: RFR: 7167: Agent Plugin [v5] In-Reply-To: References: Message-ID: > This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets. > > There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :) Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision: Fix missed renames ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/226/files - new: https://git.openjdk.java.net/jmc/pull/226/files/cebd5e4c..e785217f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=226&range=04 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=226&range=03-04 Stats: 11 lines in 2 files changed: 0 ins; 0 del; 11 mod Patch: https://git.openjdk.java.net/jmc/pull/226.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/226/head:pull/226 PR: https://git.openjdk.java.net/jmc/pull/226 From jmatsuoka at openjdk.java.net Wed Apr 28 17:57:17 2021 From: jmatsuoka at openjdk.java.net (Joshua Matsuoka) Date: Wed, 28 Apr 2021 17:57:17 GMT Subject: RFR: 7167: Agent Plugin [v6] In-Reply-To: References: Message-ID: <81i7tInHHp-rf5jdplOH3TaSatjsumQ-64cgxQejyuI=.2da150e4-3cc5-4b2f-a542-ed9afee1adcc@github.com> > This PR adds the Agent Plugin to JMC. This is a plugin for controlling the jmc agent and provides a way to attach it and add probes to any JVMs in the JVM browser, as well as providing a preset manager for creating/modifying probe presets. > > There is still a small amount of cleanup to be done so I'll mark it as a draft for now but it would be great to get a review :) Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision: Fix rcp feature to use new agent plugin name ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/226/files - new: https://git.openjdk.java.net/jmc/pull/226/files/e785217f..411dc189 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=226&range=05 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=226&range=04-05 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/226.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/226/head:pull/226 PR: https://git.openjdk.java.net/jmc/pull/226 From hirt at openjdk.java.net Thu Apr 29 18:58:51 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 29 Apr 2021 18:58:51 GMT Subject: RFR: 7124: Support the new JDK 16 allocation profiling event In-Reply-To: References: Message-ID: On Tue, 27 Apr 2021 07:17:21 GMT, Jean-Philippe Bempel wrote: > Add support of ObjectAllocationSample event in HeapPage Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/244