RFR: 7031: Build a constant pool explorer page [v2]

Fri Apr 2 08:16:07 UTC 2021

On Mon, 29 Mar 2021 20:07:03 GMT, Henrik Dafgård <hdafgard at openjdk.org> wrote:

>> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   load state for SASH
>
> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ConstantPoolsPage.java line 178:
> 
>> 176: 		@Override
>> 177: 		public void saveTo(IWritableState writableState) {
>> 178: 			PersistableSashForm.saveState(sash, writableState.createChild(SASH_ELEMENT));
> 
> This saves the state of the SashForm, but that state isn't loaded in the IPageUI constructor, so the value used will only be the default for a SashForm.
> 
> E.g. `PersistableSashForm.loadState(sash, state.getChild(SASH));`

done

-------------

PR: https://git.openjdk.java.net/jmc/pull/228