RFR: 7194 : No local JVMs found message could be more helpful

Marcus Hirt hirt at openjdk.java.net
Wed Apr 7 19:19:11 UTC 2021


On Tue, 30 Mar 2021 14:32:06 GMT, Henrik Dafgård <hdafgard at openjdk.org> wrote:

>>> Does this render OK in the help browser?
>> 
>> Probably not ;-)
>> 
>> But from my previous comments it could have become obviuos that I wasn't aware of the repo FAQ shown elsewhere. Now that I know that it's parts of the included help, I reverted the commit and added just my new answer.
>> 
>> How will we get rid of the extra commits? Have I to re-push the branch again or is there a squash functionality when the PR will be merged. Sorry, I need help here because it's my first contribution to a GitHub project.
>
>> How will we get rid of the extra commits? Have I to re-push the branch again or is there a squash functionality when the PR will be merged. Sorry, I need help here because it's my first contribution to a GitHub project.
> 
>  When the PR is integrated all commits will be squashed, so you don't really need to do anything particular here.

As Henrik said - it's all part of the Skara workflow. It will all automatically be squashed into one neat commit in the end. :)

-------------

PR: https://git.openjdk.java.net/jmc/pull/232


More information about the jmc-dev mailing list