RFR: 7194 : No local JVMs found message could be more helpful [v3]
Michael S.
github.com+29914148+docwarems at openjdk.java.net
Thu Apr 8 15:41:35 UTC 2021
On Wed, 7 Apr 2021 19:16:46 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> Michael S. has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 7194: text improved
>
> application/org.openjdk.jmc.browser/src/main/resources/org/openjdk/jmc/browser/views/messages.properties line 60:
>
>> 58: # JVMBrowserView_NO_LOCAL_JVMS_WARN_CAUSE has newlines placed so that the rows doesn't get too long. It would be
>> 59: # great if the translation also contains newlines so the rows get about the same length.
>> 60: JVMBrowserView_NO_LOCAL_JVMS_WARN_CAUSE=Local JVMs will not be detected if the JDK Mission Control Client is run with a JRE instead of a JDK, if the JDK is <11, or if the hsperfdata_<user> folder in TMP is not writable. See the FAQ help section for more information.
>
> Perhaps instead spell out the less than and expand to JDK version? Like so ", if the JDK version is less than 11, "
Ok, this one too. Saw this first comment to late -> two commits
-------------
PR: https://git.openjdk.java.net/jmc/pull/232
More information about the jmc-dev
mailing list