RFR: 7195: GC confguration with GC Flags

[Marcus Hirt]

On Fri, 2 Apr 2021 16:37:06 GMT, Brice Dutheil <github.com+803621+bric3 at openjdk.org> wrote:

>> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/GCConfigurationPage.java line 281:
>> 
>>> 279: 		// TODO Cannot discover EpsilonGC via the old collector name, because Epsilon reports the same as SerialGC
>>> 280: //		case "Epsilon":
>>> 281: //			// from https://github.com/openjdk/jdk11u/blob/6c31ac2acdc2b2efa63fe92de8368ab964d847e9/src/hotspot/share/gc/epsilon/epsilon_globals.hpp
>> 
>> Dead code. Want to try some other means of discovery?
>
> @thegreystone Finally I got some time to rework the discovery.
> 
> I'd like your input however : 
> 1. I created a class `GCFlagFilters` however I wonder if it makes sens to move it to `org.openjdk.jmc.flightrecorder` module in the `org.openjdk.jmc.flightrecorder.jdk` ?
> 2. I am not sure how to write tests. I have been playing with `org.openjdk.jmc.flightrecorder.uitest` module, but it's a bit slow to use, and I was only able to run them via maven command line.

1. I think it is fine where it is, but you can strike up a conversion in the JMC slack/the jmc-dev list, and if there is enough interest, moving it to core could be a separate PR.

2. There is a launcher in org.openjdk.jmc.flightrecorder.uitest that should allow you to run only the flight recorder uitests from within Eclipse.

-------------

PR: https://git.openjdk.java.net/jmc/pull/230