RFR: 7307: Move org.openjdk.jmc.flightrecorder.configuration bundle from application to core

Alex Macdonald aptmac at openjdk.java.net
Mon Aug 9 21:44:04 UTC 2021


This PR addresses JMC-7307 [[0]](https://bugs.openjdk.java.net/browse/JMC-7307), in which it would be helpful to have `flightrecorder.configuration` distributed in jmc core.

`flightrecorder.configuration` itself is a pretty straightforward movement of code, as it doesn't have any dependencies. Having said that, there are some flightrecorder-configuration-related classes in `controlpanel.ui` which would be nice to have in core as well, and would probably do well in `flightrecorder.configuration`. This includes VolatileStorageDelegate, and the 12 classes in `configuration.model.xml`. The `controlpanel.ui.configuration` unit tests can also come over to core, because they only tested the model xml code anyways.

So in total, we're looking at `flightrecorder.configuration` and the former `controlpanel.ui.configuration` test coming over to core, and the following classes:
- org.openjdk.jmc.flightrecorder.configuration.model.VolatileStorageDelegate
- org.openjdk.jmc.flightrecorder.configuration.model.xml.IXMLValidator
- org.openjdk.jmc.flightrecorder.configuration.model.xml.JFCGrammar
- org.openjdk.jmc.flightrecorder.configuration.model.xml.JFCXMLValidator
- org.openjdk.jmc.flightrecorder.configuration.model.xml.PrettyPrinter
- org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLAttribute
- org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLAttributeInstance
- org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLModel
- org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLNode
- org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLNodeType
- org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLTag
- org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLTagInstance
- org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLValidationResult

[0] https://bugs.openjdk.java.net/browse/JMC-7307

-------------

Commit messages:
 - re-order flightrecorder.configuration.test in test pom
 - update license headers
 - migrate VolatileStorageDelegate to flightrecorder.configuration.model
 - revert .classpath files to their original from application
 - minor cleanup
 - move configuration.model.xml test from application to core; remove controlpanel.ui.configuration.test
 - move flightrecorder.configuration coverage from application to core
 - temporarily silence test modules that are moved, will cleanup after
 - migrate controlpanel.ui.configuration.model.xml to core
 - migrate flightrecorder.configuration to core

Changes: https://git.openjdk.java.net/jmc/pull/299/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=299&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7307
  Stats: 1004 lines in 99 files changed: 373 ins; 475 del; 156 mod
  Patch: https://git.openjdk.java.net/jmc/pull/299.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/299/head:pull/299

PR: https://git.openjdk.java.net/jmc/pull/299


More information about the jmc-dev mailing list