RFR: 7451: Add heat map view [v4]

Alex Macdonald aptmac at openjdk.java.net
Fri Dec 3 19:56:20 UTC 2021


On Fri, 3 Dec 2021 19:50:57 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

>> application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/page.template line 11:
>> 
>>> 9: 
>>> 10:   <body>
>>> 11:     <div id="heatmap" width="100%%" style="text-align: center"></div>
>> 
>> Extra "%" here ?
>
> That’s intentional �� We use `String.format` to build the HTML from this template file and we need to escape `%` so it doesn’t confuse it with the arguments.
> 
> This is one of the reasons I extracted the JS to a separate file, it was annoying to have to escape this everywhere (e.g. remainder operator, other percentages).

Ah, neat! Thanks for the explanation!

-------------

PR: https://git.openjdk.java.net/jmc/pull/337


More information about the jmc-dev mailing list