RFR: 7455: Add support for jolokia JMX service connection [v6]

Martin Skarsaune duke at openjdk.java.net
Mon Dec 20 12:30:30 UTC 2021


On Mon, 20 Dec 2021 10:01:53 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed -XstartOnFirstThread as it is not valid for some JVMs
>
> application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/AbstractCachedDescriptorProvider.java line 45:
> 
>> 43: 
>> 44: /**
>> 45:  * I cache a list if identified JVMs that can be refreshed in the background by some means of
> 
> "I" personal pronomen. "if" identified. 
> 
> Better to keep it impersonal and describe what the class does. E.g. "Keeps a list of identified JVMs..."
> "The {@code AbstractCachedDescriptorProvider} keeps a list of identified JVMs..." would be even better.

I see. Will adjust �� . FYI: I'm on the old Smalltalk extreme object oriented lingo. You may have seen it in SWT and JFace code as well. A bit out of date. 
I'm currently on 2 week holiday with family, will get back to the PR next year ��

-------------

PR: https://git.openjdk.java.net/jmc/pull/332


More information about the jmc-dev mailing list