Integrated: 7480: Trim method descriptor value

Gunnar Morling duke at openjdk.java.net
Tue Dec 21 16:21:23 UTC 2021


On Sat, 18 Dec 2021 17:30:01 GMT, Gunnar Morling <duke at openjdk.java.net> wrote:

> Hey @thegreystone, here's a fix for trimming the method signature value when building the method descriptors in the agent. Without this, wrapping the tags around long signatures like that [will fail](https://github.com/moditect/jfrunit-examples/commit/bd4bc8023c760a3d719dc9295cbe010fb56d7f6f#diff-8999381a163c84127b7e94462f39060c054a984904f82c34713d0ade0954e4c5R81):
> 
> 
>  <descriptor>
>    (Ljava/sql/PreparedStatement;Ljava/lang/Object;ILorg/hibernate/type/descriptor/WrapperOptions;)V
> </descriptor>
> 
> 
> Could you log an issue if you think it's a worthwhile fix? The second commit is some unrelated clean-up I did along the way. Thx!

This pull request has now been integrated.

Changeset: 1c6ccc9b
Author:    Gunnar Morling <gunnar.morling at googlemail.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/1c6ccc9b644f7953ebb5f513aab5ada56760283b
Stats:     3 lines in 2 files changed: 0 ins; 1 del; 2 mod

7480: Trim method descriptor value

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/343


More information about the jmc-dev mailing list