From schaturvedi at openjdk.java.net Mon Feb 1 11:57:41 2021 From: schaturvedi at openjdk.java.net (Suchita Chaturvedi) Date: Mon, 1 Feb 2021 11:57:41 GMT Subject: RFR: 7039: Timestamp granularity too coarse [v4] In-Reply-To: <2LVYo7_R6yVXTZptxlAN00pG-7NG4q14IxRSgcZltEc=.dd45123e-0eec-47cb-a081-39ff91c4e305@github.com> References: <7X1f0Qi20HPDWpgs2vk1irZ6WtFAqNYX13ABXaG-hKQ=.32b6df02-fa9b-4121-a849-592a571de8be@github.com> <2LVYo7_R6yVXTZptxlAN00pG-7NG4q14IxRSgcZltEc=.dd45123e-0eec-47cb-a081-39ff91c4e305@github.com> Message-ID: On Fri, 29 Jan 2021 17:54:23 GMT, Marcus Hirt wrote: > I'd prefer if they were fixed with this PR, if there are failures related to the changes in this PR. If the failures are unrelated, i.e. master already fails in the same ways, it can be a separate PR. @thegreystone I ran UITests using below mentioned command mvn verify -P uitests -fae > testresults.txt There are few failures as below 1. [INFO] org.openjdk.jmc.rjmx.test 8.1.0-SNAPSHOT ........... FAILURE [03:45 min] 2. [INFO] org.openjdk.jmc.browser.uitest 1.0.0-SNAPSHOT ...... FAILURE [03:16 min] 3. [INFO] org.openjdk.jmc.console.jconsole.uitest 1.0.0-SNAPSHOT FAILURE [01:26 min] 4. [INFO] org.openjdk.jmc.console.persistence.uitest 1.0.0-SNAPSHOT FAILURE [01:23 min] 5. [INFO] org.openjdk.jmc.console.uitest 1.0.0-SNAPSHOT ...... FAILURE [03:57 min] 6. [INFO] org.openjdk.jmc.flightrecorder.uitest 1.0.0-SNAPSHOT FAILURE [03:42 min] 7. [INFO] org.openjdk.jmc.rcp.application.uitest 1.0.0-SNAPSHOT FAILURE [01:13 min] Number 1 is present in both master and my branch. All others are present only in master while its succeeding in my branch so may be they are due to some new change which is in master and not in my branch. Please let me know if you are getting some additional failures which I need to look into. ------------- PR: https://git.openjdk.java.net/jmc/pull/201 From marcus.hirt at datadoghq.com Mon Feb 1 13:56:46 2021 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Mon, 1 Feb 2021 14:56:46 +0100 Subject: JMC 8.0.0 GA Message-ID: Hi all, The JMC 8.0.0-gac tag was set 11 days ago, and so far I have not heard about any issue important enough to hold up the release. Unless I hear otherwise, I'll declare GA tomorrow the 2nd of February 21:00 CET. Kind regards, Marcus From marcus.hirt at datadoghq.com Tue Feb 2 16:11:44 2021 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Tue, 2 Feb 2021 17:11:44 +0100 Subject: Regression / JMC 8.0.0 release delayed Message-ID: Hi all, Oracle found a regression that will have to be fixed before we can release JMC 8.0.0: https://bugs.openjdk.java.net/browse/JMC-7088 Henrik is taking a closer look at it. Sorry for the inconvenience. Kind regards, Marcus From hdafgard at openjdk.java.net Wed Feb 3 16:51:51 2021 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Wed, 3 Feb 2021 16:51:51 GMT Subject: RFR: 7088: Show concurrent option showing lesser number of records. Message-ID: <6u7o_EiaUKVMozqOMl-P5uF39mUp7EXIRBju4DyDsKo=.ea915d83-88ff-47f0-a006-d2e01e6a0302@github.com> Due to how StreamBackedItemCollections differ from EventCollections we can't rely on the assumption made that disjoint events are sorted in each IItemIterable. And since the classes aren't visible from RulesToolkit we have to look at the class name like this. ------------- Commit messages: - Fix whitespace formatting - Disable optimisation for stream backed item collections Changes: https://git.openjdk.java.net/jmc/pull/208/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=208&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7088 Stats: 68 lines in 1 file changed: 25 ins; 6 del; 37 mod Patch: https://git.openjdk.java.net/jmc/pull/208.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/208/head:pull/208 PR: https://git.openjdk.java.net/jmc/pull/208 From hirt at openjdk.java.net Wed Feb 3 17:43:41 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 3 Feb 2021 17:43:41 GMT Subject: RFR: 7088: Show concurrent option showing lesser number of records. In-Reply-To: <6u7o_EiaUKVMozqOMl-P5uF39mUp7EXIRBju4DyDsKo=.ea915d83-88ff-47f0-a006-d2e01e6a0302@github.com> References: <6u7o_EiaUKVMozqOMl-P5uF39mUp7EXIRBju4DyDsKo=.ea915d83-88ff-47f0-a006-d2e01e6a0302@github.com> Message-ID: On Wed, 3 Feb 2021 16:47:11 GMT, Henrik Dafg?rd wrote: > Due to how StreamBackedItemCollections differ from EventCollections we can't rely on the assumption made that disjoint events are sorted in each IItemIterable. And since the classes aren't visible from RulesToolkit we have to look at the class name like this. core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/util/RulesToolkit.java line 1373: > 1371: */ > 1372: public static IQuantity getEarliestStartTime(IItemCollection items) { > 1373: if (items.getClass().getName().equals("EventCollection")) { //$NON-NLS-1$ I think a comment with a link to the issue would be nice here. :) ------------- PR: https://git.openjdk.java.net/jmc/pull/208 From hdafgard at openjdk.java.net Wed Feb 3 18:47:58 2021 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Wed, 3 Feb 2021 18:47:58 GMT Subject: RFR: 7088: Show concurrent option showing lesser number of records. [v2] In-Reply-To: <6u7o_EiaUKVMozqOMl-P5uF39mUp7EXIRBju4DyDsKo=.ea915d83-88ff-47f0-a006-d2e01e6a0302@github.com> References: <6u7o_EiaUKVMozqOMl-P5uF39mUp7EXIRBju4DyDsKo=.ea915d83-88ff-47f0-a006-d2e01e6a0302@github.com> Message-ID: <2lC9ggkIBrmr3GelFCKxnq5gcQLrEEqNwuXlLs_rZvc=.b846d3e9-508b-49d8-96b0-389299a11a7e@github.com> > Due to how StreamBackedItemCollections differ from EventCollections we can't rely on the assumption made that disjoint events are sorted in each IItemIterable. And since the classes aren't visible from RulesToolkit we have to look at the class name like this. Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision: Add comment with issue reference ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/208/files - new: https://git.openjdk.java.net/jmc/pull/208/files/661db8a2..289e5844 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=208&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=208&range=00-01 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/208.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/208/head:pull/208 PR: https://git.openjdk.java.net/jmc/pull/208 From hirt at openjdk.java.net Wed Feb 3 18:56:39 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 3 Feb 2021 18:56:39 GMT Subject: RFR: 7039: Timestamp granularity too coarse [v5] In-Reply-To: References: <7X1f0Qi20HPDWpgs2vk1irZ6WtFAqNYX13ABXaG-hKQ=.32b6df02-fa9b-4121-a849-592a571de8be@github.com> Message-ID: On Thu, 28 Jan 2021 15:09:56 GMT, Suchita Chaturvedi wrote: >> As part of this enhancement request, user can see the timestamps down to fraction of a second. >> This will solve the problem for all views, including Event Browser, Properties where most of the records are differentiated by fraction of seconds but since the timestamp shown is only till second, the difference is not visible on UI. >> >> For ex: If the End Time of Event is listed as below, the difference is clearly visible >> ![image](https://user-images.githubusercontent.com/11155712/105097851-465a8680-5acf-11eb-8a5c-f01ecb3390ce.png) > > Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: > > Replaced colon with dot as per review comment Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/201 From schaturvedi at openjdk.java.net Wed Feb 3 20:38:38 2021 From: schaturvedi at openjdk.java.net (Suchita Chaturvedi) Date: Wed, 3 Feb 2021 20:38:38 GMT Subject: Integrated: 7039: Timestamp granularity too coarse In-Reply-To: <7X1f0Qi20HPDWpgs2vk1irZ6WtFAqNYX13ABXaG-hKQ=.32b6df02-fa9b-4121-a849-592a571de8be@github.com> References: <7X1f0Qi20HPDWpgs2vk1irZ6WtFAqNYX13ABXaG-hKQ=.32b6df02-fa9b-4121-a849-592a571de8be@github.com> Message-ID: On Tue, 19 Jan 2021 21:58:44 GMT, Suchita Chaturvedi wrote: > As part of this enhancement request, user can see the timestamps down to fraction of a second. > This will solve the problem for all views, including Event Browser, Properties where most of the records are differentiated by fraction of seconds but since the timestamp shown is only till second, the difference is not visible on UI. > > For ex: If the End Time of Event is listed as below, the difference is clearly visible > ![image](https://user-images.githubusercontent.com/11155712/105097851-465a8680-5acf-11eb-8a5c-f01ecb3390ce.png) This pull request has now been integrated. Changeset: 7b1ae3e3 Author: Suchita Chaturvedi URL: https://git.openjdk.java.net/jmc/commit/7b1ae3e3 Stats: 17 lines in 2 files changed: 13 ins; 0 del; 4 mod 7039: Timestamp granularity too coarse Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/201 From hirt at openjdk.java.net Thu Feb 4 00:10:40 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 4 Feb 2021 00:10:40 GMT Subject: RFR: 7088: Show concurrent option showing lesser number of records. [v2] In-Reply-To: <2lC9ggkIBrmr3GelFCKxnq5gcQLrEEqNwuXlLs_rZvc=.b846d3e9-508b-49d8-96b0-389299a11a7e@github.com> References: <6u7o_EiaUKVMozqOMl-P5uF39mUp7EXIRBju4DyDsKo=.ea915d83-88ff-47f0-a006-d2e01e6a0302@github.com> <2lC9ggkIBrmr3GelFCKxnq5gcQLrEEqNwuXlLs_rZvc=.b846d3e9-508b-49d8-96b0-389299a11a7e@github.com> Message-ID: On Wed, 3 Feb 2021 18:47:58 GMT, Henrik Dafg?rd wrote: >> Due to how StreamBackedItemCollections differ from EventCollections we can't rely on the assumption made that disjoint events are sorted in each IItemIterable. And since the classes aren't visible from RulesToolkit we have to look at the class name like this. > > Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision: > > Add comment with issue reference Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/208 From hirt at openjdk.java.net Thu Feb 4 10:09:52 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 4 Feb 2021 10:09:52 GMT Subject: Integrated: 6655: Ignoring test files Message-ID: 6655: Ignoring test files ------------- Commit messages: - 6655: Ignoring test files Changes: https://git.openjdk.java.net/jmc/pull/17/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=17&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-6655 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/17.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/17/head:pull/17 PR: https://git.openjdk.java.net/jmc/pull/17 From hdafgard at openjdk.java.net Thu Feb 4 10:09:52 2021 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Thu, 4 Feb 2021 10:09:52 GMT Subject: Integrated: 6655: Ignoring test files In-Reply-To: References: Message-ID: On Wed, 11 Dec 2019 22:10:35 GMT, Marcus Hirt wrote: > 6655: Ignoring test files Marked as reviewed by hdafgard (Reviewer). ------------- PR: https://git.openjdk.java.net/jmc/pull/17 From hirt at openjdk.java.net Thu Feb 4 17:01:40 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 4 Feb 2021 17:01:40 GMT Subject: RFR: 7088: Show concurrent option showing lesser number of records. In-Reply-To: <6u7o_EiaUKVMozqOMl-P5uF39mUp7EXIRBju4DyDsKo=.ea915d83-88ff-47f0-a006-d2e01e6a0302@github.com> References: <6u7o_EiaUKVMozqOMl-P5uF39mUp7EXIRBju4DyDsKo=.ea915d83-88ff-47f0-a006-d2e01e6a0302@github.com> Message-ID: On Wed, 3 Feb 2021 16:47:11 GMT, Henrik Dafg?rd wrote: > Due to how StreamBackedItemCollections differ from EventCollections we can't rely on the assumption made that disjoint events are sorted in each IItemIterable. And since the classes aren't visible from RulesToolkit we have to look at the class name like this. @Gunde, please /integrate so that @guruhb can cherry pick this one for 8. ------------- PR: https://git.openjdk.java.net/jmc/pull/208 From hdafgard at openjdk.java.net Thu Feb 4 17:11:42 2021 From: hdafgard at openjdk.java.net (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Thu, 4 Feb 2021 17:11:42 GMT Subject: Integrated: 7088: Show concurrent option showing lesser number of records. In-Reply-To: <6u7o_EiaUKVMozqOMl-P5uF39mUp7EXIRBju4DyDsKo=.ea915d83-88ff-47f0-a006-d2e01e6a0302@github.com> References: <6u7o_EiaUKVMozqOMl-P5uF39mUp7EXIRBju4DyDsKo=.ea915d83-88ff-47f0-a006-d2e01e6a0302@github.com> Message-ID: On Wed, 3 Feb 2021 16:47:11 GMT, Henrik Dafg?rd wrote: > Due to how StreamBackedItemCollections differ from EventCollections we can't rely on the assumption made that disjoint events are sorted in each IItemIterable. And since the classes aren't visible from RulesToolkit we have to look at the class name like this. This pull request has now been integrated. Changeset: bd35f0bd Author: Henrik Dafg?rd URL: https://git.openjdk.java.net/jmc/commit/bd35f0bd Stats: 69 lines in 1 file changed: 26 ins; 4 del; 39 mod 7088: Show concurrent option showing lesser number of records. Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/208 From aptmac at openjdk.java.net Thu Feb 4 22:30:49 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Thu, 4 Feb 2021 22:30:49 GMT Subject: RFR: 7063: JfrThreadsPageTest (UI-test) fails (part 2) Message-ID: This PR is related to JMC-7077, and is a continuation of the fix for JMC-7063 [1]. After updating the `JfrThreadsPageTest` tests to better handle timestamps, Bipin mentioned in JMC-7077 [0] that some tests were still failing due to focusing issues. This PR attempts to address these issues, by adding checks to make sure the ui is a sufficient size to run the tests that require interaction with the canvases. I've chosen to label this fix as 7063 part 2, because JMC-7077 is loaded and isn't only concerned with these changes. Let me know if this works, otherwise I can change the commit message and PR title. Now there is a new function in the test class to verify that the controls are visible. It does this by first checking the scrolled composite for a horizontal scrollbar (if there is one then some widgets may not be visible), and then checks the height of the ChartCanvas to ensure that the lanes can be interacted with. If the ui is not large enough for this criteria, then the tests are skipped using `Assume.assumeTrue()` in the specific unit tests. I've played around with varying ui dimensions by altering the height/width values in `ApplicationWorkbenchWindowAdvisor.java`, and the tests look to be skipped when appropriate. For example, I set the width to be 600px, and the resulting test run: Tests run: 10, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 112.402 s - in org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest testHideAllThreads(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped testTextCanvasSelection(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped testZoom(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped testFoldingChart(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 20.694 s testFoldingTable(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 10.219 s testMenuItemEnablement(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped testInvalidFoldingActions(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 9.268 s testResetButtons(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped testTimeFilterInvalid(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped testPersistingSashWeights(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 15.607 s [0] https://bugs.openjdk.java.net/browse/JMC-7077 [1] https://github.com/openjdk/jmc/commit/8d6fb1b70f96c52f3bd71584ddca287c802e1f6f ------------- Commit messages: - 7063: JfrThreadsPageTest (UI-test) fails (part 2) Changes: https://git.openjdk.java.net/jmc/pull/209/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=209&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7063 Stats: 156 lines in 6 files changed: 152 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jmc/pull/209.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/209/head:pull/209 PR: https://git.openjdk.java.net/jmc/pull/209 From aptmac at openjdk.java.net Thu Feb 4 22:32:50 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Thu, 4 Feb 2021 22:32:50 GMT Subject: RFR: 7121: Unhandled exception while working with Thread Graphs Message-ID: This short PR addresses JMC-7121 [0], in which a division by 0 error can occur when viewing the threads page with a focused selection that has no relevant thread information. A big thanks to Bipin for catching this, but for also providing easy steps to reproduce the issue. The fix here adds a check when initializing the minimum lane height, ensuring that the default value gets set if there are no items. [0] https://bugs.openjdk.java.net/browse/JMC-7121 ------------- Commit messages: - 7121: Unhandled exception while working with Thread Graphs Changes: https://git.openjdk.java.net/jmc/pull/210/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=210&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7121 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/210.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/210/head:pull/210 PR: https://git.openjdk.java.net/jmc/pull/210 From aptmac at openjdk.java.net Thu Feb 4 22:33:46 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Thu, 4 Feb 2021 22:33:46 GMT Subject: RFR: 7120: Charts in custom pages are not auto refreshed Message-ID: This PR addresses JMC-7120 [0], in which charts in the custom pages are not auto refreshed. This issue is a regression from the changes to the `ChartCanvas` in the threads page enhancement, sorry about that. The culprit here was the wrongful removal of a `redrawChart()` call in `ChartCanvas.setChart`. Looking back through the old commits I have for the Threads Page work I couldn't find where it was removed, but it must have been pretty early into the work. I noticed that the `redrawChart()` is present in JMC 7 [1] and in the commit prior to the threads page pr going in [2], but not afterwards [3]. This PR simply adds back the redraw call. gif: ![7120](https://user-images.githubusercontent.com/10425301/106956199-462fcd00-6704-11eb-9dad-f60ff55590a5.gif) [0] https://bugs.openjdk.java.net/browse/JMC-7120 [1] https://hg.openjdk.java.net/jmc/jmc7/file/63ec7d0ee8d9/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartCanvas.java#l533 [2] https://github.com/openjdk/jmc/blob/c3f49204ce36139ac83ccfa88b2ada26a0b2cd04/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartCanvas.java#L533 [3] https://github.com/openjdk/jmc/blob/5feaf25fa2a4a61236a733053dc60134c89efccf/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartCanvas.java#L716 ------------- Commit messages: - 7120: Charts in custom pages are not auto refreshed Changes: https://git.openjdk.java.net/jmc/pull/211/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=211&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7120 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/211.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/211/head:pull/211 PR: https://git.openjdk.java.net/jmc/pull/211 From guru.hb at oracle.com Fri Feb 5 07:48:39 2021 From: guru.hb at oracle.com (Guru Prasad H B) Date: Fri, 5 Feb 2021 07:48:39 +0000 Subject: [jmc8] merge request from master to jmc8 branch for JMC-7039, JMC-7088 Message-ID: <1B940FBD-4F81-4268-AA5C-20F4AC7849B0@oracle.com> Hi Marcus, Please approve the merge request to ?jmc8? release branch for (1) and (2) mentioned below : 1. JMC-7039: Timestamp granularity too coarse (https://github.com/openjdk/jmc/commit/7b1ae3e3da4757bf3b19bfc6c9c052bf086f343d) 2. JMC-7088: Show concurrent option showing lesser number of records.(https://github.com/openjdk/jmc/commit/bd35f0bda93be1f429c12f439c8c68afc146961b) Thanks, Guru From hirt at openjdk.java.net Fri Feb 5 14:25:38 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 5 Feb 2021 14:25:38 GMT Subject: RFR: 7120: Charts in custom pages are not auto refreshed In-Reply-To: References: Message-ID: On Thu, 4 Feb 2021 22:30:32 GMT, Alex Macdonald wrote: > This PR addresses JMC-7120 [0], in which charts in the custom pages are not auto refreshed. This issue is a regression from the changes to the `ChartCanvas` in the threads page enhancement, sorry about that. > > The culprit here was the wrongful removal of a `redrawChart()` call in `ChartCanvas.setChart`. Looking back through the old commits I have for the Threads Page work I couldn't find where it was removed, but it must have been pretty early into the work. I noticed that the `redrawChart()` is present in JMC 7 [1] and in the commit prior to the threads page pr going in [2], but not afterwards [3]. This PR simply adds back the redraw call. > > gif: > ![7120](https://user-images.githubusercontent.com/10425301/106956199-462fcd00-6704-11eb-9dad-f60ff55590a5.gif) > > [0] https://bugs.openjdk.java.net/browse/JMC-7120 > [1] https://hg.openjdk.java.net/jmc/jmc7/file/63ec7d0ee8d9/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartCanvas.java#l533 > [2] https://github.com/openjdk/jmc/blob/c3f49204ce36139ac83ccfa88b2ada26a0b2cd04/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartCanvas.java#L533 > [3] https://github.com/openjdk/jmc/blob/5feaf25fa2a4a61236a733053dc60134c89efccf/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartCanvas.java#L716 Marked as reviewed by hirt (Lead). Thank you for fixing @aptmac - this should also fix the redraw problem of the range indicator. @guruhb, can you please cherry pick this one to jmc8 once it is in? ------------- PR: https://git.openjdk.java.net/jmc/pull/211 From hirt at openjdk.java.net Fri Feb 5 14:27:38 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 5 Feb 2021 14:27:38 GMT Subject: RFR: 7121: Unhandled exception while working with Thread Graphs In-Reply-To: References: Message-ID: On Thu, 4 Feb 2021 22:28:51 GMT, Alex Macdonald wrote: > This short PR addresses JMC-7121 [0], in which a division by 0 error can occur when viewing the threads page with a focused selection that has no relevant thread information. A big thanks to Bipin for catching this, but for also providing easy steps to reproduce the issue. > > The fix here adds a check when initializing the minimum lane height, ensuring that the default value gets set if there are no items. > > [0] https://bugs.openjdk.java.net/browse/JMC-7121 Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/210 From hirt at openjdk.java.net Fri Feb 5 14:27:38 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 5 Feb 2021 14:27:38 GMT Subject: RFR: 7121: Unhandled exception while working with Thread Graphs In-Reply-To: References: Message-ID: On Fri, 5 Feb 2021 14:24:08 GMT, Marcus Hirt wrote: >> This short PR addresses JMC-7121 [0], in which a division by 0 error can occur when viewing the threads page with a focused selection that has no relevant thread information. A big thanks to Bipin for catching this, but for also providing easy steps to reproduce the issue. >> >> The fix here adds a check when initializing the minimum lane height, ensuring that the default value gets set if there are no items. >> >> [0] https://bugs.openjdk.java.net/browse/JMC-7121 > > Marked as reviewed by hirt (Lead). @guruhb - I believe this one is safe enough to bring over to 8. ------------- PR: https://git.openjdk.java.net/jmc/pull/210 From aptmac at openjdk.java.net Fri Feb 5 15:03:57 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Fri, 5 Feb 2021 15:03:57 GMT Subject: RFR: 7063: JfrThreadsPageTest (UI-test) fails (part 2) [v2] In-Reply-To: References: Message-ID: > This PR is related to JMC-7077, and is a continuation of the fix for JMC-7063 [1]. > > After updating the `JfrThreadsPageTest` tests to better handle timestamps, Bipin mentioned in JMC-7077 [0] that some tests were still failing due to focusing issues. This PR attempts to address these issues, by adding checks to make sure the ui is a sufficient size to run the tests that require interaction with the canvases. I've chosen to label this fix as 7063 part 2, because JMC-7077 is loaded and isn't only concerned with these changes. Let me know if this works, otherwise I can change the commit message and PR title. > > Now there is a new function in the test class to verify that the controls are visible. It does this by first checking the scrolled composite for a horizontal scrollbar (if there is one then some widgets may not be visible), and then checks the height of the ChartCanvas to ensure that the lanes can be interacted with. If the ui is not large enough for this criteria, then the tests are skipped using `Assume.assumeTrue()` in the specific unit tests. I've played around with varying ui dimensions by altering the height/width values in `ApplicationWorkbenchWindowAdvisor.java`, and the tests look to be skipped when appropriate. > > For example, I set the width to be 600px, and the resulting test run: > Tests run: 10, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 112.402 s - in org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest > testHideAllThreads(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testTextCanvasSelection(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testZoom(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testFoldingChart(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 20.694 s > testFoldingTable(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 10.219 s > testMenuItemEnablement(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testInvalidFoldingActions(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 9.268 s > testResetButtons(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testTimeFilterInvalid(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testPersistingSashWeights(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 15.607 s > > [0] https://bugs.openjdk.java.net/browse/JMC-7077 > [1] https://github.com/openjdk/jmc/commit/8d6fb1b70f96c52f3bd71584ddca287c802e1f6f Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision: run mvn:spotless ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/209/files - new: https://git.openjdk.java.net/jmc/pull/209/files/b8323f3f..770ebe86 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=209&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=209&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/209.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/209/head:pull/209 PR: https://git.openjdk.java.net/jmc/pull/209 From aptmac at openjdk.java.net Fri Feb 5 16:19:57 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Fri, 5 Feb 2021 16:19:57 GMT Subject: RFR: 7063: JfrThreadsPageTest (UI-test) fails (part 2) [v3] In-Reply-To: References: Message-ID: > This PR is related to JMC-7077, and is a continuation of the fix for JMC-7063 [1]. > > After updating the `JfrThreadsPageTest` tests to better handle timestamps, Bipin mentioned in JMC-7077 [0] that some tests were still failing due to focusing issues. This PR attempts to address these issues, by adding checks to make sure the ui is a sufficient size to run the tests that require interaction with the canvases. I've chosen to label this fix as 7063 part 2, because JMC-7077 is loaded and isn't only concerned with these changes. Let me know if this works, otherwise I can change the commit message and PR title. > > Now there is a new function in the test class to verify that the controls are visible. It does this by first checking the scrolled composite for a horizontal scrollbar (if there is one then some widgets may not be visible), and then checks the height of the ChartCanvas to ensure that the lanes can be interacted with. If the ui is not large enough for this criteria, then the tests are skipped using `Assume.assumeTrue()` in the specific unit tests. I've played around with varying ui dimensions by altering the height/width values in `ApplicationWorkbenchWindowAdvisor.java`, and the tests look to be skipped when appropriate. > > For example, I set the width to be 600px, and the resulting test run: > Tests run: 10, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 112.402 s - in org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest > testHideAllThreads(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testTextCanvasSelection(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testZoom(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testFoldingChart(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 20.694 s > testFoldingTable(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 10.219 s > testMenuItemEnablement(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testInvalidFoldingActions(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 9.268 s > testResetButtons(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testTimeFilterInvalid(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testPersistingSashWeights(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 15.607 s > > [0] https://bugs.openjdk.java.net/browse/JMC-7077 > [1] https://github.com/openjdk/jmc/commit/8d6fb1b70f96c52f3bd71584ddca287c802e1f6f Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision: run mvn:spotless on uitests ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/209/files - new: https://git.openjdk.java.net/jmc/pull/209/files/770ebe86..1ff1bc5d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=209&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=209&range=01-02 Stats: 7 lines in 3 files changed: 1 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jmc/pull/209.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/209/head:pull/209 PR: https://git.openjdk.java.net/jmc/pull/209 From hirt at openjdk.java.net Fri Feb 5 16:30:42 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 5 Feb 2021 16:30:42 GMT Subject: RFR: 7120: Charts in custom pages are not auto refreshed In-Reply-To: References: Message-ID: On Fri, 5 Feb 2021 14:23:04 GMT, Marcus Hirt wrote: >> This PR addresses JMC-7120 [0], in which charts in the custom pages are not auto refreshed. This issue is a regression from the changes to the `ChartCanvas` in the threads page enhancement, sorry about that. >> >> The culprit here was the wrongful removal of a `redrawChart()` call in `ChartCanvas.setChart`. Looking back through the old commits I have for the Threads Page work I couldn't find where it was removed, but it must have been pretty early into the work. I noticed that the `redrawChart()` is present in JMC 7 [1] and in the commit prior to the threads page pr going in [2], but not afterwards [3]. This PR simply adds back the redraw call. >> >> gif: >> ![7120](https://user-images.githubusercontent.com/10425301/106956199-462fcd00-6704-11eb-9dad-f60ff55590a5.gif) >> >> [0] https://bugs.openjdk.java.net/browse/JMC-7120 >> [1] https://hg.openjdk.java.net/jmc/jmc7/file/63ec7d0ee8d9/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartCanvas.java#l533 >> [2] https://github.com/openjdk/jmc/blob/c3f49204ce36139ac83ccfa88b2ada26a0b2cd04/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartCanvas.java#L533 >> [3] https://github.com/openjdk/jmc/blob/5feaf25fa2a4a61236a733053dc60134c89efccf/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartCanvas.java#L716 > > Thank you for fixing @aptmac - this should also fix the redraw problem of the range indicator. @guruhb, can you please cherry pick this one to jmc8 once it is in? I can do the cherry-picking. ------------- PR: https://git.openjdk.java.net/jmc/pull/211 From hirt at openjdk.java.net Fri Feb 5 18:47:40 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 5 Feb 2021 18:47:40 GMT Subject: RFR: 7130: JfrThreadsPageTest (UI-test) fails (part 2) [v3] In-Reply-To: References: Message-ID: On Fri, 5 Feb 2021 16:19:57 GMT, Alex Macdonald wrote: >> This PR is related to JMC-7077, and is a continuation of the fix for JMC-7063 [1]. >> >> After updating the `JfrThreadsPageTest` tests to better handle timestamps, Bipin mentioned in JMC-7077 [0] that some tests were still failing due to focusing issues. This PR attempts to address these issues, by adding checks to make sure the ui is a sufficient size to run the tests that require interaction with the canvases. I've chosen to label this fix as 7063 part 2, because JMC-7077 is loaded and isn't only concerned with these changes. Let me know if this works, otherwise I can change the commit message and PR title. >> >> Now there is a new function in the test class to verify that the controls are visible. It does this by first checking the scrolled composite for a horizontal scrollbar (if there is one then some widgets may not be visible), and then checks the height of the ChartCanvas to ensure that the lanes can be interacted with. If the ui is not large enough for this criteria, then the tests are skipped using `Assume.assumeTrue()` in the specific unit tests. I've played around with varying ui dimensions by altering the height/width values in `ApplicationWorkbenchWindowAdvisor.java`, and the tests look to be skipped when appropriate. >> >> For example, I set the width to be 600px, and the resulting test run: >> Tests run: 10, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 112.402 s - in org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest >> testHideAllThreads(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped >> testTextCanvasSelection(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped >> testZoom(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped >> testFoldingChart(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 20.694 s >> testFoldingTable(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 10.219 s >> testMenuItemEnablement(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped >> testInvalidFoldingActions(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 9.268 s >> testResetButtons(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped >> testTimeFilterInvalid(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped >> testPersistingSashWeights(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 15.607 s >> >> [0] https://bugs.openjdk.java.net/browse/JMC-7077 >> [1] https://github.com/openjdk/jmc/commit/8d6fb1b70f96c52f3bd71584ddca287c802e1f6f > > Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision: > > run mvn:spotless on uitests Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/209 From aptmac at openjdk.java.net Fri Feb 5 19:04:38 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Fri, 5 Feb 2021 19:04:38 GMT Subject: Integrated: 7120: Charts in custom pages are not auto refreshed In-Reply-To: References: Message-ID: On Thu, 4 Feb 2021 22:30:32 GMT, Alex Macdonald wrote: > This PR addresses JMC-7120 [0], in which charts in the custom pages are not auto refreshed. This issue is a regression from the changes to the `ChartCanvas` in the threads page enhancement, sorry about that. > > The culprit here was the wrongful removal of a `redrawChart()` call in `ChartCanvas.setChart`. Looking back through the old commits I have for the Threads Page work I couldn't find where it was removed, but it must have been pretty early into the work. I noticed that the `redrawChart()` is present in JMC 7 [1] and in the commit prior to the threads page pr going in [2], but not afterwards [3]. This PR simply adds back the redraw call. > > gif: > ![7120](https://user-images.githubusercontent.com/10425301/106956199-462fcd00-6704-11eb-9dad-f60ff55590a5.gif) > > [0] https://bugs.openjdk.java.net/browse/JMC-7120 > [1] https://hg.openjdk.java.net/jmc/jmc7/file/63ec7d0ee8d9/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartCanvas.java#l533 > [2] https://github.com/openjdk/jmc/blob/c3f49204ce36139ac83ccfa88b2ada26a0b2cd04/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartCanvas.java#L533 > [3] https://github.com/openjdk/jmc/blob/5feaf25fa2a4a61236a733053dc60134c89efccf/application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartCanvas.java#L716 This pull request has now been integrated. Changeset: a248e5c9 Author: Alex Macdonald URL: https://git.openjdk.java.net/jmc/commit/a248e5c9 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 7120: Charts in custom pages are not auto refreshed Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/211 From aptmac at openjdk.java.net Fri Feb 5 19:09:45 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Fri, 5 Feb 2021 19:09:45 GMT Subject: Integrated: 7121: Unhandled exception while working with Thread Graphs In-Reply-To: References: Message-ID: On Thu, 4 Feb 2021 22:28:51 GMT, Alex Macdonald wrote: > This short PR addresses JMC-7121 [0], in which a division by 0 error can occur when viewing the threads page with a focused selection that has no relevant thread information. A big thanks to Bipin for catching this, but for also providing easy steps to reproduce the issue. > > The fix here adds a check when initializing the minimum lane height, ensuring that the default value gets set if there are no items. > > [0] https://bugs.openjdk.java.net/browse/JMC-7121 This pull request has now been integrated. Changeset: 80f7c2d8 Author: Alex Macdonald URL: https://git.openjdk.java.net/jmc/commit/80f7c2d8 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 7121: Unhandled exception while working with Thread Graphs Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/210 From aptmac at openjdk.java.net Fri Feb 5 19:11:37 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Fri, 5 Feb 2021 19:11:37 GMT Subject: Integrated: 7130: JfrThreadsPageTest (UI-test) fails (part 2) In-Reply-To: References: Message-ID: On Thu, 4 Feb 2021 22:27:23 GMT, Alex Macdonald wrote: > This PR is related to JMC-7077, and is a continuation of the fix for JMC-7063 [1]. > > After updating the `JfrThreadsPageTest` tests to better handle timestamps, Bipin mentioned in JMC-7077 [0] that some tests were still failing due to focusing issues. This PR attempts to address these issues, by adding checks to make sure the ui is a sufficient size to run the tests that require interaction with the canvases. I've chosen to label this fix as 7063 part 2, because JMC-7077 is loaded and isn't only concerned with these changes. Let me know if this works, otherwise I can change the commit message and PR title. > > Now there is a new function in the test class to verify that the controls are visible. It does this by first checking the scrolled composite for a horizontal scrollbar (if there is one then some widgets may not be visible), and then checks the height of the ChartCanvas to ensure that the lanes can be interacted with. If the ui is not large enough for this criteria, then the tests are skipped using `Assume.assumeTrue()` in the specific unit tests. I've played around with varying ui dimensions by altering the height/width values in `ApplicationWorkbenchWindowAdvisor.java`, and the tests look to be skipped when appropriate. > > For example, I set the width to be 600px, and the resulting test run: > Tests run: 10, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 112.402 s - in org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest > testHideAllThreads(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testTextCanvasSelection(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testZoom(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testFoldingChart(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 20.694 s > testFoldingTable(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 10.219 s > testMenuItemEnablement(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testInvalidFoldingActions(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 9.268 s > testResetButtons(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testTimeFilterInvalid(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) skipped > testPersistingSashWeights(org.openjdk.jmc.flightrecorder.uitest.JfrThreadsPageTest) Time elapsed: 15.607 s > > [0] https://bugs.openjdk.java.net/browse/JMC-7077 > [1] https://github.com/openjdk/jmc/commit/8d6fb1b70f96c52f3bd71584ddca287c802e1f6f This pull request has now been integrated. Changeset: 3645eb1c Author: Alex Macdonald URL: https://git.openjdk.java.net/jmc/commit/3645eb1c Stats: 157 lines in 6 files changed: 153 ins; 0 del; 4 mod 7130: JfrThreadsPageTest (UI-test) fails (part 2) Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/209 From schaturvedi at openjdk.java.net Fri Feb 5 19:18:54 2021 From: schaturvedi at openjdk.java.net (Suchita Chaturvedi) Date: Fri, 5 Feb 2021 19:18:54 GMT Subject: RFR: 6753: JMC Help Documentation requires corrections Message-ID: This PR updates the old instructions of starting JMC when it was bundled as part of jdk. Please review the change and let me know if there are any changes required. ------------- Commit messages: - 6753: JMC Help Documentation requires corrections Changes: https://git.openjdk.java.net/jmc/pull/212/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=212&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-6753 Stats: 7 lines in 1 file changed: 0 ins; 1 del; 6 mod Patch: https://git.openjdk.java.net/jmc/pull/212.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/212/head:pull/212 PR: https://git.openjdk.java.net/jmc/pull/212 From schaturvedi at openjdk.java.net Fri Feb 5 20:21:51 2021 From: schaturvedi at openjdk.java.net (Suchita Chaturvedi) Date: Fri, 5 Feb 2021 20:21:51 GMT Subject: RFR: 7040: Event list is not updated and Stack trace stale upon Set as Focused Selection Message-ID: This PR fixes the issue of the event table not refreshing on change of focused selection. Please review the change. ------------- Commit messages: - 7040: Event list is not updated and Stack trace stale upon Set as Focused Selection Changes: https://git.openjdk.java.net/jmc/pull/213/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=213&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7040 Stats: 7 lines in 1 file changed: 0 ins; 6 del; 1 mod Patch: https://git.openjdk.java.net/jmc/pull/213.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/213/head:pull/213 PR: https://git.openjdk.java.net/jmc/pull/213 From github.com+5106647+oscerd at openjdk.java.net Sun Feb 7 10:31:39 2021 From: github.com+5106647+oscerd at openjdk.java.net (Andrea Cosentino) Date: Sun, 7 Feb 2021 10:31:39 GMT Subject: RFR: 7040: Event list is not updated and Stack trace stale upon Set as Focused Selection In-Reply-To: References: Message-ID: <1EWoHx3V7Rfd7Qx1GiqjWLVbx0gM8XjqnB7O27YYum4=.c8f26c10-045a-4311-b289-ed96aed85983@github.com> On Fri, 5 Feb 2021 20:17:59 GMT, Suchita Chaturvedi wrote: > This PR fixes the issue of the event table not refreshing on change of focused selection. > > Please review the change. Marked as reviewed by oscerd at github.com (no known OpenJDK username). ------------- PR: https://git.openjdk.java.net/jmc/pull/213 From github.com+5106647+oscerd at openjdk.java.net Sun Feb 7 10:31:40 2021 From: github.com+5106647+oscerd at openjdk.java.net (Andrea Cosentino) Date: Sun, 7 Feb 2021 10:31:40 GMT Subject: RFR: 7040: Event list is not updated and Stack trace stale upon Set as Focused Selection In-Reply-To: <1EWoHx3V7Rfd7Qx1GiqjWLVbx0gM8XjqnB7O27YYum4=.c8f26c10-045a-4311-b289-ed96aed85983@github.com> References: <1EWoHx3V7Rfd7Qx1GiqjWLVbx0gM8XjqnB7O27YYum4=.c8f26c10-045a-4311-b289-ed96aed85983@github.com> Message-ID: On Sun, 7 Feb 2021 10:28:53 GMT, Andrea Cosentino wrote: >> This PR fixes the issue of the event table not refreshing on change of focused selection. >> >> Please review the change. > > Marked as reviewed by oscerd at github.com (no known OpenJDK username). Tested locally. ------------- PR: https://git.openjdk.java.net/jmc/pull/213 From github.com+5106647+oscerd at openjdk.java.net Mon Feb 8 07:11:53 2021 From: github.com+5106647+oscerd at openjdk.java.net (Andrea Cosentino) Date: Mon, 8 Feb 2021 07:11:53 GMT Subject: RFR: 6907: Upgrade Jacoco to 0.8.6 Message-ID: Updating to Jacoco 0.8.6 ------------- Commit messages: - 6907: Upgrade Jacoco to 0.8.6 Changes: https://git.openjdk.java.net/jmc/pull/214/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=214&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-6907 Stats: 8 lines in 6 files changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jmc/pull/214.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/214/head:pull/214 PR: https://git.openjdk.java.net/jmc/pull/214 From hirt at openjdk.java.net Mon Feb 8 09:00:39 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 8 Feb 2021 09:00:39 GMT Subject: RFR: 6907: Upgrade Jacoco to 0.8.6 In-Reply-To: References: Message-ID: On Mon, 8 Feb 2021 07:07:55 GMT, Andrea Cosentino wrote: > Updating to Jacoco 0.8.6 Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/214 From github.com+5106647+oscerd at openjdk.java.net Mon Feb 8 09:29:42 2021 From: github.com+5106647+oscerd at openjdk.java.net (Andrea Cosentino) Date: Mon, 8 Feb 2021 09:29:42 GMT Subject: Integrated: 6907: Upgrade Jacoco to 0.8.6 In-Reply-To: References: Message-ID: On Mon, 8 Feb 2021 07:07:55 GMT, Andrea Cosentino wrote: > Updating to Jacoco 0.8.6 This pull request has now been integrated. Changeset: 9381a9a2 Author: Andrea Cosentino Committer: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/9381a9a2 Stats: 8 lines in 6 files changed: 0 ins; 0 del; 8 mod 6907: Upgrade Jacoco to 0.8.6 Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/214 From github.com+5106647+oscerd at openjdk.java.net Mon Feb 8 09:59:56 2021 From: github.com+5106647+oscerd at openjdk.java.net (Andrea Cosentino) Date: Mon, 8 Feb 2021 09:59:56 GMT Subject: RFR: 7133: Update the build script help to include the installCore option Message-ID: Noticed this: if you build jmc with build.sh script for the first time, you'll need to run the installCore command first and then all the command listed for testing and packaging it. ------------- Commit messages: - Updated the build instructions in case of build.sh usage Changes: https://git.openjdk.java.net/jmc/pull/215/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=215&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7133 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/215.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/215/head:pull/215 PR: https://git.openjdk.java.net/jmc/pull/215 From hirt at openjdk.java.net Mon Feb 8 09:59:56 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 8 Feb 2021 09:59:56 GMT Subject: RFR: 7133: Update the build script help to include the installCore option In-Reply-To: References: Message-ID: On Mon, 8 Feb 2021 07:20:05 GMT, Andrea Cosentino wrote: > Noticed this: if you build jmc with build.sh script for the first time, you'll need to run the installCore command first and then all the command listed for testing and packaging it. Marked as reviewed by hirt (Lead). README.md line 223: > 221: ``` > 222: usage: call ./build.sh with the following options: > 223: --installCore to install the core bits How about "to install the core artifacts"? ------------- PR: https://git.openjdk.java.net/jmc/pull/215 From github.com+5106647+oscerd at openjdk.java.net Mon Feb 8 09:59:57 2021 From: github.com+5106647+oscerd at openjdk.java.net (Andrea Cosentino) Date: Mon, 8 Feb 2021 09:59:57 GMT Subject: RFR: 7133: Update the build script help to include the installCore option In-Reply-To: References: Message-ID: On Mon, 8 Feb 2021 07:20:05 GMT, Andrea Cosentino wrote: > Noticed this: if you build jmc with build.sh script for the first time, you'll need to run the installCore command first and then all the command listed for testing and packaging it. I can't open an issue on JIRA, since I don't have an account currently. ------------- PR: https://git.openjdk.java.net/jmc/pull/215 From github.com+5106647+oscerd at openjdk.java.net Mon Feb 8 09:59:57 2021 From: github.com+5106647+oscerd at openjdk.java.net (Andrea Cosentino) Date: Mon, 8 Feb 2021 09:59:57 GMT Subject: RFR: 7133: Update the build script help to include the installCore option In-Reply-To: References: Message-ID: On Mon, 8 Feb 2021 09:00:53 GMT, Marcus Hirt wrote: >> Noticed this: if you build jmc with build.sh script for the first time, you'll need to run the installCore command first and then all the command listed for testing and packaging it. > > README.md line 223: > >> 221: ``` >> 222: usage: call ./build.sh with the following options: >> 223: --installCore to install the core bits > > How about "to install the core artifacts"? Thanks for reviewing, should be done now. ------------- PR: https://git.openjdk.java.net/jmc/pull/215 From github.com+5106647+oscerd at openjdk.java.net Mon Feb 8 11:29:41 2021 From: github.com+5106647+oscerd at openjdk.java.net (Andrea Cosentino) Date: Mon, 8 Feb 2021 11:29:41 GMT Subject: Integrated: 7133: Update the build script help to include the installCore option In-Reply-To: References: Message-ID: On Mon, 8 Feb 2021 07:20:05 GMT, Andrea Cosentino wrote: > Noticed this: if you build jmc with build.sh script for the first time, you'll need to run the installCore command first and then all the command listed for testing and packaging it. This pull request has now been integrated. Changeset: 77605def Author: Andrea Cosentino Committer: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/77605def Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 7133: Update the build script help to include the installCore option Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/215 From hirt at openjdk.java.net Mon Feb 8 21:39:40 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 8 Feb 2021 21:39:40 GMT Subject: RFR: 7040: Event list is not updated and Stack trace stale upon Set as Focused Selection In-Reply-To: References: Message-ID: On Fri, 5 Feb 2021 20:17:59 GMT, Suchita Chaturvedi wrote: > This PR fixes the issue of the event table not refreshing on change of focused selection. > > Please review the change. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/213 From hirt at openjdk.java.net Mon Feb 8 21:39:43 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Mon, 8 Feb 2021 21:39:43 GMT Subject: RFR: 6753: JMC Help Documentation requires corrections In-Reply-To: References: Message-ID: On Fri, 5 Feb 2021 19:15:18 GMT, Suchita Chaturvedi wrote: > This PR updates the old instructions of starting JMC when it was bundled as part of jdk. > > Please review the change and let me know if there are any changes required. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/212 From schaturvedi at openjdk.java.net Mon Feb 8 21:39:40 2021 From: schaturvedi at openjdk.java.net (Suchita Chaturvedi) Date: Mon, 8 Feb 2021 21:39:40 GMT Subject: Integrated: 7040: Event list is not updated and Stack trace stale upon Set as Focused Selection In-Reply-To: References: Message-ID: <1FgOx976DrzuF3Lpk4GbN64jzSdk6jT4iPnAYwBEhXM=.ac41db95-4f96-4fe2-8c72-972311aea37e@github.com> On Fri, 5 Feb 2021 20:17:59 GMT, Suchita Chaturvedi wrote: > This PR fixes the issue of the event table not refreshing on change of focused selection. > > Please review the change. This pull request has now been integrated. Changeset: 369c1508 Author: Suchita Chaturvedi URL: https://git.openjdk.java.net/jmc/commit/369c1508 Stats: 7 lines in 1 file changed: 0 ins; 6 del; 1 mod 7040: Event list is not updated and Stack trace stale upon Set as Focused Selection Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/213 From schaturvedi at openjdk.java.net Mon Feb 8 21:39:43 2021 From: schaturvedi at openjdk.java.net (Suchita Chaturvedi) Date: Mon, 8 Feb 2021 21:39:43 GMT Subject: Integrated: 6753: JMC Help Documentation requires corrections In-Reply-To: References: Message-ID: On Fri, 5 Feb 2021 19:15:18 GMT, Suchita Chaturvedi wrote: > This PR updates the old instructions of starting JMC when it was bundled as part of jdk. > > Please review the change and let me know if there are any changes required. This pull request has now been integrated. Changeset: 733aacf0 Author: Suchita Chaturvedi URL: https://git.openjdk.java.net/jmc/commit/733aacf0 Stats: 7 lines in 1 file changed: 0 ins; 1 del; 6 mod 6753: JMC Help Documentation requires corrections Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/212 From ghb at openjdk.java.net Wed Feb 10 02:46:46 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Wed, 10 Feb 2021 02:46:46 GMT Subject: RFR: 7136: Restrict local management agent for own process Message-ID: RC : Starting Local management agent for JMC's own process is not required. ------------- Commit messages: - 7136: Restrict local management agent for own process Changes: https://git.openjdk.java.net/jmc/pull/217/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=217&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7136 Stats: 11 lines in 1 file changed: 3 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jmc/pull/217.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/217/head:pull/217 PR: https://git.openjdk.java.net/jmc/pull/217 From github.com+4610701+jpbempel at openjdk.java.net Wed Feb 10 09:56:38 2021 From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Wed, 10 Feb 2021 09:56:38 GMT Subject: RFR: 7136: Restrict local management agent for own process In-Reply-To: References: Message-ID: On Wed, 10 Feb 2021 02:43:49 GMT, Guru Hb wrote: > RC : Starting Local management agent for JMC's own process is not required. LGTM! ------------- PR: https://git.openjdk.java.net/jmc/pull/217 From hirt at openjdk.java.net Thu Feb 11 08:56:37 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 11 Feb 2021 08:56:37 GMT Subject: RFR: 7136: Restrict local management agent for own process In-Reply-To: References: Message-ID: On Wed, 10 Feb 2021 02:43:49 GMT, Guru Hb wrote: > RC : Starting Local management agent for JMC's own process is not required. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.java.net/jmc/pull/217 From hirt at openjdk.java.net Thu Feb 11 19:50:50 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Thu, 11 Feb 2021 19:50:50 GMT Subject: RFR: 7131: Uitests failing on Windows Message-ID: Fixed various problems, most related to the timestamp patch (#201). ------------- Commit messages: - Fixing formatting - Fixing core - Fixing various problems Changes: https://git.openjdk.java.net/jmc/pull/218/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=218&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7131 Stats: 3734 lines in 14 files changed: 479 ins; 0 del; 3255 mod Patch: https://git.openjdk.java.net/jmc/pull/218.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/218/head:pull/218 PR: https://git.openjdk.java.net/jmc/pull/218 From aptmac at openjdk.java.net Thu Feb 11 22:20:40 2021 From: aptmac at openjdk.java.net (Alex Macdonald) Date: Thu, 11 Feb 2021 22:20:40 GMT Subject: RFR: 7131: Uitests failing on Windows In-Reply-To: References: Message-ID: On Thu, 11 Feb 2021 19:46:43 GMT, Marcus Hirt wrote: > Fixed various problems, most related to the timestamp patch (#201). Works on Windows for me, and also fixes the `ControlRecordingsTest` problems on Linux as well. ------------- Marked as reviewed by aptmac (Committer). PR: https://git.openjdk.java.net/jmc/pull/218 From ghb at openjdk.java.net Fri Feb 12 04:49:40 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Fri, 12 Feb 2021 04:49:40 GMT Subject: RFR: 7131: Uitests failing on Windows In-Reply-To: References: Message-ID: On Thu, 11 Feb 2021 19:46:43 GMT, Marcus Hirt wrote: > Fixed various problems, most related to the timestamp patch (#201). Looks good to me. ------------- Marked as reviewed by ghb (Reviewer). PR: https://git.openjdk.java.net/jmc/pull/218 From hirt at openjdk.java.net Fri Feb 12 10:04:42 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 12 Feb 2021 10:04:42 GMT Subject: Integrated: 7131: Uitests failing on Windows In-Reply-To: References: Message-ID: On Thu, 11 Feb 2021 19:46:43 GMT, Marcus Hirt wrote: > Fixed various problems, most related to the timestamp patch (#201). This pull request has now been integrated. Changeset: 3a19fb51 Author: Marcus Hirt URL: https://git.openjdk.java.net/jmc/commit/3a19fb51 Stats: 3734 lines in 14 files changed: 479 ins; 0 del; 3255 mod 7131: Uitests failing on Windows Reviewed-by: aptmac, ghb ------------- PR: https://git.openjdk.java.net/jmc/pull/218 From ghb at openjdk.java.net Fri Feb 12 12:36:39 2021 From: ghb at openjdk.java.net (Guru Hb) Date: Fri, 12 Feb 2021 12:36:39 GMT Subject: Integrated: 7136: Restrict local management agent for own process In-Reply-To: References: Message-ID: On Wed, 10 Feb 2021 02:43:49 GMT, Guru Hb wrote: > RC : Starting Local management agent for JMC's own process is not required. This pull request has now been integrated. Changeset: e52a3615 Author: Guru Hb URL: https://git.openjdk.java.net/jmc/commit/e52a3615 Stats: 11 lines in 1 file changed: 3 ins; 0 del; 8 mod 7136: Restrict local management agent for own process Reviewed-by: hirt ------------- PR: https://git.openjdk.java.net/jmc/pull/217 From duke at openjdk.java.net Mon Feb 15 21:07:06 2021 From: duke at openjdk.java.net (duke) Date: Mon, 15 Feb 2021 21:07:06 GMT Subject: git: openjdk/jmc: Added tag 8.0.0-ga for changeset 8ab40bfb Message-ID: <227bf459-ad7f-4d0b-ba11-d74ee9e43666@openjdk.java.net> Tagged by: Marcus Hirt Date: 2021-02-15 22:00:47 +0000 GA source release for JMC 8.0.0 Changeset: 8ab40bfb Author: Marcus Hirt Committer: Marcus Hirt Date: 2021-02-12 10:00:40 +0000 URL: https://git.openjdk.java.net/jmc/commit/8ab40bfb From marcus at hirt.se Mon Feb 15 21:37:20 2021 From: marcus at hirt.se (Marcus Hirt) Date: Mon, 15 Feb 2021 22:37:20 +0100 Subject: JMC 8.0.0-ga tag set. Message-ID: <044d01d703e2$bd505650$37f102f0$@hirt.se> Hi all, The JMC 8.0.0-ga tag has (finally) been set. :) https://github.com/openjdk/jmc/releases/tag/8.0.0-ga Thanks everyone for all your hard work making this release possible! Kind regards, Marcus From github.com+4610701+jpbempel at openjdk.java.net Tue Feb 23 09:28:56 2021 From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Tue, 23 Feb 2021 09:28:56 GMT Subject: RFR: 6936: Parser should track statistics during parsing Message-ID: Add new `IParserStats` interface implemented by `EventCollection`. That way, `IItemCollection` is not touched, but you need to cast the instance to `IParserStats`. Support of old (v0.x) JFR format. During parsing, we collect number of events per type, the size, number of chunks and version of the file. We also track for version 1.x/2.x the number of skipped events. `RecordingPrinter` tool class is modified to support a summary verbosity mode and `-summary` option to print statistics per event type. ------------- Commit messages: - 6936: Parser should track statistics during parsing Changes: https://git.openjdk.java.net/jmc/pull/219/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=219&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-6936 Stats: 414 lines in 22 files changed: 400 ins; 0 del; 14 mod Patch: https://git.openjdk.java.net/jmc/pull/219.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/219/head:pull/219 PR: https://git.openjdk.java.net/jmc/pull/219 From github.com+4610701+jpbempel at openjdk.java.net Tue Feb 23 11:06:58 2021 From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Tue, 23 Feb 2021 11:06:58 GMT Subject: RFR: 6936: Parser should track statistics during parsing [v2] In-Reply-To: References: Message-ID: > Add new `IParserStats` interface implemented by `EventCollection`. > That way, `IItemCollection` is not touched, but you need to cast the > instance to `IParserStats`. > Support of old (v0.x) JFR format. > During parsing, we collect number of events per type, the size, number > of chunks and version of the file. > We also track for version 1.x/2.x the number of skipped events. > `RecordingPrinter` tool class is modified to support a summary verbosity mode > and `-summary` option to print statistics per event type. Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: add/update copyright year ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/219/files - new: https://git.openjdk.java.net/jmc/pull/219/files/b2113547..9f966581 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=219&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=219&range=00-01 Stats: 75 lines in 11 files changed: 66 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/jmc/pull/219.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/219/head:pull/219 PR: https://git.openjdk.java.net/jmc/pull/219 From github.com+4610701+jpbempel at openjdk.java.net Tue Feb 23 11:07:00 2021 From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Tue, 23 Feb 2021 11:07:00 GMT Subject: RFR: 6936: Parser should track statistics during parsing [v2] In-Reply-To: References: Message-ID: On Tue, 23 Feb 2021 11:04:16 GMT, Jean-Philippe Bempel wrote: >> Add new `IParserStats` interface implemented by `EventCollection`. >> That way, `IItemCollection` is not touched, but you need to cast the >> instance to `IParserStats`. >> Support of old (v0.x) JFR format. >> During parsing, we collect number of events per type, the size, number >> of chunks and version of the file. >> We also track for version 1.x/2.x the number of skipped events. >> `RecordingPrinter` tool class is modified to support a summary verbosity mode >> and `-summary` option to print statistics per event type. > > Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: > > add/update copyright year core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/EventArrays.java line 4: > 2: > 3: import java.util.Set; > 4: no copyright on this file, is it normal? core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/synthetic/JdkTypeIDsPreJdk11.java line 42: > 40: */ > 41: @SuppressWarnings({"nls", "unused"}) > 42: public final class JdkTypeIDsPreJdk11 { Made public to be able to use it from here: https://github.com/openjdk/jmc/blob/9f9665812a80339782c2e00be83b041954ee766b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v0/EventParserManager.java#L100 ------------- PR: https://git.openjdk.java.net/jmc/pull/219 From hirt at openjdk.java.net Tue Feb 23 23:07:43 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Tue, 23 Feb 2021 23:07:43 GMT Subject: RFR: 6936: Parser should track statistics during parsing [v2] In-Reply-To: References: Message-ID: <5lpQ0GLPE6ZhJ5MlEG9SDDdthIiuM2S_BCkrufzJZrE=.c537f353-638f-404f-826f-3080279e0b30@github.com> On Tue, 23 Feb 2021 11:01:30 GMT, Jean-Philippe Bempel wrote: >> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: >> >> add/update copyright year > > core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/EventArrays.java line 4: > >> 2: >> 3: import java.util.Set; >> 4: > > no copyright on this file, is it normal? Ooops. This file should definitely have an Oracle Copyright Notice. ------------- PR: https://git.openjdk.java.net/jmc/pull/219 From github.com+4610701+jpbempel at openjdk.java.net Wed Feb 24 07:52:05 2021 From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Wed, 24 Feb 2021 07:52:05 GMT Subject: RFR: 6936: Parser should track statistics during parsing [v3] In-Reply-To: References: Message-ID: > Add new `IParserStats` interface implemented by `EventCollection`. > That way, `IItemCollection` is not touched, but you need to cast the > instance to `IParserStats`. > Support of old (v0.x) JFR format. > During parsing, we collect number of events per type, the size, number > of chunks and version of the file. > We also track for version 1.x/2.x the number of skipped events. > `RecordingPrinter` tool class is modified to support a summary verbosity mode > and `-summary` option to print statistics per event type. Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: Add Oracle copyright header ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/219/files - new: https://git.openjdk.java.net/jmc/pull/219/files/9f966581..0ea61a16 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=219&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=219&range=01-02 Stats: 32 lines in 1 file changed: 32 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/219.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/219/head:pull/219 PR: https://git.openjdk.java.net/jmc/pull/219 From github.com+4610701+jpbempel at openjdk.java.net Wed Feb 24 07:56:40 2021 From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Wed, 24 Feb 2021 07:56:40 GMT Subject: RFR: 6936: Parser should track statistics during parsing [v2] In-Reply-To: <5lpQ0GLPE6ZhJ5MlEG9SDDdthIiuM2S_BCkrufzJZrE=.c537f353-638f-404f-826f-3080279e0b30@github.com> References: <5lpQ0GLPE6ZhJ5MlEG9SDDdthIiuM2S_BCkrufzJZrE=.c537f353-638f-404f-826f-3080279e0b30@github.com> Message-ID: On Tue, 23 Feb 2021 23:05:18 GMT, Marcus Hirt wrote: >> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/EventArrays.java line 4: >> >>> 2: >>> 3: import java.util.Set; >>> 4: >> >> no copyright on this file, is it normal? > > Ooops. This file should definitely have an Oracle Copyright Notice. done ------------- PR: https://git.openjdk.java.net/jmc/pull/219 From hirt at openjdk.java.net Wed Feb 24 12:32:39 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 24 Feb 2021 12:32:39 GMT Subject: RFR: 6936: Parser should track statistics during parsing In-Reply-To: References: Message-ID: On Tue, 23 Feb 2021 09:24:55 GMT, Jean-Philippe Bempel wrote: > Add new `IParserStats` interface implemented by `EventCollection`. > That way, `IItemCollection` is not touched, but you need to cast the > instance to `IParserStats`. > Support of old (v0.x) JFR format. > During parsing, we collect number of events per type, the size, number > of chunks and version of the file. > We also track for version 1.x/2.x the number of skipped events. > `RecordingPrinter` tool class is modified to support a summary verbosity mode > and `-summary` option to print statistics per event type. Do we need the number of events per type? Isn't that the same as a count aggregate with a type filter? ------------- PR: https://git.openjdk.java.net/jmc/pull/219 From github.com+4610701+jpbempel at openjdk.java.net Wed Feb 24 12:41:39 2021 From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Wed, 24 Feb 2021 12:41:39 GMT Subject: RFR: 6936: Parser should track statistics during parsing In-Reply-To: References: Message-ID: On Wed, 24 Feb 2021 12:29:39 GMT, Marcus Hirt wrote: > Do we need the number of events per type? Isn't that the same as a count aggregate with a type filter? Sure it's the same (or should be ?? ) but at least you have this information close to the other ones to interpret them ------------- PR: https://git.openjdk.java.net/jmc/pull/219 From hirt at openjdk.java.net Wed Feb 24 12:48:43 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Wed, 24 Feb 2021 12:48:43 GMT Subject: RFR: 6936: Parser should track statistics during parsing [v2] In-Reply-To: References: Message-ID: On Tue, 23 Feb 2021 11:04:16 GMT, Jean-Philippe Bempel wrote: >> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: >> >> add/update copyright year > > core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/synthetic/JdkTypeIDsPreJdk11.java line 42: > >> 40: */ >> 41: @SuppressWarnings({"nls", "unused"}) >> 42: public final class JdkTypeIDsPreJdk11 { > > Made public to be able to use it from here: https://github.com/openjdk/jmc/blob/9f9665812a80339782c2e00be83b041954ee766b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v0/EventParserManager.java#L100 If we make that class public, we might as well rename it. Since the JDK 8 backport, it really is Oracle type IDs - so perhaps OracleJdkTypeIDsPre11? ------------- PR: https://git.openjdk.java.net/jmc/pull/219 From github.com+4610701+jpbempel at openjdk.java.net Fri Feb 26 16:35:00 2021 From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Fri, 26 Feb 2021 16:35:00 GMT Subject: RFR: 6936: Parser should track statistics during parsing [v4] In-Reply-To: References: Message-ID: > Add new `IParserStats` interface implemented by `EventCollection`. > That way, `IItemCollection` is not touched, but you need to cast the > instance to `IParserStats`. > Support of old (v0.x) JFR format. > During parsing, we collect number of events per type, the size, number > of chunks and version of the file. > We also track for version 1.x/2.x the number of skipped events. > `RecordingPrinter` tool class is modified to support a summary verbosity mode > and `-summary` option to print statistics per event type. Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: Rename JdkTypeIDsPreJdk11 ------------- Changes: - all: https://git.openjdk.java.net/jmc/pull/219/files - new: https://git.openjdk.java.net/jmc/pull/219/files/0ea61a16..9abc1965 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=219&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=219&range=02-03 Stats: 44 lines in 4 files changed: 1 ins; 0 del; 43 mod Patch: https://git.openjdk.java.net/jmc/pull/219.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/219/head:pull/219 PR: https://git.openjdk.java.net/jmc/pull/219 From github.com+4610701+jpbempel at openjdk.java.net Fri Feb 26 16:35:01 2021 From: github.com+4610701+jpbempel at openjdk.java.net (Jean-Philippe Bempel) Date: Fri, 26 Feb 2021 16:35:01 GMT Subject: RFR: 6936: Parser should track statistics during parsing [v2] In-Reply-To: References: Message-ID: <1cZnSHn32urTxzTDcZqT-JK0f2msnkgKVOdiWSzuKAI=.1e2b526a-a191-40f1-8da7-9f3b24b6504a@github.com> On Wed, 24 Feb 2021 12:46:13 GMT, Marcus Hirt wrote: >> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/synthetic/JdkTypeIDsPreJdk11.java line 42: >> >>> 40: */ >>> 41: @SuppressWarnings({"nls", "unused"}) >>> 42: public final class JdkTypeIDsPreJdk11 { >> >> Made public to be able to use it from here: https://github.com/openjdk/jmc/blob/9f9665812a80339782c2e00be83b041954ee766b/core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v0/EventParserManager.java#L100 > > If we make that class public, we might as well rename it. Since the JDK 8 backport, it really is Oracle type IDs - so perhaps OracleJdkTypeIDsPre11? done ------------- PR: https://git.openjdk.java.net/jmc/pull/219 From hirt at openjdk.java.net Fri Feb 26 22:42:59 2021 From: hirt at openjdk.java.net (Marcus Hirt) Date: Fri, 26 Feb 2021 22:42:59 GMT Subject: RFR: 7139: Prepare new and noteworthy for JMC 8.0.0 Message-ID: There is a launcher included to build from within Eclipse. Import the project into Eclipse and run the launcher. Open the generated html page in a browser. ------------- Commit messages: - Adding the project file - Updating dictionary - Updating noimage names - Adding updated images and removing obsolete ones - Improved stylesheet - Removed old bugfix entry - All known issues - Update - Full copyright header - First commit for the release notes tool Changes: https://git.openjdk.java.net/jmc/pull/220/files Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=220&range=00 Issue: https://bugs.openjdk.java.net/browse/JMC-7139 Stats: 391 lines in 30 files changed: 391 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jmc/pull/220.diff Fetch: git fetch https://git.openjdk.java.net/jmc pull/220/head:pull/220 PR: https://git.openjdk.java.net/jmc/pull/220