RFR: 6946: There should be an option to build the agent in the build script [v8]

Patrick Reinhart reinhapa at openjdk.java.net
Wed Jan 6 08:20:56 UTC 2021


On Mon, 4 Jan 2021 19:39:23 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6946: correction
>
> build.sh line 88:
> 
>> 86:         printf " \t%s\t%s\n" "--clean" "to run maven clean"
>> 87:         printf " \t%s\t%s\n" "--run" "to run JMC once it was packaged"
>> 88:         printf " \t%s\t%s\n" "--runAgentExample" "to run Agent Example once it was packaged"
> 
> Any chance you could also add --runAgentConverterExample? :)
> 
> Basically:
> --add-opens java.base/jdk.internal.misc=ALL-UNNAMED -XX:+FlightRecorder -javaagent:${resource_loc:/org.openjdk.jmc.agent/target/org.openjdk.jmc.agent-1.0.0-SNAPSHOT.jar}=${resource_loc:/org.openjdk.jmc.agent/src/test/resources/org/openjdk/jmc/agent/converters/test/jfrprobes_template.xml}

Although I'm not an reviewer �� it seems that the `build.cmd` is missing the `--runAgentExample` additon mentioned by @thegreystone. Anything else looks ok.

-------------

PR: https://git.openjdk.java.net/jmc/pull/183


More information about the jmc-dev mailing list