RFR: 6946: There should be an option to build the agent in the build script [v10]

Miroslav Wengner mwengner at openjdk.java.net
Fri Jan 8 14:10:57 UTC 2021


On Wed, 6 Jan 2021 19:13:52 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - 6946: typo correction
>>  - 6946: runAgentByClass improvements
>
> build.sh line 89:
> 
>> 87:         printf " \t%s\t%s\n" "--run" "to run JMC once it was packaged"
>> 88:         printf " \t%s\t%s\n" "--runAgentExample" "to run Agent Example once it was packaged"
>> 89:         printf " \t%s\t%s\n" "--runAgentCustomExample --class:'org.openjdk.jmc.agent.test.InstrumentMe'" "to run custom agent class, once Agent was packaged"
> 
> This line is really long and causes multi-lines at small widths; it's difficult to read the menu. 
> 
> Does this line do anything at the moment? It doesn't have a match in `parseArgs`

yeah it does, @aptmac I've update the repo now, maybe I'd remove the Example or just merge them together,--runAgent* is the terminal option, it returns the error code. what do you think ?

-------------

PR: https://git.openjdk.java.net/jmc/pull/183


More information about the jmc-dev mailing list