RFR: 6946: There should be an option to build the agent in the build script [v10]

[Miroslav Wengner]

On Wed, 6 Jan 2021 18:49:23 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - 6946: typo correction
>>  - 6946: runAgentByClass improvements
>
> build.sh line 150:
> 
>> 148: 
>> 149:     if [[ "${OSTYPE}" =~ "linux"* ]] || [[ "${OSTYPE}" =~ "darwin"* ]]; then
>> 150:        printf "%s\n" "You can nor run agent by calling \"${PROGNAME} --runAgentExample\""
> 
> s/nor/now/

corrected

> build.sh line 314:
> 
>> 312: }
>> 313: 
>> 314: checkPreconditions
> 
> Thinking about it now, should checkPreconditions happen here, or would it be better to have it before valid arguments in `parseArgs`?
> 
> My reasoning being if I just wanted to just see the help menu, the script has to first check for java & maven, and then prints the menu. It's not a particularly long delay, but there is a delay while it verifies. I also noticed this because I had JAVA_HOME unset so the script failed without any output even though I just wanted to read the options.

I've changed the checks order, JAVA_HOME is 1st now. Nice catch !

-------------

PR: https://git.openjdk.java.net/jmc/pull/183