RFR: 6946: There should be an option to build the agent in the build script [v14]

Marcus Hirt hirt at openjdk.java.net
Mon Jan 11 19:14:00 UTC 2021


On Mon, 11 Jan 2021 16:47:17 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> https://bugs.openjdk.java.net/browse/JMC-6946
>> added: 
>> - build.sh --packageAgent
>> - build.sh --runAgentExample
>
> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6946: type correction, and error message improvement

Changes requested by hirt (Lead).

build.sh line 89:

> 87:         printf " \t%s\t%s\n" "--run" "to run JMC once it was packaged"
> 88:         printf " \t%s\t%s\n" "--runAgentExample" "to run Agent 'InstrumentMe' example once it was packaged"
> 89:         printf " \t%s\t%s\n" "--runAgentConverterExample" "to run Agent Converter 'InstrumentMeConverter' example, once Agent was packaged"

Skip converter and the comma, to keep with the pattern for the other "run"->
 "--runAgentConverterExample" "to run Agent 'InstrumentMeConverter' example once it was packaged"

build.bat line 44:

> 42: if "%1" == "--packageJmc" goto packageJmc
> 43: if "%1" == "--packageAgent" goto packageAgent
> 44: if "%1" == "--clean" goto clean

Lacks the --runAgentExample and the --runAgentConverterExample.

-------------

PR: https://git.openjdk.java.net/jmc/pull/183


More information about the jmc-dev mailing list