RFR: 7002: Too large graphs will freeze JMC
Alex Ciminian
github.com+348973+cimi at openjdk.java.net
Tue Jan 12 11:35:04 UTC 2021
On Sun, 10 Jan 2021 18:43:47 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> Looks good to me. I can try my hand at an icon. :)
>
> I think, perhaps a less on-the-nose-message for when there is no data would be nice. :)
I've changed the empty graph display to a simple label with a small font size. It seems to work ok and doesn't require other changes to the html or javascript With this method, it could become very small if the graph view window size is small. Nevertheless, I prefer this way since hacking html/css without touching the javascript is complicated: the SVG fills the page even when we have empty graphs, so I can't just overlay the graph over the text.
It looks like this now:
<img width="1086" alt="Screenshot 2021-01-10 at 20 10 26" src="https://user-images.githubusercontent.com/348973/104134166-e56cd900-537f-11eb-91ef-9b2c121f4bfe.png">
-------------
PR: https://git.openjdk.java.net/jmc/pull/193
More information about the jmc-dev
mailing list