RFR: 6946: There should be an option to build the agent in the build script [v16]

Marcus Hirt hirt at openjdk.java.net
Tue Jan 12 20:01:57 UTC 2021


On Tue, 12 Jan 2021 18:57:11 GMT, Miroslav Wengner <mwengner at openjdk.org> wrote:

>> I get the following when running the script on Mac when using _JAVA_OPTIONS:
>> try to execute an agent example
>> ./build.sh: line 231: printf: Picked up _JAVA_OPTIONS: : invalid number
>> Java Version:0
>> 
>> Perhaps just default to whatever can be found without validation if it fails to parse the version?
>
> this is good question about "java:0", but which kind of version you will choose, arguments valid for 13 and higher ?

java:0 is simply because the parser assumes there will be nothing before the version output. But people use things like _JAVA_OPTIONS, which may cause other output in between.

-------------

PR: https://git.openjdk.java.net/jmc/pull/183


More information about the jmc-dev mailing list