RFR: 6946: There should be an option to build the agent in the build script [v20]

Miroslav Wengner mwengner at openjdk.java.net
Wed Jan 13 17:16:19 UTC 2021


On Wed, 13 Jan 2021 16:44:38 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Miroslav Wengner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   6946: corrected typo
>
> build.sh line 88:
> 
>> 86:         printf " \t%s\t%s\n" "--clean" "to run maven clean"
>> 87:         printf " \t%s\t%s\n" "--run" "to run JMC once it was packaged"
>> 88:         printf " \t%s\t%s\n" "--runAgentExample" "to run Agent 'InstrumentMe' example, once it was packaged"
> 
> For `--run`, `--runAgentExample`, and `--runAgentConverterExample`, I think it reads better for the description to say "once it _is_ packaged" rather than "was"

ok, corrected

> build.sh line 83:
> 
>> 81:         printf " \t%s\t%s\n" "--test" "to run the tests"
>> 82:         printf " \t%s\t%s\n" "--testUi" "to run the tests including UI tests"
>> 83:         printf " \t%s\t%s\n" "--installCore" "install JMC core"
> 
> If trying to keep consistency, the `--installCore` is missing the "to" in it's description; it has it in the .bat file though

corrected

-------------

PR: https://git.openjdk.java.net/jmc/pull/183


More information about the jmc-dev mailing list